83356 2012-04-06 02:34:18 -0700 LocalFileSystem::initializeLocalFileSystem should be static 2012-04-06 19:06:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leo.yang leo.yang charles.wei rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 597261 0 leo.yang 2012-04-06 02:34:18 -0700 LocalFileSystem::initializeLocalFileSystem should be static because static LocalFileSystem::localFileSystem() requires initializeLocalFileSystem() is called before it gets called. 597264 1 135995 leo.yang 2012-04-06 02:40:33 -0700 Created attachment 135995 Patch 597803 2 135995 rwlbuis 2012-04-06 16:30:13 -0700 Comment on attachment 135995 Patch This seems correct. I do not think this method is used yet, but since the change itself is fine, r+. 597896 3 135995 webkit.review.bot 2012-04-06 19:06:44 -0700 Comment on attachment 135995 Patch Clearing flags on attachment: 135995 Committed r113537: <http://trac.webkit.org/changeset/113537> 597897 4 webkit.review.bot 2012-04-06 19:06:48 -0700 All reviewed patches have been landed. Closing bug. 135995 2012-04-06 02:40:33 -0700 2012-04-06 19:06:44 -0700 Patch 0001-LocalFileSystem-initializeLocalFileSystem-should-be-.patch text/plain 2246 leo.yang RnJvbSBjOWM2ZjBiNTMwMGQzYjk0OTc2ZDkxNGU0YzMzMzVmMWI4MWQ4NGYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBGcmksIDYgQXByIDIwMTIgMTc6Mzk6NDIgKzA4MDAKU3ViamVjdDogW1BBVENIXSBM b2NhbEZpbGVTeXN0ZW06OmluaXRpYWxpemVMb2NhbEZpbGVTeXN0ZW0gc2hvdWxkIGJlIHN0YXRp YwogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMzU2CgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KCkxvY2FsRmlsZVN5c3RlbTo6aW5pdGlhbGl6ZUxvY2FsRmls ZVN5c3RlbSBzaG91bGQgYmUgc3RhdGljIGJlY2F1c2UKc3RhdGljIExvY2FsRmlsZVN5c3RlbTo6 bG9jYWxGaWxlU3lzdGVtKCkgcmVxdWlyZXMgaW5pdGlhbGl6ZUxvY2FsRmlsZVN5c3RlbSgpCmlz IGNhbGxlZCBiZWZvcmUgaXQgZ2V0cyBjYWxsZWQuCgpObyBmdW5jdGlvbmFsaXRpZXMgY2hhbmdl ZCwgbm8gbmV3IHRlc3RzLgoKKiBNb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmg6 CihMb2NhbEZpbGVTeXN0ZW0pOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiAuLi4vV2ViQ29yZS9N b2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmggICB8ICAgIDIgKy0KIDIgZmlsZXMg Y2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjliOGJjNS4uMzEzNjEyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTA2 ICBMZW8gWWFuZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBMb2Nh bEZpbGVTeXN0ZW06OmluaXRpYWxpemVMb2NhbEZpbGVTeXN0ZW0gc2hvdWxkIGJlIHN0YXRpYwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMzNTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMb2NhbEZpbGVT eXN0ZW06OmluaXRpYWxpemVMb2NhbEZpbGVTeXN0ZW0gc2hvdWxkIGJlIHN0YXRpYyBiZWNhdXNl CisgICAgICAgIHN0YXRpYyBMb2NhbEZpbGVTeXN0ZW06OmxvY2FsRmlsZVN5c3RlbSgpIHJlcXVp cmVzIGluaXRpYWxpemVMb2NhbEZpbGVTeXN0ZW0oKQorICAgICAgICBpcyBjYWxsZWQgYmVmb3Jl IGl0IGdldHMgY2FsbGVkLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWxpdGllcyBjaGFuZ2VkLCBu byBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBNb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lz dGVtLmg6CisgICAgICAgIChMb2NhbEZpbGVTeXN0ZW0pOgorCiAyMDEyLTA0LTA0ICBEbWl0cnkg TG9tb3YgIDxkc2xvbW92QGdvb2dsZS5jb20+CiAKICAgICAgICAgV29ya2VyRXZlbnRRdWV1ZTo6 Y2xvc2UgbWlnaHQgYWNjZXNzIGRlbGV0ZWQgV29ya2VyRXZlbnRRdWV1ZTo6RXZlbnREaXNwYXRj aGVyVGFzay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmlsZXN5c3RlbS9M b2NhbEZpbGVTeXN0ZW0uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmlsZXN5c3RlbS9Mb2Nh bEZpbGVTeXN0ZW0uaAppbmRleCAyNDdiYjJjLi44MGNmYTI5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmgKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0xvY2FsRmlsZVN5c3RlbS5oCkBAIC02MCw3ICs2 MCw3IEBAIHB1YmxpYzoKIAogI2lmICFQTEFURk9STShDSFJPTUlVTSkKICAgICAvLyBUaGlzIGNh bGwgaXMgbm90IHRocmVhZC1zYWZlOyBtdXN0IGJlIGNhbGxlZCBiZWZvcmUgYW55IHdvcmtlciB0 aHJlYWRzIGFyZSBjcmVhdGVkLgotICAgIHZvaWQgaW5pdGlhbGl6ZUxvY2FsRmlsZVN5c3RlbShj b25zdCBTdHJpbmcmKTsKKyAgICBzdGF0aWMgdm9pZCBpbml0aWFsaXplTG9jYWxGaWxlU3lzdGVt KGNvbnN0IFN0cmluZyYpOwogCiAgICAgU3RyaW5nIGZpbGVTeXN0ZW1CYXNlUGF0aCgpIGNvbnN0 OwogI2VuZGlmCi0tIAoxLjcuNS40Cgo=