83355 2012-04-06 01:58:35 -0700 [BlackBerry] Text selection - Can't select texts 2012-04-06 05:53:59 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 xuewen.ok webkit-unassigned charles.wei mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 597257 0 xuewen.ok 2012-04-06 01:58:35 -0700 For blackberry porting, Touch and hold at any simple text, the selection handles and context menu should popup, but it doesn't. 597260 1 135993 xuewen.ok 2012-04-06 02:22:59 -0700 Created attachment 135993 Patch 597293 2 135993 staikos 2012-04-06 04:53:44 -0700 Comment on attachment 135993 Patch This kind of defeats the performance enhancements though. 597315 3 135993 webkit.review.bot 2012-04-06 05:53:53 -0700 Comment on attachment 135993 Patch Clearing flags on attachment: 135993 Committed r113429: <http://trac.webkit.org/changeset/113429> 597316 4 webkit.review.bot 2012-04-06 05:53:59 -0700 All reviewed patches have been landed. Closing bug. 135993 2012-04-06 02:22:59 -0700 2012-04-06 05:53:53 -0700 Patch 0001-BlackBerry-Text-selection-Can-t-select-texts.patch text/plain 2969 xuewen.ok RnJvbSBlMDRmNjY2ZWM4ZTUyNmFjNzg1MDlmMDMxOGZmOTNhNDQ3NmU4ODBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZWFuIFdhbmcgPFh1ZXdlbi5XYW5nQHRvcmNobW9iaWxlLmNv bS5jbj4KRGF0ZTogRnJpLCA2IEFwciAyMDEyIDE3OjIxOjU2ICswODAwClN1YmplY3Q6IFtQQVRD SF0gW0JsYWNrQmVycnldIFRleHQgc2VsZWN0aW9uIC0gQ2FuJ3Qgc2VsZWN0IHRleHRzCiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMzNTUKCkZpeCB0aGUgcHJvYmxl bSBvZiBub3Qgc2VuZGluZyBvdXQgdGhlIHJlc3VsdCBvZiB0aGUgZnVuY3Rpb24KU2VsZWN0aW9u SGFuZGxlcjo6cmVnaW9uRm9yVGV4dFF1YWRzKCkuIFRoaXMgcmVncmVzc2lvbiBpc3N1ZQppcyBp bnRyb2R1Y2VkIGJ5IHRoZSBnaXQgY29tbWl0IGY5NDQ2YjdkNjcxZDQ4YTgzM2FiMGFjZjEyYjFl MjA2MzdlMGE5MTAuCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogV2ViS2l0U3VwcG9y dC9TZWxlY3Rpb25IYW5kbGVyLmNwcDoKKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0aW9uSGFu ZGxlcjo6cmVnaW9uRm9yVGV4dFF1YWRzKToKICAgIEFkZCBjb2RlIHRvIHJldHVybiB0aGUgZnVu Y3Rpb24gcmVzdWx0LgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIC4uLi9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgIHwgICAgMyArLS0KIDIgZmlsZXMgY2hhbmdl ZCwgMTYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0No YW5nZUxvZwppbmRleCA2MjU3NWFmLi4wMWFjN2I0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNC0wNiAgU2VhbiBXYW5nICA8WHVld2VuLldh bmdAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBUZXh0IHNlbGVj dGlvbiAtIENhbid0IHNlbGVjdCB0ZXh0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODMzNTUKKworICAgICAgICBGaXggdGhlIHByb2JsZW0gb2Ygbm90 IHNlbmRpbmcgb3V0IHRoZSByZXN1bHQgb2YgdGhlIGZ1bmN0aW9uIAorICAgICAgICBTZWxlY3Rp b25IYW5kbGVyOjpyZWdpb25Gb3JUZXh0UXVhZHMoKS4gVGhpcyByZWdyZXNzaW9uIGlzc3VlCisg ICAgICAgIGlzIGludHJvZHVjZWQgYnkgdGhlIGdpdCBjb21taXQgZjk0NDZiN2Q2NzFkNDhhODMz YWIwYWNmMTJiMWUyMDYzN2UwYTkxMC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6Cisg ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OnJlZ2lvbkZvclRl eHRRdWFkcyk6CisgICAgICAgICAgICBBZGQgY29kZSB0byByZXR1cm4gdGhlIGZ1bmN0aW9uIHJl c3VsdC4KKwogMjAxMi0wNC0wNSAgSmFzb24gTGl1ICA8amFzb24ubGl1QHRvcmNobW9iaWxlLmNv bS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gRW1wdHkgUmVmZXJyZXIgc2hvdWxkIG5vdCBi ZSBzZXQgaW50byBSZXNvdXJjZVJlcXVlc3Qgd2hlbiBsb2FkaW5nIGEgbWFpbiByZXNvdXJjZS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVj dGlvbkhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv U2VsZWN0aW9uSGFuZGxlci5jcHAKaW5kZXggYTJlN2JmZS4uNTAxZWY2OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9u SGFuZGxlci5jcHAKQEAgLTEzNCwxMyArMTM0LDEyIEBAIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6 cmVnaW9uRm9yVGV4dFF1YWRzKFZlY3RvcjxGbG9hdFF1YWQ+ICZxdWFkTGlzdCwgSW50UmVjdFJl CiAKICAgICAgICAgLy8gQ29udmVydCB0aGUgdGV4dCBxdWFkcyBpbnRvIGEgbW9yZSBwbGF0Zm9y bSBmcmllbmR5CiAgICAgICAgIC8vIEludFJlY3RSZWdpb24gYW5kIGFkanVzdCBmb3Igc3ViZnJh bWVzLgotICAgICAgICBzdGQ6OnZlY3RvcjxQbGF0Zm9ybTo6SW50UmVjdD4gYWRqdXN0ZWRJbnRS ZWN0czsKICAgICAgICAgUGxhdGZvcm06OkludFJlY3Qgc2VsZWN0aW9uQm91bmRpbmdCb3g7CiAg ICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBxdWFkTGlzdC5zaXplKCk7IGkrKykgewog ICAgICAgICAgICAgV2ViQ29yZTo6SW50UmVjdCBlbmNsb3NpbmdSZWN0ID0gcXVhZExpc3RbaV0u ZW5jbG9zaW5nQm91bmRpbmdCb3goKTsKICAgICAgICAgICAgIGVuY2xvc2luZ1JlY3QuaW50ZXJz ZWN0KGZyYW1lUmVjdCk7CiAgICAgICAgICAgICBlbmNsb3NpbmdSZWN0Lm1vdmUoZnJhbWVQb3Np dGlvbi54KCksIGZyYW1lUG9zaXRpb24ueSgpKTsKLSAgICAgICAgICAgIGFkanVzdGVkSW50UmVj dHMucHVzaF9iYWNrKGVuY2xvc2luZ1JlY3QpOworICAgICAgICAgICAgcmVnaW9uID0gdW5pb25S ZWdpb25zKHJlZ2lvbiwgSW50UmVjdFJlZ2lvbihlbmNsb3NpbmdSZWN0KSk7CiAKICAgICAgICAg ICAgIC8vIENsaXAgdG8gdGhlIHZpc2libGUgY29udGVudC4KICAgICAgICAgICAgIGlmIChjbGlw cGluZ1JlY3QubG9jYXRpb24oKSAhPSBET01TdXBwb3J0OjpJbnZhbGlkUG9pbnQpCi0tIAoxLjcu NS40Cgo=