83349 2012-04-05 20:56:05 -0700 [BlackBerry] We shouldn't set empty Content-Length & Content-Type to request's headers. 2012-04-12 01:37:48 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit webkit-unassigned charles.wei leo.yang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 597186 0 jasonliuwebkit 2012-04-05 20:56:05 -0700 When there is a redirection for a POST request, we change POST to GET and make Content-Length/Content-Type to empty string. We should remove these headers instead of adding empty strings. 597192 1 135979 jasonliuwebkit 2012-04-05 21:26:43 -0700 Created attachment 135979 Patch 597242 2 135979 leo.yang 2012-04-06 00:54:41 -0700 Comment on attachment 135979 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135979&action=review > Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:210 > + m_httpHeaderFields.remove("Content-Length"); > + > + if (url().protocolInHTTPFamily()) > + m_platformRequestUpdated = false; Just ASSERT(url().protocolInHTTPFamily()) instead of *if* branch? > Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:220 > + m_httpHeaderFields.remove("Content-Type"); > + > + if (url().protocolInHTTPFamily()) > + m_platformRequestUpdated = false; Ditto. 597251 3 jasonliuwebkit 2012-04-06 01:20:38 -0700 (In reply to comment #2) > (From update of attachment 135979 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135979&action=review > > > Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:210 > > + m_httpHeaderFields.remove("Content-Length"); > > + > > + if (url().protocolInHTTPFamily()) > > + m_platformRequestUpdated = false; > > Just ASSERT(url().protocolInHTTPFamily()) instead of *if* branch? > > > Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:220 > > + m_httpHeaderFields.remove("Content-Type"); > > + > > + if (url().protocolInHTTPFamily()) > > + m_platformRequestUpdated = false; > > Ditto. Why don't we do as clearHTTPReferrer? If we remove this *if* branch, "updateResourceRequest();" can be moved, too. 598181 4 jasonliuwebkit 2012-04-09 02:06:57 -0700 r? 598898 5 135979 leo.yang 2012-04-09 19:16:21 -0700 Comment on attachment 135979 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135979&action=review OK, let's keep consistent with clearHTTPReferrer. Looks good to me. >>> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:210 >>> + m_httpHeaderFields.remove("Content-Length"); >>> + >>> + if (url().protocolInHTTPFamily()) >>> + m_platformRequestUpdated = false; >> >> Just ASSERT(url().protocolInHTTPFamily()) instead of *if* branch? > > Why don't we do as clearHTTPReferrer? > If we remove this *if* branch, "updateResourceRequest();" can be moved, too. Just ASSERT(url().protocolInHTTPFamily()) instead of *if* branch? >> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:220 >> + m_httpHeaderFields.remove("Content-Type"); >> + >> + if (url().protocolInHTTPFamily()) >> + m_platformRequestUpdated = false; > > Ditto. Ditto. 600906 6 135979 staikos 2012-04-11 22:52:43 -0700 Comment on attachment 135979 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135979&action=review I agree with Leo's comments. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:587 > if ((method != "GET") && (method != "HEAD")) { There are extra parentheses here 600918 7 136830 jasonliuwebkit 2012-04-11 23:13:44 -0700 Created attachment 136830 Patch 600923 8 jasonliuwebkit 2012-04-11 23:19:46 -0700 (In reply to comment #6) > (From update of attachment 135979 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135979&action=review > > I agree with Leo's comments. These two functions are written according to ResourceRequestBase::clearHTTPReferrer(). And Leo's comment #5 has approved. > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:587 > > if ((method != "GET") && (method != "HEAD")) { > > There are extra parentheses here I amended this issue in the new patch. 601005 9 136830 webkit.review.bot 2012-04-12 01:37:43 -0700 Comment on attachment 136830 Patch Clearing flags on attachment: 136830 Committed r113950: <http://trac.webkit.org/changeset/113950> 601006 10 webkit.review.bot 2012-04-12 01:37:48 -0700 All reviewed patches have been landed. Closing bug. 135979 2012-04-05 21:26:43 -0700 2012-04-11 23:13:30 -0700 Patch bug-83349-20120406122640.patch text/plain 3802 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc2Mzc1MWVmODIwMThj NGI5YWVjMTkyZGY3NmM4OWFhODE2NjBjYi4uMmIxZDU0MGUyYTc5M2I0MTA5NDM0MjY3ODljODI4 ZmQ4NDFiNTFiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA0LTA1ICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBXZSBzaG91bGRuJ3Qgc2V0IGVtcHR5IENvbnRlbnQtTGVuZ3RoICYgQ29udGVudC1UeXBl IHRvIGEgcmVxdWVzdCdzIGhlYWRlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04MzM0OQorCisgICAgICAgIFdoZW4gdGhlcmUgaXMgYSByZWRpcmVj dGlvbiBmb3IgYSBQT1NUIHJlcXVlc3QsIHdlIGNoYW5nZSBQT1NUIHRvIEdFVCBhbmQgc2V0Cisg ICAgICAgIENvbnRlbnQtTGVuZ3RoL0NvbnRlbnQtVHlwZSB0byBlbXB0eSBzdHJpbmdzLgorICAg ICAgICBXZSBzaG91bGQgcmVtb3ZlIHRoZXNlIGhlYWRlcnMgaW5zdGVhZCBvZiBhZGRpbmcgZW1w dHkgc3RyaW5ncy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMuIFJlZmFjdG9yLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pv Yjo6aGFuZGxlUmVkaXJlY3QpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9SZXNvdXJjZVJlcXVlc3QuaDoKKyAgICAgICAgKFJlc291cmNlUmVxdWVzdCk6CisgICAgICAg ICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlUmVxdWVzdEJsYWNrQmVycnku Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpjbGVhckhUVFBDb250ZW50 TGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VS ZXF1ZXN0OjpjbGVhckhUVFBDb250ZW50VHlwZSk6CisKIDIwMTItMDQtMDUgIERhdmlkIEJhcnRv biAgPGRiYXJ0b25AbWF0aHNjcmliZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGludHJpbnNpYyBw YWRkaW5nIGZyb20gY29udGVudEJveFJlY3QoKSwgZXRjLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmluZGV4 IGE0YmFmZDRjOThiNzkwYjVhM2Y0M2Y5ODIxNmVjZGM3MWUxNTc4NmYuLjhkOWRkY2E2ZmQxY2Zl MzliODdlNGIzNWIwNzViZDc0NmMwMDVjYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKQEAgLTU4Nyw4 ICs1ODcsOCBAQCBib29sIE5ldHdvcmtKb2I6OmhhbmRsZVJlZGlyZWN0KCkKICAgICBpZiAoKG1l dGhvZCAhPSAiR0VUIikgJiYgKG1ldGhvZCAhPSAiSEVBRCIpKSB7CiAgICAgICAgIG5ld1JlcXVl c3Quc2V0SFRUUE1ldGhvZCgiR0VUIik7CiAgICAgICAgIG5ld1JlcXVlc3Quc2V0SFRUUEJvZHko MCk7Ci0gICAgICAgIG5ld1JlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKCJDb250ZW50LUxlbmd0 aCIsIFN0cmluZygpKTsKLSAgICAgICAgbmV3UmVxdWVzdC5zZXRIVFRQSGVhZGVyRmllbGQoIkNv bnRlbnQtVHlwZSIsIFN0cmluZygpKTsKKyAgICAgICAgbmV3UmVxdWVzdC5jbGVhckhUVFBDb250 ZW50TGVuZ3RoKCk7CisgICAgICAgIG5ld1JlcXVlc3QuY2xlYXJIVFRQQ29udGVudFR5cGUoKTsK ICAgICB9CiAKICAgICAvLyBEbyBub3Qgc2VuZCBleGlzdGluZyBjcmVkZW50aWFscyB3aXRoIHRo ZSBuZXcgcmVxdWVzdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3QuaAppbmRleCAzYjhhNDc5ODJjZDEw YmU3NGNmN2ZmYThlZDIyZjU3YzhlMTliNzgyLi4zOTVjNWIzYTFhMGI2NzM0YWFkZWI3MjU1ZTJm ZTc1ZWI3MmRjMDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlUmVxdWVzdC5oCkBAIC0xMjIsNiArMTIyLDkg QEAgcHVibGljOgogICAgIFRhcmdldFR5cGUgdGFyZ2V0VHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1f dGFyZ2V0VHlwZTsgfQogICAgIHZvaWQgc2V0VGFyZ2V0VHlwZShUYXJnZXRUeXBlIHR5cGUpIHsg bV90YXJnZXRUeXBlID0gdHlwZTsgfQogCisgICAgdm9pZCBjbGVhckhUVFBDb250ZW50TGVuZ3Ro KCk7CisgICAgdm9pZCBjbGVhckhUVFBDb250ZW50VHlwZSgpOworCiBwcml2YXRlOgogICAgIGZy aWVuZCBjbGFzcyBSZXNvdXJjZVJlcXVlc3RCYXNlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJy eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3Vy Y2VSZXF1ZXN0QmxhY2tCZXJyeS5jcHAKaW5kZXggNDQyMTg0N2Q1NzZiOTViNzI0Y2IxNGJjYzgx YzcxYTY3ZjQ0NjYxMi4uOGE4OWQ4NTU2MWFiYjNjNmIwZDJiNTc5YzY4YzU0YWYyOTNhYjE5MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jl c291cmNlUmVxdWVzdEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcApAQCAtMjAw LDQgKzIwMCwyNCBAQCB2b2lkIFJlc291cmNlUmVxdWVzdDo6ZG9QbGF0Zm9ybUFkb3B0KFBhc3NP d25QdHI8Q3Jvc3NUaHJlYWRSZXNvdXJjZVJlcXVlc3REYXRhPgogICAgIG1fZm9yY2VEb3dubG9h ZCA9IGRhdGEtPm1fZm9yY2VEb3dubG9hZDsKIH0KIAordm9pZCBSZXNvdXJjZVJlcXVlc3Q6OmNs ZWFySFRUUENvbnRlbnRMZW5ndGgoKQoreworICAgIHVwZGF0ZVJlc291cmNlUmVxdWVzdCgpOwor CisgICAgbV9odHRwSGVhZGVyRmllbGRzLnJlbW92ZSgiQ29udGVudC1MZW5ndGgiKTsKKworICAg IGlmICh1cmwoKS5wcm90b2NvbEluSFRUUEZhbWlseSgpKQorICAgICAgICBtX3BsYXRmb3JtUmVx dWVzdFVwZGF0ZWQgPSBmYWxzZTsKK30KKwordm9pZCBSZXNvdXJjZVJlcXVlc3Q6OmNsZWFySFRU UENvbnRlbnRUeXBlKCkKK3sKKyAgICB1cGRhdGVSZXNvdXJjZVJlcXVlc3QoKTsKKworICAgIG1f aHR0cEhlYWRlckZpZWxkcy5yZW1vdmUoIkNvbnRlbnQtVHlwZSIpOworCisgICAgaWYgKHVybCgp LnByb3RvY29sSW5IVFRQRmFtaWx5KCkpCisgICAgICAgIG1fcGxhdGZvcm1SZXF1ZXN0VXBkYXRl ZCA9IGZhbHNlOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 136830 2012-04-11 23:13:44 -0700 2012-04-12 01:37:43 -0700 Patch bug-83349-20120412141342.patch text/plain 3955 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc2Mzc1MWVmODIwMThj NGI5YWVjMTkyZGY3NmM4OWFhODE2NjBjYi4uMmIxZDU0MGUyYTc5M2I0MTA5NDM0MjY3ODljODI4 ZmQ4NDFiNTFiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA0LTA1ICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBXZSBzaG91bGRuJ3Qgc2V0IGVtcHR5IENvbnRlbnQtTGVuZ3RoICYgQ29udGVudC1UeXBl IHRvIGEgcmVxdWVzdCdzIGhlYWRlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04MzM0OQorCisgICAgICAgIFdoZW4gdGhlcmUgaXMgYSByZWRpcmVj dGlvbiBmb3IgYSBQT1NUIHJlcXVlc3QsIHdlIGNoYW5nZSBQT1NUIHRvIEdFVCBhbmQgc2V0Cisg ICAgICAgIENvbnRlbnQtTGVuZ3RoL0NvbnRlbnQtVHlwZSB0byBlbXB0eSBzdHJpbmdzLgorICAg ICAgICBXZSBzaG91bGQgcmVtb3ZlIHRoZXNlIGhlYWRlcnMgaW5zdGVhZCBvZiBhZGRpbmcgZW1w dHkgc3RyaW5ncy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMuIFJlZmFjdG9yLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pv Yjo6aGFuZGxlUmVkaXJlY3QpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9SZXNvdXJjZVJlcXVlc3QuaDoKKyAgICAgICAgKFJlc291cmNlUmVxdWVzdCk6CisgICAgICAg ICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlUmVxdWVzdEJsYWNrQmVycnku Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpjbGVhckhUVFBDb250ZW50 TGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VS ZXF1ZXN0OjpjbGVhckhUVFBDb250ZW50VHlwZSk6CisKIDIwMTItMDQtMDUgIERhdmlkIEJhcnRv biAgPGRiYXJ0b25AbWF0aHNjcmliZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGludHJpbnNpYyBw YWRkaW5nIGZyb20gY29udGVudEJveFJlY3QoKSwgZXRjLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmluZGV4 IGE0YmFmZDRjOThiNzkwYjVhM2Y0M2Y5ODIxNmVjZGM3MWUxNTc4NmYuLjY1MTY1ODY2YTk5N2E3 NWU4ZDgxNWIyYThhNTUzNzZhZjM2MTg3MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKQEAgLTU4NCwx MSArNTg0LDExIEBAIGJvb2wgTmV0d29ya0pvYjo6aGFuZGxlUmVkaXJlY3QoKQogICAgIG5ld1Jl cXVlc3Quc2V0TXVzdEhhbmRsZUludGVybmFsbHkodHJ1ZSk7CiAKICAgICBTdHJpbmcgbWV0aG9k ID0gbmV3UmVxdWVzdC5odHRwTWV0aG9kKCkudXBwZXIoKTsKLSAgICBpZiAoKG1ldGhvZCAhPSAi R0VUIikgJiYgKG1ldGhvZCAhPSAiSEVBRCIpKSB7CisgICAgaWYgKG1ldGhvZCAhPSAiR0VUIiAm JiBtZXRob2QgIT0gIkhFQUQiKSB7CiAgICAgICAgIG5ld1JlcXVlc3Quc2V0SFRUUE1ldGhvZCgi R0VUIik7CiAgICAgICAgIG5ld1JlcXVlc3Quc2V0SFRUUEJvZHkoMCk7Ci0gICAgICAgIG5ld1Jl cXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKCJDb250ZW50LUxlbmd0aCIsIFN0cmluZygpKTsKLSAg ICAgICAgbmV3UmVxdWVzdC5zZXRIVFRQSGVhZGVyRmllbGQoIkNvbnRlbnQtVHlwZSIsIFN0cmlu ZygpKTsKKyAgICAgICAgbmV3UmVxdWVzdC5jbGVhckhUVFBDb250ZW50TGVuZ3RoKCk7CisgICAg ICAgIG5ld1JlcXVlc3QuY2xlYXJIVFRQQ29udGVudFR5cGUoKTsKICAgICB9CiAKICAgICAvLyBE byBub3Qgc2VuZCBleGlzdGluZyBjcmVkZW50aWFscyB3aXRoIHRoZSBuZXcgcmVxdWVzdC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNv dXJjZVJlcXVlc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9SZXNvdXJjZVJlcXVlc3QuaAppbmRleCAzYjhhNDc5ODJjZDEwYmU3NGNmN2ZmYThlZDIyZjU3 YzhlMTliNzgyLi4zOTVjNWIzYTFhMGI2NzM0YWFkZWI3MjU1ZTJmZTc1ZWI3MmRjMDJhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3Vy Y2VSZXF1ZXN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2Jl cnJ5L1Jlc291cmNlUmVxdWVzdC5oCkBAIC0xMjIsNiArMTIyLDkgQEAgcHVibGljOgogICAgIFRh cmdldFR5cGUgdGFyZ2V0VHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fdGFyZ2V0VHlwZTsgfQogICAg IHZvaWQgc2V0VGFyZ2V0VHlwZShUYXJnZXRUeXBlIHR5cGUpIHsgbV90YXJnZXRUeXBlID0gdHlw ZTsgfQogCisgICAgdm9pZCBjbGVhckhUVFBDb250ZW50TGVuZ3RoKCk7CisgICAgdm9pZCBjbGVh ckhUVFBDb250ZW50VHlwZSgpOworCiBwcml2YXRlOgogICAgIGZyaWVuZCBjbGFzcyBSZXNvdXJj ZVJlcXVlc3RCYXNlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJy eS5jcHAKaW5kZXggNDQyMTg0N2Q1NzZiOTViNzI0Y2IxNGJjYzgxYzcxYTY3ZjQ0NjYxMi4uOGE4 OWQ4NTU2MWFiYjNjNmIwZDJiNTc5YzY4YzU0YWYyOTNhYjE5MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlUmVxdWVzdEJsYWNr QmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9SZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcApAQCAtMjAwLDQgKzIwMCwyNCBAQCB2b2lk IFJlc291cmNlUmVxdWVzdDo6ZG9QbGF0Zm9ybUFkb3B0KFBhc3NPd25QdHI8Q3Jvc3NUaHJlYWRS ZXNvdXJjZVJlcXVlc3REYXRhPgogICAgIG1fZm9yY2VEb3dubG9hZCA9IGRhdGEtPm1fZm9yY2VE b3dubG9hZDsKIH0KIAordm9pZCBSZXNvdXJjZVJlcXVlc3Q6OmNsZWFySFRUUENvbnRlbnRMZW5n dGgoKQoreworICAgIHVwZGF0ZVJlc291cmNlUmVxdWVzdCgpOworCisgICAgbV9odHRwSGVhZGVy RmllbGRzLnJlbW92ZSgiQ29udGVudC1MZW5ndGgiKTsKKworICAgIGlmICh1cmwoKS5wcm90b2Nv bEluSFRUUEZhbWlseSgpKQorICAgICAgICBtX3BsYXRmb3JtUmVxdWVzdFVwZGF0ZWQgPSBmYWxz ZTsKK30KKwordm9pZCBSZXNvdXJjZVJlcXVlc3Q6OmNsZWFySFRUUENvbnRlbnRUeXBlKCkKK3sK KyAgICB1cGRhdGVSZXNvdXJjZVJlcXVlc3QoKTsKKworICAgIG1faHR0cEhlYWRlckZpZWxkcy5y ZW1vdmUoIkNvbnRlbnQtVHlwZSIpOworCisgICAgaWYgKHVybCgpLnByb3RvY29sSW5IVFRQRmFt aWx5KCkpCisgICAgICAgIG1fcGxhdGZvcm1SZXF1ZXN0VXBkYXRlZCA9IGZhbHNlOworfQorCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==