83343 2012-04-05 18:41:53 -0700 Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject 2012-06-25 05:16:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric leviw webkit.review.bot oldest_to_newest 597115 0 eae 2012-04-05 18:41:53 -0700 Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject 597121 1 135963 eae 2012-04-05 18:44:38 -0700 Created attachment 135963 Patch 597531 2 135963 webkit.review.bot 2012-04-06 11:56:16 -0700 Comment on attachment 135963 Patch Clearing flags on attachment: 135963 Committed r113471: <http://trac.webkit.org/changeset/113471> 597532 3 webkit.review.bot 2012-04-06 11:56:20 -0700 All reviewed patches have been landed. Closing bug. 656499 4 135963 allan.jensen 2012-06-25 05:16:36 -0700 Comment on attachment 135963 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135963&action=review > Source/WebCore/rendering/RenderEmbeddedObject.cpp:267 > + IntPoint roundedPoint = roundedIntPoint(pointInContainer); > > if (Scrollbar* horizontalScrollbar = view->horizontalScrollbar()) { > - if (horizontalScrollbar->shouldParticipateInHitTesting() && horizontalScrollbar->frameRect().contains(pointInContainer)) { > + if (horizontalScrollbar->shouldParticipateInHitTesting() && horizontalScrollbar->frameRect().contains(roundedPoint)) { I am curious, why is this rounding necessary? 135963 2012-04-05 18:44:38 -0700 2012-06-25 05:16:36 -0700 Patch bug-83343-20120405184437.patch text/plain 3601 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzQwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTA1ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggTGF5b3V0VW5pdCB1c2Fn ZSBhbmQgcm91bmRpbmcgaW4gUmVuZGVyQmxvY2sgYW5kIFJlbmRlckVtYmVkZGVkT2JqZWN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzM0MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB1c2FnZSBv ZiBMYXlvdXRVbml0cyBhbmQgcm91bmRpbmcvcGl4ZWwgc25hcHBpbmcgaW4gUmVuZGVyQmxvY2sg YW5kCisgICAgICAgIFJlbmRlckVtYmVkZGVkT2JqZWN0IGluIHByZXBhcmF0aW9uIGZvciB0dXJp bmcgb24gc3VicGl4ZWwgc3VwcG9ydC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5n ZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpiYXNlbGluZVBvc2l0aW9uKToKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyRW1iZWRkZWRPYmplY3Q6Om5vZGVBdFBvaW50KToKKwogMjAxMi0wNC0wNSAg SGFucyBNdWxsZXIgIDxobXVsbGVyQGFkb2JlLmNvbT4KIAogICAgICAgICBDU1MgRXhjbHVzaW9u cyBwb2x5Z29uIHNoYXBlIGFyZ3VtZW50cyBzaG91bGQgYmUgY29tbWEgc2VwYXJhdGVkCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDExMzM5 NikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTU5MTYsOSArNTkxNiw5IEBAIExheW91dFVuaXQgUmVuZGVyQmxvY2s6OmJhc2Vs aW5lUG9zaXRpb24KICAgICAgICAgYm9vbCBpZ25vcmVCYXNlbGluZSA9IChsYXllcigpICYmIChs YXllcigpLT5tYXJxdWVlKCkgfHwgKGRpcmVjdGlvbiA9PSBIb3Jpem9udGFsTGluZSA/IChsYXll cigpLT52ZXJ0aWNhbFNjcm9sbGJhcigpIHx8IGxheWVyKCktPnNjcm9sbFlPZmZzZXQoKSAhPSAw KQogICAgICAgICAgICAgOiAobGF5ZXIoKS0+aG9yaXpvbnRhbFNjcm9sbGJhcigpIHx8IGxheWVy KCktPnNjcm9sbFhPZmZzZXQoKSAhPSAwKSkpKSB8fCAoaXNXcml0aW5nTW9kZVJvb3QoKSAmJiAh aXNSdWJ5UnVuKCkpOwogICAgICAgICAKLSAgICAgICAgaW50IGJhc2VsaW5lUG9zID0gaWdub3Jl QmFzZWxpbmUgPyBMYXlvdXRVbml0KC0xKSA6IGxhc3RMaW5lQm94QmFzZWxpbmUoKTsKKyAgICAg ICAgTGF5b3V0VW5pdCBiYXNlbGluZVBvcyA9IGlnbm9yZUJhc2VsaW5lID8gc3RhdGljX2Nhc3Q8 TGF5b3V0VW5pdD4oLTEpIDogbGFzdExpbmVCb3hCYXNlbGluZSgpOwogICAgICAgICAKLSAgICAg ICAgaW50IGJvdHRvbU9mQ29udGVudCA9IGRpcmVjdGlvbiA9PSBIb3Jpem9udGFsTGluZSA/IGJv cmRlclRvcCgpICsgcGFkZGluZ1RvcCgpICsgY29udGVudEhlaWdodCgpIDogYm9yZGVyUmlnaHQo KSArIHBhZGRpbmdSaWdodCgpICsgY29udGVudFdpZHRoKCk7CisgICAgICAgIExheW91dFVuaXQg Ym90dG9tT2ZDb250ZW50ID0gZGlyZWN0aW9uID09IEhvcml6b250YWxMaW5lID8gYm9yZGVyVG9w KCkgKyBwYWRkaW5nVG9wKCkgKyBjb250ZW50SGVpZ2h0KCkgOiBib3JkZXJSaWdodCgpICsgcGFk ZGluZ1JpZ2h0KCkgKyBjb250ZW50V2lkdGgoKTsKICAgICAgICAgaWYgKGJhc2VsaW5lUG9zICE9 IC0xICYmIGJhc2VsaW5lUG9zIDw9IGJvdHRvbU9mQ29udGVudCkKICAgICAgICAgICAgIHJldHVy biBkaXJlY3Rpb24gPT0gSG9yaXpvbnRhbExpbmUgPyBtYXJnaW5Ub3AoKSArIGJhc2VsaW5lUG9z IDogbWFyZ2luUmlnaHQoKSArIGJhc2VsaW5lUG9zOwogICAgICAgICAgICAgCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5jcHAJKHJl dmlzaW9uIDExMzM5NikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbWJlZGRl ZE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2MSwxNiArMjYxLDE3IEBAIGJvb2wgUmVu ZGVyRW1iZWRkZWRPYmplY3Q6Om5vZGVBdFBvaW50KGMKICAgICAgICAgcmV0dXJuIHRydWU7CiAK ICAgICBQbHVnaW5WaWV3QmFzZSogdmlldyA9IHN0YXRpY19jYXN0PFBsdWdpblZpZXdCYXNlKj4o d2lkZ2V0KCkpOworICAgIEludFBvaW50IHJvdW5kZWRQb2ludCA9IHJvdW5kZWRJbnRQb2ludChw b2ludEluQ29udGFpbmVyKTsKIAogICAgIGlmIChTY3JvbGxiYXIqIGhvcml6b250YWxTY3JvbGxi YXIgPSB2aWV3LT5ob3Jpem9udGFsU2Nyb2xsYmFyKCkpIHsKLSAgICAgICAgaWYgKGhvcml6b250 YWxTY3JvbGxiYXItPnNob3VsZFBhcnRpY2lwYXRlSW5IaXRUZXN0aW5nKCkgJiYgaG9yaXpvbnRh bFNjcm9sbGJhci0+ZnJhbWVSZWN0KCkuY29udGFpbnMocG9pbnRJbkNvbnRhaW5lcikpIHsKKyAg ICAgICAgaWYgKGhvcml6b250YWxTY3JvbGxiYXItPnNob3VsZFBhcnRpY2lwYXRlSW5IaXRUZXN0 aW5nKCkgJiYgaG9yaXpvbnRhbFNjcm9sbGJhci0+ZnJhbWVSZWN0KCkuY29udGFpbnMocm91bmRl ZFBvaW50KSkgewogICAgICAgICAgICAgcmVzdWx0LnNldFNjcm9sbGJhcihob3Jpem9udGFsU2Ny b2xsYmFyKTsKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CiAgICAgfQogCiAg ICAgaWYgKFNjcm9sbGJhciogdmVydGljYWxTY3JvbGxiYXIgPSB2aWV3LT52ZXJ0aWNhbFNjcm9s bGJhcigpKSB7Ci0gICAgICAgIGlmICh2ZXJ0aWNhbFNjcm9sbGJhci0+c2hvdWxkUGFydGljaXBh dGVJbkhpdFRlc3RpbmcoKSAmJiB2ZXJ0aWNhbFNjcm9sbGJhci0+ZnJhbWVSZWN0KCkuY29udGFp bnMocG9pbnRJbkNvbnRhaW5lcikpIHsKKyAgICAgICAgaWYgKHZlcnRpY2FsU2Nyb2xsYmFyLT5z aG91bGRQYXJ0aWNpcGF0ZUluSGl0VGVzdGluZygpICYmIHZlcnRpY2FsU2Nyb2xsYmFyLT5mcmFt ZVJlY3QoKS5jb250YWlucyhyb3VuZGVkUG9pbnQpKSB7CiAgICAgICAgICAgICByZXN1bHQuc2V0 U2Nyb2xsYmFyKHZlcnRpY2FsU2Nyb2xsYmFyKTsKICAgICAgICAgICAgIHJldHVybiB0cnVlOwog ICAgICAgICB9Cg==