83342 2012-04-05 18:27:33 -0700 webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files 2016-07-28 13:22:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=160302 P2 Normal --- 1 fischman ddkilzer commit-queue darin dbates ddkilzer glenn mcatanzaro rniwa youennf oldest_to_newest 597106 0 fischman 2012-04-05 18:27:33 -0700 Apparently webkit-patch upload's --suggest-reviewers feature is broken in the presence of moved (removed?) files. After moving a test & its expectation from LayoutTests/http/tests/media to LayoutTests/media the upload failed like this: $ ./Tools/Scripts/webkit-patch upload --request-commit --suggest-reviewers 83296 Total errors found: 0 in 4 files Was that diff correct? [Y/n]: Fetching: https://bugs.webkit.org/show_bug.cgi?id=83296&ctype=xml Path /usr/local/google/fischman/src/chromium/src/third_party/WebKit/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt does not exist. Path /usr/local/google/fischman/src/chromium/src/third_party/WebKit/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt does not exist. Removing the --suggest-reviewers option made it work just fine. 1215334 1 284804 ddkilzer 2016-07-28 12:47:46 -0700 Created attachment 284804 Patch v1 1215336 2 commit-queue 2016-07-28 12:50:37 -0700 Attachment 284804 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:413: [SCMTest._shared_test_revisions_changing_file] Instance of 'SCMTest' has no 'scm' member [pylint/E1101] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1215339 3 ddkilzer 2016-07-28 12:52:38 -0700 (In reply to comment #2) > Attachment 284804 [details] did not pass style-queue: > > ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:413: > [SCMTest._shared_test_revisions_changing_file] Instance of 'SCMTest' has no > 'scm' member [pylint/E1101] [5] > Total errors found: 1 in 4 files This can be safely ignored. Tests pass despite this warning. 1215357 4 284804 commit-queue 2016-07-28 13:22:15 -0700 Comment on attachment 284804 Patch v1 Clearing flags on attachment: 284804 Committed r203832: <http://trac.webkit.org/changeset/203832> 1215358 5 commit-queue 2016-07-28 13:22:20 -0700 All reviewed patches have been landed. Closing bug. 284804 2016-07-28 12:47:46 -0700 2016-07-28 13:22:15 -0700 Patch v1 bug-83342-20160728124633.patch text/plain 6696 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzODE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2FkMjdmNmU3MDViN2UyNzAwZDUxNWUyYjdhZDFhYzE0 OGQ3ZjJiMi4uZDQ1MmRlN2VmMDE1MjU0MDM0ZWI4NzU2ZTE2ZmY4MzcyN2U1MTVlNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2 IEBACiAyMDE2LTA3LTI4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAg ICAgICAgd2Via2l0LXBhdGNoIHVwbG9hZCAtLXN1Z2dlc3QtcmV2aWV3ZXJzIHNob3VsZG4ndCBi cmVhayBpbiB0aGUgcHJlc2VuY2Ugb2YgZGVsZXRlZCBvciBtb3ZlZCBmaWxlcworICAgICAgICA8 aHR0cHM6Ly93ZWJraXQub3JnL2IvODMzNDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9z Y20vZ2l0LnB5OgorICAgICAgICAoR2l0LnJldmlzaW9uc19jaGFuZ2luZ19maWxlKTogUmVtb3Zl IGNvZGUgdG8gcmFpc2UgYW4gZXhjZXB0aW9uCisgICAgICAgIHdoZW4gdGhlIGZpbGUgZG9lc24n dCBleGlzdC4gIElmIGEgZmlsZSB3YXMgbW92ZWQgb3IgcmVuYW1lZCwKKyAgICAgICAgdGhlbiB0 aGlzIGNhdXNlZCB0aGUgc2NyaXB0IHRvIHRlcm1pbmF0ZSwgd2hpY2ggd2FzIHZlcnkKKyAgICAg ICAgZnJ1c3RyYXRpbmcgd2hlbiB5b3Ugd2FudGVkIGEgbGlzdCBvZiByZXZpZXdlcnMuCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3NjbV91bml0dGVzdC5w eToKKyAgICAgICAgKFNDTVRlc3QuX3NoYXJlZF90ZXN0X3JldmlzaW9uc19jaGFuZ2luZ19maWxl KTogVXBkYXRlIHRlc3QKKyAgICAgICAgZXhwZWN0YXRpb24gdG8gcmV0dXJuIGFuIGVtcHR5IGxp c3Qgb2YgcmV2aXNpb25zLgorICAgICAgICAodGVzdF9jcmVhdGVfcGF0Y2hfaXNfZnVsbF9wYXRj aCk6IERyaXZlLWJ5IGZpeCB3aGVuIHJ1bm5pbmcgYWxsCisgICAgICAgIHdlYmtpdHB5IHRlc3Rz IChpbmNsdWRpbmcgc2NtIHRlc3RzKS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jaGVja291dC9zY20vc3ZuLnB5OgorICAgICAgICAoU1ZOLnJldmlzaW9uc19jaGFuZ2luZ19m aWxlKTogQ2F0Y2ggU2NyaXB0RXJyb3IgZXhjZXB0aW9ucyBhbmQKKyAgICAgICAgcmV0dXJuIGFu IGVtcHR5IGFycmF5IG9mIHJldmlzaW9ucyBpZiB0aGlzIG9jY3Vycy4KKworMjAxNi0wNy0yOCAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFJlbW92ZSB1bnVz ZWQgY2hlY2stZm9yLWV4aXQtdGltZS1kZXN0cnVjdG9ycywgY2hlY2stZm9yLWdsb2JhbC1pbml0 aWFsaXplcnMgc2NyaXB0cyBhbmQgZGVwbG95IC1XZXhpdC10aW1lLWRlc3RydWN0b3JzLCAtV2ds b2JhbC1jb25zdHJ1Y3RvcnMgY2xhbmcgc3dpdGNoZXMgY29uc2lzdGVudGx5CiAgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xNjAzMDI+CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9naXQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9zY20vZ2l0LnB5CmluZGV4IGI0NWIwMmMwNjI0YTU0Y2UwZjky NTMyY2I1YTVmMTc3N2Q4OTE0YjkuLjRmYzEyZmRhYjhkZWNjNmQ0N2NkNmYzMWVmY2ZjZGUzODQw YjAzZGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0 L3NjbS9naXQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQv c2NtL2dpdC5weQpAQCAtMSw1ICsxLDUgQEAKICMgQ29weXJpZ2h0IChjKSAyMDA5LCAyMDEwLCAy MDExIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0jIENvcHlyaWdodCAoYykgMjAw OSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoYykgMjAwOSwg MjAxNiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9u IGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBt b2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNv bmRpdGlvbnMgYXJlCkBAIC0yNDIsMTAgKzI0Miw2IEBAIGNsYXNzIEdpdChTQ00sIFNWTlJlcG9z aXRvcnkpOgogICAgICAgICByZXR1cm4gc2VsZi5fY2hhbmdlc19maWxlc19mb3JfY29tbWl0KGNv bW1pdF9pZCkKIAogICAgIGRlZiByZXZpc2lvbnNfY2hhbmdpbmdfZmlsZShzZWxmLCBwYXRoLCBs aW1pdD01KToKLSAgICAgICAgIyByYWlzZSBhIHNjcmlwdCBlcnJvciBpZiBwYXRoIGRvZXMgbm90 IGV4aXN0cyB0byBtYXRjaCB0aGUgYmVoYXZpb3Igb2YgIHRoZSBzdm4gaW1wbGVtZW50YXRpb24u Ci0gICAgICAgIGlmIG5vdCBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhwYXRoKToKLSAgICAgICAg ICAgIHJhaXNlIFNjcmlwdEVycm9yKG1lc3NhZ2U9IlBhdGggJXMgZG9lcyBub3QgZXhpc3QuIiAl IHBhdGgpCi0KICAgICAgICAgIyBnaXQgcmV2LWxpc3QgaGVhZCAtLXJlbW92ZS1lbXB0eSAtLWxp bWl0PTUgLS0gcGF0aCB3b3VsZCBiZSBlcXVpdmFsZW50LgogICAgICAgICBjb21taXRfaWRzID0g c2VsZi5fcnVuX2dpdChbImxvZyIsICItLXJlbW92ZS1lbXB0eSIsICItLXByZXR0eT1mb3JtYXQ6 JUgiLCAiLSVzIiAlIGxpbWl0LCAiLS0iLCBwYXRoXSkuc3BsaXRsaW5lcygpCiAgICAgICAgIHJl dHVybiBmaWx0ZXIobGFtYmRhIHJldmlzaW9uOiByZXZpc2lvbiwgbWFwKHNlbGYuc3ZuX3Jldmlz aW9uX2Zyb21fZ2l0X2NvbW1pdCwgY29tbWl0X2lkcykpCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc2NtX3VuaXR0ZXN0LnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3NjbV91bml0dGVzdC5weQppbmRl eCBiZDcxYzVlM2M3N2ExNTQyYjAxNDFmYjRhNTkxYTk5OTMyMDg2YTVmLi5jYmRhYWRhNjVmZjZi ZjgxY2E3MTk5YjBmYjhjYTJjZGQ0OGU1YmYxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc2NtX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zY21fdW5pdHRlc3QucHkKQEAgLTEs NSArMSw1IEBACiAjIENvcHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgotIyBDb3B5cmlnaHQgKEMpIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMDksIDIwMTYgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgogIyBDb3B5cmlnaHQgKEMpIDIwMTEgRGFuaWVsIEJhdGVzIChkYmF0ZXNAaW50dWRh dGEuY29tKS4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkBAIC00MTAsNyAr NDEwLDcgQEAgY2xhc3MgU0NNVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICBkZWYgX3No YXJlZF90ZXN0X3JldmlzaW9uc19jaGFuZ2luZ19maWxlKHNlbGYpOgogICAgICAgICBzZWxmLmFz c2VydEl0ZW1zRXF1YWwoc2VsZi5zY20ucmV2aXNpb25zX2NoYW5naW5nX2ZpbGUoInRlc3RfZmls ZSIpLCBbNSwgNCwgMywgMl0pCi0gICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKFNjcmlwdEVycm9y LCBzZWxmLnNjbS5yZXZpc2lvbnNfY2hhbmdpbmdfZmlsZSwgIm5vbl9leGlzdGVudF9maWxlIikK KyAgICAgICAgc2VsZi5hc3NlcnRJdGVtc0VxdWFsKHNlbGYuc2NtLnJldmlzaW9uc19jaGFuZ2lu Z19maWxlKCJub25fZXhpc3RlbnRfZmlsZSIpLCBbXSkKIAogICAgIGRlZiBfc2hhcmVkX3Rlc3Rf Y29tbWl0dGVyX2VtYWlsX2Zvcl9yZXZpc2lvbihzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChzZWxmLnNjbS5jb21taXR0ZXJfZW1haWxfZm9yX3JldmlzaW9uKDMpLCBnZXRwYXNzLmdl dHVzZXIoKSkgICMgQ29tbWl0dGVyICJlbWFpbCIgd2lsbCBiZSB0aGUgY3VycmVudCB1c2VyCkBA IC03MDQsOSArNzA0LDE2IEBAIGNsYXNzIFNWTlRlc3QoU0NNVGVzdCk6CiAgICAgICAgIG9zLmNo ZGlyKHRlc3RfZGlyX3BhdGgpCiAgICAgICAgIHNjbSA9IGRldGVjdF9zY21fc3lzdGVtKHRlc3Rf ZGlyX3BhdGgpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2NtLmNoZWNrb3V0X3Jvb3QsIHNl bGYuc3ZuX2NoZWNrb3V0X3BhdGgpICMgU2FuaXR5IGNoZWNrIHRoYXQgZGV0ZWN0aW9uIHdvcmtl ZCByaWdodC4KLSAgICAgICAgcGF0Y2hfY29udGVudHMgPSBzY20uY3JlYXRlX3BhdGNoKCkKLSAg ICAgICAgIyBPdXIgZmFrZSAnc3ZuLWNyZWF0ZS1wYXRjaCcgcmV0dXJucyAkUFdEIGluc3RlYWQg b2YgYSBwYXRjaCwgY2hlY2sgdGhhdCBpdCB3YXMgZXhlY3V0ZWQgZnJvbSB0aGUgcm9vdCBvZiB0 aGUgcmVwby4KLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgiJXNcbiIgJSBvcy5wYXRoLnJlYWxw YXRoKHNjbS5jaGVja291dF9yb290KSwgcGF0Y2hfY29udGVudHMpICAjIEFkZCBhIFxuIGJlY2F1 c2UgZWNobyBhZGRzIGEgXG4uCisgICAgICAgIGFjdHVhbF9wYXRjaF9jb250ZW50cyA9IHNjbS5j cmVhdGVfcGF0Y2goKQorICAgICAgICBleHBlY3RlZF9wYXRjaF9jb250ZW50cyA9ICIiIkluZGV4 OiB0ZXN0X2RpcjIvdGVzdF9maWxlMgorPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQorLS0tIHRlc3RfZGlyMi90ZXN0X2Zp bGUyXHQocmV2aXNpb24gMCkKKysrKyB0ZXN0X2RpcjIvdGVzdF9maWxlMlx0KHdvcmtpbmcgY29w eSkKK0BAIC0wLDAgKzEgQEAKKyt0ZXN0IGNvbnRlbnQKK1xcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKKyIiIgorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGV4cGVjdGVkX3BhdGNoX2NvbnRl bnRzLCBhY3R1YWxfcGF0Y2hfY29udGVudHMpCiAKICAgICBkZWYgdGVzdF9kZXRlY3Rpb24oc2Vs Zik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5zY20uZGlzcGxheV9uYW1lKCksICJz dm4iKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQv c2NtL3N2bi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9z dm4ucHkKaW5kZXggMDMwODYwNDcyZWI2YTcyOWUzYTAyZWZmZWQ0ZDM0NThiNDNkMWIxOS4uMjA4 ZTllZmViNzM1ZGY5Y2IyYTk3MTQ4YzIxNDQ4Yzc1N2EzYjE0YSAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3N2bi5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc3ZuLnB5CkBAIC0xLDUgKzEsNSBA QAogIyBDb3B5cmlnaHQgKGMpIDIwMDksIDIwMTAsIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KLSMgQ29weXJpZ2h0IChjKSAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChjKSAyMDA5LCAyMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTIzNiw5ICsy MzYsMTMgQEAgY2xhc3MgU1ZOKFNDTSwgU1ZOUmVwb3NpdG9yeSk6CiAKICAgICBkZWYgcmV2aXNp b25zX2NoYW5naW5nX2ZpbGUoc2VsZiwgcGF0aCwgbGltaXQ9NSk6CiAgICAgICAgIHJldmlzaW9u cyA9IFtdCi0gICAgICAgICMgc3ZuIGxvZyB3aWxsIGV4aXQoMSkgKGFuZCB0aHVzIHNlbGYucnVu IHdpbGwgcmFpc2UpIGlmIHRoZSBwYXRoIGRvZXMgbm90IGV4aXN0LgorICAgICAgICAjIHN2biBs b2cgd2lsbCBleGl0KDEpIChhbmQgdGh1cyBzZWxmLnJ1biB3aWxsIHJhaXNlKSBpZiBhIHBhdGgg aXMgbm90IGtub3duIHRvIHN2bi4KICAgICAgICAgbG9nX2NvbW1hbmQgPSBbJ2xvZycsICctLXF1 aWV0JywgJy0tbGltaXQ9JXMnICUgbGltaXQsIHBhdGhdCi0gICAgICAgIGZvciBsaW5lIGluIHNl bGYuX3J1bl9zdm4obG9nX2NvbW1hbmQsIGN3ZD1zZWxmLmNoZWNrb3V0X3Jvb3QpLnNwbGl0bGlu ZXMoKToKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgbG9nX291dHB1dCA9IHNlbGYuX3J1bl9z dm4obG9nX2NvbW1hbmQsIGN3ZD1zZWxmLmNoZWNrb3V0X3Jvb3QpCisgICAgICAgIGV4Y2VwdCBT Y3JpcHRFcnJvciwgZToKKyAgICAgICAgICAgIHJldHVybiBbXQorICAgICAgICBmb3IgbGluZSBp biBsb2dfb3V0cHV0LnNwbGl0bGluZXMoKToKICAgICAgICAgICAgIG1hdGNoID0gcmUuc2VhcmNo KCdecig/UDxyZXZpc2lvbj5cZCspICcsIGxpbmUpCiAgICAgICAgICAgICBpZiBub3QgbWF0Y2g6 CiAgICAgICAgICAgICAgICAgY29udGludWUK