83325 2012-04-05 16:11:34 -0700 Get rid of the useless flag PREEMPT_GEOLOCATION_PERMISSION 2012-04-14 13:29:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin ap jberlin rniwa oldest_to_newest 596993 0 benjamin 2012-04-05 16:11:34 -0700 The flag PREEMPT_GEOLOCATION_PERMISSION was added in http://trac.webkit.org/changeset/63742 around some code of Geolocation. I could not find any case where PREEMPT_GEOLOCATION_PERMISSION is not used. Unless someone does not use this flag, I plan to remove the flag and the related useless code. 597011 1 135933 benjamin 2012-04-05 16:33:57 -0700 Created attachment 135933 Patch 597058 2 135933 rniwa 2012-04-05 17:31:21 -0700 Comment on attachment 135933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135933&action=review > Source/WebCore/ChangeLog:23 > + (WebCore::Geolocation::positionChanged): The case (!isAllowed()) was there > + to support granting the authorization for WTF_USE_PREEMPT_GEOLOCATION_PERMISSION. You mean when PREEMPT_GEOLOCATION_PERMISSION is disabled? 597060 3 benjamin 2012-04-05 17:37:29 -0700 > > Source/WebCore/ChangeLog:23 > > + (WebCore::Geolocation::positionChanged): The case (!isAllowed()) was there > > + to support granting the authorization for WTF_USE_PREEMPT_GEOLOCATION_PERMISSION. > > You mean when PREEMPT_GEOLOCATION_PERMISSION is disabled? Yes indeed. I will reword that when landing. 597725 4 benjamin 2012-04-06 15:24:16 -0700 Committed r113505: <http://trac.webkit.org/changeset/113505> 602676 5 ap 2012-04-14 10:53:35 -0700 Was there a specific reason to use CRASH instead of ASSERT? We usually only do that for out of memory conditions, and use ASSERT. 602692 6 benjamin 2012-04-14 13:29:05 -0700 > Was there a specific reason to use CRASH instead of ASSERT? We usually only do that for out of memory conditions, and use ASSERT. This particular check comes from a hardening patch I previously did. At the time, Adam suggested it would be better to crash so we learn if that happens I the wild. At the time, I did not aggree because there were too many corner case for granting permission. Now that the permission system is greatly simplified, I think CRASH() is reasonable. 135933 2012-04-05 16:33:57 -0700 2012-04-05 20:05:05 -0700 Patch bug-83325-20120405163356.patch text/plain 8958 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA1NTE3M2NmOThkOTYwOTk4ZDg5YjJm OWZkMWRkMTg2Y2FiMTNlOWYuLjAyNWNjNDZmZThmOTYyYWQwNGU0ZTViNjY3MTVjNmI5YjcwYTdk ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDQtMDUgIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgR2V0IHJpZCBvZiB0aGUgdXNlbGVzcyBmbGFn IFBSRUVNUFRfR0VPTE9DQVRJT05fUEVSTUlTU0lPTgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMzMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBSZW1vdmUgdGhlIGZsYWcu CisKIDIwMTItMDQtMDUgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW1dpbkNFXSBSZW1vdmUgdW5uZWNlc3NhcnkgZnVuY3Rpb24gZGVjbGVyYXRpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNThkOGY0Y2UyYTJmOWNmNDNmMWZiZGVmZWY1NTdmNDFlOTA3NmY0Li4y ODRjN2E5NTdjZjEzNmU2N2FlYTY1M2NiMTQyMzM2MTkxYWI4NTc1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMzAgQEAKKzIwMTItMDQtMDUgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBs ZS5jb20+CisKKyAgICAgICAgR2V0IHJpZCBvZiB0aGUgdXNlbGVzcyBmbGFnIFBSRUVNUFRfR0VP TE9DQVRJT05fUEVSTUlTU0lPTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODMzMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgZmxhZyBXVEZfVVNFX1BSRUVNUFRfR0VPTE9DQVRJT05fUEVSTUlTU0lP TiB3YXMgYWRkZWQgaW4gcjYzNzQyIGJ1dAorICAgICAgICB3YXMgbmV2ZXIgZGlzYWJsZWQgYnkg YW55b25lLiBTdXBwb3J0aW5nIHRoaXMgZmVhdHVyZSBhZGRlZCBjb21wbGV4aXR5IGJ5CisgICAg ICAgIGludHJvZHVjaW5nIHR3byBhdXRob3JpemF0aW9uIHNjaGVtZS4KKworICAgICAgICBUaGlz IHBhdGNoIHJlbW92ZXMgV1RGX1VTRV9QUkVFTVBUX0dFT0xPQ0FUSU9OX1BFUk1JU1NJT04gYW5k IHRoZSBjb2RlIHN1cHBvcnRpbmcKKyAgICAgICAgZ3JhbnRpbmcgdGhlIGF1dGhvcml6YXRpb24g YWZ0ZXIgc3RhcnRVcGRhdGluZygpLgorCisgICAgICAgICogTW9kdWxlcy9nZW9sb2NhdGlvbi9H ZW9sb2NhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbjo6R2VvTm90aWZp ZXI6OnJ1blN1Y2Nlc3NDYWxsYmFjayk6IFdpdGggdGhlIHNpbXBsaWZpZWQKKyAgICAgICAgYXV0 aG9yaXphdGlvbiBjb2RlLCB3ZSBlbnN1cmUgc3Ryb25nZXIgY29uc3RyYWludCBvbiBHZW9Ob3Rp Zmllcjo6cnVuU3VjY2Vzc0NhbGxiYWNrKCkuCisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlv bjo6c3RvcCk6CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbjo6c3RhcnRSZXF1ZXN0KToK KyAgICAgICAgKFdlYkNvcmU6Okdlb2xvY2F0aW9uOjpjbGVhcldhdGNoKToKKyAgICAgICAgKFdl YkNvcmU6Okdlb2xvY2F0aW9uOjpzZXRJc0FsbG93ZWQpOgorICAgICAgICAoV2ViQ29yZTo6R2Vv bG9jYXRpb246OnBvc2l0aW9uQ2hhbmdlZCk6IFRoZSBjYXNlICghaXNBbGxvd2VkKCkpIHdhcyB0 aGVyZQorICAgICAgICB0byBzdXBwb3J0IGdyYW50aW5nIHRoZSBhdXRob3JpemF0aW9uIGZvciBX VEZfVVNFX1BSRUVNUFRfR0VPTE9DQVRJT05fUEVSTUlTU0lPTi4KKyAgICAgICAgKFdlYkNvcmU6 Okdlb2xvY2F0aW9uOjpoYW5kbGVQZW5kaW5nUGVybWlzc2lvbk5vdGlmaWVycyk6CisgICAgICAg ICogTW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbi5oOgorICAgICAgICAoR2VvbG9jYXRp b24pOgorCiAyMDEyLTA0LTA1ICBBbnRvbmlvIEdvbWVzICA8YWdvbWVzQHJpbS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBiaXQgbGVmdCBvdmVyIGZyb20gcmViYXNpbmcgdGhlIG9yaWdpbiBw YXRjaCBiZWZvcmUgbGFuZGluZyBpdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4 IDQ2OTJiMDIyN2RiNDhjOTU3MTFiZjViY2U4N2RlNjMzOWVhNWE3OGYuLjQwMGMwNDNmNGIwYWE1 ZjFkMzRiMzM2Zjc4YmFiNzZhNDAxYmM5MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA0LTA1ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxh aW5AYXBwbGUuY29tPgorCisgICAgICAgIEdldCByaWQgb2YgdGhlIHVzZWxlc3MgZmxhZyBQUkVF TVBUX0dFT0xPQ0FUSU9OX1BFUk1JU1NJT04KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgzMzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9BYm91dERhdGFVc2VGZWF0dXJlcy5p bjoKKwogMjAxMi0wNC0wNSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIEZvcmNlIGNvbXBvc2l0aW5nIG1vZGUgd2hlbiBiYWNraW5nIHN0 b3JlIGlzIG5vdCBhY3RpdmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDBjMmE0NzNlZmJlZmQyYjI4NWQ5MTA5 ZDNlMDFlZjZmOWM5MmYyYTEuLjg4M2E3ODE5MTViNzk1ZjlhNjA4ZTBlZGZhOGI4ZDNiMmYxNjRk ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dU Ri93dGYvUGxhdGZvcm0uaApAQCAtMTEwOCw5ICsxMTA4LDYgQEAKICNkZWZpbmUgV1RGX1VTRV9B Q0NFU1NJQklMSVRZX0NPTlRFWFRfTUVOVVMgMQogI2VuZGlmCiAKLS8qIEdlb2xvY2F0aW9uIHJl cXVlc3QgcG9saWN5LiBwcmUtZW1wdGl2ZSBwb2xpY3kgaXMgdG8gYWNxdWlyZSB1c2VyIHBlcm1p c3Npb24gYmVmb3JlIGFjcXVpcmluZyBsb2NhdGlvbi4gKi8KLSNkZWZpbmUgV1RGX1VTRV9QUkVF TVBUX0dFT0xPQ0FUSU9OX1BFUk1JU1NJT04gMQotCiAjaWYgQ1BVKEFSTV9USFVNQjIpCiAjZGVm aW5lIEVOQUJMRV9CUkFOQ0hfQ09NUEFDVElPTiAxCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vR2VvbG9jYXRpb24uY3BwIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbi5jcHAKaW5kZXggZTJjYzg5YzYz NjhjNGU3OWUyYjVlY2U4OTY3OGVmOGYwNjVjMWNmZi4uZTFjMmM5ZjEyYjg3NTUxYzg3NTg4OGE2 OWNiZWRiNmZhZTIxNmM2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nZW9s b2NhdGlvbi9HZW9sb2NhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nZW9s b2NhdGlvbi9HZW9sb2NhdGlvbi5jcHAKQEAgLTEyMiwxMCArMTIyLDggQEAgdm9pZCBHZW9sb2Nh dGlvbjo6R2VvTm90aWZpZXI6OnJ1blN1Y2Nlc3NDYWxsYmFjayhHZW9wb3NpdGlvbiogcG9zaXRp b24pCiB7CiAgICAgLy8gSWYgd2UgYXJlIGhlcmUgYW5kIHRoZSBHZW9sb2NhdGlvbiBwZXJtaXNz aW9uIGlzIG5vdCBhcHByb3ZlZCwgc29tZXRoaW5nIGhhcwogICAgIC8vIGdvbmUgaG9ycmlibHkg d3JvbmcuCi0gICAgLy8gV2UgYmFpbCBvdXQgdG8gYXZvaWQgYW55IHByaXZhY3kgaXNzdWUuCi0g ICAgQVNTRVJUKG1fZ2VvbG9jYXRpb24tPmlzQWxsb3dlZCgpKTsKICAgICBpZiAoIW1fZ2VvbG9j YXRpb24tPmlzQWxsb3dlZCgpKQotICAgICAgICByZXR1cm47CisgICAgICAgIENSQVNIKCk7CiAK ICAgICBtX3N1Y2Nlc3NDYWxsYmFjay0+aGFuZGxlRXZlbnQocG9zaXRpb24pOwogfQpAQCAtMjgw LDkgKzI3OCw3IEBAIHZvaWQgR2VvbG9jYXRpb246OnN0b3AoKQogICAgIG1fYWxsb3dHZW9sb2Nh dGlvbiA9IFVua25vd247CiAgICAgY2FuY2VsQWxsUmVxdWVzdHMoKTsKICAgICBzdG9wVXBkYXRp bmcoKTsKLSNpZiBVU0UoUFJFRU1QVF9HRU9MT0NBVElPTl9QRVJNSVNTSU9OKQogICAgIG1fcGVu ZGluZ0ZvclBlcm1pc3Npb25Ob3RpZmllcnMuY2xlYXIoKTsKLSNlbmRpZgogfQogCiBHZW9wb3Np dGlvbiogR2VvbG9jYXRpb246Omxhc3RQb3NpdGlvbigpCkBAIC0zMzUsMTQgKzMzMSwxMSBAQCBQ YXNzUmVmUHRyPEdlb2xvY2F0aW9uOjpHZW9Ob3RpZmllcj4gR2VvbG9jYXRpb246OnN0YXJ0UmVx dWVzdChQYXNzUmVmUHRyPFBvc2l0aQogICAgICAgICBub3RpZmllci0+c2V0VXNlQ2FjaGVkUG9z aXRpb24oKTsKICAgICBlbHNlIGlmIChub3RpZmllci0+aGFzWmVyb1RpbWVvdXQoKSkKICAgICAg ICAgbm90aWZpZXItPnN0YXJ0VGltZXJJZk5lZWRlZCgpOwotI2lmIFVTRShQUkVFTVBUX0dFT0xP Q0FUSU9OX1BFUk1JU1NJT04pCiAgICAgZWxzZSBpZiAoIWlzQWxsb3dlZCgpKSB7CiAgICAgICAg IC8vIGlmIHdlIGRvbid0IHlldCBoYXZlIHBlcm1pc3Npb24sIHJlcXVlc3QgZm9yIHBlcm1pc3Np b24gYmVmb3JlIGNhbGxpbmcgc3RhcnRVcGRhdGluZygpCiAgICAgICAgIG1fcGVuZGluZ0ZvclBl cm1pc3Npb25Ob3RpZmllcnMuYWRkKG5vdGlmaWVyKTsKICAgICAgICAgcmVxdWVzdFBlcm1pc3Np b24oKTsKLSAgICB9Ci0jZW5kaWYKLSAgICBlbHNlIGlmIChzdGFydFVwZGF0aW5nKG5vdGlmaWVy LmdldCgpKSkKKyAgICB9IGVsc2UgaWYgKHN0YXJ0VXBkYXRpbmcobm90aWZpZXIuZ2V0KCkpKQog ICAgICAgICBub3RpZmllci0+c3RhcnRUaW1lcklmTmVlZGVkKCk7CiAgICAgZWxzZQogICAgICAg ICBub3RpZmllci0+c2V0RmF0YWxFcnJvcihQb3NpdGlvbkVycm9yOjpjcmVhdGUoUG9zaXRpb25F cnJvcjo6UE9TSVRJT05fVU5BVkFJTEFCTEUsIGZhaWxlZFRvU3RhcnRTZXJ2aWNlRXJyb3JNZXNz YWdlKSk7CkBAIC00MzUsMTAgKzQyOCw4IEBAIHZvaWQgR2VvbG9jYXRpb246OmNsZWFyV2F0Y2go aW50IHdhdGNoSWQpCiAgICAgaWYgKHdhdGNoSWQgPCBmaXJzdEF2YWlsYWJsZVdhdGNoSWQpCiAg ICAgICAgIHJldHVybjsKIAotI2lmIFVTRShQUkVFTVBUX0dFT0xPQ0FUSU9OX1BFUk1JU1NJT04p CiAgICAgaWYgKEdlb05vdGlmaWVyKiBub3RpZmllciA9IG1fd2F0Y2hlcnMuZmluZCh3YXRjaElk KSkKICAgICAgICAgbV9wZW5kaW5nRm9yUGVybWlzc2lvbk5vdGlmaWVycy5yZW1vdmUobm90aWZp ZXIpOwotI2VuZGlmCiAgICAgbV93YXRjaGVycy5yZW1vdmUod2F0Y2hJZCk7CiAgICAgCiAgICAg aWYgKCFoYXNMaXN0ZW5lcnMoKSkKQEAgLTQ1NCwxNCArNDQ1LDEyIEBAIHZvaWQgR2VvbG9jYXRp b246OnNldElzQWxsb3dlZChib29sIGFsbG93ZWQpCiAgICAgLy8gcG9zaXRpb24uCiAgICAgbV9h bGxvd0dlb2xvY2F0aW9uID0gYWxsb3dlZCA/IFllcyA6IE5vOwogICAgIAotI2lmIFVTRShQUkVF TVBUX0dFT0xPQ0FUSU9OX1BFUk1JU1NJT04pCiAgICAgLy8gUGVybWlzc2lvbiByZXF1ZXN0IHdh cyBtYWRlIGR1cmluZyB0aGUgc3RhcnRSZXF1ZXN0IHByb2Nlc3MKICAgICBpZiAoIW1fcGVuZGlu Z0ZvclBlcm1pc3Npb25Ob3RpZmllcnMuaXNFbXB0eSgpKSB7CiAgICAgICAgIGhhbmRsZVBlbmRp bmdQZXJtaXNzaW9uTm90aWZpZXJzKCk7CiAgICAgICAgIG1fcGVuZGluZ0ZvclBlcm1pc3Npb25O b3RpZmllcnMuY2xlYXIoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSNlbmRpZgogCiAgICAg aWYgKCFpc0FsbG93ZWQoKSkgewogICAgICAgICBSZWZQdHI8UG9zaXRpb25FcnJvcj4gZXJyb3Ig PSBQb3NpdGlvbkVycm9yOjpjcmVhdGUoUG9zaXRpb25FcnJvcjo6UEVSTUlTU0lPTl9ERU5JRUQs IHBlcm1pc3Npb25EZW5pZWRFcnJvck1lc3NhZ2UpOwpAQCAtNjQyLDIwICs2MzEsMTMgQEAgdm9p ZCBHZW9sb2NhdGlvbjo6bWFrZVN1Y2Nlc3NDYWxsYmFja3MoKQogCiB2b2lkIEdlb2xvY2F0aW9u Ojpwb3NpdGlvbkNoYW5nZWQoKQogeworICAgIEFTU0VSVChpc0FsbG93ZWQoKSk7CisKICAgICBt X2NhY2hlZFBvc2l0aW9uID0gbGFzdFBvc2l0aW9uKCk7CiAKICAgICAvLyBTdG9wIGFsbCBjdXJy ZW50bHkgcnVubmluZyB0aW1lcnMuCiAgICAgc3RvcFRpbWVycygpOwogCi0gICAgaWYgKCFpc0Fs bG93ZWQoKSkgewotICAgICAgICAvLyByZXF1ZXN0UGVybWlzc2lvbigpIHdpbGwgYXNrIHRoZSBj aHJvbWUgZm9yIHBlcm1pc3Npb24uIFRoaXMgbWF5IGJlCi0gICAgICAgIC8vIGltcGxlbWVudGVk IHN5bmNocm9ub3VzbHkgb3IgYXN5bmNocm9ub3VzbHkuIEluIGJvdGggY2FzZXMsCi0gICAgICAg IC8vIG1ha2VTdWNjZXNzQ2FsbGJhY2tzKCkgd2lsbCBiZSBjYWxsZWQgaWYgcGVybWlzc2lvbiBp cyBncmFudGVkLCBzbwotICAgICAgICAvLyB0aGVyZSdzIG5vdGhpbmcgbW9yZSB0byBkbyBoZXJl LgotICAgICAgICByZXF1ZXN0UGVybWlzc2lvbigpOwotICAgICAgICByZXR1cm47Ci0gICAgfQot CiAgICAgbWFrZVN1Y2Nlc3NDYWxsYmFja3MoKTsKIH0KIApAQCAtNjg0LDcgKzY2Niw2IEBAIHZv aWQgR2VvbG9jYXRpb246OnN0b3BVcGRhdGluZygpCiAgICAgR2VvbG9jYXRpb25Db250cm9sbGVy Ojpmcm9tKHBhZ2UpLT5yZW1vdmVPYnNlcnZlcih0aGlzKTsKIH0KIAotI2lmIFVTRShQUkVFTVBU X0dFT0xPQ0FUSU9OX1BFUk1JU1NJT04pCiB2b2lkIEdlb2xvY2F0aW9uOjpoYW5kbGVQZW5kaW5n UGVybWlzc2lvbk5vdGlmaWVycygpCiB7CiAgICAgLy8gV2hpbGUgd2UgaXRlcmF0ZSB0aHJvdWdo IHRoZSBsaXN0LCB3ZSBuZWVkIG5vdCB3b3JyeSBhYm91dCBsaXN0IGJlaW5nIG1vZGlmaWVkIGFz IHRoZSBwZXJtaXNzaW9uIApAQCAtNzA0LDcgKzY4NSw2IEBAIHZvaWQgR2VvbG9jYXRpb246Omhh bmRsZVBlbmRpbmdQZXJtaXNzaW9uTm90aWZpZXJzKCkKICAgICAgICAgICAgIG5vdGlmaWVyLT5z ZXRGYXRhbEVycm9yKFBvc2l0aW9uRXJyb3I6OmNyZWF0ZShQb3NpdGlvbkVycm9yOjpQRVJNSVNT SU9OX0RFTklFRCwgcGVybWlzc2lvbkRlbmllZEVycm9yTWVzc2FnZSkpOwogICAgIH0KIH0KLSNl bmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbi5oCmluZGV4IDhiNjNjN2YzNTNiNzE1Njk2NGQ5 OWU0YzhhZTc2YmQ3ZDMxYWQ3ZDcuLjdmM2NmOTM2NGQyNmE5Nzk0MzAyNTMwYjU0YjE4YTIyNTAw MTgyZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vR2Vv bG9jYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0dlb2xv Y2F0aW9uLmgKQEAgLTE1MCw5ICsxNTAsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgc3RhcnRVcGRh dGluZyhHZW9Ob3RpZmllciopOwogICAgIHZvaWQgc3RvcFVwZGF0aW5nKCk7CiAKLSNpZiBVU0Uo UFJFRU1QVF9HRU9MT0NBVElPTl9QRVJNSVNTSU9OKQogICAgIHZvaWQgaGFuZGxlUGVuZGluZ1Bl cm1pc3Npb25Ob3RpZmllcnMoKTsKLSNlbmRpZgogCiAgICAgUGFzc1JlZlB0cjxHZW9Ob3RpZmll cj4gc3RhcnRSZXF1ZXN0KFBhc3NSZWZQdHI8UG9zaXRpb25DYWxsYmFjaz4sIFBhc3NSZWZQdHI8 UG9zaXRpb25FcnJvckNhbGxiYWNrPiwgUGFzc1JlZlB0cjxQb3NpdGlvbk9wdGlvbnM+KTsKIApA QCAtMTY0LDkgKzE2Miw3IEBAIHByaXZhdGU6CiAKICAgICBHZW9Ob3RpZmllclNldCBtX29uZVNo b3RzOwogICAgIFdhdGNoZXJzIG1fd2F0Y2hlcnM7Ci0jaWYgVVNFKFBSRUVNUFRfR0VPTE9DQVRJ T05fUEVSTUlTU0lPTikKICAgICBHZW9Ob3RpZmllclNldCBtX3BlbmRpbmdGb3JQZXJtaXNzaW9u Tm90aWZpZXJzOwotI2VuZGlmCiAgICAgUmVmUHRyPEdlb3Bvc2l0aW9uPiBtX2xhc3RQb3NpdGlv bjsKIAogICAgIGVudW0gewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YkNvcmVTdXBwb3J0L0Fib3V0RGF0YVVzZUZlYXR1cmVzLmluIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Fib3V0RGF0YVVzZUZlYXR1cmVzLmluCmluZGV4IGUxYTdj ZWQxNTg3Y2Q3NDU5YWEyYjc3NDEyZGQwZDhlZWNlMDk5OWUuLjNmY2JmNWVlMDMyMmZkMGE1M2Rj N2Y3ZGNlMjFkMTNjYzY0NzJlOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJDb3JlU3VwcG9ydC9BYm91dERhdGFVc2VGZWF0dXJlcy5pbgorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQWJvdXREYXRhVXNlRmVhdHVyZXMuaW4KQEAg LTQ5LDcgKzQ5LDYgQEAgT1NfUkFORE9NTkVTUwogUEFOR08KIFBMQVRGT1JNX1NUUkFURUdJRVMK IFBMVUdJTl9IT1NUX1BST0NFU1MKLVBSRUVNUFRfR0VPTE9DQVRJT05fUEVSTUlTU0lPTgogUFJP VEVDVElPTl9TUEFDRV9BVVRIX0NBTExCQUNLCiBQVEhSRUFEUwogUFRIUkVBRF9HRVRTUEVDSUZJ Q19ESVJFQ1QK