83314 2012-04-05 14:28:20 -0700 [BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia 2012-04-05 16:00:35 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 anilsson webkit-unassigned rwlbuis tonikitoo webkit.review.bot oldest_to_newest 596910 0 anilsson 2012-04-05 14:28:20 -0700 One new virtual method was added to SkCanvas, and it's probably not called by GraphicsContextSkia, but add it just to be sure. 596933 1 135910 anilsson 2012-04-05 14:58:49 -0700 Created attachment 135910 Patch 596943 2 webkit.review.bot 2012-04-05 15:03:22 -0700 Attachment 135910 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/blackberry/InstrumentedPlatformCanvas.h:203: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 596956 3 135917 anilsson 2012-04-05 15:11:05 -0700 Created attachment 135917 Patch 596980 4 135917 webkit.review.bot 2012-04-05 16:00:31 -0700 Comment on attachment 135917 Patch Clearing flags on attachment: 135917 Committed r113390: <http://trac.webkit.org/changeset/113390> 596981 5 webkit.review.bot 2012-04-05 16:00:35 -0700 All reviewed patches have been landed. Closing bug. 135910 2012-04-05 14:58:49 -0700 2012-04-05 15:10:50 -0700 Patch bug-83314-20120405235847.patch text/plain 1922 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWEzMzhjNjNjODRjZjU4 NGQ4Njc2NGUyZTQ2MDk1MmZhYzUwYjk3MC4uMTY5OTBmYzk0Yzc5Y2I4NjJkZDQwNjRlMTg5ODBk ZmE5OTg4NDQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTA1ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gVXBk YXRlIHRoZSBJbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcyBhZnRlciByZWJhc2luZyBTa2lhCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzMxNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJJTSBQUjogMTQz NzcxCisgICAgICAgIE9uZSBuZXcgdmlydHVhbCBtZXRob2Qgd2FzIGFkZGVkIHRvIHRoZSBTa0Nh bnZhcywgdG8gZHJhdyBhIG5pbmUgcGllY2UKKyAgICAgICAgaW1hZ2UuIE92ZXJyaWRlIGl0IGFu ZCBtYXJrIG91dHB1dCBhcyBub3QgYmVpbmcgYSBzb2xpZCBjb2xvciBhbnltb3JlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9JbnN0cnVtZW50ZWRQbGF0Zm9ybUNh bnZhcy5oOgorICAgICAgICAoV2ViQ29yZTo6SW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXM6OmRy YXdCaXRtYXBOaW5lKToKKyAgICAgICAgKEluc3RydW1lbnRlZFBsYXRmb3JtQ2FudmFzKToKKwog MjAxMi0wNC0wNSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzkzNTkwMjk+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODMzMTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvSW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXMuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvSW5zdHJ1bWVudGVkUGxhdGZvcm1D YW52YXMuaAppbmRleCA3ODBiYzAxYjFlNDkwNmU1ZDFkZDA1NTVhNWZiOTk3YTA1YmQ0MjMzLi4y MGJlZGFhMjM0YjI5ODY4ODEwYjhmMzdiZDYzZjNiOWRmYzkwYTI2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0luc3RydW1lbnRlZFBsYXRm b3JtQ2FudmFzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2ti ZXJyeS9JbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcy5oCkBAIC0xOTksNiArMTk5LDE0IEBAIHB1 YmxpYzoKICAgICAgICAgU2tDYW52YXM6OmRyYXdCaXRtYXBNYXRyaXgoYml0bWFwLCBtYXRyaXgs IHBhaW50KTsKICAgICB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgZHJhd0JpdG1hcE5pbmUoY29uc3Qg U2tCaXRtYXAmIGJpdG1hcCwgY29uc3QgU2tJUmVjdCYgY2VudGVyLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBTa1JlY3QmIGRzdCwgY29uc3QgU2tQYWludCogcGFpbnQg PSBOVUxMKQorICAgIHsKKyAgICAgICAgV1JBUENBTlZBU19MT0dfRU5UUlkoIiIpOworICAgICAg ICBtX2lzU29saWRDb2xvciA9IGZhbHNlOworICAgICAgICBTa0NhbnZhczo6ZHJhd0JpdG1hcE5p bmUoYml0bWFwLCBjZW50ZXIsIGRzdCwgcGFpbnQpOworICAgIH0KKwogICAgIHZpcnR1YWwgdm9p ZCBkcmF3U3ByaXRlKGNvbnN0IFNrQml0bWFwJiBiaXRtYXAsIGludCBsZWZ0LCBpbnQgdG9wLAog ICAgICAgICAgICAgY29uc3QgU2tQYWludCogcGFpbnQpCiAgICAgewo= 135917 2012-04-05 15:11:05 -0700 2012-04-05 16:00:31 -0700 Patch bug-83314-20120406001103.patch text/plain 1919 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWEzMzhjNjNjODRjZjU4 NGQ4Njc2NGUyZTQ2MDk1MmZhYzUwYjk3MC4uMTY5OTBmYzk0Yzc5Y2I4NjJkZDQwNjRlMTg5ODBk ZmE5OTg4NDQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTA1ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gVXBk YXRlIHRoZSBJbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcyBhZnRlciByZWJhc2luZyBTa2lhCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzMxNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJJTSBQUjogMTQz NzcxCisgICAgICAgIE9uZSBuZXcgdmlydHVhbCBtZXRob2Qgd2FzIGFkZGVkIHRvIHRoZSBTa0Nh bnZhcywgdG8gZHJhdyBhIG5pbmUgcGllY2UKKyAgICAgICAgaW1hZ2UuIE92ZXJyaWRlIGl0IGFu ZCBtYXJrIG91dHB1dCBhcyBub3QgYmVpbmcgYSBzb2xpZCBjb2xvciBhbnltb3JlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9JbnN0cnVtZW50ZWRQbGF0Zm9ybUNh bnZhcy5oOgorICAgICAgICAoV2ViQ29yZTo6SW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXM6OmRy YXdCaXRtYXBOaW5lKToKKyAgICAgICAgKEluc3RydW1lbnRlZFBsYXRmb3JtQ2FudmFzKToKKwog MjAxMi0wNC0wNSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzkzNTkwMjk+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODMzMTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvSW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXMuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvSW5zdHJ1bWVudGVkUGxhdGZvcm1D YW52YXMuaAppbmRleCA3ODBiYzAxYjFlNDkwNmU1ZDFkZDA1NTVhNWZiOTk3YTA1YmQ0MjMzLi45 MjdiNTk5MGQ1NDAzY2M1MjdjMzYwZDY5NDI0MTk3MzlmNDg0YTEwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0luc3RydW1lbnRlZFBsYXRm b3JtQ2FudmFzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2ti ZXJyeS9JbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcy5oCkBAIC0xOTksNiArMTk5LDE0IEBAIHB1 YmxpYzoKICAgICAgICAgU2tDYW52YXM6OmRyYXdCaXRtYXBNYXRyaXgoYml0bWFwLCBtYXRyaXgs IHBhaW50KTsKICAgICB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgZHJhd0JpdG1hcE5pbmUoY29uc3Qg U2tCaXRtYXAmIGJpdG1hcCwgY29uc3QgU2tJUmVjdCYgY2VudGVyLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBTa1JlY3QmIGRzdCwgY29uc3QgU2tQYWludCogcGFpbnQg PSAwKQorICAgIHsKKyAgICAgICAgV1JBUENBTlZBU19MT0dfRU5UUlkoIiIpOworICAgICAgICBt X2lzU29saWRDb2xvciA9IGZhbHNlOworICAgICAgICBTa0NhbnZhczo6ZHJhd0JpdG1hcE5pbmUo Yml0bWFwLCBjZW50ZXIsIGRzdCwgcGFpbnQpOworICAgIH0KKwogICAgIHZpcnR1YWwgdm9pZCBk cmF3U3ByaXRlKGNvbnN0IFNrQml0bWFwJiBiaXRtYXAsIGludCBsZWZ0LCBpbnQgdG9wLAogICAg ICAgICAgICAgY29uc3QgU2tQYWludCogcGFpbnQpCiAgICAgewo=