83312 2012-04-05 14:18:21 -0700 Use QuickSort when sorting primitive values by string representation 2012-04-05 16:08:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough fpizlo ggaren oldest_to_newest 596905 0 benjamin 2012-04-05 14:18:21 -0700 Currently, we use a stable sort when sorting the JSValues of a JSArray. When all the values are primitive types, one cannot differentiate two values with equal string representation. We should use a faster, non stable, sort algorithm in that case. 596909 1 135904 benjamin 2012-04-05 14:23:45 -0700 Created attachment 135904 Patch 596968 2 135904 barraclough 2012-04-05 15:36:38 -0700 Comment on attachment 135904 Patch very nice! 596989 3 benjamin 2012-04-05 16:08:34 -0700 Committed r113391: <http://trac.webkit.org/changeset/113391> 135904 2012-04-05 14:23:45 -0700 2012-04-05 15:36:38 -0700 Patch bug-83312-20120405142344.patch text/plain 2558 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZDA2M2E0ODQwN2RhM2M3MzQwYjdhNzYwYmE4YWQ1MDMwMGQwOTViLi4zYmE3NDMwM2NiYWFhYmIz NTFjMTMzOWZmZDBiOTQzMjQ3MjY2YjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMSBAQAogMjAxMi0wNC0wNSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KIAorICAgICAgICBVc2UgUXVpY2tTb3J0IHdoZW4gc29ydGluZyBwcmltaXRpdmUgdmFs dWVzIGJ5IHN0cmluZyByZXByZXNlbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMzMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSB2YWx1ZSB3ZSBhcmUgc29ydGluZyBhcmUgYWxs IHByaW1pdGl2ZSB2YWx1ZXMsIHdlIGRvIG5vdCBuZWVkIHRvCisgICAgICAgIGVuc3VyZSBhIHN0 YWJsZSBzb3J0IGFzIHR3byB2YWx1ZXMgd2l0aCBlcXVhbCBzdHJpbmcgcmVwcmVzZW50YXRpb24g YXJlCisgICAgICAgIGluZGlzdGluZ3Vpc2hhYmxlIGZyb20gSmF2YVNjcmlwdC4KKworICAgICAg ICBUaGlzIGdpdmVzIGFib3V0IDE2JSBwZXJmb3JtYW5jZSBpbmNyZWFzZSB3aGVuIHNvcnRpbmcg cHJpbWl0aXZlIHZhbHVlcy4KKworICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5jcHA6CisgICAg ICAgIChKU0M6OkpTQXJyYXk6OnNvcnQpOgorCisyMDEyLTA0LTA1ICBCZW5qYW1pbiBQb3VsYWlu ICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCiAgICAgICAgIE1ha2Ugc29tZXRoaW5nIGZhc3RlciB0 aGFuIEpTU3RyaW5nQnVpbGRlciBmb3Igam9pbmluZyBhbiBhcnJheSBvZiBKU1ZhbHVlCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE4MAogCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCmluZGV4IDQyNTVlYWMxNmEwZDUy MmE0YzU4MTg1YTgyYjYzNjI1M2ZiMzg2Y2UuLmFiNzVhMjJlYzA5NDVkZWM3ODMxODgxM2Q5ZjNm MWVhNWRiNzM5MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT QXJyYXkuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3Bw CkBAIC0xNDc1LDEwICsxNDc1LDEyIEBAIHZvaWQgSlNBcnJheTo6c29ydChFeGVjU3RhdGUqIGV4 ZWMpCiAgICAgCiAgICAgSGVhcDo6aGVhcCh0aGlzKS0+cHVzaFRlbXBTb3J0VmVjdG9yKCZ2YWx1 ZXMpOwogCisgICAgYm9vbCBpc1NvcnRpbmdQcmltaXRpdmVWYWx1ZXMgPSB0cnVlOwogICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgbGVuZ3RoTm90SW5jbHVkaW5nVW5kZWZpbmVkOyBpKyspIHsK ICAgICAgICAgSlNWYWx1ZSB2YWx1ZSA9IG1fc3RvcmFnZS0+bV92ZWN0b3JbaV0uZ2V0KCk7CiAg ICAgICAgIEFTU0VSVCghdmFsdWUuaXNVbmRlZmluZWQoKSk7CiAgICAgICAgIHZhbHVlc1tpXS5m aXJzdCA9IHZhbHVlOworICAgICAgICBpc1NvcnRpbmdQcmltaXRpdmVWYWx1ZXMgPSBpc1NvcnRp bmdQcmltaXRpdmVWYWx1ZXMgJiYgdmFsdWUuaXNQcmltaXRpdmUoKTsKICAgICB9CiAKICAgICAv LyBGSVhNRTogVGhlIGZvbGxvd2luZyBsb29wIGNvbnRpbnVlcyB0byBjYWxsIHRvU3RyaW5nIG9u IHN1YnNlcXVlbnQgdmFsdWVzIGV2ZW4gYWZ0ZXIKQEAgLTE0OTYsNyArMTQ5OCwxMCBAQCB2b2lk IEpTQXJyYXk6OnNvcnQoRXhlY1N0YXRlKiBleGVjKQogICAgIC8vIHRoYW4gTyhOIGxvZyBOKS4K IAogI2lmIEhBVkUoTUVSR0VTT1JUKQotICAgIG1lcmdlc29ydCh2YWx1ZXMuYmVnaW4oKSwgdmFs dWVzLnNpemUoKSwgc2l6ZW9mKFZhbHVlU3RyaW5nUGFpciksIGNvbXBhcmVCeVN0cmluZ1BhaXJG b3JRU29ydCk7CisgICAgaWYgKGlzU29ydGluZ1ByaW1pdGl2ZVZhbHVlcykKKyAgICAgICAgcXNv cnQodmFsdWVzLmJlZ2luKCksIHZhbHVlcy5zaXplKCksIHNpemVvZihWYWx1ZVN0cmluZ1BhaXIp LCBjb21wYXJlQnlTdHJpbmdQYWlyRm9yUVNvcnQpOworICAgIGVsc2UKKyAgICAgICAgbWVyZ2Vz b3J0KHZhbHVlcy5iZWdpbigpLCB2YWx1ZXMuc2l6ZSgpLCBzaXplb2YoVmFsdWVTdHJpbmdQYWly KSwgY29tcGFyZUJ5U3RyaW5nUGFpckZvclFTb3J0KTsKICNlbHNlCiAgICAgLy8gRklYTUU6IFRo ZSBxc29ydCBsaWJyYXJ5IGZ1bmN0aW9uIGlzIGxpa2VseSB0byBub3QgYmUgYSBzdGFibGUgc29y dC4KICAgICAvLyBFQ01BU2NyaXB0LTI2MiBkb2VzIG5vdCBzcGVjaWZ5IGEgc3RhYmxlIHNvcnQs IGJ1dCBpbiBwcmFjdGljZSwgYnJvd3NlcnMgcGVyZm9ybSBhIHN0YWJsZSBzb3J0Lgo=