83310 2012-04-05 13:46:05 -0700 [Chromium] Correct misleading trace event names in Canvas2DLayerChromium 2012-04-05 15:02:36 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 junov junov cc-bugs jamesr senorblanco webkit.review.bot oldest_to_newest 596877 0 junov 2012-04-05 13:46:05 -0700 The trace event "SkDeferredCanvas::flush" in paintContentsIfDirty() is poorly named because the code gets called even when the canvas is a regular SkCanvas, in which case it wraps a call to GrContext::flush if the canvas is accelerated. A couple lines lower, the trace event named "GrContext::flush" is also poorly named because it assumes that GrContext::flush is the main task performed by GraphicsContext3D::flush, which is not the case since the GrContext may have already been flushed by the call to SkCanvas::flush. Better just call it "GraphicsContext3D::flush" 596880 1 135894 junov 2012-04-05 13:48:35 -0700 Created attachment 135894 Patch 596904 2 135894 enne 2012-04-05 14:16:46 -0700 Comment on attachment 135894 Patch Yay, for less confusion. 596940 3 135894 webkit.review.bot 2012-04-05 15:02:15 -0700 Comment on attachment 135894 Patch Clearing flags on attachment: 135894 Committed r113384: <http://trac.webkit.org/changeset/113384> 596941 4 webkit.review.bot 2012-04-05 15:02:36 -0700 All reviewed patches have been landed. Closing bug. 135894 2012-04-05 13:48:35 -0700 2012-04-05 15:02:14 -0700 Patch bug-83310-20120405164833.patch text/plain 1385 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA0LTA1ICBKdXN0aW4g Tm92b3NhZCAgPGp1bm92QGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIENvcnJl Y3QgbWlzbGVhZGluZyB0cmFjZSBldmVudCBuYW1lcyBpbiBDYW52YXMyRExheWVyQ2hyb21pdW0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMzEwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9DYW52YXMyRExheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q2FudmFzMkRMYXllckNocm9taXVtOjpwYWludENvbnRlbnRzSWZEaXJ0eSk6CisK IDIwMTItMDQtMDUgIEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmViYXNlbGluZSBiaW5kaW5nIHRlc3RzIGFmdGVyIHIxMTMyNzIuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9DYW52YXMyRExheWVyQ2hyb21pdW0uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0NhbnZhczJETGF5ZXJDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDExMzMyNSkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NhbnZhczJETGF5ZXJDaHJvbWl1bS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMSwxMSArMTIxLDExIEBAIHZvaWQgQ2FudmFzMkRMYXll ckNocm9taXVtOjpwYWludENvbnRlbnQKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKG1fY2Fu dmFzKSB7Ci0gICAgICAgIFRSQUNFX0VWRU5UKCJTa0RlZmVycmVkQ2FudmFzOjpmbHVzaCIsIG1f Y2FudmFzLCAwKTsKKyAgICAgICAgVFJBQ0VfRVZFTlQoIlNrQ2FudmFzOjpmbHVzaCIsIG1fY2Fu dmFzLCAwKTsKICAgICAgICAgbV9jYW52YXMtPmZsdXNoKCk7CiAgICAgfQogCi0gICAgVFJBQ0Vf RVZFTlQoIkdyQ29udGV4dDo6Zmx1c2giLCBtX2NvbnRleHQsIDApOworICAgIFRSQUNFX0VWRU5U KCJHcmFwaGljc0NvbnRleHQzRDo6Zmx1c2giLCBtX2NvbnRleHQsIDApOwogICAgIG1fY29udGV4 dC0+Zmx1c2goKTsKIH0KIAo=