83264 2012-04-05 04:16:26 -0700 [EFL][DRT] @font-face support fails on EFL 2012-04-18 10:17:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84234 1 d-r d-r abarth ap dglazkov epoger eric gyuyoung.kim hbono japhet lucas.de.marchi rakuco rwlbuis webkit.review.bot oldest_to_newest 596463 0 d-r 2012-04-05 04:16:26 -0700 Several LayoutTests require @font-face to be working. This seems to fail, e.g. at least in the new tests from bug 34147: /fast/css/font-face-synthetic-bold-italic.html /fast/css/font-face-weight-matching.html 604673 1 137667 d-r 2012-04-18 04:14:11 -0700 Created attachment 137667 Inverting switch logic for storing custom font data Feedback from Chromium people is appreciated. 604729 2 137667 dglazkov 2012-04-18 07:56:15 -0700 Comment on attachment 137667 Inverting switch logic for storing custom font data View in context: https://bugs.webkit.org/attachment.cgi?id=137667&action=review > Source/WebCore/loader/cache/CachedFont.cpp:30 > +#if !(PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) && !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) Since we no longer use CG in Chromium, I don't think that condition is even needed here. Elliot? 604780 3 epoger 2012-04-18 08:46:26 -0700 (In reply to comment #2) > (From update of attachment 137667 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137667&action=review > > > Source/WebCore/loader/cache/CachedFont.cpp:30 > > +#if !(PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) && !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) > > Since we no longer use CG in Chromium, I don't think that condition is even needed here. Elliot? Well, (PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) should always evaluate to FALSE, because as of http://trac.webkit.org/changeset/110056 , the Chromium gyp files within WebKit won't use CG. There is still cleanup that needs to be done to get rid of all the lingering Chromium+CG code... tracked in http://crbug.com/110881 ('cleanup: remove use_skia=0 build option') 604785 4 d-r 2012-04-18 08:51:56 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 137667 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=137667&action=review > > > > > Source/WebCore/loader/cache/CachedFont.cpp:30 > > > +#if !(PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) && !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) > > > > Since we no longer use CG in Chromium, I don't think that condition is even needed here. Elliot? > > Well, (PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) should always evaluate to FALSE, because as of http://trac.webkit.org/changeset/110056 , the Chromium gyp files within WebKit won't use CG. > > There is still cleanup that needs to be done to get rid of all the lingering Chromium+CG code... tracked in http://crbug.com/110881 ('cleanup: remove use_skia=0 build option') So, can I conclude that #if !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) would be enough? 604789 5 epoger 2012-04-18 08:58:39 -0700 (In reply to comment #4) > So, can I conclude that > #if !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) > would be enough? As far as I know, yes. 604790 6 137704 d-r 2012-04-18 08:59:23 -0700 Created attachment 137704 Inverting switch logic for storing custom font data Chromium case removed after feedback from Chromium people. 604853 7 137704 webkit.review.bot 2012-04-18 10:17:13 -0700 Comment on attachment 137704 Inverting switch logic for storing custom font data Clearing flags on attachment: 137704 Committed r114523: <http://trac.webkit.org/changeset/114523> 604854 8 webkit.review.bot 2012-04-18 10:17:19 -0700 All reviewed patches have been landed. Closing bug. 137667 2012-04-18 04:14:11 -0700 2012-04-18 08:59:23 -0700 Inverting switch logic for storing custom font data bug83264.patch text/plain 1462 d-r ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZDk0NzMyLi44YWIyYzlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDQtMTggIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGxp bnV4LmludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtEUlRdIEBmb250LWZhY2Ugc3VwcG9ydCBm YWlscyBvbiBFRkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgzMjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU1RPUkVfRk9OVF9DVVNUT01fUExBVEZPUk1fREFUQSB3YXMgbm90IGRlZmluZWQgZm9yIEVG TC4KKyAgICAgICAgRml4aW5nIHRoYXQgYnkgcmVtb3ZpbmcgYSBsb25nIHN0YW5kaW5nIEZJWE1F IHdpdGggdGhlIGludGVudGlvbgorICAgICAgICB0byB0dXJuIHRoZSB3aGl0ZWxpc3QgZm9yIHRo aXMgc3dpdGNoIGludG8gYSBibGFja2xpc3QuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2Fj aGVkRm9udC5jcHA6CisKIDIwMTItMDQtMTcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogZG9jdW1lbnQub3BlbiByZW1vdmVz IHRoZSBkb2N1bWVudEVsZW1lbnQsIGJ1dCBkb2VzIG5vdCBjbGVhciB0aGUgZWxlbWVudHMgcGFu ZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkRm9udC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkRm9udC5jcHAKaW5kZXggNTZm ODdkMi4uZTZkMjM5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0Nh Y2hlZEZvbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRGb250 LmNwcApAQCAtMjcsOCArMjcsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNh Y2hlZEZvbnQuaCIKIAotLy8gRklYTUU6IFRoaXMgc2hvdWxkIHJlYWxseSBiZSBhIGJsYWNrbGlz dCBpbnN0ZWFkIG9mIGEgd2hpdGVsaXN0Ci0jaWYgVVNFKENHKSB8fCBQTEFURk9STShRVCkgfHwg UExBVEZPUk0oR1RLKSB8fCAoUExBVEZPUk0oQ0hST01JVU0pICYmICghT1MoREFSV0lOKSB8fCBV U0UoU0tJQV9PTl9NQUNfQ0hST01JVU0pKSkgfHwgT1MoV0lOQ0UpIHx8IFBMQVRGT1JNKEJMQUNL QkVSUlkpCisjaWYgIShQTEFURk9STShDSFJPTUlVTSkgJiYgT1MoREFSV0lOKSAmJiBVU0UoQ0cp KSAmJiAhUExBVEZPUk0oV0lOX0NBSVJPKSAmJiAhUExBVEZPUk0oV1gpCiAjZGVmaW5lIFNUT1JF X0ZPTlRfQ1VTVE9NX1BMQVRGT1JNX0RBVEEKICNlbmRpZgogCg== 137704 2012-04-18 08:59:23 -0700 2012-04-18 10:17:13 -0700 Inverting switch logic for storing custom font data bug83264_v2.patch text/plain 1369 d-r ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MGJjOWFkLi5iNjEzN2IwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDQtMTggIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGxp bnV4LmludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtEUlRdIEBmb250LWZhY2Ugc3VwcG9ydCBm YWlscyBvbiBFRkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgzMjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU1RPUkVfRk9OVF9DVVNUT01fUExBVEZPUk1fREFUQSB3YXMgbm90IGRlZmluZWQgZm9yIEVG TC4KKyAgICAgICAgRml4aW5nIHRoYXQgYnkgcmVtb3ZpbmcgYSBsb25nIHN0YW5kaW5nIEZJWE1F IHdpdGggdGhlIGludGVudGlvbgorICAgICAgICB0byB0dXJuIHRoZSB3aGl0ZWxpc3QgZm9yIHRo aXMgc3dpdGNoIGludG8gYSBibGFja2xpc3QuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2Fj aGVkRm9udC5jcHA6CisKIDIwMTItMDQtMTggIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRGF0YUdyaWQgc2hvdWxkIHVzZSBl eHBsaWNpdCByb290IG5vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRGb250LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRGb250 LmNwcAppbmRleCA1NmY4N2QyLi5mZGRkNzlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvY2FjaGUvQ2FjaGVkRm9udC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2Nh Y2hlL0NhY2hlZEZvbnQuY3BwCkBAIC0yNyw4ICsyNyw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgi CiAjaW5jbHVkZSAiQ2FjaGVkRm9udC5oIgogCi0vLyBGSVhNRTogVGhpcyBzaG91bGQgcmVhbGx5 IGJlIGEgYmxhY2tsaXN0IGluc3RlYWQgb2YgYSB3aGl0ZWxpc3QKLSNpZiBVU0UoQ0cpIHx8IFBM QVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspIHx8IChQTEFURk9STShDSFJPTUlVTSkgJiYgKCFP UyhEQVJXSU4pIHx8IFVTRShTS0lBX09OX01BQ19DSFJPTUlVTSkpKSB8fCBPUyhXSU5DRSkgfHwg UExBVEZPUk0oQkxBQ0tCRVJSWSkKKyNpZiAhUExBVEZPUk0oV0lOX0NBSVJPKSAmJiAhUExBVEZP Uk0oV1gpCiAjZGVmaW5lIFNUT1JFX0ZPTlRfQ1VTVE9NX1BMQVRGT1JNX0RBVEEKICNlbmRpZgog Cg==