83248 2012-04-04 22:59:07 -0700 [BlackBerry] Upstream the BlackBerry change to rendering/RenderPart.cpp 2014-01-28 08:11:57 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 73144 1 leo.yang leo.yang andersca charles.wei robin.webkit rwlbuis staikos tonikitoo zimmermann oldest_to_newest 596312 0 leo.yang 2012-04-04 22:59:07 -0700 The blackberry porting is using a different way to accelerate plugins. 596316 1 135759 leo.yang 2012-04-04 23:04:48 -0700 Created attachment 135759 Patch 596456 2 135759 rwlbuis 2012-04-05 03:53:06 -0700 Comment on attachment 135759 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135759&action=review > Source/WebCore/rendering/RenderPart.cpp:86 > +#endif How about: if (widget() && widget()->isPluginViewBase() && static_cast<PluginViewBase*>(widget())->platformLayer()) #if !PLATFORM(BLACKBERRY) return true; #else return false; #endif Then even if the code after that changes, we keep doing the right thing for plugins. 597124 3 135965 leo.yang 2012-04-05 18:48:35 -0700 Created attachment 135965 Patch v2 Revised to follow Rob's suggestion 599288 4 135965 tonikitoo 2012-04-10 08:28:42 -0700 Comment on attachment 135965 Patch v2 Sorry, Leo, but I do not want to add a #if plat(bb) here like this. I would suggest: - make a helper with a meaningful name, and add if's there. Maybe even a static local function. - add a setting, where bb is the only platform that default returns false. also it would be good to mention where in the code blackberry port we HW accelerate plugin layers, etc. 135759 2012-04-04 23:04:48 -0700 2012-04-05 18:48:35 -0700 Patch 0001-BlackBerry-Upstream-the-BlackBerry-change-to-renderi.patch text/plain 2283 leo.yang RnJvbSAwNzhhOTVkNTFlNmJjMzc4MDYzZTNmZjk0NTIwMmY1MDBjYzViYjljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUaHUsIDUgQXByIDIwMTIgMTQ6MDQ6MDMgKzA4MDAKU3ViamVjdDogW1BBVENIXSBb QmxhY2tCZXJyeV0gVXBzdHJlYW0gdGhlIEJsYWNrQmVycnkgY2hhbmdlIHRvCiByZW5kZXJpbmcv UmVuZGVyUGFydC5jcHAKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MzI0OAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpUaGUgYmxhY2tiZXJyeSBwb3J0aW5n IGlzIHVzaW5nIGEgZGlmZmVyZW50IHdheSB0byBhY2NlbGVyYXRlIHBsdWdpbnMuCgoqIHJlbmRl cmluZy9SZW5kZXJQYXJ0LmNwcDoKKFdlYkNvcmU6OlJlbmRlclBhcnQ6OnJlcXVpcmVzQWNjZWxl cmF0ZWRDb21wb3NpdGluZyk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJQYXJ0LmNwcCB8ICAgIDQgKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCsp LCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyOWI4YmM1Li4xNGIxNmIzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDQtMDQgIExlbyBZYW5nICA8bGVvLnlhbmdAdG9y Y2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVhbSB0aGUgQmxh Y2tCZXJyeSBjaGFuZ2UgdG8gcmVuZGVyaW5nL1JlbmRlclBhcnQuY3BwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzI0OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBibGFja2JlcnJ5IHBvcnRpbmcg aXMgdXNpbmcgYSBkaWZmZXJlbnQgd2F5IHRvIGFjY2VsZXJhdGUgcGx1Z2lucy4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJQYXJ0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclBh cnQ6OnJlcXVpcmVzQWNjZWxlcmF0ZWRDb21wb3NpdGluZyk6CisKIDIwMTItMDQtMDQgIERtaXRy eSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4KIAogICAgICAgICBXb3JrZXJFdmVudFF1ZXVl OjpjbG9zZSBtaWdodCBhY2Nlc3MgZGVsZXRlZCBXb3JrZXJFdmVudFF1ZXVlOjpFdmVudERpc3Bh dGNoZXJUYXNrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBh cnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnQuY3BwCmluZGV4IDky ZmNmNWQuLjc5NjU1ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJQYXJ0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydC5jcHAK QEAgLTc4LDggKzc4LDEyIEBAIGJvb2wgUmVuZGVyUGFydDo6cmVxdWlyZXNBY2NlbGVyYXRlZENv bXBvc2l0aW5nKCkgY29uc3QKICAgICAvLyByZW5kZXJlciBhbmQgdGhlIHBsdWdpbiBoYXMgYSBs YXllciwgdGhlbiB3ZSBuZWVkIGEgbGF5ZXIuIFNlY29uZCwgaWYgdGhpcyBpcyAKICAgICAvLyBh IHJlbmRlcmVyIHdpdGggYSBjb250ZW50RG9jdW1lbnQgYW5kIHRoYXQgZG9jdW1lbnQgbmVlZHMg YSBsYXllciwgdGhlbiB3ZSBuZWVkCiAgICAgLy8gYSBsYXllci4KKyNpZiAhUExBVEZPUk0oQkxB Q0tCRVJSWSkKKyAgICAvLyBPbiBCbGFja0JlcnJ5LCB3ZSBhcmUgZ2V0dGluZyA8b2JqZWN0PiAo cmVhZCBoZXJlIHBsdWdpbnMpIEhXIGFjY2VsZXJhdGVkIGRpZmZlcmVudGx5LAorICAgIC8vIHNv IGVuYWJsaW5nIG9iamVjdCB0YWdzIGdlbmVyYWxseSBoZXJlIGlzIG5vdCB3aGF0IHdlIHdhbnQu CiAgICAgaWYgKHdpZGdldCgpICYmIHdpZGdldCgpLT5pc1BsdWdpblZpZXdCYXNlKCkgJiYgc3Rh dGljX2Nhc3Q8UGx1Z2luVmlld0Jhc2UqPih3aWRnZXQoKSktPnBsYXRmb3JtTGF5ZXIoKSkKICAg ICAgICAgcmV0dXJuIHRydWU7CisjZW5kaWYKIAogICAgIGlmICghbm9kZSgpIHx8ICFub2RlKCkt PmlzRnJhbWVPd25lckVsZW1lbnQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotLSAKMS43LjUu NAoK 135965 2012-04-05 18:48:35 -0700 2012-04-10 08:28:42 -0700 Patch v2 0001-BlackBerry-Upstream-the-BlackBerry-change-to-renderi.patch text/plain 2445 leo.yang RnJvbSA2Y2Y1ZDcyNWFkMzE2NDJmNDdmN2E0NDJjYTQwMjY5Y2U5ZWRiOTM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUaHUsIDUgQXByIDIwMTIgMTQ6MDQ6MDMgKzA4MDAKU3ViamVjdDogW1BBVENIXSBb QmxhY2tCZXJyeV0gVXBzdHJlYW0gdGhlIEJsYWNrQmVycnkgY2hhbmdlIHRvCiByZW5kZXJpbmcv UmVuZGVyUGFydC5jcHAKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MzI0OAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpUaGUgYmxhY2tiZXJyeSBwb3J0aW5n IGlzIHVzaW5nIGEgZGlmZmVyZW50IHdheSB0byBhY2NlbGVyYXRlIHBsdWdpbnMuCgoqIHJlbmRl cmluZy9SZW5kZXJQYXJ0LmNwcDoKKFdlYkNvcmU6OlJlbmRlclBhcnQ6OnJlcXVpcmVzQWNjZWxl cmF0ZWRDb21wb3NpdGluZyk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJQYXJ0LmNwcCB8ICAgIDkgKysrKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDI5YjhiYzUuLjE0YjE2YjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNC0wNCAgTGVvIFlhbmcgIDxsZW8ueWFu Z0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVwc3RyZWFtIHRo ZSBCbGFja0JlcnJ5IGNoYW5nZSB0byByZW5kZXJpbmcvUmVuZGVyUGFydC5jcHAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMjQ4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJsYWNrYmVycnkgcG9y dGluZyBpcyB1c2luZyBhIGRpZmZlcmVudCB3YXkgdG8gYWNjZWxlcmF0ZSBwbHVnaW5zLgorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclBhcnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyUGFydDo6cmVxdWlyZXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nKToKKwogMjAxMi0wNC0wNCAg RG1pdHJ5IExvbW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgogCiAgICAgICAgIFdvcmtlckV2ZW50 UXVldWU6OmNsb3NlIG1pZ2h0IGFjY2VzcyBkZWxldGVkIFdvcmtlckV2ZW50UXVldWU6OkV2ZW50 RGlzcGF0Y2hlclRhc2suCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyUGFydC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydC5jcHAKaW5k ZXggOTJmY2Y1ZC4uOGI2ODEzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclBhcnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQYXJ0 LmNwcApAQCAtNzgsOCArNzgsMTUgQEAgYm9vbCBSZW5kZXJQYXJ0OjpyZXF1aXJlc0FjY2VsZXJh dGVkQ29tcG9zaXRpbmcoKSBjb25zdAogICAgIC8vIHJlbmRlcmVyIGFuZCB0aGUgcGx1Z2luIGhh cyBhIGxheWVyLCB0aGVuIHdlIG5lZWQgYSBsYXllci4gU2Vjb25kLCBpZiB0aGlzIGlzIAogICAg IC8vIGEgcmVuZGVyZXIgd2l0aCBhIGNvbnRlbnREb2N1bWVudCBhbmQgdGhhdCBkb2N1bWVudCBu ZWVkcyBhIGxheWVyLCB0aGVuIHdlIG5lZWQKICAgICAvLyBhIGxheWVyLgotICAgIGlmICh3aWRn ZXQoKSAmJiB3aWRnZXQoKS0+aXNQbHVnaW5WaWV3QmFzZSgpICYmIHN0YXRpY19jYXN0PFBsdWdp blZpZXdCYXNlKj4od2lkZ2V0KCkpLT5wbGF0Zm9ybUxheWVyKCkpCisgICAgaWYgKHdpZGdldCgp ICYmIHdpZGdldCgpLT5pc1BsdWdpblZpZXdCYXNlKCkgJiYgc3RhdGljX2Nhc3Q8UGx1Z2luVmll d0Jhc2UqPih3aWRnZXQoKSktPnBsYXRmb3JtTGF5ZXIoKSkgeworI2lmICFQTEFURk9STShCTEFD S0JFUlJZKQogICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbHNlCisgICAgICAgIC8vIE9uIEJsYWNr QmVycnksIHdlIGFyZSBnZXR0aW5nIDxvYmplY3Q+IChyZWFkIGhlcmUgcGx1Z2lucykgSFcgYWNj ZWxlcmF0ZWQgZGlmZmVyZW50bHksCisgICAgICAgIC8vIHNvIGVuYWJsaW5nIG9iamVjdCB0YWdz IGdlbmVyYWxseSBoZXJlIGlzIG5vdCB3aGF0IHdlIHdhbnQuCisgICAgICAgIHJldHVybiBmYWxz ZTsKKyNlbmRpZgorICAgIH0KIAogICAgIGlmICghbm9kZSgpIHx8ICFub2RlKCktPmlzRnJhbWVP d25lckVsZW1lbnQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotLSAKMS43LjUuNAoK