83246 2012-04-04 21:04:57 -0700 Make CSSValueID's into an enum instead of a collection of integers. 2012-04-10 04:31:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric kling macpherson menard simon.fraser webkit.review.bot oldest_to_newest 596276 0 macpherson 2012-04-04 21:04:57 -0700 Make CSSValueID's into an enum instead of a collection of integers. 596278 1 135753 macpherson 2012-04-04 21:06:49 -0700 Created attachment 135753 Patch 598719 2 macpherson 2012-04-09 16:14:12 -0700 I'm just going to keep adding reviewers until someone does it. 598770 3 135753 webkit.review.bot 2012-04-09 16:59:12 -0700 Comment on attachment 135753 Patch Clearing flags on attachment: 135753 Committed r113643: <http://trac.webkit.org/changeset/113643> 598771 4 webkit.review.bot 2012-04-09 16:59:17 -0700 All reviewed patches have been landed. Closing bug. 599156 5 135753 menard 2012-04-10 04:31:04 -0700 Comment on attachment 135753 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135753&action=review > Source/WebCore/ChangeLog:9 > + Follow-up patches will then convert existing code that uses integers to use the new enum. Don't forget to patch RenderStyle.h systemFont and systemColor for all ports :). 135753 2012-04-04 21:06:49 -0700 2012-04-10 04:31:04 -0700 Patch bug-83246-20120405140646.patch text/plain 1810 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk2ZWY2YTdkOTMzOWY4 NTUxN2NmZTE2ZjgwOGQ1NDlmMjY1NjdkZS4uOGI2YWZiMzNkNGRhOTU4NTRmYjg3MzU4ZGE1MzYz YjI4NTRlYjQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTA0ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIENT U1ZhbHVlSUQncyBpbnRvIGFuIGVudW0gaW5zdGVhZCBvZiBhIGNvbGxlY3Rpb24gb2YgaW50ZWdl cnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzI0 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg cGF0Y2ggc2ltcGx5IGNvbnZlcnRzIHRoZSBsaXN0IG9mIGludGVnZXJzIGludG8gYW4gZW51bS4K KyAgICAgICAgRm9sbG93LXVwIHBhdGNoZXMgd2lsbCB0aGVuIGNvbnZlcnQgZXhpc3RpbmcgY29k ZSB0aGF0IHVzZXMgaW50ZWdlcnMgdG8gdXNlIHRoZSBuZXcgZW51bS4KKworICAgICAgICBObyBu ZXcgdGVzdHMgLyBubyBmdW5jdGlvbmFsaXR5IGNoYW5nZWQuCisKKyAgICAgICAgKiBjc3MvbWFr ZXZhbHVlcy5wbDoKKwogMjAxMi0wNC0wNCAgUmFmYWVsIFdlaW5zdGVpbiAgPHJhZmFlbHdAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtNdXRhdGlvbk9ic2VydmVyc10gaW1wbGVtZW50IHRha2VS ZWNvcmRzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtldmFsdWVzLnBsIGIv U291cmNlL1dlYkNvcmUvY3NzL21ha2V2YWx1ZXMucGwKaW5kZXggMTU4MTNjMGQzNjQzYjRmOWVi MTEwYTM1NDM1ZGZkMWMwOTdjNTEwMC4uMzUzMzYwNjk4OTY5ZGY2ZDk3YWNmYTMwNDQxODg0NDhl NDA1ZjhkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2V2YWx1ZXMucGwKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL21ha2V2YWx1ZXMucGwKQEAgLTEzMCw3ICsxMzAsOCBAQCBw cmludCBIRUFERVIgPDwgIkVPRiI7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY29uc3QgaW50 IENTU1ZhbHVlSW52YWxpZCA9IDA7CitlbnVtIENTU1ZhbHVlSUQgeworICAgIENTU1ZhbHVlSW52 YWxpZCA9IDAsCiBFT0YKIAogbXkgJGkgPSAxOwpAQCAtMTM4LDEyICsxMzksMTQgQEAgbXkgJG1h eExlbiA9IDA7CiBmb3JlYWNoIG15ICRuYW1lIChAbmFtZXMpIHsKICAgbXkgJGlkID0gJG5hbWU7 CiAgICRpZCA9fiBzLyheW14tXSl8LSguKS91YygkMXx8JDIpL2dlOwotICBwcmludCBIRUFERVIg ImNvbnN0IGludCBDU1NWYWx1ZSIgLiAkaWQgLiAiID0gIiAuICRpIC4gIjtcbiI7CisgIHByaW50 IEhFQURFUiAiICAgIENTU1ZhbHVlIiAuICRpZCAuICIgPSAiIC4gJGkgLiAiLFxuIjsKICAgJGkg PSAkaSArIDE7CiAgIGlmIChsZW5ndGgoJG5hbWUpID4gJG1heExlbikgewogICAgICRtYXhMZW4g PSBsZW5ndGgoJG5hbWUpOwogICB9CiB9CisKK3ByaW50IEhFQURFUiAifTtcblxuIjsKIHByaW50 IEhFQURFUiAiY29uc3QgaW50IG51bUNTU1ZhbHVlS2V5d29yZHMgPSAiIC4gJGkgLiAiO1xuIjsK IHByaW50IEhFQURFUiAiY29uc3Qgc2l6ZV90IG1heENTU1ZhbHVlS2V5d29yZExlbmd0aCA9ICIg LiAkbWF4TGVuIC4gIjtcbiI7CiBwcmludCBIRUFERVIgPDwgIkVPRiI7Cg==