83244 2012-04-04 19:46:57 -0700 [mac] WKTR should always keep its windows offscreen 2012-06-08 15:48:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 81965 1 thorton thorton bdakin jberlin jonlee simon.fraser webkit-bug-importer oldest_to_newest 596241 0 thorton 2012-04-04 19:46:57 -0700 Tests that use window.resize jump onto the main display. This is really annoying. I have a patch. 596242 1 webkit-bug-importer 2012-04-04 19:47:10 -0700 <rdar://problem/11188764> 596251 2 135749 thorton 2012-04-04 19:59:59 -0700 Created attachment 135749 patch 596256 3 135749 simon.fraser 2012-04-04 20:16:32 -0700 Comment on attachment 135749 patch View in context: https://bugs.webkit.org/attachment.cgi?id=135749&action=review > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:79 > + if(_shouldUseFakeOrigin) Space after if. > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:83 > + else > + return currentFrame; > +} No else after a return. 596285 4 thorton 2012-04-04 21:29:39 -0700 (In reply to comment #3) > (From update of attachment 135749 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135749&action=review > > > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:79 > > + if(_shouldUseFakeOrigin) > > Space after if. > > > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:83 > > + else > > + return currentFrame; > > +} > > No else after a return. Thanks! Landed in http://trac.webkit.org/changeset/113288 135749 2012-04-04 19:59:59 -0700 2012-04-04 20:16:32 -0700 patch wktr-resize.diff text/plain 2867 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NDAz YmU3Li4yZDgwZWQ0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTItMDQtMDQgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY10gV0tUUiBzaG91bGQgYWx3YXlzIGtl ZXAgaXRzIHdpbmRvd3Mgb2Zmc2NyZWVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04MzI0NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTExODg3NjQ+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9u J3Qgd2FudCB0byBhbGxvdyB3aW5kb3dzIG9udG8gdGhlIG1haW4gZGlzcGxheTsgaW50ZXJjZXB0 IGF0dGVtcHRzIHRvCisgICAgICAgIGNoYW5nZSBXZWJLaXRUZXN0UnVubmVyV2luZG93J3MgZnJh bWUgb3JpZ2luIGFuZCBwcmV2ZW50IGl0IGZyb20gaGFwcGVuaW5nLgorCisgICAgICAgIEFsc28g a2VlcCBhcm91bmQgYW5kIHJlc3BvbmQgd2l0aCBhIG5ldyAiZmFrZSIgb3JpZ2luLCBpbiBjYXNl IHNvbWVvbmUgaXMKKyAgICAgICAgZXhwZWN0aW5nIGl0IHRvIGNoYW5nZSAoSSBjb3VsZG4ndCBm aW5kIGFueSB0ZXN0cyB0aGF0IGV4cGVjdGVkIHRoaXMsIGhvd2V2ZXIpLgorCisgICAgICAgICog V2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tOgorICAgICAgICAoLVtX ZWJLaXRUZXN0UnVubmVyV2luZG93IHNldEZyYW1lT3JpZ2luOl0pOgorICAgICAgICAoLVtXZWJL aXRUZXN0UnVubmVyV2luZG93IHNldEZyYW1lOmRpc3BsYXk6YW5pbWF0ZTpdKToKKyAgICAgICAg KC1bV2ViS2l0VGVzdFJ1bm5lcldpbmRvdyBzZXRGcmFtZTpkaXNwbGF5Ol0pOgorICAgICAgICAo LVtXZWJLaXRUZXN0UnVubmVyV2luZG93IGZyYW1lXSk6CisKIDIwMTItMDQtMDQgIENocmlzdG9w aGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtE UlRdIENhdGNoIHRoZSAicmVzb3VyY2UscmVxdWVzdCx3aWxsc2VuZCIgc2lnbmFsCmRpZmYgLS1n aXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0gYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KaW5kZXggNjZk ZDcxNi4uMTliZWRmYSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxh dGZvcm1XZWJWaWV3TWFjLm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRm b3JtV2ViVmlld01hYy5tbQpAQCAtMzIsNiArMzIsOCBAQAogCiBAaW50ZXJmYWNlIFdlYktpdFRl c3RSdW5uZXJXaW5kb3cgOiBOU1dpbmRvdyB7CiAgICAgV1RSOjpQbGF0Zm9ybVdlYlZpZXcqIF9w bGF0Zm9ybVdlYlZpZXc7CisgICAgTlNQb2ludCBfZmFrZU9yaWdpbjsKKyAgICBib29sIF9zaG91 bGRVc2VGYWtlT3JpZ2luOwogfQogQHByb3BlcnR5IChub25hdG9taWMsIGFzc2lnbikgV1RSOjpQ bGF0Zm9ybVdlYlZpZXcqIHBsYXRmb3JtV2ViVmlldzsKIEBlbmQKQEAgLTQzLDYgKzQ1LDQyIEBA IC0gKEJPT0wpaXNLZXlXaW5kb3cKIHsKICAgICByZXR1cm4gX3BsYXRmb3JtV2ViVmlldyA/IF9w bGF0Zm9ybVdlYlZpZXctPndpbmRvd0lzS2V5KCkgOiBZRVM7CiB9CisKKy0gKHZvaWQpc2V0RnJh bWVPcmlnaW46KE5TUG9pbnQpcG9pbnQKK3sKKyAgICBfZmFrZU9yaWdpbiA9IHBvaW50OworICAg IF9zaG91bGRVc2VGYWtlT3JpZ2luID0gWUVTOworfQorCistICh2b2lkKXNldEZyYW1lOihOU1Jl Y3Qpd2luZG93RnJhbWUgZGlzcGxheTooQk9PTClkaXNwbGF5Vmlld3MgYW5pbWF0ZTooQk9PTClw ZXJmb3JtQW5pbWF0aW9uCit7CisgICAgTlNSZWN0IGN1cnJlbnRGcmFtZSA9IFtzdXBlciBmcmFt ZV07CisKKyAgICBfZmFrZU9yaWdpbiA9IHdpbmRvd0ZyYW1lLm9yaWdpbjsKKyAgICBfc2hvdWxk VXNlRmFrZU9yaWdpbiA9IFlFUzsKKworICAgIFtzdXBlciBzZXRGcmFtZTpOU01ha2VSZWN0KGN1 cnJlbnRGcmFtZS5vcmlnaW4ueCwgY3VycmVudEZyYW1lLm9yaWdpbi55LCB3aW5kb3dGcmFtZS5z aXplLndpZHRoLCB3aW5kb3dGcmFtZS5zaXplLmhlaWdodCkgZGlzcGxheTpkaXNwbGF5Vmlld3Mg YW5pbWF0ZTpwZXJmb3JtQW5pbWF0aW9uXTsKK30KKworLSAodm9pZClzZXRGcmFtZTooTlNSZWN0 KXdpbmRvd0ZyYW1lIGRpc3BsYXk6KEJPT0wpZGlzcGxheVZpZXdzCit7CisgICAgTlNSZWN0IGN1 cnJlbnRGcmFtZSA9IFtzdXBlciBmcmFtZV07CisKKyAgICBfZmFrZU9yaWdpbiA9IHdpbmRvd0Zy YW1lLm9yaWdpbjsKKyAgICBfc2hvdWxkVXNlRmFrZU9yaWdpbiA9IFlFUzsKKworICAgIFtzdXBl ciBzZXRGcmFtZTpOU01ha2VSZWN0KGN1cnJlbnRGcmFtZS5vcmlnaW4ueCwgY3VycmVudEZyYW1l Lm9yaWdpbi55LCB3aW5kb3dGcmFtZS5zaXplLndpZHRoLCB3aW5kb3dGcmFtZS5zaXplLmhlaWdo dCkgZGlzcGxheTpkaXNwbGF5Vmlld3NdOworfQorCistIChOU1JlY3QpZnJhbWUKK3sKKyAgICBO U1JlY3QgY3VycmVudEZyYW1lID0gW3N1cGVyIGZyYW1lXTsKKworICAgIGlmKF9zaG91bGRVc2VG YWtlT3JpZ2luKQorICAgICAgICByZXR1cm4gTlNNYWtlUmVjdChfZmFrZU9yaWdpbi54LCBfZmFr ZU9yaWdpbi55LCBjdXJyZW50RnJhbWUuc2l6ZS53aWR0aCwgY3VycmVudEZyYW1lLnNpemUuaGVp Z2h0KTsKKyAgICBlbHNlCisgICAgICAgIHJldHVybiBjdXJyZW50RnJhbWU7Cit9CiBAZW5kCiAK IG5hbWVzcGFjZSBXVFIgewo=