83226 2012-04-04 15:12:16 -0700 build-webkit | filter-build-webkit returns success even when build-webkit fails 2016-01-06 10:26:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=67523 P2 Normal --- 70080 1 eric webkit-unassigned abarth bburg dino joepeck ojan zoltan oldest_to_newest 596004 0 eric 2012-04-04 15:12:16 -0700 build-webkit | filter-build-webkit returns success even when build-webkit fails Fixing this would make my life easier. :) I would like to be able to use: build-webkit | filter-build-webkit && run-webkit-tests 596005 1 eric 2012-04-04 15:12:29 -0700 Hmm... Looks like bug 70080 attempted this before. 596006 2 eric 2012-04-04 15:12:47 -0700 Another solution would be to just integrate filter-build-webkit into build-webkit :) 596011 3 dino 2012-04-04 15:13:45 -0700 (In reply to comment #2) > Another solution would be to just integrate filter-build-webkit into build-webkit :) Yeah. Pass --filter-build or something. 596015 4 eric 2012-04-04 15:17:35 -0700 mdelany doesn't seem to have a bugzilla account or I would have CC'd him. :) http://trac.webkit.org/log/trunk/Tools/Scripts/filter-build-webkit 1153076 5 bburg 2016-01-06 10:26:39 -0800 There is nothing that we can change in filter-build-webkit (a perl script) to get the exit status from an earlier command in the pipeline. There are two ways to get this behavior without changing any scripts: 1. In bash, use cmd1 |& cmd2 (shortcut for cmd1 2>&1 | cmd2). Then the BUILD FAILED detection will work. 2. In bash, run 'set -o pipefail'. This uses the leftmost non-zero return code from a pipeline rather than the rightmost program. In the future, build-webkit should incorporate filter-build-webkit. If filter-build-webkit were running build commands, then it could capture and propagate the exit codes from its child processes.