<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>83225</bug_id>
          
          <creation_ts>2012-04-04 15:09:31 -0700</creation_ts>
          <short_desc>[CMake] Do not pass -P to the preprocessor when running make_names.pl.</short_desc>
          <delta_ts>2012-04-10 15:59:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Raphael Kubo da Costa (:rakuco)">rakuco</reporter>
          <assigned_to name="Raphael Kubo da Costa (:rakuco)">rakuco</assigned_to>
          <cc>mxie</cc>
    
    <cc>paroga</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>595998</commentid>
    <comment_count>0</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-04-04 15:09:31 -0700</bug_when>
    <thetext>[CMake] Do not pass -P to the preprocessor in the common case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>596014</commentid>
    <comment_count>1</comment_count>
      <attachid>135696</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-04-04 15:14:44 -0700</bug_when>
    <thetext>Created attachment 135696
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>596166</commentid>
    <comment_count>2</comment_count>
      <attachid>135696</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-04-04 18:09:42 -0700</bug_when>
    <thetext>Comment on attachment 135696
Patch

Attachment 135696 did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12338025</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>596293</commentid>
    <comment_count>3</comment_count>
      <attachid>135696</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-04-04 21:55:24 -0700</bug_when>
    <thetext>Comment on attachment 135696
Patch

Removing flags for now; this needs more thought in order not to break generate-bindings and the regexes in IDLStructure.pm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>596319</commentid>
    <comment_count>4</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-04-04 23:11:27 -0700</bug_when>
    <thetext>Why do you want to remove the flag?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>596322</commentid>
    <comment_count>5</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-04-04 23:13:17 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Why do you want to remove the flag?
Sorry, ChangeLog explains it already. ;-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>597118</commentid>
    <comment_count>6</comment_count>
      <attachid>135961</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-04-05 18:43:41 -0700</bug_when>
    <thetext>Created attachment 135961
A hopefully better approach</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>597265</commentid>
    <comment_count>7</comment_count>
      <attachid>135961</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-04-06 02:54:50 -0700</bug_when>
    <thetext>Comment on attachment 135961
A hopefully better approach

if you really need to split up, i&apos;d like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>597286</commentid>
    <comment_count>8</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-04-06 04:27:54 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 135961 [details])
&gt; if you really need to split up, i&apos;d like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly.

At first I thought of making it have the same value as CODE_GENERATOR_PREPROCESSOR for MSVC and QNX. Is that what you mean?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>597358</commentid>
    <comment_count>9</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-04-06 08:00:18 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #7)
&gt; &gt; (From update of attachment 135961 [details] [details])
&gt; &gt; if you really need to split up, i&apos;d like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly.
&gt; 
&gt; At first I thought of making it have the same value as CODE_GENERATOR_PREPROCESSOR for MSVC and QNX. Is that what you mean?

yes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>598769</commentid>
    <comment_count>10</comment_count>
      <attachid>136346</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-04-09 16:58:37 -0700</bug_when>
    <thetext>Created attachment 136346
A better approach, take 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>599742</commentid>
    <comment_count>11</comment_count>
      <attachid>136346</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-04-10 15:46:51 -0700</bug_when>
    <thetext>Comment on attachment 136346
A better approach, take 2

Looks good.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>599754</commentid>
    <comment_count>12</comment_count>
      <attachid>136346</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-04-10 15:59:16 -0700</bug_when>
    <thetext>Comment on attachment 136346
A better approach, take 2

Clearing flags on attachment: 136346

Committed r113786: &lt;http://trac.webkit.org/changeset/113786&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>599755</commentid>
    <comment_count>13</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-04-10 15:59:25 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>135696</attachid>
            <date>2012-04-04 15:14:44 -0700</date>
            <delta_ts>2012-04-05 18:43:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-83225-20120404191443.patch</filename>
            <type>text/plain</type>
            <size>2072</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4
IGExZDkxOGVlODAwM2Q2YTc4OTFhNWIyOTI3OTUyYmQ1N2U2MmMyNjMuLjRhNTY2NTFjMzMyNWVm
YWQxZjgwNzE2MWU5ZmIxYmIxNzE0MjM1NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp
b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA
IC0xMiw3ICsxMiw3IEBAIElGIChNU1ZDKQogRUxTRUlGIChDTUFLRV9TWVNURU1fTkFNRSBNQVRD
SEVTIFFOWCkKICAgICBTRVQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SICIke0NNQUtFX0NY
WF9DT01QSUxFUn0gLUUgLVdwLC1QIC14IGMrKyIpCiBFTFNFICgpCi0gICAgU0VUKENPREVfR0VO
RVJBVE9SX1BSRVBST0NFU1NPUiAiJHtDTUFLRV9DWFhfQ09NUElMRVJ9IC1FIC1QIC14IGMrKyIp
CisgICAgU0VUKENPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUiAiJHtDTUFLRV9DWFhfQ09NUElM
RVJ9IC1FIC14IGMrKyIpCiBFTkRJRiAoKQogCiBTRVQoTElCX1NVRkZJWCAiIiBDQUNIRSBTVFJJ
TkcgIkRlZmluZSBzdWZmaXggb2YgZGlyZWN0b3J5IG5hbWUgKDMyLzY0KSIpCmRpZmYgLS1naXQg
YS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMWQxZGUyYjJkODY1ZWIwYmU0YjExMWJmYTU0
MjBlZjczNWRkNjY4ZS4uMzE4ZmJjNmI4Yjg1ZTliNTdhNjlkYjlhZDQ3MjU1ZTE2MmI2Zjk5ZCAx
MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisy
MDEyLTA0LTA0ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4KKwor
ICAgICAgICBbQ01ha2VdIERvIG5vdCBwYXNzIC1QIHRvIHRoZSBwcmVwcm9jZXNzb3IgaW4gdGhl
IGNvbW1vbiBjYXNlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9ODMyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBUaGlzIGlzIGEgZm9sbG93LXVwIHRvIHIxMTMyNDQgdG8gbWFrZSBXZWJLaXQgYnVpbGQg
d2l0aCBHQ0MgNC43LAorICAgICAgICB3aG9zZSBwcmVwcm9jZXNzb3Igc2VlbXMgdG8gaWdub3Jl
IGVtcHR5IGxpbmVzIHdoZW4gLVAgaXMgcGFzc2VkCisgICAgICAgIHRvIGl0LiAgU3VjaCBiZWhh
dmlvciBicmVha3MgZG9tL21ha2VfbmFtZXMucGwgKGluIGZhY3QsCisgICAgICAgIEluRmlsZXNQ
YXJzZXIucG0pLCB3aGljaCBleHBlY3RzIGFuIGVtcHR5IGxpbmUgc2VwYXJhdGluZyBjb21tb24K
KyAgICAgICAgcGFyYW1ldGVycyBhbmQgdGhlIHNwZWNpZmljIG9uZXMuCisKKyAgICAgICAgQSBm
aXggZm9yIHRoaXMgc2FtZSBlcnJvciB3YXMgc3VwcG9zZWRseSBkb25lIGluIHI4NDEyMywgYnV0
IHNpbmNlCisgICAgICAgIHRoZSBDTWFrZS1iYXNlZCBwb3J0cyBhbHdheXMgcGFzcyAtLXByZXBy
b2Nlc3NvciB0byB0aGUgUGVybCB0b29scworICAgICAgICB0aGUgZml4IG5ldmVyIHJlYWNoZWQg
dXMuCisKKyAgICAgICAgVGhlIGlkZWEgaXMgdG8gbmV2ZXIgcGFzcyAtUCwgYXMgdGhlIHJlbGV2
YW50IHRvb2xzIGFscmVhZHkgaWdub3JlCisgICAgICAgIGxpbmVzIHN0YXJ0aW5nIHdpdGggJyMn
IGFuZCBlbXB0eSBsaW5lcyBhcmUgbGVmdCB3aGVyZSB0aGV5IGFyZQorICAgICAgICBzdXBwb3Nl
ZCB0byBiZS4KKworICAgICAgICBOb3RlIHRoZSBwcmVwcm9jZXNzb3IgbGluZXMgZm9yIFFOWCBh
bmQgTVNWQyB3ZXJlIG5vdCBjaGFuZ2VkLCBhcworICAgICAgICBJIGRvbid0IGhhdmUgYWNjZXNz
IHRvIHRob3NlIHN5c3RlbXMgYW5kIHRoZXkgZG9uJ3QgdXNlIEdDQyA0LjcuCisKKyAgICAgICAg
KiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZToKKwogMjAxMi0wNC0wMyAgVG9ueSBD
aGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHJlbW92ZSBXZWJLaXQgZmlsZXMg
ZnJvbSAuZ2l0YXR0cmlidXRlcwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>135961</attachid>
            <date>2012-04-05 18:43:41 -0700</date>
            <delta_ts>2012-04-09 16:58:29 -0700</delta_ts>
            <desc>A hopefully better approach</desc>
            <filename>bug-83225-20120405224340.patch</filename>
            <type>text/plain</type>
            <size>4050</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4
IGExZDkxOGVlODAwM2Q2YTc4OTFhNWIyOTI3OTUyYmQ1N2U2MmMyNjMuLmI4NjhiZWQ1YmRmZDYw
YjhlMGM5YmMyZjdkNDVmNDAwYTllNWYwODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp
b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA
IC01LDYgKzUsMTAgQEAgSUYgKFdURl9PU19VTklYKQogICAgIEFERF9ERUZJTklUSU9OUygtRFhQ
X1VOSVgpCiBFTkRJRiAoV1RGX09TX1VOSVgpCiAKKyMgQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VT
U09SX1dJVEhfTElORU1BUktFUlMgb25seSBtYXR0ZXJzIHdpdGggR0NDID49IDQuNy4wLiAgU2lu
Y2UgdGhpcworIyB2ZXJzaW9uLCAtUCBkb2VzIG5vdCBvdXRwdXQgZW1wdHkgbGluZXMsIHdoaWNo
IGN1cnJlbnRseSBicmVha3MgbWFrZV9uYW1lcy5wbCBpbgorIyBXZWJDb3JlLiBJbnZlc3RpZ2F0
aW5nIHdoZXRoZXIgbWFrZV9uYW1lcy5wbCBzaG91bGQgYmUgY2hhbmdlZCBpbnN0ZWFkIGlzIGxl
ZnQgYXMgYW4gZXhlcmNpc2UgdG8KKyMgdGhlIHJlYWRlci4KIElGIChNU1ZDKQogICAgICMgRklY
TUU6IFNvbWUgY29kZWdlbmVyYXRvcnMgZG9uJ3Qgc3VwcG9ydCBwYXRocyB3aXRoIHNwYWNlcy4g
U28gdXNlIHRoZSBleGVjdXRhYmxlIG5hbWUgb25seS4KICAgICBHRVRfRklMRU5BTUVfQ09NUE9O
RU5UKENPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUl9FWEVDVVRBQkxFICR7Q01BS0VfQ1hYX0NP
TVBJTEVSfSBOQU1FKQpAQCAtMTMsNiArMTcsNyBAQCBFTFNFSUYgKENNQUtFX1NZU1RFTV9OQU1F
IE1BVENIRVMgUU5YKQogICAgIFNFVChDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1IgIiR7Q01B
S0VfQ1hYX0NPTVBJTEVSfSAtRSAtV3AsLVAgLXggYysrIikKIEVMU0UgKCkKICAgICBTRVQoQ09E
RV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SICIke0NNQUtFX0NYWF9DT01QSUxFUn0gLUUgLVAgLXgg
YysrIikKKyAgICBTRVQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SX1dJVEhfTElORU1BUktF
UlMgIiR7Q01BS0VfQ1hYX0NPTVBJTEVSfSAtRSAteCBjKysiKQogRU5ESUYgKCkKIAogU0VUKExJ
Ql9TVUZGSVggIiIgQ0FDSEUgU1RSSU5HICJEZWZpbmUgc3VmZml4IG9mIGRpcmVjdG9yeSBuYW1l
ICgzMi82NCkiKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZSBi
L1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKaW5kZXggM2FiZTM0MmI3ZTUzYTA4MDky
YTRhNWU3MDAwZWI4MGFhZjBkMGNlYy4uZTA2YjZmMmQ2YWRkOGYxZDgzMGFjZGNhYWJlOWU4NTYw
MDdhMGYxNiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQorKysg
Yi9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCkBAIC02Myw2ICs2MywxMiBAQCBFTkRN
QUNSTyAoKQogCiAKIE1BQ1JPIChHRU5FUkFURV9ET01fTkFNRVMgX25hbWVzcGFjZSBfYXR0cnMp
CisgICAgSUYgKENPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUl9XSVRIX0xJTkVNQVJLRVJTKQor
ICAgICAgICBTRVQoUFJFUFJPQ0VTU09SX0NPTU1BTkQgIiR7Q09ERV9HRU5FUkFUT1JfUFJFUFJP
Q0VTU09SX1dJVEhfTElORU1BUktFUlN9IikKKyAgICBFTFNFICgpCisgICAgICAgIFNFVChQUkVQ
Uk9DRVNTT1JfQ09NTUFORCAiJHtDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1J9IikKKyAgICBF
TkRJRiAoKQorCiAgICAgU0VUKE5BTUVTX0dFTkVSQVRPUiAke1dFQkNPUkVfRElSfS9kb20vbWFr
ZV9uYW1lcy5wbCkKICAgICBTRVQoX2FyZ3VtZW50cyAgLS1hdHRycyAke19hdHRyc30pCiAgICAg
U0VUKF9vdXRwdXRmaWxlcyAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vJHtfbmFtZXNw
YWNlfU5hbWVzLmNwcCAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vJHtfbmFtZXNwYWNl
fU5hbWVzLmgpCkBAIC04OSw3ICs5NSw3IEBAIE1BQ1JPIChHRU5FUkFURV9ET01fTkFNRVMgX25h
bWVzcGFjZSBfYXR0cnMpCiAgICAgQUREX0NVU1RPTV9DT01NQU5EKAogICAgICAgICBPVVRQVVQg
ICR7X291dHB1dGZpbGVzfQogICAgICAgICBERVBFTkRTICR7TkFNRVNfR0VORVJBVE9SfSAke1ND
UklQVFNfQklORElOR1N9ICR7X2F0dHJzfSAke190YWdzfQotICAgICAgICBDT01NQU5EICR7UEVS
TF9FWEVDVVRBQkxFfSAtSSR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMgJHtOQU1FU19H
RU5FUkFUT1J9IC0tcHJlcHJvY2Vzc29yICIke0NPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUn0i
IC0tb3V0cHV0RGlyICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfSAke19hcmd1bWVudHN9
ICR7X2FkZGl0aW9uQXJndW1lbnRzfQorICAgICAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxF
fSAtSSR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMgJHtOQU1FU19HRU5FUkFUT1J9IC0t
cHJlcHJvY2Vzc29yICIke1BSRVBST0NFU1NPUl9DT01NQU5EfSIgLS1vdXRwdXREaXIgJHtERVJJ
VkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9ICR7X2FyZ3VtZW50c30gJHtfYWRkaXRpb25Bcmd1bWVu
dHN9CiAgICAgICAgIFZFUkJBVElNKQogRU5ETUFDUk8gKCkKIApkaWZmIC0tZ2l0IGEvQ2hhbmdl
TG9nIGIvQ2hhbmdlTG9nCmluZGV4IDM5MGE5Y2RmZDA5NDQ0OGYzMmQzNWQwMDZkYzg5MTk1ZDJm
MjJiNDUuLmU0ODA5MjY4YzlkZGEwYTY2ZDYxMmZjYzhiY2Y1YzQzNGZlYjllODYgMTAwNjQ0Ci0t
LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMi0wNC0w
NSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFrdWNvQHdlYmtpdC5vcmc+CisKKyAgICAgICAg
W0NNYWtlXSBEbyBub3QgcGFzcyAtUCB0byB0aGUgcHJlcHJvY2Vzc29yIHdoZW4gcnVubmluZyBt
YWtlX25hbWVzLnBsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9ODMyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBUaGlzIGlzIG5lY2Vzc2FyeSB0byBtYWtlIENNYWtlLWJhc2VkIHBvcnRzIGJ1aWxkIHdp
dGggdGhlCisgICAgICAgIHJlY2VudGx5LXJlbGVhc2VkIEdDQyA0LjcuMCwgd2hvc2UgcHJlcHJv
Y2Vzc29yIHNlZW1zIHRvIGlnbm9yZQorICAgICAgICBlbXB0eSBsaW5lcyB3aGVuIC1QIGlzIHBh
c3NlZCB0byBpdC4gIFN1Y2ggYmVoYXZpb3IgYnJlYWtzCisgICAgICAgIG1ha2VfbmFtZXMucGwg
KGluIGZhY3QsIEluRmlsZXNQYXJzZXIucG0pLCB3aGljaCBleHBlY3RzIGFuIGVtcHR5CisgICAg
ICAgIGxpbmUgdG8gc2VwYXJhdGUgY29tbW9uIGFuZCBzcGVjaWZpYyBzZWN0aW9ucyBpbiAuaW4g
ZmlsZXMuCisKKyAgICAgICAgQSBmaXggZm9yIHRoaXMgc2FtZSBwcm9ibGVtIGhhcyBiZWVuIHN1
cHBvc2VkbHkgZG9uZSBpbiByODQxMjMsCisgICAgICAgIGJ1dCBhcyB0aGUgQ01ha2UtYmFzZWQg
cG9ydHMgYWx3YXlzIHBhc3MgLS1wcmVwcm9jZXNzb3IgdG8gdGhlCisgICAgICAgIFBlcmwgdG9v
bHMgdGhlIGZpeCBuZXZlciByZWFjaGVkIHVzLgorCisgICAgICAgIFRoZSBpZGVhIGlzIHRvIGRl
ZmluZSBDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1JfV0lUSF9MSU5FTUFSS0VSUworICAgICAg
ICBmb3IgKCFNU1ZDICYmICFRTlgpIGFuZCB1c2UgaXQgaW4gdGhlIG1hY3JvcyB3aGljaCBjYWxs
CisgICAgICAgIG1ha2VfbmFtZXMucGwuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u
c0NvbW1vbi5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtl
OgorCiAyMDEyLTA0LTA1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg
ICAgIHBlcmYtby1tYXRpYyBzaG91bGQgaW5jbHVkZSB1bml0IGluIHJ1bnMgSlNPTiByZXNwb25z
ZXMK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>136346</attachid>
            <date>2012-04-09 16:58:37 -0700</date>
            <delta_ts>2012-04-10 15:59:16 -0700</delta_ts>
            <desc>A better approach, take 2</desc>
            <filename>bug-83225-20120409205845.patch</filename>
            <type>text/plain</type>
            <size>3790</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4
IGExZDkxOGVlODAwM2Q2YTc4OTFhNWIyOTI3OTUyYmQ1N2U2MmMyNjMuLjZhNTU0MDNlZjc2YTY5
ZWI3YTI4MTE4OTY1YWNjMTExOTgyMmMwMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp
b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA
IC01LDE0ICs1LDIxIEBAIElGIChXVEZfT1NfVU5JWCkKICAgICBBRERfREVGSU5JVElPTlMoLURY
UF9VTklYKQogRU5ESUYgKFdURl9PU19VTklYKQogCisjIENPREVfR0VORVJBVE9SX1BSRVBST0NF
U1NPUl9XSVRIX0xJTkVNQVJLRVJTIG9ubHkgbWF0dGVycyB3aXRoIEdDQyA+PSA0LjcuMC4gIFNp
bmNlIHRoaXMKKyMgdmVyc2lvbiwgLVAgZG9lcyBub3Qgb3V0cHV0IGVtcHR5IGxpbmVzLCB3aGlj
aCBjdXJyZW50bHkgYnJlYWtzIG1ha2VfbmFtZXMucGwgaW4KKyMgV2ViQ29yZS4gSW52ZXN0aWdh
dGluZyB3aGV0aGVyIG1ha2VfbmFtZXMucGwgc2hvdWxkIGJlIGNoYW5nZWQgaW5zdGVhZCBpcyBs
ZWZ0IGFzIGFuIGV4ZXJjaXNlIHRvCisjIHRoZSByZWFkZXIuCiBJRiAoTVNWQykKICAgICAjIEZJ
WE1FOiBTb21lIGNvZGVnZW5lcmF0b3JzIGRvbid0IHN1cHBvcnQgcGF0aHMgd2l0aCBzcGFjZXMu
IFNvIHVzZSB0aGUgZXhlY3V0YWJsZSBuYW1lIG9ubHkuCiAgICAgR0VUX0ZJTEVOQU1FX0NPTVBP
TkVOVChDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1JfRVhFQ1VUQUJMRSAke0NNQUtFX0NYWF9D
T01QSUxFUn0gTkFNRSkKICAgICBTRVQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SICIke0NP
REVfR0VORVJBVE9SX1BSRVBST0NFU1NPUl9FWEVDVVRBQkxFfSAvbm9sb2dvIC9FUCIpCisgICAg
U0VUKENPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUl9XSVRIX0xJTkVNQVJLRVJTICIke0NPREVf
R0VORVJBVE9SX1BSRVBST0NFU1NPUn0iKQogRUxTRUlGIChDTUFLRV9TWVNURU1fTkFNRSBNQVRD
SEVTIFFOWCkKICAgICBTRVQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SICIke0NNQUtFX0NY
WF9DT01QSUxFUn0gLUUgLVdwLC1QIC14IGMrKyIpCisgICAgU0VUKENPREVfR0VORVJBVE9SX1BS
RVBST0NFU1NPUl9XSVRIX0xJTkVNQVJLRVJTICIke0NPREVfR0VORVJBVE9SX1BSRVBST0NFU1NP
Un0iKQogRUxTRSAoKQogICAgIFNFVChDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1IgIiR7Q01B
S0VfQ1hYX0NPTVBJTEVSfSAtRSAtUCAteCBjKysiKQorICAgIFNFVChDT0RFX0dFTkVSQVRPUl9Q
UkVQUk9DRVNTT1JfV0lUSF9MSU5FTUFSS0VSUyAiJHtDTUFLRV9DWFhfQ09NUElMRVJ9IC1FIC14
IGMrKyIpCiBFTkRJRiAoKQogCiBTRVQoTElCX1NVRkZJWCAiIiBDQUNIRSBTVFJJTkcgIkRlZmlu
ZSBzdWZmaXggb2YgZGlyZWN0b3J5IG5hbWUgKDMyLzY0KSIpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
Y21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFr
ZQppbmRleCAzYWJlMzQyYjdlNTNhMDgwOTJhNGE1ZTcwMDBlYjgwYWFmMGQwY2VjLi40ZTdjYTlm
ZTQ1ZGI5OTBjMmQzODE0YjM2NTgxY2Y1ZGJiYjU0OGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21h
a2UvV2ViS2l0TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21h
a2UKQEAgLTg5LDcgKzg5LDcgQEAgTUFDUk8gKEdFTkVSQVRFX0RPTV9OQU1FUyBfbmFtZXNwYWNl
IF9hdHRycykKICAgICBBRERfQ1VTVE9NX0NPTU1BTkQoCiAgICAgICAgIE9VVFBVVCAgJHtfb3V0
cHV0ZmlsZXN9CiAgICAgICAgIERFUEVORFMgJHtOQU1FU19HRU5FUkFUT1J9ICR7U0NSSVBUU19C
SU5ESU5HU30gJHtfYXR0cnN9ICR7X3RhZ3N9Ci0gICAgICAgIENPTU1BTkQgJHtQRVJMX0VYRUNV
VEFCTEV9IC1JJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cyAke05BTUVTX0dFTkVSQVRP
Un0gLS1wcmVwcm9jZXNzb3IgIiR7Q09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SfSIgLS1vdXRw
dXREaXIgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9ICR7X2FyZ3VtZW50c30gJHtfYWRk
aXRpb25Bcmd1bWVudHN9CisgICAgICAgIENPTU1BTkQgJHtQRVJMX0VYRUNVVEFCTEV9IC1JJHtX
RUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cyAke05BTUVTX0dFTkVSQVRPUn0gLS1wcmVwcm9j
ZXNzb3IgIiR7Q09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SX1dJVEhfTElORU1BUktFUlN9IiAt
LW91dHB1dERpciAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0gJHtfYXJndW1lbnRzfSAk
e19hZGRpdGlvbkFyZ3VtZW50c30KICAgICAgICAgVkVSQkFUSU0pCiBFTkRNQUNSTyAoKQogCmRp
ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNjEyOGUxMTZjMzNjZWNjMDlj
ZWEwZTBiYTBiOWIwYTM1YmZjMDZiZS4uYTVlZTI2NmM0NDAwOGUwZmViODM4ZGMxM2ZjZWE2YTJh
NjMzMWVkYSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx
LDI3IEBACisyMDEyLTA0LTA1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0
Lm9yZz4KKworICAgICAgICBbQ01ha2VdIERvIG5vdCBwYXNzIC1QIHRvIHRoZSBwcmVwcm9jZXNz
b3Igd2hlbiBydW5uaW5nIG1ha2VfbmFtZXMucGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzIyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgbmVjZXNzYXJ5IHRvIG1ha2UgQ01ha2UtYmFz
ZWQgcG9ydHMgYnVpbGQgd2l0aCB0aGUKKyAgICAgICAgcmVjZW50bHktcmVsZWFzZWQgR0NDIDQu
Ny4wLCB3aG9zZSBwcmVwcm9jZXNzb3Igc2VlbXMgdG8gaWdub3JlCisgICAgICAgIGVtcHR5IGxp
bmVzIHdoZW4gLVAgaXMgcGFzc2VkIHRvIGl0LiAgU3VjaCBiZWhhdmlvciBicmVha3MKKyAgICAg
ICAgbWFrZV9uYW1lcy5wbCAoaW4gZmFjdCwgSW5GaWxlc1BhcnNlci5wbSksIHdoaWNoIGV4cGVj
dHMgYW4gZW1wdHkKKyAgICAgICAgbGluZSB0byBzZXBhcmF0ZSBjb21tb24gYW5kIHNwZWNpZmlj
IHNlY3Rpb25zIGluIC5pbiBmaWxlcy4KKworICAgICAgICBBIGZpeCBmb3IgdGhpcyBzYW1lIHBy
b2JsZW0gaGFzIGJlZW4gc3VwcG9zZWRseSBkb25lIGluIHI4NDEyMywKKyAgICAgICAgYnV0IGFz
IHRoZSBDTWFrZS1iYXNlZCBwb3J0cyBhbHdheXMgcGFzcyAtLXByZXByb2Nlc3NvciB0byB0aGUK
KyAgICAgICAgUGVybCB0b29scyB0aGUgZml4IG5ldmVyIHJlYWNoZWQgdXMuCisKKyAgICAgICAg
VGhlIGlkZWEgaXMgdG8gZGVmaW5lIENPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUl9XSVRIX0xJ
TkVNQVJLRVJTCisgICAgICAgIGZvciAoIU1TVkMgJiYgIVFOWCkgYW5kIHVzZSBpdCBpbiB0aGUg
bWFjcm9zIHdoaWNoIGNhbGwKKyAgICAgICAgbWFrZV9uYW1lcy5wbC4KKworICAgICAgICAqIFNv
dXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9X
ZWJLaXRNYWNyb3MuY21ha2U6CisKIDIwMTItMDQtMDkgIERhbGUgQ3VydGlzICA8ZGFsZWN1cnRp
c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHVud29ya2FibGUgdmlkZW8tYnVmZmVy
aW5nLXJlcGFpbnRzLWNvbnRyb2xzIHRlc3QuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>