83177 2012-04-04 10:17:36 -0700 [Chromium] TestWebKitAPI links in WebCore twice 2012-04-04 22:58:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov dpranke levin webkit.review.bot oldest_to_newest 595650 0 abarth 2012-04-04 10:17:36 -0700 [Chromium] TestWebKitAPI links in WebCore twice 595653 1 135619 abarth 2012-04-04 10:19:13 -0700 Created attachment 135619 Patch 595662 2 135619 dglazkov 2012-04-04 10:28:08 -0700 Comment on attachment 135619 Patch Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? 595684 3 dglazkov 2012-04-04 10:40:00 -0700 Oh, forgot! Can you add it back to build as a target in All.gyp? 595689 4 abarth 2012-04-04 10:42:32 -0700 > All.gyp? That's in Chromium-land, right? I'll take care of adding it back once the roll happens. 595690 5 abarth 2012-04-04 10:43:16 -0700 > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests. 595694 6 dglazkov 2012-04-04 10:44:14 -0700 No, that's Source/WebKit/chromium/All.gyp. I removed it here: http://trac.webkit.org/changeset/113201 595719 7 135631 abarth 2012-04-04 11:08:44 -0700 Created attachment 135631 Patch for landing 595774 8 dpranke 2012-04-04 12:07:10 -0700 (In reply to comment #5) > > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? > > Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests. Yes ... this is run on the build.webkit.org bots (run-api-tests), but we should probably be running them on the canaries as well. 595860 9 135631 webkit.review.bot 2012-04-04 13:28:02 -0700 Comment on attachment 135631 Patch for landing Clearing flags on attachment: 135631 Committed r113231: <http://trac.webkit.org/changeset/113231> 595861 10 webkit.review.bot 2012-04-04 13:28:06 -0700 All reviewed patches have been landed. Closing bug. 596311 11 levin 2012-04-04 22:58:07 -0700 (In reply to comment #5) > > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this? > > Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests. Ideally webkit_unit_tests and this would be combined. I think folding webkit_unit_tests into this would be ideal. 135619 2012-04-04 10:19:13 -0700 2012-04-04 11:08:39 -0700 Patch bug-83177-20120404101912.patch text/plain 1714 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMzIwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTA0LTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0Nocm9taXVtXSBUZXN0V2ViS2l0QVBJIGxpbmtzIGluIFdlYkNvcmUgdHdpY2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMTc3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBj YXVzaW5nIGxpbmsgZXJyb3JzIGluIHRoZSBXaW5kb3dzIGNvbXBvbmVudCBidWlsZC4gVGhpcyBw YXRjaAorICAgICAgICBtb3ZlcyB0aGUgZGVwZW5kZW5jaWVzIGEgYml0IGxvd2VyIGRvd24gaW4g dGhlIGRlcGVuZGVuY3kgZGlhZ3JhbSBpbgorICAgICAgICB0aGUgaG9wZXMgb2YgcmVtb3Zpbmcg dGhlIGR1cGxpY2F0ZSBzeW1ib2xzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0V2Vi S2l0QVBJLmd5cC9UZXN0V2ViS2l0QVBJLmd5cDoKKwogMjAxMi0wNC0wNCAgU3VkYXJzYW5hIE5h Z2luZW5pICA8c3VkYXJzYW5hLm5hZ2luZW5pQGxpbnV4LmludGVsLmNvbT4KIAogICAgICAgICBb RUZMXSBEUlQgc3VwcG9ydCBmb3IgY29tcHV0ZWRTdHlsZUluY2x1ZGluZ1Zpc2l0ZWRJbmZvCklu ZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkuZ3lwL1Rlc3RXZWJLaXRBUEku Z3lwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS5neXAv VGVzdFdlYktpdEFQSS5neXAJKHJldmlzaW9uIDExMzE0NCkKKysrIFRvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdFdlYktpdEFQSS5neXAvVGVzdFdlYktpdEFQSS5neXAJKHdvcmtpbmcgY29weSkKQEAg LTU1LDcgKzU1LDkgQEAKICAgICAgICAgICAgICd0eXBlJzogJ2V4ZWN1dGFibGUnLCAKICAgICAg ICAgICAgICdkZXBlbmRlbmNpZXMnOiBbIAogICAgICAgICAgICAgICAgICc8KHNvdXJjZV9kaXIp L1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwOndlYmtpdCcsIAotICAgICAgICAgICAgICAgICc8 KHNvdXJjZV9kaXIpL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6d2ViY29yZScsIAor ICAgICAgICAgICAgICAgICc8KHNvdXJjZV9kaXIpL1dURi9XVEYuZ3lwL1dURi5neXA6d3RmJywg CisgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvYnVpbGQvdGVtcF9neXAvZ29v Z2xldXJsLmd5cDpnb29nbGV1cmwnLAorICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19k aXIpL3Y4L3Rvb2xzL2d5cC92OC5neXA6djgnLAogICAgICAgICAgICAgICAgICc8KGNocm9taXVt X3NyY19kaXIpL2Jhc2UvYmFzZS5neXA6dGVzdF9zdXBwb3J0X2Jhc2UnLCAKICAgICAgICAgICAg ICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90ZXN0aW5nL2d0ZXN0Lmd5cDpndGVzdCcsIAogICAg ICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3Rlc3RpbmcvZ21vY2suZ3lwOmdtb2Nr JywgCg== 135631 2012-04-04 11:08:44 -0700 2012-04-04 13:28:02 -0700 Patch for landing bug-83177-20120404110842.patch text/plain 2268 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQWxsLmd5cAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0FsbC5neXAJKHJldmlzaW9uIDExMzIxNSkKKysrIFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vQWxsLmd5cAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsNyBAQAog ICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgICAgICAgICAnV2ViS2l0VW5p dFRlc3RzLmd5cDp3ZWJraXRfdW5pdF90ZXN0cycsCiAgICAgICAgICAgICAgICAgJy4uLy4uLy4u L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5n eXA6RHVtcFJlbmRlclRyZWUnLAorICAgICAgICAgICAgICAgICcuLi8uLi8uLi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkuZ3lwL1Rlc3RXZWJLaXRBUEkuZ3lwOlRlc3RXZWJLaXRB UEknLAogICAgICAgICAgICAgXSwKICAgICAgICAgfQogICAgIF0sCkluZGV4OiBUb29scy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTMyMDkpCisr KyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0w NC0wNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFtDaHJvbWl1 bV0gVGVzdFdlYktpdEFQSSBsaW5rcyBpbiBXZWJDb3JlIHR3aWNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE3NworCisgICAgICAgIFJldmlld2Vk IGJ5IERpbWl0cmkgR2xhemtvdi4KKworICAgICAgICBUaGlzIGlzIGNhdXNpbmcgbGluayBlcnJv cnMgaW4gdGhlIFdpbmRvd3MgY29tcG9uZW50IGJ1aWxkLiBUaGlzIHBhdGNoCisgICAgICAgIG1v dmVzIHRoZSBkZXBlbmRlbmNpZXMgYSBiaXQgbG93ZXIgZG93biBpbiB0aGUgZGVwZW5kZW5jeSBk aWFncmFtIGluCisgICAgICAgIHRoZSBob3BlcyBvZiByZW1vdmluZyB0aGUgZHVwbGljYXRlIHN5 bWJvbHMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkuZ3lwL1Rlc3RX ZWJLaXRBUEkuZ3lwOgorCiAyMDEyLTA0LTA0ICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNh bmEubmFnaW5lbmlAbGludXguaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIERSVCBzdXBwb3J0 IGZvciBjb21wdXRlZFN0eWxlSW5jbHVkaW5nVmlzaXRlZEluZm8KSW5kZXg6IFRvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdFdlYktpdEFQSS5neXAvVGVzdFdlYktpdEFQSS5neXAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLmd5cC9UZXN0V2ViS2l0QVBJLmd5 cAkocmV2aXNpb24gMTEzMTQ0KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJ Lmd5cC9UZXN0V2ViS2l0QVBJLmd5cAkod29ya2luZyBjb3B5KQpAQCAtNTUsNyArNTUsOSBAQAog ICAgICAgICAgICAgJ3R5cGUnOiAnZXhlY3V0YWJsZScsIAogICAgICAgICAgICAgJ2RlcGVuZGVu Y2llcyc6IFsgCiAgICAgICAgICAgICAgICAgJzwoc291cmNlX2RpcikvV2ViS2l0L2Nocm9taXVt L1dlYktpdC5neXA6d2Via2l0JywgCi0gICAgICAgICAgICAgICAgJzwoc291cmNlX2RpcikvV2Vi Q29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDp3ZWJjb3JlJywgCisgICAgICAgICAgICAgICAg Jzwoc291cmNlX2RpcikvV1RGL1dURi5neXAvV1RGLmd5cDp3dGYnLCAKKyAgICAgICAgICAgICAg ICAnPChjaHJvbWl1bV9zcmNfZGlyKS9idWlsZC90ZW1wX2d5cC9nb29nbGV1cmwuZ3lwOmdvb2ds ZXVybCcsCisgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdjgvdG9vbHMvZ3lw L3Y4Lmd5cDp2OCcsCiAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvYmFzZS9i YXNlLmd5cDp0ZXN0X3N1cHBvcnRfYmFzZScsIAogICAgICAgICAgICAgICAgICc8KGNocm9taXVt X3NyY19kaXIpL3Rlc3RpbmcvZ3Rlc3QuZ3lwOmd0ZXN0JywgCiAgICAgICAgICAgICAgICAgJzwo Y2hyb21pdW1fc3JjX2RpcikvdGVzdGluZy9nbW9jay5neXA6Z21vY2snLCAK