83176 2012-04-04 10:08:30 -0700 gtk_unittest.GtkPortTest.test_get_crash_log failing on windows 2012-04-05 11:16:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony pnormand abarth dpranke mrobinson ojan pnormand webkit.review.bot oldest_to_newest 595642 0 tony 2012-04-04 10:08:30 -0700 http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/25106/steps/webkitpy-test/logs/stdio Looks like it's been failing since it was added in http://trac.webkit.org/changeset/113037 . Should we skip this test on Windows? 595648 1 pnormand 2012-04-04 10:13:33 -0700 Oh sorry about that! Yeah I guess it's safe to not run this test on non-linux platforms. 595649 2 135618 pnormand 2012-04-04 10:16:38 -0700 Created attachment 135618 Patch 595657 3 135618 tony 2012-04-04 10:24:08 -0700 Comment on attachment 135618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135618&action=review > Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py:72 > + if sys.platform != "linux2": What about linux3 (I think newer kernels show up as linux3)? I normally just do sys.platform.startswith("linux"). 595664 4 pnormand 2012-04-04 10:29:47 -0700 Committed r113210: <http://trac.webkit.org/changeset/113210> 595666 5 pnormand 2012-04-04 10:30:38 -0700 (In reply to comment #3) > (From update of attachment 135618 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135618&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py:72 > > + if sys.platform != "linux2": > > What about linux3 (I think newer kernels show up as linux3)? I normally just do sys.platform.startswith("linux"). Oh I didn't know about that linux3 :) I landed the modified patch. Thanks! 595768 6 dpranke 2012-04-04 12:04:07 -0700 I'm generally not a fan of skipping unit tests on different platforms; if this test is failing on windows, it suggests that it's either not correctly written or it depends on something in the environment or operating system. If it's the latter, we should probably rename this to integration_test_get_crash_log() to be clearer ... 596362 7 pnormand 2012-04-05 00:38:08 -0700 (In reply to comment #6) > I'm generally not a fan of skipping unit tests on different platforms; if this test is failing on windows, it suggests that it's either not correctly written or it depends on something in the environment or operating system. If it's the latter, we should probably rename this to integration_test_get_crash_log() to be clearer ... Indeed I was too quick skipping this on non-linux, the mock crash log used in the test is using %(core_directory)s/core-pid_%%p-_-process_%%e instead of building the path with os.path.join(). I'll send a new patch. 596364 8 135771 pnormand 2012-04-05 00:48:45 -0700 Created attachment 135771 Patch 596673 9 135771 tony 2012-04-05 10:26:06 -0700 Comment on attachment 135771 Patch If GtkPort._get_crash_log used FileSystem.join and you used MockFileSystem in the test, you would always get / when running the test since MockFileSystem always uses / as the separator. This seems fine too. 596689 10 135771 dpranke 2012-04-05 10:38:07 -0700 Comment on attachment 135771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135771&action=review > Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py:60 > + core_pattern = os.path.join(core_directory, "core-pid_%p-_-process_%e") This should probably be port._filesystem.join() (and moved below the self.make_port() call), else you'll get diffs on windows from backslashes in the path, I expect. 596724 11 135771 webkit.review.bot 2012-04-05 11:16:16 -0700 Comment on attachment 135771 Patch Clearing flags on attachment: 135771 Committed r113339: <http://trac.webkit.org/changeset/113339> 596725 12 webkit.review.bot 2012-04-05 11:16:21 -0700 All reviewed patches have been landed. Closing bug. 135618 2012-04-04 10:16:38 -0700 2012-04-05 00:48:37 -0700 Patch bug-83176-20120404191639.patch text/plain 1469 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMjA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzBlNzg2ZTRmMjY1NTYwNTE0NDNkN2FlYTQ3ODljZjEx ZjA0MGZjMy4uMDY2MjNhYzRiODNmYTg5YmMzMTlkZDU2ZjEwNWEzZTRjOTkxMDFmMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA0LTA0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBndGtfdW5pdHRlc3QuR3RrUG9ydFRlc3QudGVzdF9nZXRfY3Jhc2hfbG9nIGZh aWxpbmcgb24gd2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODMxNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrX3VuaXR0ZXN0 LnB5OgorICAgICAgICAodGVzdF9nZXRfY3Jhc2hfbG9nKTogU2tpcCB0aGUgdGVzdCBvbiBub24t bGludXggcGxhdGZvcm1zLgorCiAyMDEyLTA0LTA0ICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRh cnNhbmEubmFnaW5lbmlAbGludXguaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIERSVCBzdXBw b3J0IGZvciBjb21wdXRlZFN0eWxlSW5jbHVkaW5nVmlzaXRlZEluZm8KZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrX3VuaXR0ZXN0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtfdW5pdHRlc3QucHkK aW5kZXggYzE3MDVmNmRmMDE5MjFhZjZiNTk3YTQzNTQ1N2Y2MTIzMzY5NmUxZi4uMzRlMjU0MGE2 ZDY4MmZkMGU1NDYxYTc4ZWZlNWQwZGZmNjU2ZGRjNiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtfdW5pdHRlc3QucHkKQEAgLTY5 LDYgKzY5LDggQEAgU1RERVJSOiA8ZW1wdHk+IiIiICUgeydjb3JlX2RpcmVjdG9yeSc6IG9zLmVu dmlyb24uZ2V0KCdXRUJLSVRfQ09SRV9EVU1QU19ESVJFQ1QKICAgICAgICAgcmV0dXJuIChzZWxm Ll9tb2NrX2NyYXNoX2xvZywgW10pCiAKICAgICBkZWYgdGVzdF9nZXRfY3Jhc2hfbG9nKHNlbGYp OgorICAgICAgICBpZiBzeXMucGxhdGZvcm0gIT0gImxpbnV4MiI6CisgICAgICAgICAgICByZXR1 cm4KICAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KCkKICAgICAgICAgcG9ydC5fZ2V0X2dk Yl9vdXRwdXQgPSBzZWxmLl9tb2NrX2dkYl9vdXRwdXQKICAgICAgICAgbG9nID0gcG9ydC5fZ2V0 X2NyYXNoX2xvZygiRHVtcFJlbmRlclRyZWUiLCAyODUyOSwgIiIsICIiKQo= 135771 2012-04-05 00:48:45 -0700 2012-04-05 11:16:16 -0700 Patch bug-83176-20120405094846.patch text/plain 3463 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMjk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzRhMTcwNWM5NDhkNTVlNmQ3ZTM4ZDY1NTMxNmJlNTFj YWQ2Mjg2ZS4uZDUwMTVkZWMwOGJkM2RjNWE0ZDhlMmU1ZTljMTIzMDczYTBkNGNhMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA0LTA1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBndGtfdW5pdHRlc3QuR3RrUG9ydFRlc3QudGVzdF9nZXRfY3Jhc2hfbG9nIGZh aWxpbmcgb24gd2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODMxNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZWZhY3RvcmVkIHRoZSB0ZXN0IHRvIHVzZSBvcy5wYXRoLmpvaW4oKSB0byBzcGVj aWZ5IHRoZQorICAgICAgICBjb3JlX3BhdHRlcm4gdmFsdWUgb2YgdGhlIGVtcHR5IGNyYXNoIGxv ZyBtb2NrLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9n dGtfdW5pdHRlc3QucHk6CisgICAgICAgIChHdGtQb3J0VGVzdCk6CisgICAgICAgIChHdGtQb3J0 VGVzdC5hc3NlcnRMaW5lc0VxdWFsKToKKyAgICAgICAgKEd0a1BvcnRUZXN0LnRlc3RfZ2V0X2Ny YXNoX2xvZyk6CisgICAgICAgIChfbW9ja19nZGJfb3V0cHV0KToKKwogMjAxMi0wNC0wNCAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjXSBXS1RS IHNob3VsZCBhbHdheXMga2VlcCBpdHMgd2luZG93cyBvZmZzY3JlZW4KZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrX3VuaXR0ZXN0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtfdW5pdHRlc3QucHkK aW5kZXggZmYyZTFjMzc4ZGJjNWMyYzMzYzczNjI2YTA3ZTczMzQwZjk3NGRlOS4uZmRkYzJhZmM4 ODc1MWU3YjA3NjE2YTNjNmQ0Y2RkY2Q4ZjQ1OGFhZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGtfdW5pdHRlc3QucHkKQEAgLTQx LDE3ICs0MSw2IEBAIGZyb20gd2Via2l0cHkudG9vbC5tb2NrdG9vbCBpbXBvcnQgTW9ja09wdGlv bnMKIGNsYXNzIEd0a1BvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToKICAgICBw b3J0X25hbWUgPSAnZ3RrJwogICAgIHBvcnRfbWFrZXIgPSBHdGtQb3J0Ci0gICAgX21vY2tfY3Jh c2hfbG9nID0gIiIiXAotQ3Jhc2ggbG9nIGZvciBEdW1wUmVuZGVyVHJlZSAocGlkIDI4NTI5KToK LQotQ29yZWR1bXAgY29yZS1waWRfMjg1MjktXy1wcm9jZXNzX0R1bXBSZW5kZXJUcmVlIG5vdCBm b3VuZC4gVG8gZW5hYmxlIGNyYXNoIGxvZ3M6Ci0KLS0gcnVuIHRoaXMgY29tbWFuZCBhcyBzdXBl ci11c2VyOiBlY2hvICIlKGNvcmVfZGlyZWN0b3J5KXMvY29yZS1waWRfJSVwLV8tcHJvY2Vzc18l JWUiID4gL3Byb2Mvc3lzL2tlcm5lbC9jb3JlX3BhdHRlcm4KLS0gZW5hYmxlIGNvcmUgZHVtcHM6 IHVsaW1pdCAtYyB1bmxpbWl0ZWQKLS0gc2V0IHRoZSBXRUJLSVRfQ09SRV9EVU1QU19ESVJFQ1RP UlkgZW52aXJvbm1lbnQgdmFyaWFibGU6IGV4cG9ydCBXRUJLSVRfQ09SRV9EVU1QU19ESVJFQ1RP Ulk9JShjb3JlX2RpcmVjdG9yeSlzCi0KLQotU1RERVJSOiA8ZW1wdHk+IiIiICUgeydjb3JlX2Rp cmVjdG9yeSc6IG9zLmVudmlyb24uZ2V0KCdXRUJLSVRfQ09SRV9EVU1QU19ESVJFQ1RPUlknLCAn L3BhdGgvdG8vY29yZWR1bXBzJyl9CiAKICAgICBkZWYgdGVzdF9zaG93X3Jlc3VsdHNfaHRtbF9m aWxlKHNlbGYpOgogICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQoKQpAQCAtNjUsMTMgKzU0 LDI2IEBAIFNUREVSUjogPGVtcHR5PiIiIiAlIHsnY29yZV9kaXJlY3RvcnknOiBvcy5lbnZpcm9u LmdldCgnV0VCS0lUX0NPUkVfRFVNUFNfRElSRUNUCiAgICAgICAgIGVsc2U6CiAgICAgICAgICAg ICBzZWxmLmFzc2VydEVxdWFsKGEuc3BsaXRsaW5lcygpLCBiLnNwbGl0bGluZXMoKSkKIAotICAg IGRlZiBfbW9ja19nZGJfb3V0cHV0KHNlbGYsIGNvcmVkdW1wX3BhdGgpOgotICAgICAgICByZXR1 cm4gKHNlbGYuX21vY2tfY3Jhc2hfbG9nLCBbXSkKIAogICAgIGRlZiB0ZXN0X2dldF9jcmFzaF9s b2coc2VsZik6Ci0gICAgICAgIGlmIG5vdCBzeXMucGxhdGZvcm0uc3RhcnRzd2l0aCgibGludXgi KToKLSAgICAgICAgICAgIHJldHVybgorICAgICAgICBjb3JlX2RpcmVjdG9yeSA9IG9zLmVudmly b24uZ2V0KCdXRUJLSVRfQ09SRV9EVU1QU19ESVJFQ1RPUlknLCAnL3BhdGgvdG8vY29yZWR1bXBz JykKKyAgICAgICAgY29yZV9wYXR0ZXJuID0gb3MucGF0aC5qb2luKGNvcmVfZGlyZWN0b3J5LCAi Y29yZS1waWRfJXAtXy1wcm9jZXNzXyVlIikKKyAgICAgICAgbW9ja19lbXB0eV9jcmFzaF9sb2cg PSAiIiJcCitDcmFzaCBsb2cgZm9yIER1bXBSZW5kZXJUcmVlIChwaWQgMjg1MjkpOgorCitDb3Jl ZHVtcCBjb3JlLXBpZF8yODUyOS1fLXByb2Nlc3NfRHVtcFJlbmRlclRyZWUgbm90IGZvdW5kLiBU byBlbmFibGUgY3Jhc2ggbG9nczoKKworLSBydW4gdGhpcyBjb21tYW5kIGFzIHN1cGVyLXVzZXI6 IGVjaG8gIiUoY29yZV9wYXR0ZXJuKXMiID4gL3Byb2Mvc3lzL2tlcm5lbC9jb3JlX3BhdHRlcm4K Ky0gZW5hYmxlIGNvcmUgZHVtcHM6IHVsaW1pdCAtYyB1bmxpbWl0ZWQKKy0gc2V0IHRoZSBXRUJL SVRfQ09SRV9EVU1QU19ESVJFQ1RPUlkgZW52aXJvbm1lbnQgdmFyaWFibGU6IGV4cG9ydCBXRUJL SVRfQ09SRV9EVU1QU19ESVJFQ1RPUlk9JShjb3JlX2RpcmVjdG9yeSlzCisKKworU1RERVJSOiA8 ZW1wdHk+IiIiICUgbG9jYWxzKCkKKworICAgICAgICBkZWYgX21vY2tfZ2RiX291dHB1dChjb3Jl ZHVtcF9wYXRoKToKKyAgICAgICAgICAgIHJldHVybiAobW9ja19lbXB0eV9jcmFzaF9sb2csIFtd KQorCiAgICAgICAgIHBvcnQgPSBzZWxmLm1ha2VfcG9ydCgpCi0gICAgICAgIHBvcnQuX2dldF9n ZGJfb3V0cHV0ID0gc2VsZi5fbW9ja19nZGJfb3V0cHV0CisgICAgICAgIHBvcnQuX2dldF9nZGJf b3V0cHV0ID0gbW9ja19lbXB0eV9jcmFzaF9sb2cKICAgICAgICAgbG9nID0gcG9ydC5fZ2V0X2Ny YXNoX2xvZygiRHVtcFJlbmRlclRyZWUiLCAyODUyOSwgIiIsICIiKQotICAgICAgICBzZWxmLmFz c2VydExpbmVzRXF1YWwobG9nLCBzZWxmLl9tb2NrX2NyYXNoX2xvZykKKyAgICAgICAgc2VsZi5h c3NlcnRMaW5lc0VxdWFsKGxvZywgbW9ja19lbXB0eV9jcmFzaF9sb2cpCg==