83169 2012-04-04 09:05:12 -0700 Update LayoutUnit usage in RenderInputSpeech::paintInputFieldSpeechButton 2012-04-05 06:33:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 83089 P2 Normal --- 60318 1 leviw leviw dglazkov eae eric jchaffraix webkit.review.bot oldest_to_newest 595588 0 leviw 2012-04-04 09:05:12 -0700 Called from RenderTheme code, and therefor with an IntRect, we need to make sure we handle variables from the render tree properly. 595626 1 135613 leviw 2012-04-04 09:48:36 -0700 Created attachment 135613 Patch Not yet requesting a review since this isn't enabled on Apple's Mac port. I want to see this pass the Chromium EWS bot to ensure the refactoring is correct first. 595702 2 135613 webkit.review.bot 2012-04-04 10:52:41 -0700 Comment on attachment 135613 Patch Attachment 135613 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12320971 595711 3 135628 leviw 2012-04-04 10:59:54 -0700 Created attachment 135628 Patch2 Now with 100% fewer compiler errors? 596526 4 leviw 2012-04-05 06:33:20 -0700 My patch had some refactoring, but the main issue is resolved. *** This bug has been marked as a duplicate of bug 83089 *** 135613 2012-04-04 09:48:36 -0700 2012-04-04 10:59:54 -0700 Patch patch text/plain 3570 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzE5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTA0ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgTGF5b3V0VW5p dCB1c2FnZSBpbiBSZW5kZXJJbnB1dFNwZWVjaDo6cGFpbnRJbnB1dEZpZWxkU3BlZWNoQnV0dG9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE2OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0aW5n IExheW91dFVuaXQgdXNhZ2UgZm9yIHRoZSBmdW5jdGlvbiB0byBwYWludCBpbnB1dCBmaWVsZCBz cGVlY2ggYnV0dG9ucy4gU2luY2UKKyAgICAgICAgdGhpcyBtZXRob2QgaXMgb25seSBjYWxsZWQg ZnJvbSBSZW5kZXJUaGVtZSBjb2RlLCBpdCByZWNlaXZlcyBhbiBJbnRSZWN0LCBhbmQgbmVlZHMK KyAgICAgICAgdG8gZG8gdGhlIHJpZ2h0IHRoaW5nIHRvIGhhbmRsZSBMYXlvdXRVbml0IHZhbHVl cyBmcm9tIHRoZSByZW5kZXIgdHJlZS4KKworICAgICAgICBUaGUgcGFpbnRlZCBzcGVlY2ggYnV0 dG9uIG11c3QgYmUgYSBzcXVhcmUgbm8gbGFyZ2VyIHRoYW4gdGhlIHJlY3QgcGFzc2VkIGluLCBz byB3ZSAKKyAgICAgICAgcGl4ZWwgc25hcCB0aGUgY29udGVudEJveFJlY3QgYmVmb3JlIGNvbXBh cmluZyB3aXRoIHRoZSBwaXhlbCBzbmFwcGVkIHZhbHVlIHBhc3NlZCBpbi4KKyAgICAgICAgQWxz byB0YWtpbmcgdGhlIG9wcG9ydHVuaXR5IHRvIHNpbXBsaWZ5IHRoZSBsb2dpYyBvZiBkZXRlcm1p bmluZyB0aGUgYm94IG9mZnNldC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZSBp biBiZWhhdmlvci4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbnB1dFNwZWVjaC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJbnB1dFNwZWVjaDo6cGFpbnRJbnB1dEZpZWxkU3Bl ZWNoQnV0dG9uKToKKwogMjAxMi0wNC0wNCAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogbGluZWFyaXNlIGFnZ3JlZ2F0ZSdz IHJldGFpbmluZyBzaXplIGNhbGN1bGF0aW9uLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlcklucHV0U3BlZWNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVySW5wdXRTcGVlY2guY3BwCShyZXZpc2lvbiAxMTMxNjEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5wdXRTcGVlY2guY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02NiwyNCArNjYsMTkgQEAgYm9vbCBSZW5kZXJJbnB1dFNwZWVjaDo6cGFpbnRJbnB1dEZp ZWxkUwogICAgIGlmICghaW5wdXQtPnJlbmRlcmVyKCktPmlzQm94KCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKICAgICBSZW5kZXJCb3gqIGlucHV0UmVuZGVyQm94ID0gdG9SZW5kZXJCb3goaW5w dXQtPnJlbmRlcmVyKCkpOwotICAgIEludFJlY3QgaW5wdXRDb250ZW50Qm94ID0gaW5wdXRSZW5k ZXJCb3gtPmNvbnRlbnRCb3hSZWN0KCk7CisgICAgSW50UmVjdCBpbnB1dENvbnRlbnRCb3ggPSBw aXhlbFNuYXBwZWRJbnRSZWN0KGlucHV0UmVuZGVyQm94LT5jb250ZW50Qm94UmVjdCgpKTsKIAog ICAgIC8vIE1ha2Ugc3VyZSB0aGUgc2NhbGVkIGJ1dHRvbiBzdGF5cyBzcXVhcmUgYW5kIHdpbGwg Zml0IGluIGl0cyBwYXJlbnQncyBib3guCiAgICAgaW50IGJ1dHRvblNpemUgPSBzdGQ6Om1pbihp bnB1dENvbnRlbnRCb3gud2lkdGgoKSwgc3RkOjptaW4oaW5wdXRDb250ZW50Qm94LmhlaWdodCgp LCByZWN0LmhlaWdodCgpKSk7CisgICAgCisgICAgSW50UG9pbnQgcGFpbnRPZmZzZXQocmVjdC5s b2NhdGlvbigpLngoKSwgcmVjdC5sb2NhdGlvbigpLnkoKSAtIHJvdW5kVG9JbnQob2JqZWN0LT5v ZmZzZXRGcm9tQW5jZXN0b3JDb250YWluZXIoaW5wdXRSZW5kZXJCb3gpLmhlaWdodCgpKTsKICAg ICAvLyBDYWxjdWxhdGUgYnV0dG9uJ3MgY29vcmRpbmF0ZXMgcmVsYXRpdmUgdG8gdGhlIGlucHV0 IGVsZW1lbnQuCiAgICAgLy8gQ2VudGVyIHRoZSBidXR0b24gdmVydGljYWxseS4gIFJvdW5kIHVw IHRob3VnaCwgc28gaWYgaXQgaGFzIHRvIGJlIG9uZSBwaXhlbCBvZmYtY2VudGVyLCBpdCB3aWxs CiAgICAgLy8gYmUgb25lIHBpeGVsIGNsb3NlciB0byB0aGUgYm90dG9tIG9mIHRoZSBmaWVsZC4g IFRoaXMgdGVuZHMgdG8gbG9vayBiZXR0ZXIgd2l0aCB0aGUgdGV4dC4KLSAgICBJbnRSZWN0IGJ1 dHRvblJlY3Qob2JqZWN0LT5vZmZzZXRGcm9tQW5jZXN0b3JDb250YWluZXIoaW5wdXRSZW5kZXJC b3gpLndpZHRoKCksCi0gICAgICAgICAgICAgICAgICAgICAgIGlucHV0Q29udGVudEJveC55KCkg KyAoaW5wdXRDb250ZW50Qm94LmhlaWdodCgpIC0gYnV0dG9uU2l6ZSArIDEpIC8gMiwKKyAgICBJ bnRSZWN0IGJ1dHRvblJlY3QocGFpbnRPZmZzZXQueCgpLAorICAgICAgICAgICAgICAgICAgICAg ICBwYWludE9mZnNldC55KCkgKyBpbnB1dENvbnRlbnRCb3gueSgpICsgKGlucHV0Q29udGVudEJv eC5oZWlnaHQoKSAtIGJ1dHRvblNpemUgKyAxKSAvIDIsCiAgICAgICAgICAgICAgICAgICAgICAg IGJ1dHRvblNpemUsIGJ1dHRvblNpemUpOwogCi0gICAgLy8gQ29tcHV0ZSBhbiBvZmZzZXQgYmV0 d2VlbiB0aGUgcGFydCByZW5kZXJlciBhbmQgdGhlIGlucHV0IHJlbmRlcmVyLgotICAgIEludFNp emUgb2Zmc2V0RnJvbUlucHV0UmVuZGVyZXIgPSAtKG9iamVjdC0+b2Zmc2V0RnJvbUFuY2VzdG9y Q29udGFpbmVyKGlucHV0UmVuZGVyQm94KSk7Ci0gICAgLy8gTW92ZSB0aGUgcmVjdCBpbnRvIHBh cnRSZW5kZXJlcidzIGNvb3Jkcy4KLSAgICBidXR0b25SZWN0Lm1vdmUob2Zmc2V0RnJvbUlucHV0 UmVuZGVyZXIpOwotICAgIC8vIEFjY291bnQgZm9yIHRoZSBsb2NhbCBkcmF3aW5nIG9mZnNldC4K LSAgICBidXR0b25SZWN0Lm1vdmVCeShyZWN0LmxvY2F0aW9uKCkpOwotCiAgICAgREVGSU5FX1NU QVRJQ19MT0NBTChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlTm9ybWFsLCAoSW1hZ2U6OmxvYWRQ bGF0Zm9ybVJlc291cmNlKCJpbnB1dFNwZWVjaCIpKSk7CiAgICAgREVGSU5FX1NUQVRJQ19MT0NB TChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlUmVjb3JkaW5nLCAoSW1hZ2U6OmxvYWRQbGF0Zm9y bVJlc291cmNlKCJpbnB1dFNwZWVjaFJlY29yZGluZyIpKSk7CiAgICAgREVGSU5FX1NUQVRJQ19M T0NBTChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlV2FpdGluZywgKEltYWdlOjpsb2FkUGxhdGZv cm1SZXNvdXJjZSgiaW5wdXRTcGVlY2hXYWl0aW5nIikpKTsK 135628 2012-04-04 10:59:54 -0700 2012-04-04 10:59:54 -0700 Patch2 patch text/plain 3570 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzE5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTA0ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgTGF5b3V0VW5p dCB1c2FnZSBpbiBSZW5kZXJJbnB1dFNwZWVjaDo6cGFpbnRJbnB1dEZpZWxkU3BlZWNoQnV0dG9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE2OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0aW5n IExheW91dFVuaXQgdXNhZ2UgZm9yIHRoZSBmdW5jdGlvbiB0byBwYWludCBpbnB1dCBmaWVsZCBz cGVlY2ggYnV0dG9ucy4gU2luY2UKKyAgICAgICAgdGhpcyBtZXRob2QgaXMgb25seSBjYWxsZWQg ZnJvbSBSZW5kZXJUaGVtZSBjb2RlLCBpdCByZWNlaXZlcyBhbiBJbnRSZWN0LCBhbmQgbmVlZHMK KyAgICAgICAgdG8gZG8gdGhlIHJpZ2h0IHRoaW5nIHRvIGhhbmRsZSBMYXlvdXRVbml0IHZhbHVl cyBmcm9tIHRoZSByZW5kZXIgdHJlZS4KKworICAgICAgICBUaGUgcGFpbnRlZCBzcGVlY2ggYnV0 dG9uIG11c3QgYmUgYSBzcXVhcmUgbm8gbGFyZ2VyIHRoYW4gdGhlIHJlY3QgcGFzc2VkIGluLCBz byB3ZSAKKyAgICAgICAgcGl4ZWwgc25hcCB0aGUgY29udGVudEJveFJlY3QgYmVmb3JlIGNvbXBh cmluZyB3aXRoIHRoZSBwaXhlbCBzbmFwcGVkIHZhbHVlIHBhc3NlZCBpbi4KKyAgICAgICAgQWxz byB0YWtpbmcgdGhlIG9wcG9ydHVuaXR5IHRvIHNpbXBsaWZ5IHRoZSBsb2dpYyBvZiBkZXRlcm1p bmluZyB0aGUgYm94IG9mZnNldC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZSBp biBiZWhhdmlvci4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbnB1dFNwZWVjaC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJbnB1dFNwZWVjaDo6cGFpbnRJbnB1dEZpZWxkU3Bl ZWNoQnV0dG9uKToKKwogMjAxMi0wNC0wNCAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogbGluZWFyaXNlIGFnZ3JlZ2F0ZSdz IHJldGFpbmluZyBzaXplIGNhbGN1bGF0aW9uLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlcklucHV0U3BlZWNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVySW5wdXRTcGVlY2guY3BwCShyZXZpc2lvbiAxMTMxNjEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5wdXRTcGVlY2guY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02NiwyNCArNjYsMTkgQEAgYm9vbCBSZW5kZXJJbnB1dFNwZWVjaDo6cGFpbnRJbnB1dEZp ZWxkUwogICAgIGlmICghaW5wdXQtPnJlbmRlcmVyKCktPmlzQm94KCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKICAgICBSZW5kZXJCb3gqIGlucHV0UmVuZGVyQm94ID0gdG9SZW5kZXJCb3goaW5w dXQtPnJlbmRlcmVyKCkpOwotICAgIEludFJlY3QgaW5wdXRDb250ZW50Qm94ID0gaW5wdXRSZW5k ZXJCb3gtPmNvbnRlbnRCb3hSZWN0KCk7CisgICAgSW50UmVjdCBpbnB1dENvbnRlbnRCb3ggPSBw aXhlbFNuYXBwZWRJbnRSZWN0KGlucHV0UmVuZGVyQm94LT5jb250ZW50Qm94UmVjdCgpKTsKIAog ICAgIC8vIE1ha2Ugc3VyZSB0aGUgc2NhbGVkIGJ1dHRvbiBzdGF5cyBzcXVhcmUgYW5kIHdpbGwg Zml0IGluIGl0cyBwYXJlbnQncyBib3guCiAgICAgaW50IGJ1dHRvblNpemUgPSBzdGQ6Om1pbihp bnB1dENvbnRlbnRCb3gud2lkdGgoKSwgc3RkOjptaW4oaW5wdXRDb250ZW50Qm94LmhlaWdodCgp LCByZWN0LmhlaWdodCgpKSk7CisgICAgCisgICAgSW50UG9pbnQgcGFpbnRPZmZzZXQocmVjdC5s b2NhdGlvbigpLngoKSwgcmVjdC5sb2NhdGlvbigpLnkoKSAtIHJvdW5kVG9JbnQob2JqZWN0LT5v ZmZzZXRGcm9tQW5jZXN0b3JDb250YWluZXIoaW5wdXRSZW5kZXJCb3gpLmhlaWdodCgpKTsKICAg ICAvLyBDYWxjdWxhdGUgYnV0dG9uJ3MgY29vcmRpbmF0ZXMgcmVsYXRpdmUgdG8gdGhlIGlucHV0 IGVsZW1lbnQuCiAgICAgLy8gQ2VudGVyIHRoZSBidXR0b24gdmVydGljYWxseS4gIFJvdW5kIHVw IHRob3VnaCwgc28gaWYgaXQgaGFzIHRvIGJlIG9uZSBwaXhlbCBvZmYtY2VudGVyLCBpdCB3aWxs CiAgICAgLy8gYmUgb25lIHBpeGVsIGNsb3NlciB0byB0aGUgYm90dG9tIG9mIHRoZSBmaWVsZC4g IFRoaXMgdGVuZHMgdG8gbG9vayBiZXR0ZXIgd2l0aCB0aGUgdGV4dC4KLSAgICBJbnRSZWN0IGJ1 dHRvblJlY3Qob2JqZWN0LT5vZmZzZXRGcm9tQW5jZXN0b3JDb250YWluZXIoaW5wdXRSZW5kZXJC b3gpLndpZHRoKCksCi0gICAgICAgICAgICAgICAgICAgICAgIGlucHV0Q29udGVudEJveC55KCkg KyAoaW5wdXRDb250ZW50Qm94LmhlaWdodCgpIC0gYnV0dG9uU2l6ZSArIDEpIC8gMiwKKyAgICBJ bnRSZWN0IGJ1dHRvblJlY3QocGFpbnRPZmZzZXQueCgpLAorICAgICAgICAgICAgICAgICAgICAg ICBwYWludE9mZnNldC55KCkgKyBpbnB1dENvbnRlbnRCb3gueSgpICsgKGlucHV0Q29udGVudEJv eC5oZWlnaHQoKSAtIGJ1dHRvblNpemUgKyAxKSAvIDIsCiAgICAgICAgICAgICAgICAgICAgICAg IGJ1dHRvblNpemUsIGJ1dHRvblNpemUpOwogCi0gICAgLy8gQ29tcHV0ZSBhbiBvZmZzZXQgYmV0 d2VlbiB0aGUgcGFydCByZW5kZXJlciBhbmQgdGhlIGlucHV0IHJlbmRlcmVyLgotICAgIEludFNp emUgb2Zmc2V0RnJvbUlucHV0UmVuZGVyZXIgPSAtKG9iamVjdC0+b2Zmc2V0RnJvbUFuY2VzdG9y Q29udGFpbmVyKGlucHV0UmVuZGVyQm94KSk7Ci0gICAgLy8gTW92ZSB0aGUgcmVjdCBpbnRvIHBh cnRSZW5kZXJlcidzIGNvb3Jkcy4KLSAgICBidXR0b25SZWN0Lm1vdmUob2Zmc2V0RnJvbUlucHV0 UmVuZGVyZXIpOwotICAgIC8vIEFjY291bnQgZm9yIHRoZSBsb2NhbCBkcmF3aW5nIG9mZnNldC4K LSAgICBidXR0b25SZWN0Lm1vdmVCeShyZWN0LmxvY2F0aW9uKCkpOwotCiAgICAgREVGSU5FX1NU QVRJQ19MT0NBTChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlTm9ybWFsLCAoSW1hZ2U6OmxvYWRQ bGF0Zm9ybVJlc291cmNlKCJpbnB1dFNwZWVjaCIpKSk7CiAgICAgREVGSU5FX1NUQVRJQ19MT0NB TChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlUmVjb3JkaW5nLCAoSW1hZ2U6OmxvYWRQbGF0Zm9y bVJlc291cmNlKCJpbnB1dFNwZWVjaFJlY29yZGluZyIpKSk7CiAgICAgREVGSU5FX1NUQVRJQ19M T0NBTChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlV2FpdGluZywgKEltYWdlOjpsb2FkUGxhdGZv cm1SZXNvdXJjZSgiaW5wdXRTcGVlY2hXYWl0aW5nIikpKTsK