83166 2012-04-04 08:13:36 -0700 Adjust max bisection search iterations for TouchpadFlingGestureCurve. 2012-04-05 06:49:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wjmaclean wjmaclean jamesr nduca webkit.review.bot oldest_to_newest 595547 0 wjmaclean 2012-04-04 08:13:36 -0700 Adjust max bisection search iterations for TouchpadFlingGestureCurve. 595549 1 135596 wjmaclean 2012-04-04 08:14:52 -0700 Created attachment 135596 Patch 595552 2 wjmaclean 2012-04-04 08:16:39 -0700 Apologies for the second patch, but I was wondering if we should do something special to handle any case where max iterations is hit. Log it? Use an ASSERT? We could add that to this patch if it's appropriate. 595623 3 wjmaclean 2012-04-04 09:44:06 -0700 (In reply to comment #2) > Apologies for the second patch, but I was wondering if we should do something special to handle any case where max iterations is hit. Log it? Use an ASSERT? We could add that to this patch if it's appropriate. Just to add some data ... I've run informal tests, and found we routinely get to 17 iterations, although I've never seen higher than that. But in theory it could go at least a little higher. 595840 4 jamesr 2012-04-04 13:16:27 -0700 Is there anything special we should do if it doesn't converge? I would say just take whatever value we get. 596510 5 wjmaclean 2012-04-05 05:42:25 -0700 (In reply to comment #4) > Is there anything special we should do if it doesn't converge? I would say just take whatever value we get. That's probably the best we can hope for. Even if it wasn't fully convereged, it ought to be very close I would think. We'll leave it as is then. 596532 6 135596 webkit.review.bot 2012-04-05 06:49:28 -0700 Comment on attachment 135596 Patch Clearing flags on attachment: 135596 Committed r113319: <http://trac.webkit.org/changeset/113319> 596533 7 webkit.review.bot 2012-04-05 06:49:33 -0700 All reviewed patches have been landed. Closing bug. 135596 2012-04-04 08:14:52 -0700 2012-04-05 06:49:28 -0700 Patch bug-83166-20120404111450.patch text/plain 1660 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThmZTU0ZGU4MDMzM2Zk MzVjNjZiMGI5NjU4NDEyOGRkYTU3ZDhlYS4uODIxMDc5NTJhNWJhZjYzMzAyNTdhMjRlZTI3NTA4 MmE5ZTQ3MDRjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTA0ICBXLiBK YW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGp1c3Qg bWF4IGJpc2VjdGlvbiBzZWFyY2ggaXRlcmF0aW9ucyBmb3IgVG91Y2hwYWRGbGluZ0dlc3R1cmVD dXJ2ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgz MTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292 ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL1RvdWNocGFkRmxp bmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0w NC0wNCAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IG1ha2UgcGFkZGluZyBhbmQgY2xpZW50IHdpbmRvdyB3aWR0aCBwYXJ0IG9m IHRpbWVsaW5lIGNhbGN1bGF0b3IncyBzdGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vVG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1RvdWNocGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5jcHAKaW5k ZXggYTU4YmFkOTY0NjAzMzJlYjUzYzQ1NzI2MTkxZThmM2E1YTAxN2Y3NC4uNWY5YmFjZGEyZmMw MWQyNzI1ZDE5ODRjZTFkNzZjODJlMWVmMjZmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vVG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9Ub3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUuY3Bw CkBAIC01MSw3ICs1MSw3IEBAIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAvLyBUaGUgY3VydmUgaXMg bW9kZWxsZWQgYXMgYSA0dGggb3JkZXIgcG9seW5vbWlhbCwgc3RhcnRpbmcgYXQgdCA9IDAsIGFu ZCBlbmRpbmcgYXQgdCA9IG1fY3VydmVEdXJhdGlvbi4KIC8vIEF0dGVtcHRzIHRvIGdlbmVyYXRl IHBvc2l0aW9uL3ZlbG9jaXR5IGVzdGltYXRlcyBvdXRzaWRlIHRoaXMgcmFuZ2UgYXJlIHVuZGVm aW5lZC4KIAotY29uc3QgaW50IFRvdWNocGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZTo6bV9t YXhTZWFyY2hJdGVyYXRpb25zID0gNDA7Citjb25zdCBpbnQgVG91Y2hwYWRGbGluZ1BsYXRmb3Jt R2VzdHVyZUN1cnZlOjptX21heFNlYXJjaEl0ZXJhdGlvbnMgPSAyMDsKIAogUGFzc093blB0cjxQ bGF0Zm9ybUdlc3R1cmVDdXJ2ZT4gVG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjpj cmVhdGUoY29uc3QgRmxvYXRQb2ludCYgdmVsb2NpdHksIEludFBvaW50IGN1bXVsYXRpdmVTY3Jv bGwpCiB7Cg==