83159 2012-04-04 07:18:42 -0700 [chromium] Only shut down V8 if we actually initialized it 2012-04-05 01:53:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth adamk dglazkov fishd jamesr rafaelw tkent webkit.review.bot yurys oldest_to_newest 595516 0 jochen 2012-04-04 07:18:42 -0700 [chromium] Only shut down V8 if we actually initialized it 595517 1 135585 jochen 2012-04-04 07:19:25 -0700 Created attachment 135585 Patch 595526 2 135585 yurys 2012-04-04 07:40:12 -0700 Comment on attachment 135585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135585&action=review > Source/WebKit/chromium/src/WebKit.cpp:82 > +static bool s_V8Initialized = false; Pleas guard it with #ifndef NDEBUG 595531 3 135589 jochen 2012-04-04 07:57:45 -0700 Created attachment 135589 Patch 595534 4 webkit.review.bot 2012-04-04 07:59:17 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 595535 5 jochen 2012-04-04 07:59:54 -0700 (In reply to comment #2) > (From update of attachment 135585 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135585&action=review > > > Source/WebKit/chromium/src/WebKit.cpp:82 > > +static bool s_V8Initialized = false; > > Pleas guard it with #ifndef NDEBUG Pavel suggested to introduce shutdownWithoutV8 as a counterpart to initializeWithoutV8 instead 595830 6 fishd 2012-04-04 13:09:24 -0700 Hmm... I think the first patch might be nicer because it is less error prone. Embedders will not need to keep track of how they initialized WebKit. I'd probably modify the first patch to name the static variable more specifically, like: "s_addedV8CallCompletedCallback" 595834 7 fishd 2012-04-04 13:12:46 -0700 It also seems like we could more tightly couple the call to AddCallCompletedCallback with the existence of s_endOfTaskRunner. Then, we could just have WebKit::shutdown() null-test s_endOfTaskRunner to determine if it should call RemoveCallCompletedCallback. They really do go hand-in-hand. 596363 8 135770 jochen 2012-04-05 00:48:24 -0700 Created attachment 135770 Patch 596368 9 135770 pfeldman 2012-04-05 00:52:29 -0700 Comment on attachment 135770 Patch Rubber stamping since I think you've done what Darin was suggesting. 596405 10 135770 webkit.review.bot 2012-04-05 01:53:20 -0700 Comment on attachment 135770 Patch Clearing flags on attachment: 135770 Committed r113301: <http://trac.webkit.org/changeset/113301> 596406 11 webkit.review.bot 2012-04-05 01:53:26 -0700 All reviewed patches have been landed. Closing bug. 135585 2012-04-04 07:19:25 -0700 2012-04-04 07:57:40 -0700 Patch bug-83159-20120404161923.patch text/plain 1989 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI4MWY4ODcyY2ZmMDJjMjljOGQ1ZmFkZGFiNDY0ZmYxNjE0ZjdkZjAuLmFkOTg4NTExZDRjYmE3 ZGRmM2Q2YTdlNmZkMDRlNjU5MGVkNDk3OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDQtMDQgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBPbmx5IHNodXQgZG93biBWOCBpZiB3ZSBh Y3R1YWxseSBpbml0aWFsaXplZCBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODMxNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHNyYy9XZWJLaXQuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFs aXplKToKKyAgICAgICAgKFdlYktpdDo6c2h1dGRvd24pOgorCiAyMDEyLTA0LTA0ICBIYW5zIFdl bm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU3BlZWNoUmVjb2duaXpl ci5oOiBhZGQgbWlzc2luZyBmb3J3YXJkIGRlY2xhcmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViS2l0LmNwcAppbmRleCAxZDhhZTkxZjk3NmFmNDc1OTAyZTlmZmFjM2Y2MGEyM2U4OTkw NDk3Li4xN2JiNzNmZjA3YWY2MmFmNmFjMDcxMTU4Zjc3ZGVmMmRmYTQ4ZDcwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKQEAgLTc4LDYgKzc4LDkgQEAgc3RhdGljIFdlYlRo cmVhZDo6VGFza09ic2VydmVyKiBzX2VuZE9mVGFza1J1bm5lciA9IDA7CiAvLyBEb2luZyBzbyBt YXkgY2F1c2UgaGFyZCB0byByZXByb2R1Y2UgY3Jhc2hlcy4KIHN0YXRpYyBib29sIHNfd2ViS2l0 SW5pdGlhbGl6ZWQgPSBmYWxzZTsKIAorLy8gTWFrZSBzdXJlIHdlIG9ubHkgc2h1dCBkb3duIFY4 IHdoZW4gd2UgYWN0dWFsbHkgaW5pdGlhbGl6ZWQgaXQuCitzdGF0aWMgYm9vbCBzX1Y4SW5pdGlh bGl6ZWQgPSBmYWxzZTsKKwogc3RhdGljIFdlYktpdFBsYXRmb3JtU3VwcG9ydCogc193ZWJLaXRQ bGF0Zm9ybVN1cHBvcnQgPSAwOwogc3RhdGljIGJvb2wgc19sYXlvdXRUZXN0TW9kZSA9IGZhbHNl OwogCkBAIC0xMDIsNiArMTA1LDcgQEAgdm9pZCBpbml0aWFsaXplKFdlYktpdFBsYXRmb3JtU3Vw cG9ydCogd2ViS2l0UGxhdGZvcm1TdXBwb3J0KQogewogICAgIGluaXRpYWxpemVXaXRob3V0Vjgo d2ViS2l0UGxhdGZvcm1TdXBwb3J0KTsKIAorICAgIHNfVjhJbml0aWFsaXplZCA9IHRydWU7CiAg ICAgdjg6OlY4OjpTZXRFbnRyb3B5U291cmNlKCZnZW5lcmF0ZUVudHJvcHkpOwogICAgIHY4OjpW ODo6SW5pdGlhbGl6ZSgpOwogICAgIFdlYkNvcmU6OlY4QmluZGluZ1Blcklzb2xhdGVEYXRhOjpl bnN1cmVJbml0aWFsaXplZCh2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKQEAgLTE1Myw3ICsx NTcsOCBAQCB2b2lkIHNodXRkb3duKCkKIHsKICNpZiBFTkFCTEUoTVVUQVRJT05fT0JTRVJWRVJT KQogI2lmbmRlZiBOREVCVUcKLSAgICB2ODo6Vjg6OlJlbW92ZUNhbGxDb21wbGV0ZWRDYWxsYmFj aygmYXNzZXJ0VjhSZWN1cnNpb25TY29wZSk7CisgICAgaWYgKHNfVjhJbml0aWFsaXplZCkKKyAg ICAgICAgdjg6OlY4OjpSZW1vdmVDYWxsQ29tcGxldGVkQ2FsbGJhY2soJmFzc2VydFY4UmVjdXJz aW9uU2NvcGUpOwogI2VuZGlmCiAKICAgICBpZiAoc19lbmRPZlRhc2tSdW5uZXIpIHsK 135589 2012-04-04 07:57:45 -0700 2012-04-05 00:48:16 -0700 Patch bug-83159-20120404165743.patch text/plain 2365 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI4MWY4ODcyY2ZmMDJjMjljOGQ1ZmFkZGFiNDY0ZmYxNjE0ZjdkZjAuLjNjNjg5MDhlYzY1NTlm OGJhNGViZjk3NTM4NjYwN2NlMmQxNWZjY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDQtMDQgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBJbnRyb2R1Y2UgV2ViS2l0OjpzaHV0ZG93 bldpdGhvdXRWOCBhcyBjb3VudGVyLXBhcnQgdG8gV2ViS2l0Ojppbml0aWFsaXplV2l0aG91dFY4 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE1OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGlj L1dlYktpdC5oOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViS2l0LmNwcDoK KyAgICAgICAgKFdlYktpdDo6c2h1dGRvd24pOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAg KFdlYktpdDo6c2h1dGRvd25XaXRob3V0VjgpOgorCiAyMDEyLTA0LTA0ICBIYW5zIFdlbm5ib3Jn ICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU3BlZWNoUmVjb2duaXplci5oOiBh ZGQgbWlzc2luZyBmb3J3YXJkIGRlY2xhcmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYktpdC5oCmluZGV4IGE4OWQ0Nzg1ZjUzOGEyZGYzN2UwN2RjZGE3ZTc4MzNlM2JmNzA5ZGEu LmI0NjdkZjIzYjIxMjg4ZmRmNTNiNzVjM2Y3MjM4M2QyZTQ5MmM0ZmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYktpdC5oCkBAIC01Nyw2ICs1NywxNSBAQCBXRUJLSVRfRVhQT1JU IHZvaWQgaW5pdGlhbGl6ZVdpdGhvdXRWOChXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqKTsKIC8vIHRl cm1pbmF0ZWQgYnkgdGhlIHRpbWUgdGhpcyBmdW5jdGlvbiByZXR1cm5zLgogV0VCS0lUX0VYUE9S VCB2b2lkIHNodXRkb3duKCk7CiAKKy8vIE9uY2Ugc2h1dGRvd24sIHRoZSBXZWJLaXRQbGF0Zm9y bVN1cHBvcnQgcGFzc2VkIHRvIGluaXRpYWxpemUgd2lsbCBubyBsb25nZXIKKy8vIGJlIGFjY2Vz c2VkLiBObyBvdGhlciBXZWJLaXQgb2JqZWN0cyBzaG91bGQgYmUgaW4gdXNlIHdoZW4gdGhpcyBm dW5jdGlvbiBpcworLy8gY2FsbGVkLiBBbnkgYmFja2dyb3VuZCB0aHJlYWRzIGNyZWF0ZWQgYnkg V2ViS2l0IGFyZSBwcm9taXNlZCB0byBiZQorLy8gdGVybWluYXRlZCBieSB0aGUgdGltZSB0aGlz IGZ1bmN0aW9uIHJldHVybnMuCisvLworLy8gVGhpcyBpcyBhIHNwZWNpYWwgdmFyaWVudCBvZiBz aHV0ZG93biB0aGF0IGRvZXMgbm90IHNodXRkb3duIFY4LiBJdCBtdXN0IGJlCisvLyB1c2VkLCBp ZiBpbml0aWFsaXplV2l0aG91dFY4IHdhcyB1c2VkIHRvIGluaXRpYWxpemUgV2ViS2l0LgorV0VC S0lUX0VYUE9SVCB2b2lkIHNodXRkb3duV2l0aG91dFY4KCk7CisKIC8vIFJldHVybnMgdGhlIFdl YktpdFBsYXRmb3JtU3VwcG9ydCBpbnN0YW5jZSBwYXNzZWQgdG8gaW5pdGlhbGl6ZS4KIFdFQktJ VF9FWFBPUlQgV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKaW5kZXggMWQ4YWU5MWY5NzZhZjQ3 NTkwMmU5ZmZhYzNmNjBhMjNlODk5MDQ5Ny4uZTY1ZWU5ZWZmY2JhY2NhOTlmYjEwNjhhNzY3YTgz Njk3NGE3MDYwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCkBAIC0xNjMs NiArMTYzLDExIEBAIHZvaWQgc2h1dGRvd24oKQogICAgICAgICBzX2VuZE9mVGFza1J1bm5lciA9 IDA7CiAgICAgfQogI2VuZGlmCisgICAgc2h1dGRvd25XaXRob3V0VjgoKTsKK30KKwordm9pZCBz aHV0ZG93bldpdGhvdXRWOCgpCit7CiAgICAgc193ZWJLaXRQbGF0Zm9ybVN1cHBvcnQgPSAwOwog ICAgIFBsYXRmb3JtOjpzaHV0ZG93bigpOwogCg== 135770 2012-04-05 00:48:24 -0700 2012-04-05 01:53:20 -0700 Patch bug-83159-20120405094822.patch text/plain 2412 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI4MWY4ODcyY2ZmMDJjMjljOGQ1ZmFkZGFiNDY0ZmYxNjE0ZjdkZjAuLjY0YTI1Nzg0YWFhNzEy MGE0NThlZDY0NjhkNDRmNGFjNGM5Zjk3MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDQtMDUgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBPbmx5IHNodXQgZG93biBWOCBpZiB3ZSBh Y3R1YWxseSBpbml0aWFsaXplZCBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODMxNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHNyYy9XZWJLaXQuY3BwOgorICAgICAgICAoV2ViS2l0Ojppbml0aWFs aXplKToKKyAgICAgICAgKFdlYktpdDo6c2h1dGRvd24pOgorCiAyMDEyLTA0LTA0ICBIYW5zIFdl bm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU3BlZWNoUmVjb2duaXpl ci5oOiBhZGQgbWlzc2luZyBmb3J3YXJkIGRlY2xhcmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViS2l0LmNwcAppbmRleCAxZDhhZTkxZjk3NmFmNDc1OTAyZTlmZmFjM2Y2MGEyM2U4OTkw NDk3Li5lOTczZDZkMjQ0NDAyNGUwZTI4MjU0MDQ1MWU2MDIzZDljNDU4NDlkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKQEAgLTEwNywxMiArMTA3LDExIEBAIHZvaWQgaW5p dGlhbGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqIHdlYktpdFBsYXRmb3JtU3VwcG9ydCkKICAg ICBXZWJDb3JlOjpWOEJpbmRpbmdQZXJJc29sYXRlRGF0YTo6ZW5zdXJlSW5pdGlhbGl6ZWQodjg6 Oklzb2xhdGU6OkdldEN1cnJlbnQoKSk7CiAKICNpZiBFTkFCTEUoTVVUQVRJT05fT0JTRVJWRVJT KQotI2lmbmRlZiBOREVCVUcKLSAgICB2ODo6Vjg6OkFkZENhbGxDb21wbGV0ZWRDYWxsYmFjaygm YXNzZXJ0VjhSZWN1cnNpb25TY29wZSk7Ci0jZW5kaWYKLQogICAgIC8vIGN1cnJlbnRUaHJlYWQg d2lsbCBhbHdheXMgYmUgbm9uLW51bGwgaW4gcHJvZHVjdGlvbiwgYnV0IGNhbiBiZSBudWxsIGlu IENocm9taXVtIHVuaXQgdGVzdHMuCiAgICAgaWYgKFdlYlRocmVhZCogY3VycmVudFRocmVhZCA9 IHdlYktpdFBsYXRmb3JtU3VwcG9ydC0+Y3VycmVudFRocmVhZCgpKSB7CisjaWZuZGVmIE5ERUJV RworICAgICAgICB2ODo6Vjg6OkFkZENhbGxDb21wbGV0ZWRDYWxsYmFjaygmYXNzZXJ0VjhSZWN1 cnNpb25TY29wZSk7CisjZW5kaWYKICAgICAgICAgQVNTRVJUKCFzX2VuZE9mVGFza1J1bm5lcik7 CiAgICAgICAgIHNfZW5kT2ZUYXNrUnVubmVyID0gbmV3IEVuZE9mVGFza1J1bm5lcjsKICAgICAg ICAgY3VycmVudFRocmVhZC0+YWRkVGFza09ic2VydmVyKHNfZW5kT2ZUYXNrUnVubmVyKTsKQEAg LTE1MSwxMiArMTUwLDEzIEBAIHZvaWQgaW5pdGlhbGl6ZVdpdGhvdXRWOChXZWJLaXRQbGF0Zm9y bVN1cHBvcnQqIHdlYktpdFBsYXRmb3JtU3VwcG9ydCkKIAogdm9pZCBzaHV0ZG93bigpCiB7Cisg ICAgLy8gV2ViS2l0IG1pZ2h0IGhhdmUgYmVlbiBpbml0aWFsaXplZCB3aXRob3V0IFY4LCBzbyBi ZSBjYXJlZnVsIG5vdCB0byBpbnZva2UKKyAgICAvLyBWOCBzcGVjaWZpYyBmdW5jdGlvbnMsIGlm IFY4IHdhcyBub3QgcHJvcGVybHkgaW5pdGlhbGl6ZWQuCiAjaWYgRU5BQkxFKE1VVEFUSU9OX09C U0VSVkVSUykKKyAgICBpZiAoc19lbmRPZlRhc2tSdW5uZXIpIHsKICNpZm5kZWYgTkRFQlVHCi0g ICAgdjg6OlY4OjpSZW1vdmVDYWxsQ29tcGxldGVkQ2FsbGJhY2soJmFzc2VydFY4UmVjdXJzaW9u U2NvcGUpOworICAgICAgICB2ODo6Vjg6OlJlbW92ZUNhbGxDb21wbGV0ZWRDYWxsYmFjaygmYXNz ZXJ0VjhSZWN1cnNpb25TY29wZSk7CiAjZW5kaWYKLQotICAgIGlmIChzX2VuZE9mVGFza1J1bm5l cikgewogICAgICAgICBBU1NFUlQoc193ZWJLaXRQbGF0Zm9ybVN1cHBvcnQtPmN1cnJlbnRUaHJl YWQoKSk7CiAgICAgICAgIHNfd2ViS2l0UGxhdGZvcm1TdXBwb3J0LT5jdXJyZW50VGhyZWFkKCkt PnJlbW92ZVRhc2tPYnNlcnZlcihzX2VuZE9mVGFza1J1bm5lcik7CiAgICAgICAgIGRlbGV0ZSBz X2VuZE9mVGFza1J1bm5lcjsK