83158 2012-04-04 06:46:30 -0700 [Qt] Entire page highlighted on panning. 2012-04-04 08:52:31 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 595496 0 allan.jensen 2012-04-04 06:46:30 -0700 On some pages the entire page is highlighted when panning. This is partially solved with the fix for bug #83153, but many pages still have global event listeners making which node to highlight tricky. I will go with a solution of highlighting either links or focusable elements, OR the nearest enclosing inline element. This avoids highlighting blocks unless they are a link, form or otherwise supports focus. 595503 1 135584 allan.jensen 2012-04-04 06:53:07 -0700 Created attachment 135584 Patch 595575 2 135584 webkit.review.bot 2012-04-04 08:52:27 -0700 Comment on attachment 135584 Patch Clearing flags on attachment: 135584 Committed r113195: <http://trac.webkit.org/changeset/113195> 595576 3 webkit.review.bot 2012-04-04 08:52:31 -0700 All reviewed patches have been landed. Closing bug. 135584 2012-04-04 06:53:07 -0700 2012-04-04 08:52:27 -0700 Patch bug-83158-20120404155328.patch text/plain 2889 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTQ3YzEwZjRjMzUxMWNl NmYxNzNjYzRiN2Q3MTYzZjFlOTE3MjY3My4uZWFiNmEwNDkxMGU4MTljNjk4YTBjMTFiMThkOGU3 NTUwMmJhOGZlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEyLTA0LTA0ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCisgICAgICAgIFtR dF0gRW50aXJlIHBhZ2UgaGlnaGxpZ2h0ZWQgb24gcGFubmluZy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMTU4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmhpZ2hsaWdodFBvdGVudGlhbEFjdGl2 YXRpb24pOgorCisyMDEyLTA0LTA0ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5z ZW5Abm9raWEuY29tPgorCiAgICAgICAgIFtRdF0gVW5hYmxlIHRvIHpvb20gdG8gc29tZSBhcmVh cy4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMTQ0 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRl eCBiMmM2YzNhYmU5YWVjMGFmODllMjA1MDkxMWUyYThjZWE4MzA0Y2MxLi5jODE5OTc0NzUzZGI5 NWJiMDE5NWNhNDQ4MmU4MzZkOGE3YTliYjU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0xNDU1LDE5ICsxNDU1LDI1IEBAIHZvaWQgV2Vi UGFnZTo6aGlnaGxpZ2h0UG90ZW50aWFsQWN0aXZhdGlvbihjb25zdCBJbnRQb2ludCYgcG9pbnQs IGNvbnN0IEludFNpemUmCiAgICAgSW50UG9pbnQgYWRqdXN0ZWRQb2ludDsKIAogICAgIGlmIChw b2ludCAhPSBJbnRQb2ludDo6emVybygpKSB7CisgICAgICAgIE5vZGUqIGFkanVzdGVkTm9kZSA9 IDA7CiAjaWYgRU5BQkxFKFRPVUNIX0FESlVTVE1FTlQpCi0gICAgICAgIG1haW5mcmFtZS0+ZXZl bnRIYW5kbGVyKCktPmJlc3RDbGlja2FibGVOb2RlRm9yVG91Y2hQb2ludChwb2ludCwgSW50U2l6 ZShhcmVhLndpZHRoKCkgLyAyLCBhcmVhLmhlaWdodCgpIC8gMiksIGFkanVzdGVkUG9pbnQsIGFj dGl2YXRpb25Ob2RlKTsKKyAgICAgICAgbWFpbmZyYW1lLT5ldmVudEhhbmRsZXIoKS0+YmVzdENs aWNrYWJsZU5vZGVGb3JUb3VjaFBvaW50KHBvaW50LCBJbnRTaXplKGFyZWEud2lkdGgoKSAvIDIs IGFyZWEuaGVpZ2h0KCkgLyAyKSwgYWRqdXN0ZWRQb2ludCwgYWRqdXN0ZWROb2RlKTsKICNlbHNl CiAgICAgICAgIEhpdFRlc3RSZXN1bHQgcmVzdWx0ID0gbWFpbmZyYW1lLT5ldmVudEhhbmRsZXIo KS0+aGl0VGVzdFJlc3VsdEF0UG9pbnQobWFpbmZyYW1lLT52aWV3KCktPndpbmRvd1RvQ29udGVu dHMocG9pbnQpLCAvKmFsbG93U2hhZG93Q29udGVudCovIGZhbHNlLCAvKmlnbm9yZUNsaXBwaW5n Ki8gdHJ1ZSk7Ci0gICAgICAgIGFjdGl2YXRpb25Ob2RlID0gcmVzdWx0LmlubmVyTm9kZSgpOwot I2VuZGlmCi0gICAgICAgIGlmIChhY3RpdmF0aW9uTm9kZSAmJiAhYWN0aXZhdGlvbk5vZGUtPmlz Rm9jdXNhYmxlKCkpIHsKLSAgICAgICAgICAgIGZvciAoTm9kZSogbm9kZSA9IGFjdGl2YXRpb25O b2RlOyBub2RlOyBub2RlID0gbm9kZS0+cGFyZW50T3JIb3N0Tm9kZSgpKSB7Ci0gICAgICAgICAg ICAgICAgaWYgKG5vZGUtPmlzRm9jdXNhYmxlKCkpIHsKLSAgICAgICAgICAgICAgICAgICAgYWN0 aXZhdGlvbk5vZGUgPSBub2RlOwotICAgICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAg ICAgICAgICB9CisgICAgICAgIGFkanVzdGVkTm9kZSA9IHJlc3VsdC5pbm5lck5vZGUoKTsKKyNl bmRpZgorICAgICAgICAvLyBGaW5kIHRoZSBub2RlIHRvIGhpZ2hsaWdodC4gVGhpcyBpcyBub3Qg dGhlIHNhbWUgYXMgdGhlIG5vZGUgcmVzcG9uZGluZyB0aGUgdGFwIGdlc3R1cmUsIGJlY2F1c2Ug bWFueQorICAgICAgICAvLyBwYWdlcyBoYXMgYSBnbG9iYWwgY2xpY2sgaGFuZGxlciBhbmQgd2Ug ZG8gbm90IHdhbnQgdG8gaGlnaGxpZ2h0IHRoZSBib2R5LgorICAgICAgICAvLyBJbnN0ZWFkIGZp bmQgdGhlIGVuY2xvc2luZyBsaW5rIG9yIGZvY3VzYWJsZSBlbGVtZW50LCBvciB0aGUgbGFzdCBl bmNsb3NpbmcgaW5saW5lIGVsZW1lbnQuCisgICAgICAgIGZvciAoTm9kZSogbm9kZSA9IGFkanVz dGVkTm9kZTsgbm9kZTsgbm9kZSA9IG5vZGUtPnBhcmVudE9ySG9zdE5vZGUoKSkgeworICAgICAg ICAgICAgaWYgKG5vZGUtPmlzTW91c2VGb2N1c2FibGUoKSB8fCBub2RlLT5pc0xpbmsoKSkgewor ICAgICAgICAgICAgICAgIGFjdGl2YXRpb25Ob2RlID0gbm9kZTsKKyAgICAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGlmIChub2RlLT5yZW5kZXJlcigpICYm IG5vZGUtPnJlbmRlcmVyKCktPmlzSW5saW5lKCkpCisgICAgICAgICAgICAgICAgYWN0aXZhdGlv bk5vZGUgPSBub2RlOworICAgICAgICAgICAgZWxzZSBpZiAoYWN0aXZhdGlvbk5vZGUpCisgICAg ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICB9CiAK