83153 2012-04-04 06:13:10 -0700 Best clickable node might return non "clickable" node. 2012-04-04 08:42:22 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen webkit-unassigned webkit.review.bot oldest_to_newest 595472 0 allan.jensen 2012-04-04 06:13:10 -0700 EventHandler::bestClickableNodeForTouchPoint has a fallback of returning the innerNode of the hittest if no node responding to gesture tap events is found. The reason was a originally a safety mechanism in-case any elements were missed so they at least still could be clicked if hit accurately. With proper detection this fallback is unnecessary and confusing. 595475 1 135573 allan.jensen 2012-04-04 06:15:43 -0700 Created attachment 135573 Patch 595567 2 135573 webkit.review.bot 2012-04-04 08:42:18 -0700 Comment on attachment 135573 Patch Clearing flags on attachment: 135573 Committed r113193: <http://trac.webkit.org/changeset/113193> 595568 3 webkit.review.bot 2012-04-04 08:42:22 -0700 All reviewed patches have been landed. Closing bug. 135573 2012-04-04 06:15:43 -0700 2012-04-04 08:42:18 -0700 Patch Patch text/plain 4244 allan.jensen ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZjQzODgwLi5iN2QzNTc0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTItMDQt MDQgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKKyAg ICAgICAgQmVzdCBjbGlja2FibGUgbm9kZSBtaWdodCByZXR1cm4gbm9uICJjbGlja2FibGUiIG5v ZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE1 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdG91 Y2hhZGp1c3RtZW50L3RvdWNoLWlubGluZXMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHRvdWNo YWRqdXN0bWVudC90b3VjaC1pbmxpbmVzLmh0bWw6CisKKzIwMTItMDQtMDQgIEFsbGFuIFNhbmRm ZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CisKICAgICAgICAgQmVzdCB6b29t YWJsZSBhcmVhIGRvZXMgbm90IGJhbGFuY2UgaW50ZXJzZWN0aW9uIHdpdGggdGFyZ2V0IGFyZWEu CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE0OAog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90b3VjaGFkanVzdG1lbnQvdG91Y2gtaW5saW5lcy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy90b3VjaGFkanVzdG1lbnQvdG91Y2gtaW5saW5lcy1l eHBlY3RlZC50eHQKaW5kZXggOTc0YWQ4Mi4uNjNmZDRmMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvdG91Y2hhZGp1c3RtZW50L3RvdWNoLWlubGluZXMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL3RvdWNoYWRqdXN0bWVudC90b3VjaC1pbmxpbmVzLWV4cGVjdGVkLnR4dApAQCAtMTUs OCArMTUsOCBAQCBQQVNTIGFkanVzdGVkTm9kZS5pZCBpcyAiMiIKIFBBU1MgYWRqdXN0ZWROb2Rl LmlkIGlzICI0IgogUEFTUyBhZGp1c3RlZE5vZGUuaWQgaXMgIjYiCiBUZXN0IGEgZmV3IGRpcmVj dCBtaXNzZXMuCi1QQVNTIGFkanVzdGVkTm9kZS5pZCBpcyAiIgotUEFTUyBhZGp1c3RlZE5vZGUu aWQgaXMgIiIKK1BBU1MgYWRqdXN0ZWROb2RlIGlzIG51bGwKK1BBU1MgYWRqdXN0ZWROb2RlIGlz IG51bGwKIFRlc3Qgc29tZSBpbi1kaXJlY3QgaGl0cy4KIFBBU1MgYWRqdXN0ZWROb2RlLmlkIGlz ICIyIgogUEFTUyBhZGp1c3RlZE5vZGUuaWQgaXMgIjMiCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy90b3VjaGFkanVzdG1lbnQvdG91Y2gtaW5saW5lcy5odG1sIGIvTGF5b3V0VGVzdHMvdG91Y2hh ZGp1c3RtZW50L3RvdWNoLWlubGluZXMuaHRtbAppbmRleCBlOTk4MDRiLi5iZmIyMmU3IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy90b3VjaGFkanVzdG1lbnQvdG91Y2gtaW5saW5lcy5odG1sCisr KyBiL0xheW91dFRlc3RzL3RvdWNoYWRqdXN0bWVudC90b3VjaC1pbmxpbmVzLmh0bWwKQEAgLTI2 LDcgKzI2LDcgQEAgaGkgdGhlcmUgPGEgaWQ9IjYiIGhyZWY9IiM2Ij5zb21lIGxpbmsgdGhhdCBp cyBicmVha2luZyBtdWx0aXBsZSBsaW5lcyBqdXN0IGZvcgogICAgICAgICB2YXIgd2lkdGggPSBy YWRpdXMgKiAyOwogICAgICAgICB2YXIgaGVpZ2h0ID0gcmFkaXVzICogMjsKICAgICAgICAgdmFy IGFkanVzdGVkTm9kZSA9IGludGVybmFscy50b3VjaE5vZGVBZGp1c3RlZFRvQmVzdENsaWNrYWJs ZU5vZGUoeCwgeSwgd2lkdGgsIGhlaWdodCwgZG9jdW1lbnQpOwotICAgICAgICBpZiAoYWRqdXN0 ZWROb2RlLm5vZGVUeXBlID09IDMpIC8vIFRFWFQgbm9kZQorICAgICAgICBpZiAoYWRqdXN0ZWRO b2RlICYmIGFkanVzdGVkTm9kZS5ub2RlVHlwZSA9PSAzKSAvLyBURVhUIG5vZGUKICAgICAgICAg ICAgIGFkanVzdGVkTm9kZSA9IGFkanVzdGVkTm9kZS5wYXJlbnROb2RlOwogICAgICAgICByZXR1 cm4gYWRqdXN0ZWROb2RlOwogICAgIH0KQEAgLTUzLDEwICs1MywxMCBAQCBoaSB0aGVyZSA8YSBp ZD0iNiIgaHJlZj0iIzYiPnNvbWUgbGluayB0aGF0IGlzIGJyZWFraW5nIG11bHRpcGxlIGxpbmVz IGp1c3QgZm9yCiAgICAgICAgIGRlYnVnKCdUZXN0IGEgZmV3IGRpcmVjdCBtaXNzZXMuJyk7CiAK ICAgICAgICAgYWRqdXN0ZWROb2RlID0gdGVzdFJvdW5kVG91Y2goNTYsIDYwLCA4KQotICAgICAg ICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2FkanVzdGVkTm9kZS5pZCcsICcnKTsKKyAgICAgICAg c2hvdWxkRXZhbHVhdGVUbygnYWRqdXN0ZWROb2RlJywgJ251bGwnKTsKIAogICAgICAgICBhZGp1 c3RlZE5vZGUgPSB0ZXN0Um91bmRUb3VjaCgyMCwgMTYwLCA0KQotICAgICAgICBzaG91bGRCZUVx dWFsVG9TdHJpbmcoJ2FkanVzdGVkTm9kZS5pZCcsICcnKTsKKyAgICAgICAgc2hvdWxkRXZhbHVh dGVUbygnYWRqdXN0ZWROb2RlJywgJ251bGwnKTsKIAogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDFl MjkxZGIuLjA1MzFlMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMi0wNC0wNCAg QWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAorICAgICAg ICBCZXN0IGNsaWNrYWJsZSBub2RlIG1pZ2h0IHJldHVybiBub24gImNsaWNrYWJsZSIgbm9kZS4g CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE1Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBy ZXR1cm4gbm9uLWNsaWNrYWJsZSBub2RlcyBhcyBhIGJlc3QgY2xpY2thYmxlIG5vZGUuCisKKyAg ICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhh bmRsZXI6OmJlc3RDbGlja2FibGVOb2RlRm9yVG91Y2hQb2ludCk6CisKKzIwMTItMDQtMDQgIEFs bGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CisKICAgICAgICAg QmVzdCB6b29tYWJsZSBhcmVhIGRvZXMgbm90IGJhbGFuY2UgaW50ZXJzZWN0aW9uIHdpdGggdGFy Z2V0IGFyZWEuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04MzE0OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggMTY4M2MzZC4u NjU3NGQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMjQ2OSwxMSAr MjQ2OSw3IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjpiZXN0Q2xpY2thYmxlTm9kZUZvclRvdWNoUG9p bnQoY29uc3QgSW50UG9pbnQmIHRvdWNoQ2VudGVyLCBjCiAKICAgICBJbnRSZWN0IHRvdWNoUmVj dCA9IHJlc3VsdC5yZWN0Rm9yUG9pbnQodG91Y2hDZW50ZXIpOwogICAgIFJlZlB0cjxTdGF0aWNI YXNoU2V0Tm9kZUxpc3Q+IG5vZGVMaXN0ID0gU3RhdGljSGFzaFNldE5vZGVMaXN0OjphZG9wdChy ZXN1bHQucmVjdEJhc2VkVGVzdFJlc3VsdCgpKTsKLSAgICBpZiAoIWZpbmRCZXN0Q2xpY2thYmxl Q2FuZGlkYXRlKHRhcmdldE5vZGUsIHRhcmdldFBvaW50LCB0b3VjaENlbnRlciwgdG91Y2hSZWN0 LCAqbm9kZUxpc3QuZ2V0KCkpKSB7Ci0gICAgICAgIC8vIERlZmF1bHQgdG8ganVzdCByZXR1cm5p bmcgaW5uZXJOb25TaGFyZWROb2RlLgotICAgICAgICB0YXJnZXRQb2ludCA9IHRvdWNoQ2VudGVy OwotICAgICAgICB0YXJnZXROb2RlID0gcmVzdWx0LmlubmVyTm9uU2hhcmVkTm9kZSgpOwotICAg IH0KKyAgICBmaW5kQmVzdENsaWNrYWJsZUNhbmRpZGF0ZSh0YXJnZXROb2RlLCB0YXJnZXRQb2lu dCwgdG91Y2hDZW50ZXIsIHRvdWNoUmVjdCwgKm5vZGVMaXN0LmdldCgpKTsKIH0KIAogdm9pZCBF dmVudEhhbmRsZXI6OmJlc3Rab29tYWJsZUFyZWFGb3JUb3VjaFBvaW50KGNvbnN0IEludFBvaW50 JiB0b3VjaENlbnRlciwgY29uc3QgSW50U2l6ZSYgdG91Y2hSYWRpdXMsIEludFJlY3QmIHRhcmdl dEFyZWEsIE5vZGUqJiB0YXJnZXROb2RlKQo=