83149 2012-04-04 05:15:01 -0700 [Qt] Further improvements of the tap gesture recognizer 2012-04-04 05:33:40 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth hausmann menard webkit.review.bot zherczeg zoltan oldest_to_newest 595434 0 kenneth 2012-04-04 05:15:01 -0700 Further testing on the device showed a few other issues: 1. single tap event (fired on timeout) is not ignored while finger is still pressed 2. a pan further than the maxPanDistance only ignores single tap's and not double tap's 595435 1 135563 kenneth 2012-04-04 05:16:00 -0700 Created attachment 135563 Patch 595450 2 kenneth 2012-04-04 05:33:31 -0700 Landed in 113175 135563 2012-04-04 05:16:00 -0700 2012-04-04 05:33:40 -0700 Patch bug-83149-20120404140752.patch text/plain 6162 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDI3NmNlZGNlZjQ1ZGRl MmIxZWEwZjlhM2U1MDdhYzhhMzFiNzlmYi4uYTE3Mjg3NjA4MDFhMmNiMzk2Y2VhYjY1MGZjNWU4 OTA1YWVhMWJlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTA0LTA0ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBb UXRdIEZ1cnRoZXIgaW1wcm92ZW1lbnRzIG9mIHRoZSB0YXAgZ2VzdHVyZSByZWNvZ25pemVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElnbm9yZSBzaW5n bGUgdGFwIHdoaWxlIGZpbmdlciBpcyBzdGlsbCBwcmVzc2VkLgorICAgICAgICBTb21lIHJlbmFt aW5nIHRvIG1ha2UgdGhlIHN0YXRlcyBtb3JlIGNsZWFyLgorICAgICAgICBBIHBhbiBmdXJ0aGVy IHRoYW4gdGhlIG1heFBhbkRpc3RhbmNlIGNhbiBub3cgaW52YWxpZGF0ZQorICAgICAgICBkb3Vi bGUtdGFwcyBhcyB3ZWxsLgorCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVyZVJl Y29nbml6ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdFRhcEdlc3R1cmVSZWNvZ25pemVyOjpR dFRhcEdlc3R1cmVSZWNvZ25pemVyKToKKyAgICAgICAgKFdlYktpdDo6UXRUYXBHZXN0dXJlUmVj b2duaXplcjo6cmVjb2duaXplKToKKyAgICAgICAgKFdlYktpdDo6UXRUYXBHZXN0dXJlUmVjb2du aXplcjo6c2luZ2xlVGFwVGltZW91dCk6CisgICAgICAgIChXZWJLaXQ6OlF0VGFwR2VzdHVyZVJl Y29nbml6ZXI6OnRhcEFuZEhvbGRUaW1lb3V0KToKKyAgICAgICAgKFdlYktpdDo6UXRUYXBHZXN0 dXJlUmVjb2duaXplcjo6cmVzZXQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFRhcEdlc3R1 cmVSZWNvZ25pemVyLmg6CisKKzIwMTItMDQtMDQgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2Vu ICA8a2VubmV0aEB3ZWJraXQub3JnPgorCiAgICAgICAgIFtRdF0gSW1wcm92ZSB0aGUgdGFwIGdl c3R1cmUgcmVjb2duaXplcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODMxMzUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0 L1F0VGFwR2VzdHVyZVJlY29nbml6ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0 L1F0VGFwR2VzdHVyZVJlY29nbml6ZXIuY3BwCmluZGV4IGI2Yjg1ZmE3ZGE4MTBlMjg0NDg1NTVi MGMzNzQ5NDUwNjY1NmEzYzAuLjAwYTM0ZTMwOWJiOTFmZTY0NzcxOTRjMGY3NmQ4MDI0MWUxMGRl ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFRhcEdlc3R1cmVS ZWNvZ25pemVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRUYXBHZXN0 dXJlUmVjb2duaXplci5jcHAKQEAgLTMzLDcgKzMzLDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAK IFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OlF0VGFwR2VzdHVyZVJlY29nbml6ZXIoUXRXZWJQYWdl RXZlbnRIYW5kbGVyKiBldmVudEhhbmRsZXIpCiAgICAgOiBRdEdlc3R1cmVSZWNvZ25pemVyKGV2 ZW50SGFuZGxlcikKLSAgICAsIG1fdGFwU3RhdGUoTm9UYXApCisgICAgLCBtX2NhbmRpZGF0ZShJ bnZhbGlkKQogewogfQogCkBAIC01NSwxNiArNTUsMTUgQEAgYm9vbCBRdFRhcEdlc3R1cmVSZWNv Z25pemVyOjpyZWNvZ25pemUoY29uc3QgUVRvdWNoRXZlbnQqIGV2ZW50LCBxaW50NjQgZXZlbnRU aW0KIAogICAgIHN3aXRjaCAoZXZlbnQtPnR5cGUoKSkgewogICAgIGNhc2UgUUV2ZW50OjpUb3Vj aEJlZ2luOgotICAgICAgICBBU1NFUlQobV90YXBTdGF0ZSA9PSBOb1RhcCk7CiAgICAgICAgIG1f ZG91YmxlVGFwVGltZXIuc3RvcCgpOyAvLyBDYW5jZWwgb3RoZXIgcGVuZGluZyBzaW5nbGUgdGFw IGV2ZW50LgogCiAgICAgICAgIEFTU0VSVCghbV90YXBBbmRIb2xkVGltZXIuaXNBY3RpdmUoKSk7 CiAgICAgICAgIG1fdGFwQW5kSG9sZFRpbWVyLnN0YXJ0KHRhcEFuZEhvbGRUaW1lLCB0aGlzKTsK IAogICAgICAgICBpZiAobV9sYXN0VG91Y2hFdmVudCAmJiB3aXRoaW5EaXN0YW5jZSh0b3VjaFBv aW50LCBtYXhEb3VibGVUYXBEaXN0YW5jZSkpCi0gICAgICAgICAgICBtX3RhcFN0YXRlID0gRG91 YmxlVGFwQ2FuZGlkYXRlOworICAgICAgICAgICAgbV9jYW5kaWRhdGUgPSBEb3VibGVUYXBDYW5k aWRhdGU7CiAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgbV90YXBTdGF0ZSA9IFNpbmdsZVRh cFN0YXJ0ZWQ7CisgICAgICAgICAgICBtX2NhbmRpZGF0ZSA9IFNpbmdsZVRhcENhbmRpZGF0ZTsK ICAgICAgICAgICAgIC8vIFRoZSBiZWxvdyBpbiBmYWN0cyByZXNldHMgYW55IHByZXZpb3VzIHNp bmdsZSB0YXAgZXZlbnQuCiAgICAgICAgICAgICBtX2V2ZW50SGFuZGxlci0+aGFuZGxlUG90ZW50 aWFsU2luZ2xlVGFwRXZlbnQodG91Y2hQb2ludCk7CiAgICAgICAgICAgICBtX2xhc3RUb3VjaEV2 ZW50ID0gYWRvcHRQdHIobmV3IFFUb3VjaEV2ZW50KCpldmVudCkpOwpAQCAtNzQsMjAgKzczLDIx IEBAIGJvb2wgUXRUYXBHZXN0dXJlUmVjb2duaXplcjo6cmVjb2duaXplKGNvbnN0IFFUb3VjaEV2 ZW50KiBldmVudCwgcWludDY0IGV2ZW50VGltCiAKICAgICBjYXNlIFFFdmVudDo6VG91Y2hVcGRh dGU6CiAgICAgICAgIC8vIElmIHRoZSB0b3VjaCBwb2ludCBtb3ZlcyBmdXJ0aGVyIHRoYW4gdGhl IHRocmVzaG9sZCwgd2UgY2FuY2VsIHRoZSB0YXAgZ2VzdHVyZS4KLSAgICAgICAgaWYgKG1fdGFw U3RhdGUgPT0gU2luZ2xlVGFwU3RhcnRlZCAmJiAhd2l0aGluRGlzdGFuY2UodG91Y2hQb2ludCwg bWF4UGFuRGlzdGFuY2UpKQorICAgICAgICBpZiAobV9jYW5kaWRhdGUgIT0gSW52YWxpZCAmJiAh d2l0aGluRGlzdGFuY2UodG91Y2hQb2ludCwgbWF4UGFuRGlzdGFuY2UpKQogICAgICAgICAgICAg cmVzZXQoKTsKICAgICAgICAgYnJlYWs7CiAKICAgICBjYXNlIFFFdmVudDo6VG91Y2hFbmQ6CiAg ICAgICAgIG1fdGFwQW5kSG9sZFRpbWVyLnN0b3AoKTsKIAotICAgICAgICBpZiAobV90YXBTdGF0 ZSA9PSBEb3VibGVUYXBDYW5kaWRhdGUgJiYgd2l0aGluRGlzdGFuY2UodG91Y2hQb2ludCwgbWF4 RG91YmxlVGFwRGlzdGFuY2UpKQotICAgICAgICAgICAgbV9ldmVudEhhbmRsZXItPmhhbmRsZURv dWJsZVRhcEV2ZW50KHRvdWNoUG9pbnQpOworICAgICAgICBpZiAobV9jYW5kaWRhdGUgPT0gSW52 YWxpZCkKKyAgICAgICAgICAgIGJyZWFrOwogCi0gICAgICAgIGlmIChtX3RhcFN0YXRlICE9IE5v VGFwKQorICAgICAgICBpZiAobV9jYW5kaWRhdGUgPT0gRG91YmxlVGFwQ2FuZGlkYXRlKSB7CiAg ICAgICAgICAgICBtX2V2ZW50SGFuZGxlci0+aGFuZGxlUG90ZW50aWFsU2luZ2xlVGFwRXZlbnQo UVRvdWNoRXZlbnQ6OlRvdWNoUG9pbnQoKSk7CisgICAgICAgICAgICBtX2V2ZW50SGFuZGxlci0+ aGFuZGxlRG91YmxlVGFwRXZlbnQodG91Y2hQb2ludCk7CisgICAgICAgIH0KIAotICAgICAgICBt X3RhcFN0YXRlID0gTm9UYXA7CiAgICAgICAgIGJyZWFrOwogCiAgICAgZGVmYXVsdDoKQEAgLTk5 LDMzICs5OSwzOCBAQCBib29sIFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OnJlY29nbml6ZShjb25z dCBRVG91Y2hFdmVudCogZXZlbnQsIHFpbnQ2NCBldmVudFRpbQogCiB2b2lkIFF0VGFwR2VzdHVy ZVJlY29nbml6ZXI6OnNpbmdsZVRhcFRpbWVvdXQoKQogeworICAgIC8vIEZpbmdlciBpcyBzdGls bCBwcmVzc2VkLCBpZ25vcmUuCisgICAgaWYgKG1fdGFwQW5kSG9sZFRpbWVyLmlzQWN0aXZlKCkp CisgICAgICAgIHJldHVybjsKKwogICAgIEFTU0VSVChtX2xhc3RUb3VjaEV2ZW50KTsKKyAgICBj b25zdCBRVG91Y2hFdmVudDo6VG91Y2hQb2ludCYgdG91Y2hQb2ludCA9IG1fbGFzdFRvdWNoRXZl bnQtPnRvdWNoUG9pbnRzKCkuZmlyc3QoKTsKIAotICAgIG1fZXZlbnRIYW5kbGVyLT5oYW5kbGVQ b3RlbnRpYWxTaW5nbGVUYXBFdmVudChRVG91Y2hFdmVudDo6VG91Y2hQb2ludCgpKTsKLSAgICBt X2V2ZW50SGFuZGxlci0+aGFuZGxlU2luZ2xlVGFwRXZlbnQobV9sYXN0VG91Y2hFdmVudC0+dG91 Y2hQb2ludHMoKS5maXJzdCgpKTsKKyAgICBpZiAobV9jYW5kaWRhdGUgPT0gU2luZ2xlVGFwQ2Fu ZGlkYXRlKSB7CisgICAgICAgIG1fZXZlbnRIYW5kbGVyLT5oYW5kbGVQb3RlbnRpYWxTaW5nbGVU YXBFdmVudChRVG91Y2hFdmVudDo6VG91Y2hQb2ludCgpKTsKKyAgICAgICAgbV9ldmVudEhhbmRs ZXItPmhhbmRsZVNpbmdsZVRhcEV2ZW50KHRvdWNoUG9pbnQpOworICAgIH0KICAgICByZXNldCgp OwogfQogCiB2b2lkIFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OnRhcEFuZEhvbGRUaW1lb3V0KCkK IHsKICAgICBBU1NFUlQobV9sYXN0VG91Y2hFdmVudCk7Ci0KLSAgICBtX2V2ZW50SGFuZGxlci0+ aGFuZGxlUG90ZW50aWFsU2luZ2xlVGFwRXZlbnQoUVRvdWNoRXZlbnQ6OlRvdWNoUG9pbnQoKSk7 Ci0gICAgcmVzZXQoKTsKLQogI2lmIDAgLy8gTm8gc3VwcG9ydCBmb3Igc3ludGhldGljIGNvbnRl eHQgbWVudXMgaW4gV0syIHlldC4KICAgICBjb25zdCBRVG91Y2hFdmVudDo6VG91Y2hQb2ludCYg dG91Y2hQb2ludCA9IG1fbGFzdFRvdWNoRXZlbnQtPnRvdWNoUG9pbnRzKCkuZmlyc3QoKTsKLSAg ICBXZWJHZXN0dXJlRXZlbnQgZXZlbnQoV2ViRXZlbnQ6Okdlc3R1cmVUYXBBbmRIb2xkLCB0b3Vj aFBvaW50LnBvcygpLnRvUG9pbnQoKSwgdG91Y2hQb2ludC5zY3JlZW5Qb3MoKS50b1BvaW50KCks IFdlYkV2ZW50OjpNb2RpZmllcnMoMCksIDApOwotICAgIG1fZXZlbnRIYW5kbGVyLT5oYW5kbGVH ZXN0dXJlRXZlbnQoZXZlbnQpOworCisgICAgbV9ldmVudEhhbmRsZXItPmhhbmRsZVBvdGVudGlh bFNpbmdsZVRhcEV2ZW50KFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50KCkpOworICAgIG1fZXZlbnRI YW5kbGVyLT5oYW5kbGVUYXBBbmRIb2xkRXZlbnQodG91Y2hQb2ludCk7CiAjZW5kaWYKKyAgICBy ZXNldCgpOwogfQogCiB2b2lkIFF0VGFwR2VzdHVyZVJlY29nbml6ZXI6OnJlc2V0KCkKIHsKLSAg ICBpZiAobV90YXBTdGF0ZSAhPSBOb1RhcCkKKyAgICBpZiAobV9jYW5kaWRhdGUgIT0gSW52YWxp ZCkKICAgICAgICAgbV9ldmVudEhhbmRsZXItPmhhbmRsZVBvdGVudGlhbFNpbmdsZVRhcEV2ZW50 KFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50KCkpOwogCi0gICAgbV90YXBTdGF0ZSA9IE5vVGFwOwor ICAgIG1fY2FuZGlkYXRlID0gSW52YWxpZDsKICAgICBtX3RhcEFuZEhvbGRUaW1lci5zdG9wKCk7 CiAgICAgbV9kb3VibGVUYXBUaW1lci5zdG9wKCk7CiAgICAgbV9sYXN0VG91Y2hFdmVudC5jbGVh cigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVy ZVJlY29nbml6ZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFRhcEdlc3R1cmVS ZWNvZ25pemVyLmgKaW5kZXggYjVjZjhmZTg2YTM5MWZmYjQ5ZWU0MmU0MGY3YmExOTAyMjQ0NTU3 MC4uN2NhN2ZmOTkxMmJhMTlmYmVhM2IzZTEyOGYyMzAzZDRiYjljYTIxOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVyZVJlY29nbml6ZXIuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRUYXBHZXN0dXJlUmVjb2duaXplci5oCkBA IC02MywxMSArNjMsMTAgQEAgcHJpdmF0ZToKICAgICBPd25QdHI8UVRvdWNoRXZlbnQ+IG1fbGFz dFRvdWNoRXZlbnQ7CiAKICAgICBlbnVtIHsKLSAgICAgICAgTm9UYXAsCi0gICAgICAgIFNpbmds ZVRhcFN0YXJ0ZWQsCisgICAgICAgIEludmFsaWQsCisgICAgICAgIFNpbmdsZVRhcENhbmRpZGF0 ZSwKICAgICAgICAgRG91YmxlVGFwQ2FuZGlkYXRlLAotICAgICAgICBUYXBBbmRIb2xkCi0gICAg fSBtX3RhcFN0YXRlOworICAgIH0gbV9jYW5kaWRhdGU7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBX ZWJLaXQK