83137 2012-04-04 03:34:19 -0700 [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC 2012-04-05 02:25:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 58443 0 kevin.cs.oh webkit-unassigned ericu eric haraken kbr webkit.review.bot oldest_to_newest 595378 0 kevin.cs.oh 2012-04-04 03:34:19 -0700 This is the bug to fix the failure for fast/filesystem/flags-passing.html 596254 1 kevin.cs.oh 2012-04-04 20:11:35 -0700 The error message is like that... CONSOLE MESSAGE: line 27: TypeError: 'undefined' is not a function (evaluating 'this[testsList[testCounter++]]()') FAIL: Timed out waiting for notifyDone to be called 596350 2 135768 kevin.cs.oh 2012-04-05 00:16:27 -0700 Created attachment 135768 Patch 596367 3 135768 haraken 2012-04-05 00:52:26 -0700 Comment on attachment 135768 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review > LayoutTests/fast/filesystem/script-tests/flags-passing.js:27 > + window[testsList[testCounter++]](); The change looks OK, but we can simplify the code more, like this: var testsList = [runObjectTest, cleanupAndRunNext, ...]; // An array of functions (not function names) ... else { (testsList[testCounter++])(); } 596394 4 135781 kevin.cs.oh 2012-04-05 01:45:09 -0700 Created attachment 135781 Patch 596396 5 135768 kevin.cs.oh 2012-04-05 01:46:00 -0700 Comment on attachment 135768 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review Thanks for the review! >> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27 >> + window[testsList[testCounter++]](); > > The change looks OK, but we can simplify the code more, like this: > > var testsList = [runObjectTest, cleanupAndRunNext, ...]; // An array of functions (not function names) > > ... else { > (testsList[testCounter++])(); > } Done. :) 596397 6 135781 haraken 2012-04-05 01:46:06 -0700 Comment on attachment 135781 Patch Looks OK. Thanks for fixing the bug! 596416 7 135781 webkit.review.bot 2012-04-05 02:25:35 -0700 Comment on attachment 135781 Patch Clearing flags on attachment: 135781 Committed r113305: <http://trac.webkit.org/changeset/113305> 596417 8 webkit.review.bot 2012-04-05 02:25:40 -0700 All reviewed patches have been landed. Closing bug. 135768 2012-04-05 00:16:27 -0700 2012-04-05 01:46:00 -0700 Patch bug-83137-20120405161625.patch text/plain 1986 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMjc1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjIxODJhMmU4MDllZDg2NWZlZTc1 NzAxMGNlNTg4ODUyZDgzNDI2OS4uMjAyMWJiMDhlOGJiMjIyNWZlYWQ0ODE3ZjM4ZjZjNWNhNWFj ZGQ1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTA0ICBDaGFuZ1Nlb2sgT2ggIDxz aGl2YW1pZG93QGdtYWlsLmNvbT4KKworICAgICAgICBbR1RLXVtEUlRdIEZhaWwgZmFzdC9maWxl c3lzdGVtL2ZsYWdzLXBhc3NpbmcuaHRtbCBvbiBKU0MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC9maWxlc3lzdGVtL2ZsYWdzLXBhc3NpbmcuaHRt bCBpcyBmYWlsZWQgb24gd2Via2l0Z3RrKyBhcHBsaWVkIEZpbGVTeXN0ZW0gQVBJIHBhdGNoCisg ICAgICAgIGZvciBidWc1ODQ0My4gJ3Rlc3RzTGlzdCcgaXMgYSBnbG9iYWwgYXJyYXkgb2JqZWN0 LCBidXQgaXQncyBhY2Nlc3NlZCBpbiBydW5OZXh0VGVzdAorICAgICAgICBmdW5jdGlvbiBvYmpl Y3QgbGlrZSB0aGlzLCAidGhpc1t0ZXN0c0xpc3RbdGVzdENvdW50ZXIrK11dKCk7Ii4gSSdtIG5v dCBmYW1pbGlhcgorICAgICAgICB3aXRoIEphdmFTY3JpcHQgYW5kIFY4LCBidXQgaW4gbXkgdW5k ZXJzdGFuZGluZywgaXQgbG9va3MgYSBiaXQgc3RyYW5nZS4KKyAgICAgICAgJ3RoaXMnIGluIHRo ZSBzdGF0ZW1lbnQgbWVhbnMgcnVuTmV4dFRlc3QgZnVuY3Rpb24gb2JqZWN0IHdoaWNoIGRvZXNu J3QgaGF2ZQorICAgICAgICB0ZXN0TGlzdCBhcnJheSBvYmplY3QuIChJdCdzIGEgZ2xvYmFsIHNj b3BlIHZhcmlhYmxlLikgVGhpcyB0ZXN0IG1pZ2h0IGJlIGFibGUgdG8KKyAgICAgICAgcGFzcyBv biBWOCBKUyBlbmdpbmUsIGJ1dCBub3Qgb24gSlNDIGF0IGxlYXN0IG15IHRyeS4gU28gSSBwcm9w b3NlIHVzaW5nICd3aW5kb3cnCisgICAgICAgIGluc3RlYWQgb2YgJ3RoaXMnLgorCisgICAgICAg ICogZmFzdC9maWxlc3lzdGVtL3NjcmlwdC10ZXN0cy9mbGFncy1wYXNzaW5nLmpzOgorICAgICAg ICAocnVuTmV4dFRlc3QpOgorCiAyMDEyLTA0LTA0ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBVcGRhdGUgYSBsYXlvdXQgdGVzdCwgYWRkaW5nIGEgY2FzZSBm b3IgdHJhdmVyc2luZyBhIFNoYWRvd1Jvb3Qgd2hpY2ggZG9lcyBub3QgaGF2ZSBhbnkgY2hpbGRy ZW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vc2NyaXB0LXRlc3Rz L2ZsYWdzLXBhc3NpbmcuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vc2NyaXB0LXRl c3RzL2ZsYWdzLXBhc3NpbmcuanMKaW5kZXggMmU1ZmJlZWEyNmQyMzZmOTZhMTJhNDA1YTMzYWY2 YTQ2MWRlOGQ5NS4uZTlhYzg3NTk0ZTE0MjZhZWU4MzY1ZWY2YzE4MzQ1YWFhNDU2ZmExOSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3NjcmlwdC10ZXN0cy9mbGFncy1w YXNzaW5nLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS9zY3JpcHQtdGVzdHMv ZmxhZ3MtcGFzc2luZy5qcwpAQCAtMjQsNyArMjQsNyBAQCBmdW5jdGlvbiBydW5OZXh0VGVzdCh2 KSB7CiAgICAgICAgIHNob3VsZEJlKCd1bmV4cGVjdGVkQ2FsbGJhY2tzQ291bnQnLCAnMCcpOwog ICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKICAgICB9IGVsc2UKLSAgICAgICAgdGhpc1t0ZXN0c0xp c3RbdGVzdENvdW50ZXIrK11dKCk7CisgICAgICAgIHdpbmRvd1t0ZXN0c0xpc3RbdGVzdENvdW50 ZXIrK11dKCk7CiB9CiAKIGZ1bmN0aW9uIGVycm9yQ2FsbGJhY2soZXJyb3IpIHsK 135781 2012-04-05 01:45:09 -0700 2012-04-05 02:25:34 -0700 Patch bug-83137-20120405174508.patch text/plain 2469 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMjk5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzk0M2NkY2I0MmZjYWEzMWFkYTU1 Yzg5ZGEyN2I3MTkzNTY1NDg4YS4uOTE1ZDI4ZGVmMTM0OTAzODY2N2UxMTY4NGMzOTIzZWU0ZjMz N2JjNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTA1ICBDaGFuZ1Nlb2sgT2ggIDxz aGl2YW1pZG93QGdtYWlsLmNvbT4KKworICAgICAgICBbR1RLXVtEUlRdIEZhaWwgZmFzdC9maWxl c3lzdGVtL2ZsYWdzLXBhc3NpbmcuaHRtbCBvbiBKU0MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC9maWxlc3lzdGVtL2ZsYWdzLXBhc3NpbmcuaHRt bCBpcyBmYWlsZWQgb24gd2Via2l0Z3RrKyBhcHBsaWVkIEZpbGVTeXN0ZW0gQVBJIHBhdGNoCisg ICAgICAgIGZvciBidWc1ODQ0My4gJ3Rlc3RzTGlzdCcgaXMgYSBnbG9iYWwgYXJyYXkgb2JqZWN0 LCBidXQgaXQncyBhY2Nlc3NlZCBpbiBydW5OZXh0VGVzdAorICAgICAgICBmdW5jdGlvbiBvYmpl Y3QgbGlrZSB0aGlzLCAidGhpc1t0ZXN0c0xpc3RbdGVzdENvdW50ZXIrK11dKCk7Ii4gSSdtIG5v dCBmYW1pbGlhcgorICAgICAgICB3aXRoIEphdmFTY3JpcHQgYW5kIFY4LCBidXQgaW4gbXkgdW5k ZXJzdGFuZGluZywgaXQgbG9va3MgYSBiaXQgc3RyYW5nZS4KKyAgICAgICAgJ3RoaXMnIGluIHRo ZSBzdGF0ZW1lbnQgbWVhbnMgcnVuTmV4dFRlc3QgZnVuY3Rpb24gb2JqZWN0IHdoaWNoIGRvZXNu J3QgaGF2ZQorICAgICAgICB0ZXN0TGlzdCBhcnJheSBvYmplY3QuIChJdCdzIGEgZ2xvYmFsIHNj b3BlIHZhcmlhYmxlLikgVGhpcyB0ZXN0IG1pZ2h0IGJlIGFibGUgdG8KKyAgICAgICAgcGFzcyBv biBWOCBKUyBlbmdpbmUsIGJ1dCBub3Qgb24gSlNDIGF0IGxlYXN0IG15IHRyeS4KKyAgICAgICAg J3Rlc3RzTGlzdCcgaXMgY2hhbmdlZCBmcm9tIGEgZnVuY3Rpb24gbmFtZSBhcnJheSB0byBhIGZ1 bmN0aW9uIGFycmF5LgorCisgICAgICAgICogZmFzdC9maWxlc3lzdGVtL3NjcmlwdC10ZXN0cy9m bGFncy1wYXNzaW5nLmpzOgorICAgICAgICAocnVuTmV4dFRlc3QpOgorCiAyMDEyLTA0LTAxICBO aWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFdvcmsg YXJvdW5kIGFuIGVudGl0eSBwYXJzaW5nIGJ1ZyBpbiBsaWJ4bWwyIDIuNy4zIChzdXBwbGllZCB3 aXRoIExpb24pIGFuZCB1bnNraXAgdGVzdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv ZmlsZXN5c3RlbS9zY3JpcHQtdGVzdHMvZmxhZ3MtcGFzc2luZy5qcyBiL0xheW91dFRlc3RzL2Zh c3QvZmlsZXN5c3RlbS9zY3JpcHQtdGVzdHMvZmxhZ3MtcGFzc2luZy5qcwppbmRleCAyZTVmYmVl YTI2ZDIzNmY5NmExMmE0MDVhMzNhZjZhNDYxZGU4ZDk1Li41NWM4MWM2NzM3ZTBiY2MzNzkzMmVk N2U2OTU4ODA5Yzg1NTI3MzNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0 ZW0vc2NyaXB0LXRlc3RzL2ZsYWdzLXBhc3NpbmcuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9m aWxlc3lzdGVtL3NjcmlwdC10ZXN0cy9mbGFncy1wYXNzaW5nLmpzCkBAIC04LDEyICs4LDEyIEBA IHZhciBleHBlY3RlZCA9IGZ1bmN0aW9uKGUpIHsgZXhwZWN0ZWRDYWxsYmFja3NDb3VudCsrOyB9 OwogdmFyIHVuZXhwZWN0ZWQgPSBmdW5jdGlvbihlKSB7IHVuZXhwZWN0ZWRDYWxsYmFja3NDb3Vu dCsrOyB9OwogCiB2YXIgdGVzdHNMaXN0ID0gWwotICAgICdydW5PYmplY3RUZXN0JywKLSAgICAn Y2xlYW51cEFuZFJ1bk5leHQnLAotICAgICdydW5KU09OVGVzdCcsCi0gICAgJ3J1bkpTT05UZXN0 V2l0aEV4Y2x1c2l2ZScsCi0gICAgJ3J1bk51bGxUZXN0JywKLSAgICAncnVuTm9uT2JqZWN0VGVz dCcKKyAgICBydW5PYmplY3RUZXN0LAorICAgIGNsZWFudXBBbmRSdW5OZXh0LAorICAgIHJ1bkpT T05UZXN0LAorICAgIHJ1bkpTT05UZXN0V2l0aEV4Y2x1c2l2ZSwKKyAgICBydW5OdWxsVGVzdCwK KyAgICBydW5Ob25PYmplY3RUZXN0CiBdOwogdmFyIHRlc3RDb3VudGVyID0gMDsKIApAQCAtMjQs NyArMjQsNyBAQCBmdW5jdGlvbiBydW5OZXh0VGVzdCh2KSB7CiAgICAgICAgIHNob3VsZEJlKCd1 bmV4cGVjdGVkQ2FsbGJhY2tzQ291bnQnLCAnMCcpOwogICAgICAgICBmaW5pc2hKU1Rlc3QoKTsK ICAgICB9IGVsc2UKLSAgICAgICAgdGhpc1t0ZXN0c0xpc3RbdGVzdENvdW50ZXIrK11dKCk7Cisg ICAgICAgICh0ZXN0c0xpc3RbdGVzdENvdW50ZXIrK10pKCk7CiB9CiAKIGZ1bmN0aW9uIGVycm9y Q2FsbGJhY2soZXJyb3IpIHsK