<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>83134</bug_id>
          
          <creation_ts>2012-04-04 02:52:57 -0700</creation_ts>
          <short_desc>Web Inspector: front-end should accept raw web socket address for the remote connection.</short_desc>
          <delta_ts>2012-04-04 04:19:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Pavel Feldman">pfeldman</reporter>
          <assigned_to name="Pavel Feldman">pfeldman</assigned_to>
          <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>timothy</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>595346</commentid>
    <comment_count>0</comment_count>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2012-04-04 02:52:57 -0700</bug_when>
    <thetext>Migrated from the /devtools/page web socket schema to the generic one where page address can be specified as index.html?ws=localhost:9222/page1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595349</commentid>
    <comment_count>1</comment_count>
      <attachid>135539</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2012-04-04 02:56:10 -0700</bug_when>
    <thetext>Created attachment 135539
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595355</commentid>
    <comment_count>2</comment_count>
      <attachid>135539</attachid>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2012-04-04 03:05:45 -0700</bug_when>
    <thetext>Comment on attachment 135539
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135539&amp;action=review

&gt; Source/WebCore/inspector/front-end/inspector.js:351
&gt; +    if (&quot;ws&quot; WebInspector.queryParamsObject)

&quot;ws&quot; in ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595357</commentid>
    <comment_count>3</comment_count>
      <attachid>135543</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2012-04-04 03:07:20 -0700</bug_when>
    <thetext>Created attachment 135543
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595405</commentid>
    <comment_count>4</comment_count>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2012-04-04 04:19:58 -0700</bug_when>
    <thetext>Committed r113167: &lt;http://trac.webkit.org/changeset/113167&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>135539</attachid>
            <date>2012-04-04 02:56:10 -0700</date>
            <delta_ts>2012-04-04 03:07:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-83134-20120404135608.patch</filename>
            <type>text/plain</type>
            <size>2239</size>
            <attacher name="Pavel Feldman">pfeldman</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Q0ZDVmMzBlNDY0MWY5
ZmY4ZjRmOGZiNzg0YmIwNzlmMDU2YWMwNi4uOTY3ZThjZjAzNzM1MjAyYWFiMzA5ZmQ2NDAyNGU4
Zjc5MTNlMzdlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTA0ICBQYXZl
bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0
b3I6IGZyb250LWVuZCBzaG91bGQgYWNjZXB0IHJhdyB3ZWIgc29ja2V0IGFkZHJlc3MgZm9yIHRo
ZSByZW1vdGUgY29ubmVjdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTgzMTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgTWlncmF0ZWQgZnJvbSB0aGUgL2RldnRvb2xzL3BhZ2Ugd2ViIHNvY2tldCBz
Y2hlbWEgdG8gdGhlIGdlbmVyaWMgb25lIHdoZXJlIHJlbW90ZSB0YXJnZXQgYWRkcmVzcworICAg
ICAgICBjYW4gYmUgc3BlY2lmaWVkIGFzIGluZGV4Lmh0bWw/d3M9bG9jYWxob3N0OjkyMjIvcGFn
ZTEuIExlZnQgdGhlIG9sZCBob3N0L3BhZ2Ugd2F5IGZvciBiYWNrd2FyZHMKKyAgICAgICAgY29t
cGF0aWJpbGl0eS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpz
OgorCiAyMDEyLTA0LTAzICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAK
ICAgICAgICAgV2ViIEluc3BlY3RvcjogZXZlbnQgbWFya3MgYXJlIG1pc3NpbmcgaW4gdGhlIHRp
bWVsaW5lIG92ZXJ2aWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv
bnQtZW5kL2luc3BlY3Rvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv
aW5zcGVjdG9yLmpzCmluZGV4IDA4ZTVhMzlmNDk1ZDI5Njc2ZWMzMzJhM2UxZjc0NmRlNTYxODYy
ZDYuLjgzZjU4MTdiOTIzNDNjMzY5YmJkNWU1ZGY1N2FhZGVlZDI5NTU3YWQgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0zNDYsMTAg
KzM0NiwxOCBAQCBXZWJJbnNwZWN0b3IuRXZlbnRzID0gewogV2ViSW5zcGVjdG9yLmxvYWRlZCA9
IGZ1bmN0aW9uKCkKIHsKICAgICBJbnNwZWN0b3JCYWNrZW5kLmxvYWRGcm9tSlNPTklmTmVlZGVk
KCk7Ci0gICAgaWYgKCJwYWdlIiBpbiBXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNPYmplY3QpIHsK
KworICAgIHZhciB3czsKKyAgICBpZiAoIndzIiBXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNPYmpl
Y3QpCisgICAgICAgIHdzID0gIndzOi8vIiArIFdlYkluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVj
dC53czsKKyAgICBlbHNlIGlmICgicGFnZSIgaW4gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2Jq
ZWN0KSB7CiAgICAgICAgIHZhciBwYWdlID0gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2JqZWN0
LnBhZ2U7CiAgICAgICAgIHZhciBob3N0ID0gImhvc3QiIGluIFdlYkluc3BlY3Rvci5xdWVyeVBh
cmFtc09iamVjdCA/IFdlYkluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdC5ob3N0IDogd2luZG93
LmxvY2F0aW9uLmhvc3Q7Ci0gICAgICAgIFdlYkluc3BlY3Rvci5zb2NrZXQgPSBuZXcgV2ViU29j
a2V0KCJ3czovLyIgKyBob3N0ICsgIi9kZXZ0b29scy9wYWdlLyIgKyBwYWdlKTsKKyAgICAgICAg
d3MgPSAid3M6Ly8iICsgaG9zdCArICIvZGV2dG9vbHMvcGFnZS8iICsgcGFnZTsKKyAgICB9CisK
KyAgICBpZiAod3MpIHsKKyAgICAgICAgV2ViSW5zcGVjdG9yLnNvY2tldCA9IG5ldyBXZWJTb2Nr
ZXQod3MpOwogICAgICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0Lm9ubWVzc2FnZSA9IGZ1bmN0aW9u
KG1lc3NhZ2UpIHsgSW5zcGVjdG9yQmFja2VuZC5kaXNwYXRjaChtZXNzYWdlLmRhdGEpOyB9CiAg
ICAgICAgIFdlYkluc3BlY3Rvci5zb2NrZXQub25lcnJvciA9IGZ1bmN0aW9uKGVycm9yKSB7IGNv
bnNvbGUuZXJyb3IoZXJyb3IpOyB9CiAgICAgICAgIFdlYkluc3BlY3Rvci5zb2NrZXQub25vcGVu
ID0gZnVuY3Rpb24oKSB7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>135543</attachid>
            <date>2012-04-04 03:07:20 -0700</date>
            <delta_ts>2012-04-04 03:08:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-83134-20120404140719.patch</filename>
            <type>text/plain</type>
            <size>2242</size>
            <attacher name="Pavel Feldman">pfeldman</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Q0ZDVmMzBlNDY0MWY5
ZmY4ZjRmOGZiNzg0YmIwNzlmMDU2YWMwNi4uOTY3ZThjZjAzNzM1MjAyYWFiMzA5ZmQ2NDAyNGU4
Zjc5MTNlMzdlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTA0ICBQYXZl
bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0
b3I6IGZyb250LWVuZCBzaG91bGQgYWNjZXB0IHJhdyB3ZWIgc29ja2V0IGFkZHJlc3MgZm9yIHRo
ZSByZW1vdGUgY29ubmVjdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTgzMTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgTWlncmF0ZWQgZnJvbSB0aGUgL2RldnRvb2xzL3BhZ2Ugd2ViIHNvY2tldCBz
Y2hlbWEgdG8gdGhlIGdlbmVyaWMgb25lIHdoZXJlIHJlbW90ZSB0YXJnZXQgYWRkcmVzcworICAg
ICAgICBjYW4gYmUgc3BlY2lmaWVkIGFzIGluZGV4Lmh0bWw/d3M9bG9jYWxob3N0OjkyMjIvcGFn
ZTEuIExlZnQgdGhlIG9sZCBob3N0L3BhZ2Ugd2F5IGZvciBiYWNrd2FyZHMKKyAgICAgICAgY29t
cGF0aWJpbGl0eS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpz
OgorCiAyMDEyLTA0LTAzICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAK
ICAgICAgICAgV2ViIEluc3BlY3RvcjogZXZlbnQgbWFya3MgYXJlIG1pc3NpbmcgaW4gdGhlIHRp
bWVsaW5lIG92ZXJ2aWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv
bnQtZW5kL2luc3BlY3Rvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv
aW5zcGVjdG9yLmpzCmluZGV4IDA4ZTVhMzlmNDk1ZDI5Njc2ZWMzMzJhM2UxZjc0NmRlNTYxODYy
ZDYuLjEzOTNmMDMwNWVlMGZkODMyNTcxODNhZTZhNTI5Mjg0MjAwMDIxZTQgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0zNDYsMTAg
KzM0NiwxOCBAQCBXZWJJbnNwZWN0b3IuRXZlbnRzID0gewogV2ViSW5zcGVjdG9yLmxvYWRlZCA9
IGZ1bmN0aW9uKCkKIHsKICAgICBJbnNwZWN0b3JCYWNrZW5kLmxvYWRGcm9tSlNPTklmTmVlZGVk
KCk7Ci0gICAgaWYgKCJwYWdlIiBpbiBXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNPYmplY3QpIHsK
KworICAgIHZhciB3czsKKyAgICBpZiAoIndzIiBpbiBXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNP
YmplY3QpCisgICAgICAgIHdzID0gIndzOi8vIiArIFdlYkluc3BlY3Rvci5xdWVyeVBhcmFtc09i
amVjdC53czsKKyAgICBlbHNlIGlmICgicGFnZSIgaW4gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1z
T2JqZWN0KSB7CiAgICAgICAgIHZhciBwYWdlID0gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2Jq
ZWN0LnBhZ2U7CiAgICAgICAgIHZhciBob3N0ID0gImhvc3QiIGluIFdlYkluc3BlY3Rvci5xdWVy
eVBhcmFtc09iamVjdCA/IFdlYkluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdC5ob3N0IDogd2lu
ZG93LmxvY2F0aW9uLmhvc3Q7Ci0gICAgICAgIFdlYkluc3BlY3Rvci5zb2NrZXQgPSBuZXcgV2Vi
U29ja2V0KCJ3czovLyIgKyBob3N0ICsgIi9kZXZ0b29scy9wYWdlLyIgKyBwYWdlKTsKKyAgICAg
ICAgd3MgPSAid3M6Ly8iICsgaG9zdCArICIvZGV2dG9vbHMvcGFnZS8iICsgcGFnZTsKKyAgICB9
CisKKyAgICBpZiAod3MpIHsKKyAgICAgICAgV2ViSW5zcGVjdG9yLnNvY2tldCA9IG5ldyBXZWJT
b2NrZXQod3MpOwogICAgICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0Lm9ubWVzc2FnZSA9IGZ1bmN0
aW9uKG1lc3NhZ2UpIHsgSW5zcGVjdG9yQmFja2VuZC5kaXNwYXRjaChtZXNzYWdlLmRhdGEpOyB9
CiAgICAgICAgIFdlYkluc3BlY3Rvci5zb2NrZXQub25lcnJvciA9IGZ1bmN0aW9uKGVycm9yKSB7
IGNvbnNvbGUuZXJyb3IoZXJyb3IpOyB9CiAgICAgICAgIFdlYkluc3BlY3Rvci5zb2NrZXQub25v
cGVuID0gZnVuY3Rpb24oKSB7Cg==
</data>
<flag name="review"
          id="140075"
          type_id="1"
          status="+"
          setter="yurys"
    />
          </attachment>
      

    </bug>

</bugzilla>