83127 2012-04-04 01:55:53 -0700 [BlackBerry] Disable paintingGoesToWindow() for the root layer when force compositing mode is active 2012-04-05 09:10:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 anilsson webkit-unassigned anilsson fspacek jamesr jkjiang jpetsovits rwlbuis sievers staikos tonikitoo vangelis webkit.review.bot oldest_to_newest 595312 0 anilsson 2012-04-04 01:55:53 -0700 The BlackBerry port will use accelerated compositing code path to render the root layer in some situation. The plan is to do this by activating the forceCompositingMode() setting, but that in itself doesn't accomplish anything, since painting will still go to window for the root layer. Thus a special clause in RenderLayerBacking::paintingGoesToWindow() will be added for PLATFORM(BLACKBERRY). 595317 1 anilsson 2012-04-04 01:58:56 -0700 The force compositing setting was introduced in bug #56156 595330 2 135533 anilsson 2012-04-04 02:19:08 -0700 Created attachment 135533 Patch 595332 3 anilsson 2012-04-04 02:24:11 -0700 Perhaps this is something the Chromium team is interested in, I'm not sure why they originally added the "force compositing" setting. Perhaps in the future, this can be a cross-platform mechanism rather than a PLATFORM(BLACKBERRY) ifdef? 595352 4 135541 anilsson 2012-04-04 03:00:36 -0700 Created attachment 135541 Patch 595353 5 anilsson 2012-04-04 03:01:25 -0700 (In reply to comment #4) > Created an attachment (id=135541) [details] > Patch Renamed the new method to "inForcedCompositingMode()" to match the existing "inCompositingMode()" method. 595865 6 jamesr 2012-04-04 13:31:43 -0700 In Chromium we paint root contents to the "window" and handle that externally to WebCore. 596509 7 staikos 2012-04-05 05:42:06 -0700 (In reply to comment #6) > In Chromium we paint root contents to the "window" and handle that externally to WebCore. Are you saying you have concerns with the approach in this patch? 596541 8 anilsson 2012-04-05 07:04:35 -0700 (In reply to comment #7) > (In reply to comment #6) > > In Chromium we paint root contents to the "window" and handle that externally to WebCore. > > Are you saying you have concerns with the approach in this patch? I don't think so - I added them to the bug's CC list since I was curious about what Chromium uses the "force compositing" setting for when it doesn't really do anything out of the box (since painting still goes to the window according to James' comment above.) If they are interested in this here feature (forcing root layer painting to go to layer instead of window) perhaps we can break it out into a separate setting in the future. 596621 9 135541 rwlbuis 2012-04-05 09:01:11 -0700 Comment on attachment 135541 Patch LGTM. 596626 10 135541 webkit.review.bot 2012-04-05 09:10:54 -0700 Comment on attachment 135541 Patch Clearing flags on attachment: 135541 Committed r113326: <http://trac.webkit.org/changeset/113326> 596627 11 webkit.review.bot 2012-04-05 09:10:59 -0700 All reviewed patches have been landed. Closing bug. 135533 2012-04-04 02:19:08 -0700 2012-04-04 03:00:26 -0700 Patch bug-83127-20120404111906.patch text/plain 3070 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Q0ZDVmMzBlNDY0MWY5 ZmY4ZjRmOGZiNzg0YmIwNzlmMDU2YWMwNi4uMTVmODE1NGQ4YWU5OTI0ZDkxMTNmOGQ4NTE3MzYw OTkyZGIyYTIwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA0LTA0ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRGlz YWJsZSBwYWludGluZ0dvZXNUb1dpbmRvdygpIGZvciB0aGUgcm9vdCBsYXllciB3aGVuIGZvcmNl ZCBjb21wb3NpdGluZyBtb2RlIGlzIGFjdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMxMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSSU0gUFI6IDEzNjM4MQorICAgICAgICBUaGUgQmxhY2tCZXJy eSBwb3J0IHdpbGwgdXNlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGNvZGUgcGF0aCB0bworICAg ICAgICByZW5kZXIgdGhlIHJvb3QgbGF5ZXIgaW4gc29tZSBzaXR1YXRpb25zLgorCisgICAgICAg IFRoZSBwbGFuIGlzIHRvIGRvIHRoaXMgYnkgYWN0aXZhdGluZyB0aGUgImZvcmNlIGNvbXBvc2l0 aW5nIG1vZGUiCisgICAgICAgIHNldHRpbmcsIGJ1dCB0aGF0IGluIGl0c2VsZiBkb2Vzbid0IGdl dCB1cyBhbGwgdGhlIHdheSwgc2luY2UgcGFpbnRpbmcKKyAgICAgICAgd2lsbCBzdGlsbCBnbyB0 byB3aW5kb3cgZm9yIHRoZSByb290IGxheWVyLgorCisgICAgICAgIEZpeGVkIGJ5IGFkZGluZyBh IHNwZWNpYWwgY2xhdXNlIGluCisgICAgICAgIFJlbmRlckxheWVyQmFja2luZzo6cGFpbnRpbmdH b2VzVG9XaW5kb3coKSBmb3IgUExBVEZPUk0oQkxBQ0tCRVJSWSkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCB0aGlzIGlzIGN1cnJlbnRseSBub3QgdGVzdGFibGUgd2l0aCB0aGUgQmxhY2tCZXJy eSBXZWJLaXQKKyAgICAgICAgdGVzdGluZyBpbmZyYXN0cnVjdHVyZS4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy TGF5ZXJCYWNraW5nOjpwYWludGluZ0dvZXNUb1dpbmRvdyk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5oOgorICAgICAgICAoUmVuZGVyTGF5ZXJDb21wb3NpdG9y KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6aXNJbkZvcmNlZENv bXBvc2l0aW5nTW9kZSk6CisKIDIwMTItMDQtMDMgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBldmVudCBtYXJrcyBhcmUgbWlz c2luZyBpbiB0aGUgdGltZWxpbmUgb3ZlcnZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggYWE1NWZlYTk4YTM1ZjM3ZTE0ZjU1NjNk OGFhM2ExMmRiMGYyNGIyZS4uZDc1YjYwM2NkNDBkNzk1MGU1YTk4MDdiNzk0NjY3NDY0OTBlMTYz NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2lu Zy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5j cHAKQEAgLTEwNzcsOCArMTA3NywxNCBAQCBib29sIFJlbmRlckxheWVyQmFja2luZzo6cGFpbnRp bmdHb2VzVG9XaW5kb3coKSBjb25zdAogICAgIGlmIChtX3VzaW5nVGlsZWRDYWNoZUxheWVyKQog ICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAobV9vd25pbmdMYXllci0+aXNSb290TGF5 ZXIoKSkKKyAgICBpZiAobV9vd25pbmdMYXllci0+aXNSb290TGF5ZXIoKSkgeworI2lmIFBMQVRG T1JNKEJMQUNLQkVSUlkpCisgICAgICAgIGlmIChjb21wb3NpdG9yKCktPmlzSW5Gb3JjZWRDb21w b3NpdGluZ01vZGUoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgorCiAgICAg ICAgIHJldHVybiBjb21wb3NpdG9yKCktPnJvb3RMYXllckF0dGFjaG1lbnQoKSAhPSBSZW5kZXJM YXllckNvbXBvc2l0b3I6OlJvb3RMYXllckF0dGFjaGVkVmlhRW5jbG9zaW5nRnJhbWU7CisgICAg fQogICAgIAogICAgIHJldHVybiBmYWxzZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaAppbmRleCAzZmM3ZWE5ZTEzNzNhN2Y0NTdhOGRh NGM1ZDJkOWE5ZDE1M2RiZmNmLi42ZDI4MzA0NmQwYzI1ZTE0N2Y1OWJkYzNhNjYyOGI0YTE5OTFi MmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5oCkBAIC02Niw3ICs2Niw5IEBAIHB1YmxpYzoKICAgICAvLyBUaGlzIHdpbGwgbWFrZSBh IGNvbXBvc2l0aW5nIGxheWVyIGF0IHRoZSByb290IGF1dG9tYXRpY2FsbHksIGFuZCBob29rIHVw IHRvCiAgICAgLy8gdGhlIG5hdGl2ZSB2aWV3L3dpbmRvdyBzeXN0ZW0uCiAgICAgdm9pZCBlbmFi bGVDb21wb3NpdGluZ01vZGUoYm9vbCBlbmFibGUgPSB0cnVlKTsKLSAgICAKKworICAgIGJvb2wg aXNJbkZvcmNlZENvbXBvc2l0aW5nTW9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fZm9yY2VDb21wb3Np dGluZ01vZGU7IH0KKwogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgYWNjZWxlcmF0ZWQgY29t cG9zaXRpbmcgaXMgZW5hYmxlZAogICAgIGJvb2wgaGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygp IGNvbnN0IHsgcmV0dXJuIG1faGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZzsgfQogCg== 135541 2012-04-04 03:00:36 -0700 2012-04-05 09:10:54 -0700 Patch bug-83127-20120404120034.patch text/plain 3071 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Q0ZDVmMzBlNDY0MWY5 ZmY4ZjRmOGZiNzg0YmIwNzlmMDU2YWMwNi4uNDdlYjk1NTU0NmU1NjQwNTliMzg1YmNmNzBjNWM4 MWQ3OGY1ZjFiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA0LTA0ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRGlz YWJsZSBwYWludGluZ0dvZXNUb1dpbmRvdygpIGZvciB0aGUgcm9vdCBsYXllciB3aGVuIGZvcmNl ZCBjb21wb3NpdGluZyBtb2RlIGlzIGFjdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMxMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSSU0gUFI6IDEzNjM4MQorICAgICAgICBUaGUgQmxhY2tCZXJy eSBwb3J0IHdpbGwgdXNlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGNvZGUgcGF0aCB0bworICAg ICAgICByZW5kZXIgdGhlIHJvb3QgbGF5ZXIgaW4gc29tZSBzaXR1YXRpb25zLgorCisgICAgICAg IFRoZSBwbGFuIGlzIHRvIGRvIHRoaXMgYnkgYWN0aXZhdGluZyB0aGUgImZvcmNlIGNvbXBvc2l0 aW5nIG1vZGUiCisgICAgICAgIHNldHRpbmcsIGJ1dCB0aGF0IGluIGl0c2VsZiBkb2Vzbid0IGdl dCB1cyBhbGwgdGhlIHdheSwgc2luY2UgcGFpbnRpbmcKKyAgICAgICAgd2lsbCBzdGlsbCBnbyB0 byB3aW5kb3cgZm9yIHRoZSByb290IGxheWVyLgorCisgICAgICAgIEZpeGVkIGJ5IGFkZGluZyBh IHNwZWNpYWwgY2xhdXNlIGluCisgICAgICAgIFJlbmRlckxheWVyQmFja2luZzo6cGFpbnRpbmdH b2VzVG9XaW5kb3coKSBmb3IgUExBVEZPUk0oQkxBQ0tCRVJSWSkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCB0aGlzIGlzIGN1cnJlbnRseSBub3QgdGVzdGFibGUgd2l0aCB0aGUgQmxhY2tCZXJy eSBXZWJLaXQKKyAgICAgICAgdGVzdGluZyBpbmZyYXN0cnVjdHVyZS4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy TGF5ZXJCYWNraW5nOjpwYWludGluZ0dvZXNUb1dpbmRvdyk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5oOgorICAgICAgICAoUmVuZGVyTGF5ZXJDb21wb3NpdG9y KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6aW5Gb3JjZWRDb21w b3NpdGluZ01vZGUpOiBBZGRlZC4KKwogMjAxMi0wNC0wMyAgQW5kcmV5IEtvc3lha292ICA8Y2Fz ZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGV2ZW50IG1hcmtzIGFy ZSBtaXNzaW5nIGluIHRoZSB0aW1lbGluZSBvdmVydmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAppbmRleCBhYTU1ZmVhOThhMzVmMzdlMTRm NTU2M2Q4YWEzYTEyZGIwZjI0YjJlLi4zNWU3MTZiZDlkZGUwYjg5MTlmMzc1ODAzN2I5MGMyODJj NDUyZjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJC YWNraW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNr aW5nLmNwcApAQCAtMTA3Nyw4ICsxMDc3LDE0IEBAIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjpw YWludGluZ0dvZXNUb1dpbmRvdygpIGNvbnN0CiAgICAgaWYgKG1fdXNpbmdUaWxlZENhY2hlTGF5 ZXIpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGlmIChtX293bmluZ0xheWVyLT5pc1Jv b3RMYXllcigpKQorICAgIGlmIChtX293bmluZ0xheWVyLT5pc1Jvb3RMYXllcigpKSB7CisjaWYg UExBVEZPUk0oQkxBQ0tCRVJSWSkKKyAgICAgICAgaWYgKGNvbXBvc2l0b3IoKS0+aW5Gb3JjZWRD b21wb3NpdGluZ01vZGUoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgorCiAg ICAgICAgIHJldHVybiBjb21wb3NpdG9yKCktPnJvb3RMYXllckF0dGFjaG1lbnQoKSAhPSBSZW5k ZXJMYXllckNvbXBvc2l0b3I6OlJvb3RMYXllckF0dGFjaGVkVmlhRW5jbG9zaW5nRnJhbWU7Cisg ICAgfQogICAgIAogICAgIHJldHVybiBmYWxzZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaAppbmRleCAzZmM3ZWE5ZTEzNzNhN2Y0NTdh OGRhNGM1ZDJkOWE5ZDE1M2RiZmNmLi5hNjJhZmQ0ODIxMTg3NmEyZmRiMTZhZDY0ODc0OTVhMmE3 MzQ2NzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJD b21wb3NpdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5oCkBAIC02Niw3ICs2Niw5IEBAIHB1YmxpYzoKICAgICAvLyBUaGlzIHdpbGwgbWFr ZSBhIGNvbXBvc2l0aW5nIGxheWVyIGF0IHRoZSByb290IGF1dG9tYXRpY2FsbHksIGFuZCBob29r IHVwIHRvCiAgICAgLy8gdGhlIG5hdGl2ZSB2aWV3L3dpbmRvdyBzeXN0ZW0uCiAgICAgdm9pZCBl bmFibGVDb21wb3NpdGluZ01vZGUoYm9vbCBlbmFibGUgPSB0cnVlKTsKLSAgICAKKworICAgIGJv b2wgaW5Gb3JjZWRDb21wb3NpdGluZ01vZGUoKSBjb25zdCB7IHJldHVybiBtX2ZvcmNlQ29tcG9z aXRpbmdNb2RlOyB9CisKICAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhlIGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nIGlzIGVuYWJsZWQKICAgICBib29sIGhhc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmco KSBjb25zdCB7IHJldHVybiBtX2hhc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmc7IH0KIAo=