83115 2012-04-03 21:04:16 -0700 Don't parse "show" and "hide" as valid values for display property. 2012-04-04 06:17:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson jamesr macpherson menard noel.gordon webkit.review.bot oldest_to_newest 595219 0 macpherson 2012-04-03 21:04:16 -0700 Don't parse "show" and "hide" as valid values for display property. 595220 1 135506 macpherson 2012-04-03 21:05:07 -0700 Created attachment 135506 Patch 595225 2 135506 abarth 2012-04-03 21:17:00 -0700 Comment on attachment 135506 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135506&action=review > Source/WebCore/ChangeLog:8 > + No new tests. I can haz test? 595227 3 135506 abarth 2012-04-03 21:20:46 -0700 Comment on attachment 135506 Patch This patch is obviously correct, but it seems like we could write some kind of test, even if the test wouldn't do anything when CSS_GRID_LAYOUT was enabled. If I were writing this patch, I would include that test, but I can understand why you didn't. 595234 4 135508 macpherson 2012-04-03 21:27:53 -0700 Created attachment 135508 Patch for landing 595237 5 135509 macpherson 2012-04-03 21:29:29 -0700 Created attachment 135509 Patch for landing 595249 6 135509 webkit.review.bot 2012-04-03 22:07:34 -0700 Comment on attachment 135509 Patch for landing Clearing flags on attachment: 135509 Committed r113139: <http://trac.webkit.org/changeset/113139> 595250 7 webkit.review.bot 2012-04-03 22:07:38 -0700 All reviewed patches have been landed. Closing bug. 595479 8 noel.gordon 2012-04-04 06:17:22 -0700 ChangeLog: "No new tests?" Could we amend the ChangeLog please. 135506 2012-04-03 21:05:07 -0700 2012-04-03 21:27:44 -0700 Patch bug-83115-20120404140505.patch text/plain 1428 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I2MGQzNTYwNjAyMDY5 NTY1NDczMjczNTBkZjRhMTQ4MDU1YzE3Zi4uMWU2MDg4NzU1ZDFkNjk1ODQ2NzQzYzg4NTdmYjg0 MjE3NTEyMTMwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTAzICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBEb24ndCBw YXJzZSAic2hvdyIgYW5kICJoaWRlIiBhcyB2YWxpZCB2YWx1ZXMgZm9yIGRpc3BsYXkgcHJvcGVy dHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzEx NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6aXNWYWxpZEtleXdvcmRQcm9wZXJ0eUFuZFZhbHVlKToKKwogMjAxMi0wNC0wMyAgSGlyb25v cmkgQm9ubyAgPGhib25vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBQcmV2ZW50IHNwZWxsY2hl Y2tpbmcgdGV4dCBwYXN0ZWQgdG8gYW4gZWxlbWVudCBoYXZpbmcgc3BlbGxjaGVja2luZyBkaXNh YmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCBkYWRiOGQ1ZWZjNzBlZjA2Mjc5NGM3 MzIxMTc0OTUwZDg4ZjRkZDBiLi4yOGVmNjc3ODBjMzYzYzZlMGM3ODAxNjNhNzFhYmQ0ZmU1YWU0 MTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtNTMxLDggKzUzMSw4IEBAIHN0YXRp YyBpbmxpbmUgYm9vbCBpc1ZhbGlkS2V5d29yZFByb3BlcnR5QW5kVmFsdWUoQ1NTUHJvcGVydHlJ RCBwcm9wZXJ0eUlkLCBpbnQKICNpZiBFTkFCTEUoQ1NTX0dSSURfTEFZT1VUKQogICAgICAgICBp ZiAodmFsdWVJRCA9PSBDU1NWYWx1ZVdlYmtpdEdyaWQgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZVdl YmtpdElubGluZUdyaWQpCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgYnJlYWs7 CiAjZW5kaWYKKyAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUVtcHR5Q2VsbHM6 IC8vIHNob3cgfCBoaWRlIHwgaW5oZXJpdAogICAgICAgICBpZiAodmFsdWVJRCA9PSBDU1NWYWx1 ZVNob3cgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZUhpZGUpCiAgICAgICAgICAgICByZXR1cm4gdHJ1 ZTsK 135508 2012-04-03 21:27:53 -0700 2012-04-03 21:29:19 -0700 Patch for landing bug-83115-20120404142751.patch text/plain 1424 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I2MGQzNTYwNjAyMDY5 NTY1NDczMjczNTBkZjRhMTQ4MDU1YzE3Zi4uMDg2NDA0Zjg0MzE2MTQ2NmRiZmI1NmUzNmU2NmY3 ZDk1MDMwYTM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTAzICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBEb24ndCBw YXJzZSAic2hvdyIgYW5kICJoaWRlIiBhcyB2YWxpZCB2YWx1ZXMgZm9yIGRpc3BsYXkgcHJvcGVy dHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzEx NQorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpp c1ZhbGlkS2V5d29yZFByb3BlcnR5QW5kVmFsdWUpOgorCiAyMDEyLTA0LTAzICBIaXJvbm9yaSBC b25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFByZXZlbnQgc3BlbGxjaGVja2lu ZyB0ZXh0IHBhc3RlZCB0byBhbiBlbGVtZW50IGhhdmluZyBzcGVsbGNoZWNraW5nIGRpc2FibGVk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IGRhZGI4ZDVlZmM3MGVmMDYyNzk0YzczMjEx NzQ5NTBkODhmNGRkMGIuLjI4ZWY2Nzc4MGMzNjNjNmUwYzc4MDE2M2E3MWFiZDRmZTVhZTQxM2Mg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC01MzEsOCArNTMxLDggQEAgc3RhdGljIGlu bGluZSBib29sIGlzVmFsaWRLZXl3b3JkUHJvcGVydHlBbmRWYWx1ZShDU1NQcm9wZXJ0eUlEIHBy b3BlcnR5SWQsIGludAogI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCiAgICAgICAgIGlmICh2 YWx1ZUlEID09IENTU1ZhbHVlV2Via2l0R3JpZCB8fCB2YWx1ZUlEID09IENTU1ZhbHVlV2Via2l0 SW5saW5lR3JpZCkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwotICAgICAgICBicmVhazsKICNl bmRpZgorICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1Byb3BlcnR5RW1wdHlDZWxsczogLy8g c2hvdyB8IGhpZGUgfCBpbmhlcml0CiAgICAgICAgIGlmICh2YWx1ZUlEID09IENTU1ZhbHVlU2hv dyB8fCB2YWx1ZUlEID09IENTU1ZhbHVlSGlkZSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwo= 135509 2012-04-03 21:29:29 -0700 2012-04-03 22:07:34 -0700 Patch for landing bug-83115-20120404142926.patch text/plain 2295 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I2MGQzNTYwNjAyMDY5 NTY1NDczMjczNTBkZjRhMTQ4MDU1YzE3Zi4uMDg2NDA0Zjg0MzE2MTQ2NmRiZmI1NmUzNmU2NmY3 ZDk1MDMwYTM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTAzICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBEb24ndCBw YXJzZSAic2hvdyIgYW5kICJoaWRlIiBhcyB2YWxpZCB2YWx1ZXMgZm9yIGRpc3BsYXkgcHJvcGVy dHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzEx NQorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpp c1ZhbGlkS2V5d29yZFByb3BlcnR5QW5kVmFsdWUpOgorCiAyMDEyLTA0LTAzICBIaXJvbm9yaSBC b25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFByZXZlbnQgc3BlbGxjaGVja2lu ZyB0ZXh0IHBhc3RlZCB0byBhbiBlbGVtZW50IGhhdmluZyBzcGVsbGNoZWNraW5nIGRpc2FibGVk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IGRhZGI4ZDVlZmM3MGVmMDYyNzk0YzczMjEx NzQ5NTBkODhmNGRkMGIuLjI4ZWY2Nzc4MGMzNjNjNmUwYzc4MDE2M2E3MWFiZDRmZTVhZTQxM2Mg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC01MzEsOCArNTMxLDggQEAgc3RhdGljIGlu bGluZSBib29sIGlzVmFsaWRLZXl3b3JkUHJvcGVydHlBbmRWYWx1ZShDU1NQcm9wZXJ0eUlEIHBy b3BlcnR5SWQsIGludAogI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCiAgICAgICAgIGlmICh2 YWx1ZUlEID09IENTU1ZhbHVlV2Via2l0R3JpZCB8fCB2YWx1ZUlEID09IENTU1ZhbHVlV2Via2l0 SW5saW5lR3JpZCkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwotICAgICAgICBicmVhazsKICNl bmRpZgorICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1Byb3BlcnR5RW1wdHlDZWxsczogLy8g c2hvdyB8IGhpZGUgfCBpbmhlcml0CiAgICAgICAgIGlmICh2YWx1ZUlEID09IENTU1ZhbHVlU2hv dyB8fCB2YWx1ZUlEID09IENTU1ZhbHVlSGlkZSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZGlzcGxheS1uby1zaG93LWhpZGUtZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2Rpc3BsYXktbm8tc2hvdy1oaWRlLWV4 cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNWNjODIyNmE0NmQ3NGMzZDZiMjdiNWJmMzk3NDdiNDUz ZWQ3MDJhYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2Rpc3BsYXkt bm8tc2hvdy1oaWRlLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwzIEBACis8IURPQ1RZUEUgaHRt bD4KKzxkaXY+VGhpcyB0ZXh0IHNob3VsZCBiZSB2aXNpYmxlLjwvZGl2PgorPGRpdj5UaGlzIHRl eHQgc2hvdWxkIGJlIHZpc2libGUuPC9kaXY+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9kaXNwbGF5LW5vLXNob3ctaGlkZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZGlz cGxheS1uby1zaG93LWhpZGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45ZTdiN2Y3YjVkOThkZGZjNTgwNzA3 YzQyM2RhNTY5ODZiYzNjZGVkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9j c3MvZGlzcGxheS1uby1zaG93LWhpZGUuaHRtbApAQCAtMCwwICsxLDMgQEAKKzwhRE9DVFlQRSBo dG1sPgorPGRpdiBzdHlsZT0iZGlzcGxheTpzaG93Ij5UaGlzIHRleHQgc2hvdWxkIGJlIHZpc2li bGUuPC9kaXY+Cis8ZGl2IHN0eWxlPSJkaXNwbGF5OmhpZGUiPlRoaXMgdGV4dCBzaG91bGQgYmUg dmlzaWJsZS48L2Rpdj4K