<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>83106</bug_id>
          
          <creation_ts>2012-04-03 19:40:33 -0700</creation_ts>
          <short_desc>Call histogramEnumeration directly</short_desc>
          <delta_ts>2012-04-04 15:55:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>82948</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Pilgrim (Google)">pilgrim</reporter>
          <assigned_to name="Mark Pilgrim (Google)">pilgrim</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>fishd</cc>
    
    <cc>haraken</cc>
    
    <cc>japhet</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>595156</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2012-04-03 19:40:33 -0700</bug_when>
    <thetext>Call histogramEnumeration directly</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595157</commentid>
    <comment_count>1</comment_count>
      <attachid>135488</attachid>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2012-04-03 19:41:05 -0700</bug_when>
    <thetext>Created attachment 135488
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595158</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2012-04-03 19:42:04 -0700</bug_when>
    <thetext>Fails to compile WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp, can not find &lt;public/Platform.h&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595170</commentid>
    <comment_count>3</comment_count>
      <attachid>135488</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-04-03 20:00:57 -0700</bug_when>
    <thetext>Comment on attachment 135488
Patch

Attachment 135488 did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12325463</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595235</commentid>
    <comment_count>4</comment_count>
      <attachid>135488</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-04-03 21:28:02 -0700</bug_when>
    <thetext>Comment on attachment 135488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135488&amp;action=review

&gt; Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:128
&gt; -        PlatformSupport::histogramEnumeration(name, sample, boundaryValue);
&gt; +        WebKit::Platform::current()-&gt;histogramEnumeration(name, sample, boundaryValue);

This should use histogramEnumeration from HistogramSupport.h (because this file is outside the platform directory).

&gt; Source/WebCore/platform/chromium/PlatformSupport.h:-265
&gt; -    static void histogramEnumeration(const char* name, int sample, int boundaryValue);

Please remove the implementation of this function in PlatformSupport.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595524</commentid>
    <comment_count>5</comment_count>
      <attachid>135587</attachid>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2012-04-04 07:37:35 -0700</bug_when>
    <thetext>Created attachment 135587
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595525</commentid>
    <comment_count>6</comment_count>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2012-04-04 07:38:20 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 135488 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=135488&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:128
&gt; &gt; -        PlatformSupport::histogramEnumeration(name, sample, boundaryValue);
&gt; &gt; +        WebKit::Platform::current()-&gt;histogramEnumeration(name, sample, boundaryValue);
&gt; 
&gt; This should use histogramEnumeration from HistogramSupport.h (because this file is outside the platform directory).

Done.

&gt; 
&gt; &gt; Source/WebCore/platform/chromium/PlatformSupport.h:-265
&gt; &gt; -    static void histogramEnumeration(const char* name, int sample, int boundaryValue);
&gt; 
&gt; Please remove the implementation of this function in PlatformSupport.cpp.

Done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595673</commentid>
    <comment_count>7</comment_count>
      <attachid>135587</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-04-04 10:34:10 -0700</bug_when>
    <thetext>Comment on attachment 135587
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135587&amp;action=review

&gt; Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:37
&gt; +#if !PLATFORM(QT)
&gt; +#include &quot;HistogramSupport.h&quot;
&gt; +#endif

This should be included unconditionally.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595677</commentid>
    <comment_count>8</comment_count>
      <attachid>135587</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-04-04 10:35:32 -0700</bug_when>
    <thetext>Comment on attachment 135587
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135587&amp;action=review

&gt; Source/WebCore/ChangeLog:7
&gt; +        Call histogramEnumeration directly
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=83106
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +

It would also be good to have some text in the ChangeLog referencing either the meta bug or the webkit-dev post.  It&apos;s fine to say that this change is part of a series of patches to XYZ.  You just want someone who starts with this patch to have a breadcrumb trail back to understanding what&apos;s going on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595955</commentid>
    <comment_count>9</comment_count>
      <attachid>135687</attachid>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2012-04-04 14:38:50 -0700</bug_when>
    <thetext>Created attachment 135687
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595956</commentid>
    <comment_count>10</comment_count>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2012-04-04 14:39:18 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 135587 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=135587&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:37
&gt; &gt; +#if !PLATFORM(QT)
&gt; &gt; +#include &quot;HistogramSupport.h&quot;
&gt; &gt; +#endif
&gt; 
&gt; This should be included unconditionally.

Done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595957</commentid>
    <comment_count>11</comment_count>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2012-04-04 14:39:29 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (From update of attachment 135587 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=135587&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/ChangeLog:7
&gt; &gt; +        Call histogramEnumeration directly
&gt; &gt; +        https://bugs.webkit.org/show_bug.cgi?id=83106
&gt; &gt; +
&gt; &gt; +        Reviewed by NOBODY (OOPS!).
&gt; &gt; +
&gt; 
&gt; It would also be good to have some text in the ChangeLog referencing either the meta bug or the webkit-dev post.  It&apos;s fine to say that this change is part of a series of patches to XYZ.  You just want someone who starts with this patch to have a breadcrumb trail back to understanding what&apos;s going on.

Done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>595964</commentid>
    <comment_count>12</comment_count>
      <attachid>135687</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-04-04 14:46:17 -0700</bug_when>
    <thetext>Comment on attachment 135687
Patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>596048</commentid>
    <comment_count>13</comment_count>
      <attachid>135687</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-04-04 15:55:26 -0700</bug_when>
    <thetext>Comment on attachment 135687
Patch

Clearing flags on attachment: 135687

Committed r113255: &lt;http://trac.webkit.org/changeset/113255&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>596049</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-04-04 15:55:42 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>135488</attachid>
            <date>2012-04-03 19:41:05 -0700</date>
            <delta_ts>2012-04-04 07:37:31 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-83106-20120403224055.patch</filename>
            <type>text/plain</type>
            <size>6231</size>
            <attacher name="Mark Pilgrim (Google)">pilgrim</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzEyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTAzICBNYXJrIFBp
bGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBDYWxsIGhpc3RvZ3JhbUVu
dW1lcmF0aW9uIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD04MzEwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEluc3BlY3RvckZyb250ZW5kSG9zdEN1
c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoaXN0b2dyYW1FbnVtZXJhdGlvbik6CisgICAg
ICAgICogcGxhdGZvcm0vY2hyb21pdW0vSGlzdG9ncmFtU3VwcG9ydENocm9taXVtLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6Okhpc3RvZ3JhbVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKToK
KyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaDoKKyAgICAgICAg
KFBsYXRmb3JtU3VwcG9ydCk6CisKIDIwMTItMDQtMDMgIEhpcm9ub3JpIEJvbm8gIDxoYm9ub0Bj
aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUHJldmVudCBzcGVsbGNoZWNraW5nIHRleHQgcGFzdGVk
IHRvIGFuIGVsZW1lbnQgaGF2aW5nIHNwZWxsY2hlY2tpbmcgZGlzYWJsZWQKSW5kZXg6IFNvdXJj
ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEluc3BlY3RvckZyb250ZW5kSG9zdEN1c3Rv
bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4
SW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3VzdG9tLmNwcAkocmV2aXNpb24gMTEzMDE3KQorKysgU291
cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3Vz
dG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzYsNyArMzYsNyBAQAogI2luY2x1ZGUgIkluc3Bl
Y3RvckZyb250ZW5kQ2xpZW50LmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yRnJvbnRlbmRIb3N0Lmgi
CiAjaWYgIVBMQVRGT1JNKFFUKQotI2luY2x1ZGUgIlBsYXRmb3JtU3VwcG9ydC5oIgorI2luY2x1
ZGUgPHB1YmxpYy9QbGF0Zm9ybS5oPgogI2VuZGlmCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcu
aCIKIApAQCAtMTI1LDcgKzEyNSw3IEBAIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gaGlz
dG9ncmFtRW4KIAogICAgIGludCBzYW1wbGUgPSBhcmdzWzBdLT5Ub0ludDMyKCktPlZhbHVlKCk7
CiAgICAgaWYgKHNhbXBsZSA8IGJvdW5kYXJ5VmFsdWUpCi0gICAgICAgIFBsYXRmb3JtU3VwcG9y
dDo6aGlzdG9ncmFtRW51bWVyYXRpb24obmFtZSwgc2FtcGxlLCBib3VuZGFyeVZhbHVlKTsKKyAg
ICAgICAgV2ViS2l0OjpQbGF0Zm9ybTo6Y3VycmVudCgpLT5oaXN0b2dyYW1FbnVtZXJhdGlvbihu
YW1lLCBzYW1wbGUsIGJvdW5kYXJ5VmFsdWUpOwogCiAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQo
KTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0hpc3RvZ3JhbVN1
cHBvcnRDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Y2hyb21pdW0vSGlzdG9ncmFtU3VwcG9ydENocm9taXVtLmNwcAkocmV2aXNpb24gMTEzMDE3KQor
KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vSGlzdG9ncmFtU3VwcG9ydENocm9t
aXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEsMTMgKzMxLDEzIEBACiAjaW5jbHVkZSAiY29u
ZmlnLmgiCiAjaW5jbHVkZSAiSGlzdG9ncmFtU3VwcG9ydC5oIgogCi0jaW5jbHVkZSAiUGxhdGZv
cm1TdXBwb3J0LmgiCisjaW5jbHVkZSA8cHVibGljL1BsYXRmb3JtLmg+CiAKIG5hbWVzcGFjZSBX
ZWJDb3JlIHsKIAogdm9pZCBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbihj
b25zdCBjaGFyKiBuYW1lLCBpbnQgc2FtcGxlLCBpbnQgYm91bmRhcnlWYWx1ZSkKIHsKLSAgICBQ
bGF0Zm9ybVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKG5hbWUsIHNhbXBsZSwgYm91bmRh
cnlWYWx1ZSk7CisgICAgV2ViS2l0OjpQbGF0Zm9ybTo6Y3VycmVudCgpLT5oaXN0b2dyYW1FbnVt
ZXJhdGlvbihuYW1lLCBzYW1wbGUsIGJvdW5kYXJ5VmFsdWUpOwogfQogCiB9IC8vIG5hbWVzcGFj
ZSBXZWJDb3JlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9y
bVN1cHBvcnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1
bS9QbGF0Zm9ybVN1cHBvcnQuaAkocmV2aXNpb24gMTEzMDE3KQorKysgU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1TdXBwb3J0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI2
Miw3ICsyNjIsNiBAQCBwdWJsaWM6CiAgICAgLy8gU3RhdHNDb3VudGVycyAtLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICAgICBzdGF0aWMgdm9p
ZCBpbmNyZW1lbnRTdGF0c0NvdW50ZXIoY29uc3QgY2hhciogbmFtZSk7CiAgICAgc3RhdGljIHZv
aWQgaGlzdG9ncmFtQ3VzdG9tQ291bnRzKGNvbnN0IGNoYXIqIG5hbWUsIGludCBzYW1wbGUsIGlu
dCBtaW4sIGludCBtYXgsIGludCBidWNrZXRDb3VudCk7Ci0gICAgc3RhdGljIHZvaWQgaGlzdG9n
cmFtRW51bWVyYXRpb24oY29uc3QgY2hhciogbmFtZSwgaW50IHNhbXBsZSwgaW50IGJvdW5kYXJ5
VmFsdWUpOwogCiAgICAgLy8gU3VkZGVuIFRlcm1pbmF0aW9uCiAgICAgc3RhdGljIHZvaWQgc3Vk
ZGVuVGVybWluYXRpb25DaGFuZ2VkKGJvb2wgZW5hYmxlZCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0
L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVt
L0NoYW5nZUxvZwkocmV2aXNpb24gMTEzMTI5KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNC0wMyAgTWFy
ayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2FsbCBoaXN0b2dy
YW1FbnVtZXJhdGlvbiBkaXJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9ODMxMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp
dDo6Q2hyb21lQ2xpZW50SW1wbDo6c2hvdWxkUnVuTW9kYWxEaWFsb2dEdXJpbmdQYWdlRGlzbWlz
c2FsKToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpX
ZWJWaWV3SW1wbDo6c2V0SXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlKToKKwogMjAxMi0w
NC0wMyAgSWFuIFZvbGxpY2sgIDx2b2xsaWNrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hy
b21pdW1dIEluY2x1ZGUgSW1hZ2UuaCBpbiBUZXh0RmllbGREZWNvcmF0b3JJbXBsLmNwcApJbmRl
eDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJ
KHJldmlzaW9uIDExMzAxNykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNs
aWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDEsNiArMTAxLDcgQEAKICNpbmNsdWRl
ICJXZWJXaW5kb3dGZWF0dXJlcy5oIgogI2luY2x1ZGUgIldpbmRvd0ZlYXR1cmVzLmgiCiAjaW5j
bHVkZSAiV3JhcHBlZFJlc291cmNlUmVxdWVzdC5oIgorI2luY2x1ZGUgPHB1YmxpYy9QbGF0Zm9y
bS5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KICNpbmNsdWRlIDx3dGYv
dGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oPgogI2luY2x1ZGUgPHd0Zi91bmljb2RlL0NoYXJhY3Rl
ck5hbWVzLmg+CkBAIC0xMDIwLDcgKzEwMjEsNyBAQCBib29sIENocm9tZUNsaWVudEltcGw6OnNo
b3VsZFJ1bk1vZGFsRGlhCiAgICAgaW50IGRpc21pc3NhbCA9IHN0YXRpY19jYXN0PGludD4oZGlz
bWlzc2FsVHlwZSkgLSAxOyAvLyBFeGNsdWRlIE5vRGlzbWlzc2FsLgogICAgIEFTU0VSVCgwIDw9
IGRpc21pc3NhbCAmJiBkaXNtaXNzYWwgPCBzdGF0aWNfY2FzdDxpbnQ+KGFycmF5c2l6ZShrRGlz
bWlzc2FscykpKTsKIAotICAgIFBsYXRmb3JtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24o
IlJlbmRlcmVyLk1vZGFsRGlhbG9nc0R1cmluZ1BhZ2VEaXNtaXNzYWwiLCBkaXNtaXNzYWwgKiBh
cnJheXNpemUoa0RpYWxvZ3MpICsgZGlhbG9nLCBhcnJheXNpemUoa0RpYWxvZ3MpICogYXJyYXlz
aXplKGtEaXNtaXNzYWxzKSk7CisgICAgV2ViS2l0OjpQbGF0Zm9ybTo6Y3VycmVudCgpLT5oaXN0
b2dyYW1FbnVtZXJhdGlvbigiUmVuZGVyZXIuTW9kYWxEaWFsb2dzRHVyaW5nUGFnZURpc21pc3Nh
bCIsIGRpc21pc3NhbCAqIGFycmF5c2l6ZShrRGlhbG9ncykgKyBkaWFsb2csIGFycmF5c2l6ZShr
RGlhbG9ncykgKiBhcnJheXNpemUoa0Rpc21pc3NhbHMpKTsKIAogICAgIG1fd2ViVmlldy0+bWFp
bkZyYW1lKCktPmFkZE1lc3NhZ2VUb0NvbnNvbGUoV2ViQ29uc29sZU1lc3NhZ2UoV2ViQ29uc29s
ZU1lc3NhZ2U6OkxldmVsRXJyb3IsIG1ha2VTdHJpbmcoIkJsb2NrZWQgIiwga0RpYWxvZ3NbZGlh
bG9nXSwgIignIiwgZGlhbG9nTWVzc2FnZSwgIicpIGR1cmluZyAiLCBrRGlzbWlzc2Fsc1tkaXNt
aXNzYWxdLCAiLiIpKSk7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp
ZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW
aWV3SW1wbC5jcHAJKHJldmlzaW9uIDExMzAxNykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v
c3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ0LDYgKzE0NCw3IEBACiAj
aW5jbHVkZSAicGxhdGZvcm0vV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgiCiAjaW5jbHVkZSAicGxh
dGZvcm0vV2ViU3RyaW5nLmgiCiAjaW5jbHVkZSAicGxhdGZvcm0vV2ViVmVjdG9yLmgiCisjaW5j
bHVkZSA8cHVibGljL1BsYXRmb3JtLmg+CiAjaW5jbHVkZSA8cHVibGljL1dlYkZsb2F0UG9pbnQu
aD4KICNpbmNsdWRlIDxwdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaD4KICNpbmNsdWRlIDxw
dWJsaWMvV2ViTGF5ZXIuaD4KQEAgLTMyOTAsNyArMzI5MSw3IEBAIHByaXZhdGU6CiAKIHZvaWQg
V2ViVmlld0ltcGw6OnNldElzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZShib29sIGFjdGl2
ZSkKIHsKLSAgICBQbGF0Zm9ybVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKCJHUFUuc2V0
SXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlIiwgYWN0aXZlICogMiArIG1faXNBY2NlbGVy
YXRlZENvbXBvc2l0aW5nQWN0aXZlLCA0KTsKKyAgICBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50
KCktPmhpc3RvZ3JhbUVudW1lcmF0aW9uKCJHUFUuc2V0SXNBY2NlbGVyYXRlZENvbXBvc2l0aW5n
QWN0aXZlIiwgYWN0aXZlICogMiArIG1faXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlLCA0
KTsKIAogICAgIGlmIChtX2lzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSA9PSBhY3RpdmUp
CiAgICAgICAgIHJldHVybjsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>135587</attachid>
            <date>2012-04-04 07:37:35 -0700</date>
            <delta_ts>2012-04-04 14:38:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-83106-20120404103724.patch</filename>
            <type>text/plain</type>
            <size>7127</size>
            <attacher name="Mark Pilgrim (Google)">pilgrim</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzE4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTA0ICBNYXJrIFBp
bGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBDYWxsIGhpc3RvZ3JhbUVu
dW1lcmF0aW9uIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD04MzEwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3Vz
dG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKToKKyAgICAg
ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9IaXN0b2dyYW1TdXBwb3J0Q2hyb21pdW0uY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6SGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24pOgor
ICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAo
UGxhdGZvcm1TdXBwb3J0KToKKwogMjAxMi0wNC0wNCAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5t
ZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZS1hZGQgdmFyaWFibGUgbmFtZXMgaW4g
Q1NTIHJlbGF0ZWQgaGVhZGVycyB0byBoZWxwIHVuZGVyc3RhbmRpbmcgdGhlIG1lYW5pbmcgb2Yg
dGhlbS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEluc3BlY3Rv
ckZyb250ZW5kSG9zdEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmlu
ZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3VzdG9tLmNwcAkocmV2aXNp
b24gMTEzMTgzKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVj
dG9yRnJvbnRlbmRIb3N0Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIsMTIgKzMyLDEy
IEBACiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKICNpbmNsdWRlICJWOEluc3BlY3RvckZyb250ZW5k
SG9zdC5oIgogCisjaWYgIVBMQVRGT1JNKFFUKQorI2luY2x1ZGUgIkhpc3RvZ3JhbVN1cHBvcnQu
aCIKKyNlbmRpZgogI2luY2x1ZGUgIkluc3BlY3RvckNvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJJ
bnNwZWN0b3JGcm9udGVuZENsaWVudC5oIgogI2luY2x1ZGUgIkluc3BlY3RvckZyb250ZW5kSG9z
dC5oIgotI2lmICFQTEFURk9STShRVCkKLSNpbmNsdWRlICJQbGF0Zm9ybVN1cHBvcnQuaCIKLSNl
bmRpZgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKICNpbmNsdWRlICJWOEJpbmRpbmcu
aCIKQEAgLTEyNSw3ICsxMjUsNyBAQCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGhpc3Rv
Z3JhbUVuCiAKICAgICBpbnQgc2FtcGxlID0gYXJnc1swXS0+VG9JbnQzMigpLT5WYWx1ZSgpOwog
ICAgIGlmIChzYW1wbGUgPCBib3VuZGFyeVZhbHVlKQotICAgICAgICBQbGF0Zm9ybVN1cHBvcnQ6
Omhpc3RvZ3JhbUVudW1lcmF0aW9uKG5hbWUsIHNhbXBsZSwgYm91bmRhcnlWYWx1ZSk7CisgICAg
ICAgIEhpc3RvZ3JhbVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKG5hbWUsIHNhbXBsZSwg
Ym91bmRhcnlWYWx1ZSk7CiAKICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogfQpJbmRleDog
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vSGlzdG9ncmFtU3VwcG9ydENocm9taXVt
LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9IaXN0
b2dyYW1TdXBwb3J0Q2hyb21pdW0uY3BwCShyZXZpc2lvbiAxMTMxODMpCisrKyBTb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9IaXN0b2dyYW1TdXBwb3J0Q2hyb21pdW0uY3BwCSh3b3Jr
aW5nIGNvcHkpCkBAIC0zMSwxMyArMzEsMTMgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs
dWRlICJIaXN0b2dyYW1TdXBwb3J0LmgiCiAKLSNpbmNsdWRlICJQbGF0Zm9ybVN1cHBvcnQuaCIK
KyNpbmNsdWRlIDxwdWJsaWMvUGxhdGZvcm0uaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2
b2lkIEhpc3RvZ3JhbVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKGNvbnN0IGNoYXIqIG5h
bWUsIGludCBzYW1wbGUsIGludCBib3VuZGFyeVZhbHVlKQogewotICAgIFBsYXRmb3JtU3VwcG9y
dDo6aGlzdG9ncmFtRW51bWVyYXRpb24obmFtZSwgc2FtcGxlLCBib3VuZGFyeVZhbHVlKTsKKyAg
ICBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmhpc3RvZ3JhbUVudW1lcmF0aW9uKG5hbWUs
IHNhbXBsZSwgYm91bmRhcnlWYWx1ZSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5k
ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3VwcG9ydC5oCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3Vw
cG9ydC5oCShyZXZpc2lvbiAxMTMxODMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv
bWl1bS9QbGF0Zm9ybVN1cHBvcnQuaAkod29ya2luZyBjb3B5KQpAQCAtMjYxLDcgKzI2MSw2IEBA
IHB1YmxpYzoKIAogICAgIC8vIFN0YXRzQ291bnRlcnMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAgICAgc3RhdGljIHZvaWQgaGlzdG9ncmFt
Q3VzdG9tQ291bnRzKGNvbnN0IGNoYXIqIG5hbWUsIGludCBzYW1wbGUsIGludCBtaW4sIGludCBt
YXgsIGludCBidWNrZXRDb3VudCk7Ci0gICAgc3RhdGljIHZvaWQgaGlzdG9ncmFtRW51bWVyYXRp
b24oY29uc3QgY2hhciogbmFtZSwgaW50IHNhbXBsZSwgaW50IGJvdW5kYXJ5VmFsdWUpOwogCiAg
ICAgLy8gU3VkZGVuIFRlcm1pbmF0aW9uCiAgICAgc3RhdGljIHZvaWQgc3VkZGVuVGVybWluYXRp
b25DaGFuZ2VkKGJvb2wgZW5hYmxlZCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No
YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwko
cmV2aXNpb24gMTEzMTg3KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdv
cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNC0wNCAgTWFyayBQaWxncmltICA8
cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2FsbCBoaXN0b2dyYW1FbnVtZXJhdGlv
biBkaXJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9ODMxMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xp
ZW50SW1wbDo6c2hvdWxkUnVuTW9kYWxEaWFsb2dEdXJpbmdQYWdlRGlzbWlzc2FsKToKKyAgICAg
ICAgKiBzcmMvUGxhdGZvcm1TdXBwb3J0LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAg
ICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpz
ZXRJc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUpOgorCiAyMDEyLTA0LTA0ICBIYW5zIFdl
bm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU3BlZWNoUmVjb2duaXpl
ci5oOiBhZGQgbWlzc2luZyBmb3J3YXJkIGRlY2xhcmF0aW9uCkluZGV4OiBTb3VyY2UvV2ViS2l0
L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gMTEzMTgz
KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHdv
cmtpbmcgY29weSkKQEAgLTEwMSw2ICsxMDEsNyBAQAogI2luY2x1ZGUgIldlYldpbmRvd0ZlYXR1
cmVzLmgiCiAjaW5jbHVkZSAiV2luZG93RmVhdHVyZXMuaCIKICNpbmNsdWRlICJXcmFwcGVkUmVz
b3VyY2VSZXF1ZXN0LmgiCisjaW5jbHVkZSA8cHVibGljL1BsYXRmb3JtLmg+CiAjaW5jbHVkZSA8
d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0NvbmNh
dGVuYXRlLmg+CiAjaW5jbHVkZSA8d3RmL3VuaWNvZGUvQ2hhcmFjdGVyTmFtZXMuaD4KQEAgLTEw
MjAsNyArMTAyMSw3IEBAIGJvb2wgQ2hyb21lQ2xpZW50SW1wbDo6c2hvdWxkUnVuTW9kYWxEaWEK
ICAgICBpbnQgZGlzbWlzc2FsID0gc3RhdGljX2Nhc3Q8aW50PihkaXNtaXNzYWxUeXBlKSAtIDE7
IC8vIEV4Y2x1ZGUgTm9EaXNtaXNzYWwuCiAgICAgQVNTRVJUKDAgPD0gZGlzbWlzc2FsICYmIGRp
c21pc3NhbCA8IHN0YXRpY19jYXN0PGludD4oYXJyYXlzaXplKGtEaXNtaXNzYWxzKSkpOwogCi0g
ICAgUGxhdGZvcm1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiUmVuZGVyZXIuTW9kYWxE
aWFsb2dzRHVyaW5nUGFnZURpc21pc3NhbCIsIGRpc21pc3NhbCAqIGFycmF5c2l6ZShrRGlhbG9n
cykgKyBkaWFsb2csIGFycmF5c2l6ZShrRGlhbG9ncykgKiBhcnJheXNpemUoa0Rpc21pc3NhbHMp
KTsKKyAgICBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmhpc3RvZ3JhbUVudW1lcmF0aW9u
KCJSZW5kZXJlci5Nb2RhbERpYWxvZ3NEdXJpbmdQYWdlRGlzbWlzc2FsIiwgZGlzbWlzc2FsICog
YXJyYXlzaXplKGtEaWFsb2dzKSArIGRpYWxvZywgYXJyYXlzaXplKGtEaWFsb2dzKSAqIGFycmF5
c2l6ZShrRGlzbWlzc2FscykpOwogCiAgICAgbV93ZWJWaWV3LT5tYWluRnJhbWUoKS0+YWRkTWVz
c2FnZVRvQ29uc29sZShXZWJDb25zb2xlTWVzc2FnZShXZWJDb25zb2xlTWVzc2FnZTo6TGV2ZWxF
cnJvciwgbWFrZVN0cmluZygiQmxvY2tlZCAiLCBrRGlhbG9nc1tkaWFsb2ddLCAiKCciLCBkaWFs
b2dNZXNzYWdlLCAiJykgZHVyaW5nICIsIGtEaXNtaXNzYWxzW2Rpc21pc3NhbF0sICIuIikpKTsK
IApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvUGxhdGZvcm1TdXBwb3J0LmNwcAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQu
Y3BwCShyZXZpc2lvbiAxMTMxODMpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0
Zm9ybVN1cHBvcnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MTgsMTEgKzcxOCw2IEBAIHZvaWQg
UGxhdGZvcm1TdXBwb3J0OjpoaXN0b2dyYW1DdXN0b21Db3UKICAgICB3ZWJLaXRQbGF0Zm9ybVN1
cHBvcnQoKS0+aGlzdG9ncmFtQ3VzdG9tQ291bnRzKG5hbWUsIHNhbXBsZSwgbWluLCBtYXgsIGJ1
Y2tldENvdW50KTsKIH0KIAotdm9pZCBQbGF0Zm9ybVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0
aW9uKGNvbnN0IGNoYXIqIG5hbWUsIGludCBzYW1wbGUsIGludCBib3VuZGFyeVZhbHVlKQotewot
ICAgIHdlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5oaXN0b2dyYW1FbnVtZXJhdGlvbihuYW1lLCBz
YW1wbGUsIGJvdW5kYXJ5VmFsdWUpOwotfQotCiAvLyBTdWRkZW4gVGVybWluYXRpb24gLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKIHZv
aWQgUGxhdGZvcm1TdXBwb3J0OjpzdWRkZW5UZXJtaW5hdGlvbkNoYW5nZWQoYm9vbCBlbmFibGVk
KQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2
aXNpb24gMTEzMTgzKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQsNiArMTQ0LDcgQEAKICNpbmNsdWRlICJwbGF0Zm9y
bS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJTdHJpbmcu
aCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJWZWN0b3IuaCIKKyNpbmNsdWRlIDxwdWJsaWMvUGxh
dGZvcm0uaD4KICNpbmNsdWRlIDxwdWJsaWMvV2ViRmxvYXRQb2ludC5oPgogI2luY2x1ZGUgPHB1
YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oPgogI2luY2x1ZGUgPHB1YmxpYy9XZWJMYXllci5o
PgpAQCAtMzI5Myw3ICszMjk0LDcgQEAgcHJpdmF0ZToKIAogdm9pZCBXZWJWaWV3SW1wbDo6c2V0
SXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlKGJvb2wgYWN0aXZlKQogewotICAgIFBsYXRm
b3JtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24oIkdQVS5zZXRJc0FjY2VsZXJhdGVkQ29t
cG9zaXRpbmdBY3RpdmUiLCBhY3RpdmUgKiAyICsgbV9pc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdB
Y3RpdmUsIDQpOworICAgIFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+aGlzdG9ncmFtRW51
bWVyYXRpb24oIkdQVS5zZXRJc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUiLCBhY3RpdmUg
KiAyICsgbV9pc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUsIDQpOwogCiAgICAgaWYgKG1f
aXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlID09IGFjdGl2ZSkKICAgICAgICAgcmV0dXJu
Owo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>135687</attachid>
            <date>2012-04-04 14:38:50 -0700</date>
            <delta_ts>2012-04-04 15:55:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-83106-20120404173839.patch</filename>
            <type>text/plain</type>
            <size>6285</size>
            <attacher name="Mark Pilgrim (Google)">pilgrim</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzI0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTA0ICBNYXJrIFBp
bGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBDYWxsIGhpc3RvZ3JhbUVu
dW1lcmF0aW9uIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD04MzEwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFBhcnQgb2YgYSByZWZhY3RvcmluZyBwcm9qZWN0IHRvIHJlbW92ZSB0aGUgUGxh
dGZvcm1TdXBwb3J0CisgICAgICAgIGFic3RyYWN0aW9uIGZyb20gc29tZSBmdW5jdGlvbnMuIFNl
ZSBidWcgODI5NDguCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhJbnNwZWN0b3JG
cm9udGVuZEhvc3RDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6aGlzdG9ncmFtRW51bWVy
YXRpb24pOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0hpc3RvZ3JhbVN1cHBvcnRDaHJv
bWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1F
bnVtZXJhdGlvbik6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1TdXBwb3J0
Lmg6CisgICAgICAgIChQbGF0Zm9ybVN1cHBvcnQpOgorCiAyMDEyLTA0LTA0ICBEYW5pZWwgU2ll
dmVycyAgPHNpZXZlcnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gQWx3YXlz
IHNraXAgZHJhdyBhbmQgcmVhZGJhY2sgaWYgdGhlcmUgaXMgbm90aGluZwpJbmRleDogU291cmNl
L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3VzdG9t
LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJ
bnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0b20uY3BwCShyZXZpc2lvbiAxMTMyNDApCisrKyBTb3Vy
Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0
b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiwxMiArMzIsMTAgQEAKICNpZiBFTkFCTEUoSU5T
UEVDVE9SKQogI2luY2x1ZGUgIlY4SW5zcGVjdG9yRnJvbnRlbmRIb3N0LmgiCiAKKyNpbmNsdWRl
ICJIaXN0b2dyYW1TdXBwb3J0LmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yQ29udHJvbGxlci5oIgog
I2luY2x1ZGUgIkluc3BlY3RvckZyb250ZW5kQ2xpZW50LmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9y
RnJvbnRlbmRIb3N0LmgiCi0jaWYgIVBMQVRGT1JNKFFUKQotI2luY2x1ZGUgIlBsYXRmb3JtU3Vw
cG9ydC5oIgotI2VuZGlmCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKIAogI2luY2x1ZGUg
IlY4QmluZGluZy5oIgpAQCAtMTI1LDcgKzEyMyw3IEBAIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpW
YWx1ZT4gaGlzdG9ncmFtRW4KIAogICAgIGludCBzYW1wbGUgPSBhcmdzWzBdLT5Ub0ludDMyKCkt
PlZhbHVlKCk7CiAgICAgaWYgKHNhbXBsZSA8IGJvdW5kYXJ5VmFsdWUpCi0gICAgICAgIFBsYXRm
b3JtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24obmFtZSwgc2FtcGxlLCBib3VuZGFyeVZh
bHVlKTsKKyAgICAgICAgSGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24obmFt
ZSwgc2FtcGxlLCBib3VuZGFyeVZhbHVlKTsKIAogICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7
CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9IaXN0b2dyYW1TdXBw
b3J0Q2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2No
cm9taXVtL0hpc3RvZ3JhbVN1cHBvcnRDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDExMzI0MCkKKysr
IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0hpc3RvZ3JhbVN1cHBvcnRDaHJvbWl1
bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDEzICszMSwxMyBAQAogI2luY2x1ZGUgImNvbmZp
Zy5oIgogI2luY2x1ZGUgIkhpc3RvZ3JhbVN1cHBvcnQuaCIKIAotI2luY2x1ZGUgIlBsYXRmb3Jt
U3VwcG9ydC5oIgorI2luY2x1ZGUgPHB1YmxpYy9QbGF0Zm9ybS5oPgogCiBuYW1lc3BhY2UgV2Vi
Q29yZSB7CiAKIHZvaWQgSGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24oY29u
c3QgY2hhciogbmFtZSwgaW50IHNhbXBsZSwgaW50IGJvdW5kYXJ5VmFsdWUpCiB7Ci0gICAgUGxh
dGZvcm1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbihuYW1lLCBzYW1wbGUsIGJvdW5kYXJ5
VmFsdWUpOworICAgIFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+aGlzdG9ncmFtRW51bWVy
YXRpb24obmFtZSwgc2FtcGxlLCBib3VuZGFyeVZhbHVlKTsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug
V2ViQ29yZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1T
dXBwb3J0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v
UGxhdGZvcm1TdXBwb3J0LmgJKHJldmlzaW9uIDExMzI0MCkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3VwcG9ydC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYs
OSArMjU2LDYgQEAgcHVibGljOgogICAgIHN0YXRpYyB2b2lkIHNldFNoYXJlZFRpbWVyRmlyZUlu
dGVydmFsKGRvdWJsZSk7CiAgICAgc3RhdGljIHZvaWQgc3RvcFNoYXJlZFRpbWVyKCk7CiAKLSAg
ICAvLyBTdGF0c0NvdW50ZXJzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLQotICAgIHN0YXRpYyB2b2lkIGhpc3RvZ3JhbUVudW1lcmF0aW9uKGNv
bnN0IGNoYXIqIG5hbWUsIGludCBzYW1wbGUsIGludCBib3VuZGFyeVZhbHVlKTsKLQogICAgIC8v
IFRoZW1pbmcgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tCiAjaWYgT1MoV0lORE9XUykKICAgICBzdGF0aWMgdm9pZCBwYWludEJ1dHRv
bigKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTMyNDIpCisrKyBT
b3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx
LDE4IEBACisyMDEyLTA0LTA0ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4K
KworICAgICAgICBDYWxsIGhpc3RvZ3JhbUVudW1lcmF0aW9uIGRpcmVjdGx5CisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzEwNgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhcnQgb2YgYSByZWZhY3Rvcmlu
ZyBwcm9qZWN0IHRvIHJlbW92ZSB0aGUgUGxhdGZvcm1TdXBwb3J0CisgICAgICAgIGFic3RyYWN0
aW9uIGZyb20gc29tZSBmdW5jdGlvbnMuIFNlZSBidWcgODI5NDguCisKKyAgICAgICAgKiBzcmMv
Q2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6
OnNob3VsZFJ1bk1vZGFsRGlhbG9nRHVyaW5nUGFnZURpc21pc3NhbCk6CisgICAgICAgICogc3Jj
L1BsYXRmb3JtU3VwcG9ydC5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0wNC0wNCAg
RGFuaWVsIFNpZXZlcnMgIDxzaWV2ZXJzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21p
dW1dIEFsd2F5cyBza2lwIGRyYXcgYW5kIHJlYWRiYWNrIGlmIHRoZXJlIGlzIG5vdGhpbmcKSW5k
ZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3Bw
CShyZXZpc2lvbiAxMTMyNDApCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVD
bGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAxLDYgKzEwMSw3IEBACiAjaW5jbHVk
ZSAiV2ViV2luZG93RmVhdHVyZXMuaCIKICNpbmNsdWRlICJXaW5kb3dGZWF0dXJlcy5oIgogI2lu
Y2x1ZGUgIldyYXBwZWRSZXNvdXJjZVJlcXVlc3QuaCIKKyNpbmNsdWRlIDxwdWJsaWMvUGxhdGZv
cm0uaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CiAjaW5jbHVkZSA8d3Rm
L3RleHQvU3RyaW5nQ29uY2F0ZW5hdGUuaD4KICNpbmNsdWRlIDx3dGYvdW5pY29kZS9DaGFyYWN0
ZXJOYW1lcy5oPgpAQCAtMTAyMCw3ICsxMDIxLDcgQEAgYm9vbCBDaHJvbWVDbGllbnRJbXBsOjpz
aG91bGRSdW5Nb2RhbERpYQogICAgIGludCBkaXNtaXNzYWwgPSBzdGF0aWNfY2FzdDxpbnQ+KGRp
c21pc3NhbFR5cGUpIC0gMTsgLy8gRXhjbHVkZSBOb0Rpc21pc3NhbC4KICAgICBBU1NFUlQoMCA8
PSBkaXNtaXNzYWwgJiYgZGlzbWlzc2FsIDwgc3RhdGljX2Nhc3Q8aW50PihhcnJheXNpemUoa0Rp
c21pc3NhbHMpKSk7CiAKLSAgICBQbGF0Zm9ybVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9u
KCJSZW5kZXJlci5Nb2RhbERpYWxvZ3NEdXJpbmdQYWdlRGlzbWlzc2FsIiwgZGlzbWlzc2FsICog
YXJyYXlzaXplKGtEaWFsb2dzKSArIGRpYWxvZywgYXJyYXlzaXplKGtEaWFsb2dzKSAqIGFycmF5
c2l6ZShrRGlzbWlzc2FscykpOworICAgIFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+aGlz
dG9ncmFtRW51bWVyYXRpb24oIlJlbmRlcmVyLk1vZGFsRGlhbG9nc0R1cmluZ1BhZ2VEaXNtaXNz
YWwiLCBkaXNtaXNzYWwgKiBhcnJheXNpemUoa0RpYWxvZ3MpICsgZGlhbG9nLCBhcnJheXNpemUo
a0RpYWxvZ3MpICogYXJyYXlzaXplKGtEaXNtaXNzYWxzKSk7CiAKICAgICBtX3dlYlZpZXctPm1h
aW5GcmFtZSgpLT5hZGRNZXNzYWdlVG9Db25zb2xlKFdlYkNvbnNvbGVNZXNzYWdlKFdlYkNvbnNv
bGVNZXNzYWdlOjpMZXZlbEVycm9yLCBtYWtlU3RyaW5nKCJCbG9ja2VkICIsIGtEaWFsb2dzW2Rp
YWxvZ10sICIoJyIsIGRpYWxvZ01lc3NhZ2UsICInKSBkdXJpbmcgIiwga0Rpc21pc3NhbHNbZGlz
bWlzc2FsXSwgIi4iKSkpOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0
Zm9ybVN1cHBvcnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj
L1BsYXRmb3JtU3VwcG9ydC5jcHAJKHJldmlzaW9uIDExMzI0MCkKKysrIFNvdXJjZS9XZWJLaXQv
Y2hyb21pdW0vc3JjL1BsYXRmb3JtU3VwcG9ydC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwNCwx
MyArNzA0LDYgQEAgdm9pZCBQbGF0Zm9ybVN1cHBvcnQ6OnN0b3BTaGFyZWRUaW1lcigpCiAgICAg
d2ViS2l0UGxhdGZvcm1TdXBwb3J0KCktPnN0b3BTaGFyZWRUaW1lcigpOwogfQogCi0vLyBTdGF0
c0NvdW50ZXJzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tCi0KLXZvaWQgUGxhdGZvcm1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJh
dGlvbihjb25zdCBjaGFyKiBuYW1lLCBpbnQgc2FtcGxlLCBpbnQgYm91bmRhcnlWYWx1ZSkKLXsK
LSAgICB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKS0+aGlzdG9ncmFtRW51bWVyYXRpb24obmFtZSwg
c2FtcGxlLCBib3VuZGFyeVZhbHVlKTsKLX0KLQogLy8gVGhlbWluZyAtLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiAj
aWYgT1MoV0lORE9XUykK
</data>

          </attachment>
      

    </bug>

</bugzilla>