83098 2012-04-03 17:39:52 -0700 Offlineasm ARM backend uses the wrong mnemonic for multiply 2012-04-03 17:52:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 595067 0 fpizlo 2012-04-03 17:39:52 -0700 Patch forthcoming. 595069 1 135469 fpizlo 2012-04-03 17:42:19 -0700 Created attachment 135469 the patch 595070 2 135469 darin 2012-04-03 17:43:59 -0700 Comment on attachment 135469 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=135469&action=review > Source/JavaScriptCore/offlineasm/armv7.rb:781 > if operands.size == 2 or operands[0] == operands[2] or operands[1] == operands[2] > - emitArmV7("muls", operands) > + emitArmV7("mul", operands) Taking your change log comment literally, it seems this should stay “muls” since it’s passing only two operands. > Source/JavaScriptCore/offlineasm/armv7.rb:784 > - $asm.puts "muls #{operands[2].armV7Operand}, #{operands[2].armV7Operand}, #{operands[1].armV7Operand}" > + $asm.puts "mul #{operands[2].armV7Operand}, #{operands[2].armV7Operand}, #{operands[1].armV7Operand}" This change matches your change log comment. 595078 3 fpizlo 2012-04-03 17:52:53 -0700 Landed in http://trac.webkit.org/changeset/113113 135469 2012-04-03 17:42:19 -0700 2012-04-03 17:45:27 -0700 the patch fixarmmul_patch_1.diff text/plain 1669 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEzMTEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA0LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg T2ZmbGluZWFzbSBBUk0gYmFja2VuZCB1c2VzIHRoZSB3cm9uZyBtbmVtb25pYyBmb3IgbXVsdGlw bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMDk4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAg ICBVc2UgIm11bCIgaW5zdGVhZCBvZiAibXVscyIgc2luY2Ugd2UncmUgcGFzc2luZyB0aHJlZSBv cGVyYW5kcywgbm90IHR3by4KKworICAgICAgICAqIG9mZmxpbmVhc20vYXJtdjcucmI6CisKIDIw MTItMDQtMDMgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAg ICAgICAgIExpbnV4IGNyYXNoZXMgZHVyaW5nIGJvb3QKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9vZmZsaW5lYXNtL2FybXY3LnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9vZmZsaW5lYXNtL2FybXY3LnJiCShyZXZpc2lvbiAxMTMxMTApCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm12Ny5yYgkod29ya2luZyBjb3B5KQpAQCAtNzc4LDEw ICs3NzgsMTAgQEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAgICAgICAgIGVtaXRBcm1WN0NvbXBh Y3QoImxzcnMiLCAibHNycyIsIG9wZXJhbmRzKQogICAgICAgICB3aGVuICJtdWxpIiwgIm11bHAi CiAgICAgICAgICAgICBpZiBvcGVyYW5kcy5zaXplID09IDIgb3Igb3BlcmFuZHNbMF0gPT0gb3Bl cmFuZHNbMl0gb3Igb3BlcmFuZHNbMV0gPT0gb3BlcmFuZHNbMl0KLSAgICAgICAgICAgICAgICBl bWl0QXJtVjcoIm11bHMiLCBvcGVyYW5kcykKKyAgICAgICAgICAgICAgICBlbWl0QXJtVjcoIm11 bCIsIG9wZXJhbmRzKQogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICRhc20ucHV0 cyAibW92ICN7b3BlcmFuZHNbMl0uYXJtVjdPcGVyYW5kfSwgI3tvcGVyYW5kc1swXS5hcm1WN09w ZXJhbmR9IgotICAgICAgICAgICAgICAgICRhc20ucHV0cyAibXVscyAje29wZXJhbmRzWzJdLmFy bVY3T3BlcmFuZH0sICN7b3BlcmFuZHNbMl0uYXJtVjdPcGVyYW5kfSwgI3tvcGVyYW5kc1sxXS5h cm1WN09wZXJhbmR9IgorICAgICAgICAgICAgICAgICRhc20ucHV0cyAibXVsICN7b3BlcmFuZHNb Ml0uYXJtVjdPcGVyYW5kfSwgI3tvcGVyYW5kc1syXS5hcm1WN09wZXJhbmR9LCAje29wZXJhbmRz WzFdLmFybVY3T3BlcmFuZH0iCiAgICAgICAgICAgICBlbmQKICAgICAgICAgd2hlbiAic3ViaSIs ICJzdWJwIiwgInN1YmlzIgogICAgICAgICAgICAgZW1pdEFybVY3Q29tcGFjdCgic3VicyIsICJz dWJzIiwgb3BlcmFuZHMpCg==