83085 2012-04-03 15:57:10 -0700 [BlackBerry] Make the switch statement in WebPage::notifyAppActivationStateChange() stronger 2012-04-04 14:54:58 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis jkjiang tonikitoo oldest_to_newest 594988 0 rwlbuis 2012-04-03 15:57:10 -0700 In WebPage::notifyAppActivationStateChange(), suggested by Dan Bates, we should get rid of the default case to force a compiler error instead of using a runtime error: for (; it != last; ++it) { switch (activationState) { case ActivationActive: (*it)->handleAppActivatedEvent(); break; case ActivationInactive: (*it)->handleAppDeactivatedEvent(); break; case ActivationStandby: (*it)->handleAppStandbyEvent(); break; default: ASSERT(0); break; } } 594991 1 135443 rwlbuis 2012-04-03 16:00:56 -0700 Created attachment 135443 Patch 595982 2 rwlbuis 2012-04-04 14:54:58 -0700 Landed in r113203. 135443 2012-04-03 16:00:56 -0700 2012-04-04 09:49:37 -0700 Patch bug-83085-20120403190119.patch text/plain 1629 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0YWJkYWQ4NjVkZjcwZTU5YWI3NDQ5Nzc4ZjQxN2YwYmI3MjY5MmI3Li44N2U0ZGNhOWI1 YzY2NmNlZmQ2NDQwNzg0NTM2YmU5Yzk3OWQzMTNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNC0wMyAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBNYWtlIHRoZSBzd2l0Y2ggc3RhdGVtZW50IGlu IFdlYlBhZ2U6Om5vdGlmeUFwcEFjdGl2YXRpb25TdGF0ZUNoYW5nZSgpIHN0cm9uZ2VyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzA4NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIDEyMTEwOQorCisg ICAgICAgIFRoaXMgd2F5IHdoZW4gd2UgYWRkIHNvbWV0aGluZyB0byB0aGUgZW51bSAgYW5kIGZv cmdldCB0byBhZGQgdG8gdGhlIHN3aXRjaCB3ZSdsbCBnZXQgYSBjb21waWxlIGVycm9yLgorCisg ICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpX ZWJQYWdlOjpub3RpZnlBcHBBY3RpdmF0aW9uU3RhdGVDaGFuZ2UpOgorCiAyMDEyLTA0LTAzICBN aWtlIExhdHRhbnppbyAgPG1sYXR0YW56aW9AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJy eV0gRXhwb3NlIENhc2VTZW5zaXRpdmUsIFdyYXAsIGFuZCBIaWdobGlnaHRBbGxNYXRjaGVzIGlu IFdlYlBhZ2U6OmZpbmROZXh0U3RyaW5nKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuY3BwCmluZGV4IGE3ZjRjNWQ0MmY0OTlhODIxOTY3MDNjZDA5NDE3Y2QxMjQ0Yzg0ZjYu LjkyMzUwMDgxZGE0MjMxMmI2MDJjNWJjYjQwNDc5NGFjMWJjNThiN2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNTA4Myw5ICs1MDgzLDYgQEAgdm9pZCBX ZWJQYWdlOjpub3RpZnlBcHBBY3RpdmF0aW9uU3RhdGVDaGFuZ2UoQWN0aXZhdGlvblN0YXRlVHlw ZSBhY3RpdmF0aW9uU3RhdGUKICAgICAgICAgY2FzZSBBY3RpdmF0aW9uU3RhbmRieToKICAgICAg ICAgICAgICgqaXQpLT5oYW5kbGVBcHBTdGFuZGJ5RXZlbnQoKTsKICAgICAgICAgICAgIGJyZWFr OwotICAgICAgICBkZWZhdWx0OiAvLyBGSVhNRTogR2V0IHJpZCBvZiB0aGUgZGVmYXVsdCB0byBm b3JjZSBhIGNvbXBpbGVyIGVycm9yIGluc3RlYWQgb2YgdXNpbmcgYSBydW50aW1lIGVycm9yLiBT ZWUgUFIgIzEyMTEwOS4KLSAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICB9CiAK