83066 2012-04-03 14:07:40 -0700 [chromium] Include Image.h in TextFieldDecoratorImpl.cpp 2012-04-03 18:04:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vollick vollick dglazkov jamesr webkit.review.bot oldest_to_newest 594868 0 vollick 2012-04-03 14:07:40 -0700 Build fix. 594889 1 135428 vollick 2012-04-03 14:25:59 -0700 Created attachment 135428 Patch 594893 2 jamesr 2012-04-03 14:29:31 -0700 What configuration has an error here? Are there any bots that are broken (and if not, why?) 594898 3 jamesr 2012-04-03 14:31:24 -0700 And what is the compile error? 594903 4 jamesr 2012-04-03 14:33:14 -0700 Ah, do you have SVG disabled locally by any chance? SVGImageCache.h has: #if ENABLE(SVG) #include "Image.h" 594914 5 135428 jamesr 2012-04-03 14:42:37 -0700 Comment on attachment 135428 Patch R=me compiling with disable_svg=1 means you're on your own, for the most part. 595057 6 vollick 2012-04-03 17:31:23 -0700 You're right -- I was compiling with disable_svg=1. I'll be sure to get rid of that gyp define. 595082 7 135428 webkit.review.bot 2012-04-03 18:03:57 -0700 Comment on attachment 135428 Patch Clearing flags on attachment: 135428 Committed r113116: <http://trac.webkit.org/changeset/113116> 595083 8 webkit.review.bot 2012-04-03 18:04:01 -0700 All reviewed patches have been landed. Closing bug. 135428 2012-04-03 14:25:59 -0700 2012-04-03 18:03:57 -0700 Patch bug-83066-20120403172558.patch text/plain 1187 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVmMGM4M2EyNGQ2N2UyZDEzMjA4YmYwYTNhODNhNTU3NDNmYzNmMjQuLmVjZDdjZTAwY2MyNjAx ZjYzY2M3YTYyYmZlMjgxOGNkYjUzOTJiZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDQtMDMgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBJbmNsdWRlIEltYWdlLmggaW4gVGV4dEZpZWxk RGVjb3JhdG9ySW1wbC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgzMDY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBzcmMvVGV4dEZpZWxkRGVjb3JhdG9ySW1wbC5jcHA6CisKIDIwMTItMDQtMDMg IFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9t aXVtXSBGaXggaW5jb3JyZWN0IGNvbW1lbnQgaW4gQ0NEYW1hZ2VUcmFja2VyVGVzdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvVGV4dEZpZWxkRGVjb3JhdG9ySW1wbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9UZXh0RmllbGREZWNvcmF0b3JJbXBsLmNw cAppbmRleCBmZWY2NmEyMTM1MjY4NWY5YjQzOTQ4OGZiYzYwMGJmZDc2NzYyOTdkLi5lNThjMDIy ZWViNDY2N2EyY2Q2NzFjYWVjOTdmNTc3MjlmYmIyNWM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9UZXh0RmllbGREZWNvcmF0b3JJbXBsLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9UZXh0RmllbGREZWNvcmF0b3JJbXBsLmNwcApAQCAtMzMsNiAr MzMsNyBAQAogCiAjaW5jbHVkZSAiQ2FjaGVkSW1hZ2UuaCIKICNpbmNsdWRlICJIVE1MSW5wdXRF bGVtZW50LmgiCisjaW5jbHVkZSAiSW1hZ2UuaCIKICNpbmNsdWRlICJXZWJJbnB1dEVsZW1lbnQu aCIKICNpbmNsdWRlICJXZWJUZXh0RmllbGREZWNvcmF0b3JDbGllbnQuaCIKIAo=