83059 2012-04-03 13:04:11 -0700 [Chromium] transform-origin-css-property.xhtml is flaky 2012-09-10 10:48:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 84203 P2 Normal --- 1 fmalita fmalita eric krit leviw zimmermann oldest_to_newest 594785 0 fmalita 2012-04-03 13:04:11 -0700 See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Ftransforms%2Ftransform-origin-css-property.xhtml Looks like the reference html produces sub-pixel artifacts. Maybe we can re-write it to avoid transformed divs. 594801 1 135407 fmalita 2012-04-03 13:17:31 -0700 Created attachment 135407 Patch 629567 2 eric 2012-05-21 15:17:07 -0700 Levi is likely your best reviewer here! 629595 3 leviw 2012-05-21 15:26:06 -0700 (In reply to comment #0) > See > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Ftransforms%2Ftransform-origin-css-property.xhtml > > Looks like the reference html produces sub-pixel artifacts. Maybe we can re-write it to avoid transformed divs. The change looks fine, but have you verified that this eliminates the flakiness? run-webkit-tests has a -- iterations flag that could help you verify it. 630003 4 135407 zimmermann 2012-05-21 23:56:43 -0700 Comment on attachment 135407 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135407&action=review Looks good to me as well, but please check as Levi suggested. If its fixed, r=me with following comments: > LayoutTests/ChangeLog:9 > + Refactored the reference to emultate rotation. typo: emulate. > LayoutTests/svg/transforms/transform-origin-css-property-expected.xhtml:30 > + var x, y; Indentation is off. 630743 5 fmalita 2012-05-22 14:16:23 -0700 Thanks for reviewing, looks like this was already fixed here: https://bugs.webkit.org/show_bug.cgi?id=84203 *** This bug has been marked as a duplicate of bug 84203 *** 135407 2012-04-03 13:17:31 -0700 2012-09-10 10:48:14 -0700 Patch bug-83059-20120403161730.patch text/plain 4183 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDI4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2RmZTNmMzgxYzVhMDFkMjdiNmE5 ZmFmOTgwOTFmNTcxM2ZmMDk1MC4uZDRmOWNjYWMwMGUwYzc3MTZkNGY3MDBkN2UwODM3NDM4ODBj ZmE3NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTAzICBGbG9yaW4gTWFsaXRhICA8 Zm1hbGl0YUBnb29nbGUuY29tPgorCisgICAgICAgIFtDaHJvbWl1bV0gdHJhbnNmb3JtLW9yaWdp bi1jc3MtcHJvcGVydHkueGh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ1NTLXRyYW5zZm9ybWVkIDxkaXY+cyBhcHBlYXIgdG8gY2F1 c2UgZmxha2luZXNzIGR1ZSB0byBzdWItcGl4ZWwgcmVuZGVyaW5nLgorICAgICAgICBSZWZhY3Rv cmVkIHRoZSByZWZlcmVuY2UgdG8gZW11bHRhdGUgcm90YXRpb24uCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisgICAgICAgICogc3ZnL3RyYW5z Zm9ybXMvdHJhbnNmb3JtLW9yaWdpbi1jc3MtcHJvcGVydHktZXhwZWN0ZWQueGh0bWw6CisKIDIw MTItMDQtMDMgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAg IFtRdF1bV0syXSBBbGwgcGx1Z2luIHRlc3RzIGFyZSBmYWlsaW5nIG9uIGJ1aWxkYm90CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQK aW5kZXggNjY4YjAyZjA3ZGYxNjEyNzMxMDQ5NWQ1Njc3NmUzYTI4YTkxNzBmYS4uMjZiMzg1NWQz MWI3NDkwNmM0NDZlOTk1ZTY2YTdiNjkzMzhjODE5ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMTE1NSw4ICsxMTU1 LDYgQEAgQlVHQ1I2MjQzMyBXSU4gOiBmYXN0L2ltYWdlcy9naWYtbG9vcC1jb3VudC5odG1sID0g SU1BR0UKIC8vIFNWRyBURVNUUwogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotQlVHV0s3OTA2OCA6IHN2Zy90cmFu c2Zvcm1zL3RyYW5zZm9ybS1vcmlnaW4tY3NzLXByb3BlcnR5LnhodG1sID0gRkFJTAotCiBCVUdX Szc4NjEzIDogc3ZnL2N1c3RvbS9jaXJjbGUtbW92ZS1pbnZhbGlkYXRpb24uc3ZnID0gSU1BR0Ug SU1BR0UrVEVYVAogCiAvLyBOZWVkcyBhIHJlYmFzZWxpbmUgYWZ0ZXIgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMDg1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9z dmcvdHJhbnNmb3Jtcy90cmFuc2Zvcm0tb3JpZ2luLWNzcy1wcm9wZXJ0eS1leHBlY3RlZC54aHRt bCBiL0xheW91dFRlc3RzL3N2Zy90cmFuc2Zvcm1zL3RyYW5zZm9ybS1vcmlnaW4tY3NzLXByb3Bl cnR5LWV4cGVjdGVkLnhodG1sCmluZGV4IDQxZjQwNjhkMzFmMmFiNjMzNDgwYmExNDQ4MDFlNWYy Njk2OTM3ZGEuLjBlNzY0ZmNmYmE5NzgwNmEyYjE0NGFlZTY1MjViMDI5YmU2ZjgzNWMgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3N2Zy90cmFuc2Zvcm1zL3RyYW5zZm9ybS1vcmlnaW4tY3NzLXBy b3BlcnR5LWV4cGVjdGVkLnhodG1sCisrKyBiL0xheW91dFRlc3RzL3N2Zy90cmFuc2Zvcm1zL3Ry YW5zZm9ybS1vcmlnaW4tY3NzLXByb3BlcnR5LWV4cGVjdGVkLnhodG1sCkBAIC0xLDExICsxLDEw IEBACiA8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+CiA8c3R5bGU+ Ci0jdHJhbnNmb3JtT3JpZ2luRGl2IHsKKyNyZWZEaXYgewogICAgcG9zaXRpb246IGFic29sdXRl OwogICAgd2lkdGg6IDMwcHg7CiAgICBoZWlnaHQ6IDMwcHg7CiAgICBiYWNrZ3JvdW5kOiBncmVl bjsKLSAgIC13ZWJraXQtdHJhbnNmb3JtOiByb3RhdGUoOTBkZWcpOwogfQogPC9zdHlsZT4KIApA QCAtMTMsMzMgKzEyLDQxIEBACiAgIDxkaXYgaWQ9ImRpdlJvb3QiPjwvZGl2PgogCiAgIDxzY3Jp cHQ+PCFbQ0RBVEFbCisgICAgdmFyIGRpdlNpemUgPSAzMDsKKyAgICB2YXIgdHJhbnNmb3JtT3Jp Z2lucyA9IFsKKyAgICAgIHsgeDogMC41LCB5OiAwLjUgIH0sCisgICAgICB7IHg6IDAsICAgeTog MCAgICB9LAorICAgICAgeyB4OiAwLCAgIHk6IDAuNSAgfSwKKyAgICAgIHsgeDogMSwgICB5OiAw ICAgIH0sCisgICAgICB7IHg6IDAsICAgeTogMC41ICB9LAorICAgICAgeyB4OiAxLCAgIHk6IDAu NSAgfSwKKyAgICAgIHsgeDogMCwgICB5OiAxICAgIH0sCisgICAgICB7IHg6IDAuNSwgeTogMSAg ICB9LAorICAgICAgeyB4OiAxLCAgIHk6IDEgICAgfSwKKyAgICBdOworCisgICAgZnVuY3Rpb24g cm90YXRlOTAocG9pbnQsIG9yaWdpbikKKyAgICB7CisgICAgICAgICAgICB2YXIgeCwgeTsKKyAg ICAgICAgICAgIHggPSBvcmlnaW4ueCArIChwb2ludC55IC0gb3JpZ2luLnkpOworICAgICAgICAg ICAgeSA9IG9yaWdpbi55IC0gKHBvaW50LnggLSBvcmlnaW4ueCk7CisgICAgICAgICAgICByZXR1 cm4ge3g6IHgsIHk6IHl9OworICAgIH0KIAotICAgIGZ1bmN0aW9uIGFkZFRyYW5zZm9ybU9yaWdp bkRpdih4LCB5LCB0cmFuc2Zvcm1PcmlnaW4pCisgICAgZnVuY3Rpb24gYWRkRGl2KHgsIHkpCiAg ICAgewogICAgICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKLSAg ICAgICBkaXYuc2V0QXR0cmlidXRlKCJpZCIsICJ0cmFuc2Zvcm1PcmlnaW5EaXYiKTsKLSAgICAg ICBkaXYuc2V0QXR0cmlidXRlKCJzdHlsZSIsICJ0b3A6ICIgKyB5ICsgInB4OyBsZWZ0OiAiKyB4 ICsgInB4OyAtd2Via2l0LXRyYW5zZm9ybS1vcmlnaW46ICIgKyB0cmFuc2Zvcm1PcmlnaW4gKyAi OyIpOworICAgICAgIGRpdi5zZXRBdHRyaWJ1dGUoImlkIiwgInJlZkRpdiIpOworICAgICAgIGRp di5zZXRBdHRyaWJ1dGUoInN0eWxlIiwgInRvcDogIiArIHkgKyAicHg7IGxlZnQ6ICIrIHggKyAi cHg7Iik7CiAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRpdlJvb3QiKS5hcHBlbmRD aGlsZChkaXYpOwogICAgIH0KIAotICAgIHZhciB0cmFuc2Zvcm1PcmlnaW5zID0gWwotICAgICAg ICAgIjUwJSA1MCUiLAotICAgICAgICAgIjAlIDAlIiwKLSAgICAgICAgICIwJSA1MCUiLAotICAg ICAgICAgIjEwMCUgMCUiLAotICAgICAgICAgIjAlIDUwJSIsCi0gICAgICAgICAiMTAwJSA1MCUi LAotICAgICAgICAgIjAlIDEwMCUiLAotICAgICAgICAgIjUwJSAxMDAlIiwKLSAgICAgICAgICIx MDAlIDEwMCUiLAotICAgICBdOwotCi0gICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdHJhbnNmb3Jt T3JpZ2lucy5sZW5ndGg7IGkrKykgIHsKLSAgICAgICAgIHZhciB4ID0gNjAgKyAoaSAlICA0KSAq IDYwOwotICAgICAgICAgdmFyIHkgPSA2MCArIE1hdGguZmxvb3IoaSAvIDQpICogNjA7Ci0gICAg ICAgICBhZGRUcmFuc2Zvcm1PcmlnaW5EaXYoeCwgeSwgdHJhbnNmb3JtT3JpZ2luc1tpXSk7Ci0g ICAgIH0KLQorICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdHJhbnNmb3JtT3JpZ2lucy5sZW5ndGg7 IGkrKykgIHsKKyAgICAgICAgdmFyIHggPSA2MCArIChpICUgIDQpICogNjA7CisgICAgICAgIHZh ciB5ID0gNjAgKyBNYXRoLmZsb29yKGkgLyA0KSAqIDYwOworICAgICAgICB2YXIgY2VudGVyID0g cm90YXRlOTAoe3g6IChkaXZTaXplIC8gMiksIHk6IChkaXZTaXplIC8gMil9LCB7eDogKGRpdlNp emUgKiB0cmFuc2Zvcm1PcmlnaW5zW2ldLngpLCB5OiAoZGl2U2l6ZSAqICgxIC0gdHJhbnNmb3Jt T3JpZ2luc1tpXS55KSl9KTsKKyAgICAgICAgYWRkRGl2KHggKyAoY2VudGVyLnggLSBkaXZTaXpl IC8gMiksIHkgLSAoY2VudGVyLnkgLSBkaXZTaXplIC8gMikpOworICAgIH0KICAgXV0+PC9zY3Jp cHQ+CiA8L2JvZHk+CiA8L2h0bWw+Cg==