83057 2012-04-03 12:32:16 -0700 [v8] Fix memory leak in V8LazyEventListener 2014-12-16 00:47:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 arv arv abarth barraclough fpizlo ggaren haraken japhet levin ojan ossy webkit.review.bot zarvai oldest_to_newest 594750 0 arv 2012-04-03 12:32:16 -0700 [v8] Fix memory leak in V8LazyEventListener 594753 1 135395 arv 2012-04-03 12:35:03 -0700 Created attachment 135395 Patch 594770 2 135395 levin 2012-04-03 12:53:34 -0700 Comment on attachment 135395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135395&action=review > Source/WebCore/bindings/v8/V8LazyEventListener.cpp:53 > +V8LazyEventListener::V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition& position, Node* node, const WorldContextHandle& worldContext) I think a PassRefPtr is appropriate here since the m_node is a RefPtr. (Of course if no one is calling using a PassRefPtr or release, then it doesn't really matter.) 594773 3 levin 2012-04-03 12:55:27 -0700 (In reply to comment #2) > (From update of attachment 135395 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135395&action=review > > > Source/WebCore/bindings/v8/V8LazyEventListener.cpp:53 > > +V8LazyEventListener::V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition& position, Node* node, const WorldContextHandle& worldContext) > > I think a PassRefPtr is appropriate here since the m_node is a RefPtr. (Of course if no one is calling using a PassRefPtr or release, then it doesn't really matter.) Whoops, you're changing that. Sorry about that. Nevermind. 594817 4 135395 ojan 2012-04-03 13:31:26 -0700 Comment on attachment 135395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135395&action=review > Source/WebCore/bindings/v8/V8LazyEventListener.cpp:217 > + // Since we only parse once, there's no need to keep data used for parsing around anymore. > + m_functionName = String(); > + m_code = String(); > + m_eventParameterName = String(); > + m_sourceURL = String(); Nice change. Deserves a mention in the changelog since it's not directly fixing the memory leak. 594860 5 arv 2012-04-03 13:59:21 -0700 Committed r113086: <http://trac.webkit.org/changeset/113086> 595356 6 zarvai 2012-04-04 03:06:18 -0700 fast/dom/inline-event-attributes-release.html layout test fails or flaky on bots: - Qt Linux Release - Lion debug 595370 7 ossy 2012-04-04 03:17:52 -0700 (In reply to comment #6) > fast/dom/inline-event-attributes-release.html > layout test fails or flaky on bots: > - Qt Linux Release > - Lion debug Reopen based on this comment. Have you got any idea why? 595646 8 arv 2012-04-04 10:12:58 -0700 (In reply to comment #7) > (In reply to comment #6) > > fast/dom/inline-event-attributes-release.html > > layout test fails or flaky on bots: > > - Qt Linux Release > > - Lion debug > > Reopen based on this comment. Have you got any idea why? I'm not sure but my gut feeling is that window.internals.numberOfLiveNodes() is not working as expected. I am the first one to use this method in a layout test so maybe it was never intended for this use case. I'm fine removing this test even though I feel like having something like this is useful 595659 9 ojan 2012-04-04 10:25:19 -0700 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showExpectations=true&tests=fast%2Fdom%2Finline-event-attributes-release.html Output on these is: FAIL afterCount - beforeCount should be 0. Was 1. It looks to me like JSC might have an actual memory leak here, which is what this test is testing. Or maybe JSC's gc needs to run more than once to gc some objects? Geoff, wdyt? Are there other JSC people we should CC who might have thoughts? 595682 10 ggaren 2012-04-04 10:37:51 -0700 > Or maybe JSC's gc needs to run more than once to gc some objects? No, that's not the case. > Geoff, wdyt? Are there other JSC people we should CC who might have thoughts? No immediate ideas without debugging it :(. 595709 11 ojan 2012-04-04 10:58:46 -0700 (In reply to comment #10) > > Geoff, wdyt? Are there other JSC people we should CC who might have thoughts? > > No immediate ideas without debugging it :(. Strangely, this test started passing for GTK after http://trac.webkit.org/changeset/113141/ and randomly passed on a couple runs on Qt Linux Release. Seems likely the test is flaky with JSC, whic looks like a genuine bug to me (or a bug in numberOfLiveNodes). In either case, the test seems fine. We should skip it on the Apple ports for now unless there is someone in JSC land who wants to look into it. 1055908 12 burg 2014-12-16 00:47:50 -0800 Closing some V8-related work items. 135395 2012-04-03 12:35:03 -0700 2012-04-04 03:18:03 -0700 Patch bug-83057-20120403123502.patch text/plain 10313 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyOTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VmNWU2ZWUzYjg4YmFl N2NkMDJmYzA4ZTU3MzU5MzY1YjE0NTc0Yi4uNTEwY2Y3ZjdlMTRhZDNmMzk1NmI2MzA0NmJkN2Y0 MjBjOTA4ZmFiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTAzICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW3Y4XSBGaXggbWVtb3J5 IGxlYWsgaW4gVjhMYXp5RXZlbnRMaXN0ZW5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMwNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGFsc28gYnJpbmdzIHRoZSBWOCBhbmQgSlNDIGltcGxl bWVudGF0aW9uIGNsb3Nlci4gVGhlIHRpbWluZyB3aGVuIHdlIGZpcnN0IGxvb2t1cAorICAgICAg ICB0aGUgZm9ybSBlbGVtZW50IGlzIG5vdyBzYW1lIGluIEpTQyBhbmQgVjggKGJ1dCBkaWZmZXJl bnQgZnJvbSBNb3ppbGxhKS4KKworICAgICAgICBUZXN0czogZmFzdC9kb20vaW5saW5lLWV2ZW50 LWF0dHJpYnV0ZXMtbW92ZWQuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9kb20vaW5saW5lLWV2 ZW50LWF0dHJpYnV0ZXMtcmVsZWFzZS5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOExh enlFdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4TGF6eUV2ZW50TGlzdGVu ZXI6OlY4TGF6eUV2ZW50TGlzdGVuZXIpOgorICAgICAgICAoV2ViQ29yZTo6VjhMYXp5RXZlbnRM aXN0ZW5lcjo6cHJlcGFyZUxpc3RlbmVyT2JqZWN0KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9W OExhenlFdmVudExpc3RlbmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpWOExhenlFdmVudExpc3Rl bmVyOjpjcmVhdGUpOgorICAgICAgICAoVjhMYXp5RXZlbnRMaXN0ZW5lcik6CisKIDIwMTItMDQt MDIgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0 IHNob3VsZCB0aHJvdHRsZSBtZW1vcnkgcHJlc3N1cmUgbm90aWZpY2F0aW9ucyBpbiBwcm9wb3J0 aW9uIHRvIGhhbmRsZXIgdGltZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OExhenlFdmVudExpc3RlbmVyLmNwcAppbmRleCA2MTYzZWFhOTU4N2UzZjliMWFhYWNiOGFhOWM5 YzBjYWNjZjBjZjNhLi42NDJkM2UxMmFiN2IzNTBmNzJhNzI1ZjEwOWQ5NWI4NzQ0NTFjN2FjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOExhenlFdmVudExpc3RlbmVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOExhenlFdmVudExpc3RlbmVy LmNwcApAQCAtNTAsMTggKzUwLDE1IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotVjhMYXp5 RXZlbnRMaXN0ZW5lcjo6VjhMYXp5RXZlbnRMaXN0ZW5lcihjb25zdCBBdG9taWNTdHJpbmcmIGZ1 bmN0aW9uTmFtZSwgY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFBhcmFtZXRlck5hbWUsIGNvbnN0 IFN0cmluZyYgY29kZSwgY29uc3QgU3RyaW5nIHNvdXJjZVVSTCwgY29uc3QgVGV4dFBvc2l0aW9u JiBwb3NpdGlvbiwgUGFzc1JlZlB0cjxOb2RlPiBub2RlLCBjb25zdCBXb3JsZENvbnRleHRIYW5k bGUmIHdvcmxkQ29udGV4dCkKK1Y4TGF6eUV2ZW50TGlzdGVuZXI6OlY4TGF6eUV2ZW50TGlzdGVu ZXIoY29uc3QgQXRvbWljU3RyaW5nJiBmdW5jdGlvbk5hbWUsIGNvbnN0IEF0b21pY1N0cmluZyYg ZXZlbnRQYXJhbWV0ZXJOYW1lLCBjb25zdCBTdHJpbmcmIGNvZGUsIGNvbnN0IFN0cmluZyBzb3Vy Y2VVUkwsIGNvbnN0IFRleHRQb3NpdGlvbiYgcG9zaXRpb24sIE5vZGUqIG5vZGUsIGNvbnN0IFdv cmxkQ29udGV4dEhhbmRsZSYgd29ybGRDb250ZXh0KQogICAgIDogVjhBYnN0cmFjdEV2ZW50TGlz dGVuZXIodHJ1ZSwgd29ybGRDb250ZXh0KQogICAgICwgbV9mdW5jdGlvbk5hbWUoZnVuY3Rpb25O YW1lKQogICAgICwgbV9ldmVudFBhcmFtZXRlck5hbWUoZXZlbnRQYXJhbWV0ZXJOYW1lKQogICAg ICwgbV9jb2RlKGNvZGUpCiAgICAgLCBtX3NvdXJjZVVSTChzb3VyY2VVUkwpCiAgICAgLCBtX25v ZGUobm9kZSkKLSAgICAsIG1fZm9ybUVsZW1lbnQoMCkKICAgICAsIG1fcG9zaXRpb24ocG9zaXRp b24pCiB7Ci0gICAgaWYgKG1fbm9kZSAmJiBtX25vZGUtPmlzSFRNTEVsZW1lbnQoKSkKLSAgICAg ICAgbV9mb3JtRWxlbWVudCA9IHN0YXRpY19jYXN0PEhUTUxFbGVtZW50Kj4obV9ub2RlLmdldCgp KS0+Zm9ybSgpOwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgpAQCAtMTY1LDEyICsxNjIsMTMg QEAgdm9pZCBWOExhenlFdmVudExpc3RlbmVyOjpwcmVwYXJlTGlzdGVuZXJPYmplY3QoU2NyaXB0 RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCkKICAgICBBU1NFUlQodmFsdWUtPklzRnVuY3Rpb24o KSk7CiAgICAgdjg6OkxvY2FsPHY4OjpGdW5jdGlvbj4gaW50ZXJtZWRpYXRlRnVuY3Rpb24gPSB2 YWx1ZS5Bczx2ODo6RnVuY3Rpb24+KCk7CiAKLSAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IG5v ZGVXcmFwcGVyID0gdG9PYmplY3RXcmFwcGVyPE5vZGU+KG1fbm9kZS5nZXQoKSk7Ci0gICAgdjg6 OkhhbmRsZTx2ODo6T2JqZWN0PiBmb3JtV3JhcHBlciA9IHRvT2JqZWN0V3JhcHBlcjxIVE1MRm9y bUVsZW1lbnQ+KG1fZm9ybUVsZW1lbnQuZ2V0KCkpOwotICAgIHY4OjpIYW5kbGU8djg6Ok9iamVj dD4gZG9jdW1lbnRXcmFwcGVyID0gdG9PYmplY3RXcmFwcGVyPERvY3VtZW50PihtX25vZGUgPyBt X25vZGUtPm93bmVyRG9jdW1lbnQoKSA6IDApOworICAgIEhUTUxGb3JtRWxlbWVudCogZm9ybUVs ZW1lbnQgPSAwOworICAgIGlmIChtX25vZGUgJiYgbV9ub2RlLT5pc0hUTUxFbGVtZW50KCkpCisg ICAgICAgIGZvcm1FbGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTEVsZW1lbnQqPihtX25vZGUpLT5m b3JtKCk7CiAKLSAgICBtX25vZGUuY2xlYXIoKTsKLSAgICBtX2Zvcm1FbGVtZW50LmNsZWFyKCk7 CisgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBub2RlV3JhcHBlciA9IHRvT2JqZWN0V3JhcHBl cjxOb2RlPihtX25vZGUpOworICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gZm9ybVdyYXBwZXIg PSB0b09iamVjdFdyYXBwZXI8SFRNTEZvcm1FbGVtZW50Pihmb3JtRWxlbWVudCk7CisgICAgdjg6 OkhhbmRsZTx2ODo6T2JqZWN0PiBkb2N1bWVudFdyYXBwZXIgPSB0b09iamVjdFdyYXBwZXI8RG9j dW1lbnQ+KG1fbm9kZSA/IG1fbm9kZS0+b3duZXJEb2N1bWVudCgpIDogMCk7CiAKICAgICB2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gcGFyYW1ldGVyc1szXSA9IHsgbm9kZVdyYXBwZXIsIGZvcm1XcmFw cGVyLCBkb2N1bWVudFdyYXBwZXIgfTsKIApAQCAtMjEyLDYgKzIxMCwxMiBAQCB2b2lkIFY4TGF6 eUV2ZW50TGlzdGVuZXI6OnByZXBhcmVMaXN0ZW5lck9iamVjdChTY3JpcHRFeGVjdXRpb25Db250 ZXh0KiBjb250ZXh0KQogCiAgICAgd3JhcHBlZEZ1bmN0aW9uLT5TZXROYW1lKHY4OjpTdHJpbmc6 Ok5ldyhmcm9tV2ViQ29yZVN0cmluZyhtX2Z1bmN0aW9uTmFtZSksIG1fZnVuY3Rpb25OYW1lLmxl bmd0aCgpKSk7CiAKKyAgICAvLyBTaW5jZSB3ZSBvbmx5IHBhcnNlIG9uY2UsIHRoZXJlJ3Mgbm8g bmVlZCB0byBrZWVwIGRhdGEgdXNlZCBmb3IgcGFyc2luZyBhcm91bmQgYW55bW9yZS4KKyAgICBt X2Z1bmN0aW9uTmFtZSA9IFN0cmluZygpOworICAgIG1fY29kZSA9IFN0cmluZygpOworICAgIG1f ZXZlbnRQYXJhbWV0ZXJOYW1lID0gU3RyaW5nKCk7CisgICAgbV9zb3VyY2VVUkwgPSBTdHJpbmco KTsKKwogICAgIHNldExpc3RlbmVyT2JqZWN0KHdyYXBwZWRGdW5jdGlvbik7CiB9CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuaCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuaAppbmRleCAx ZmI1NjVhZGQzMTdkZGRlN2JkYTExOTA1ODNjZjMwYWEyYTg0MWRhLi4zMzVlMjFkNzMyN2NkZTNl N2I3NDQ1NWM0MmRhNzRmZGNiMmJlMWYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOExhenlFdmVudExpc3RlbmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5oCkBAIC00OCw3ICs0OCw3IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAvLyBBIFY4TGF6eUV2ZW50TGlzdGVuZXIgaXMgZWl0aGVyIGEgSFRNTCBv ciBTVkcgZXZlbnQgaGFuZGxlci4KICAgICBjbGFzcyBWOExhenlFdmVudExpc3RlbmVyIDogcHVi bGljIFY4QWJzdHJhY3RFdmVudExpc3RlbmVyIHsKICAgICBwdWJsaWM6Ci0gICAgICAgIHN0YXRp YyBQYXNzUmVmUHRyPFY4TGF6eUV2ZW50TGlzdGVuZXI+IGNyZWF0ZShjb25zdCBBdG9taWNTdHJp bmcmIGZ1bmN0aW9uTmFtZSwgY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFBhcmFtZXRlck5hbWUs IGNvbnN0IFN0cmluZyYgY29kZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VVUkwsIGNvbnN0IFRleHRQ b3NpdGlvbiYgcG9zaXRpb24sIFBhc3NSZWZQdHI8Tm9kZT4gbm9kZSwgY29uc3QgV29ybGRDb250 ZXh0SGFuZGxlJiB3b3JsZENvbnRleHQpCisgICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPFY4TGF6 eUV2ZW50TGlzdGVuZXI+IGNyZWF0ZShjb25zdCBBdG9taWNTdHJpbmcmIGZ1bmN0aW9uTmFtZSwg Y29uc3QgQXRvbWljU3RyaW5nJiBldmVudFBhcmFtZXRlck5hbWUsIGNvbnN0IFN0cmluZyYgY29k ZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VVUkwsIGNvbnN0IFRleHRQb3NpdGlvbiYgcG9zaXRpb24s IE5vZGUqIG5vZGUsIGNvbnN0IFdvcmxkQ29udGV4dEhhbmRsZSYgd29ybGRDb250ZXh0KQogICAg ICAgICB7CiAgICAgICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFY4TGF6eUV2ZW50TGlzdGVu ZXIoZnVuY3Rpb25OYW1lLCBldmVudFBhcmFtZXRlck5hbWUsIGNvZGUsIHNvdXJjZVVSTCwgcG9z aXRpb24sIG5vZGUsIHdvcmxkQ29udGV4dCkpOwogICAgICAgICB9CkBAIC01OSw3ICs1OSw3IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCB2b2lkIHByZXBhcmVMaXN0ZW5l ck9iamVjdChTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CiAKICAgICBwcml2YXRlOgotICAgICAg ICBWOExhenlFdmVudExpc3RlbmVyKGNvbnN0IEF0b21pY1N0cmluZyYgZnVuY3Rpb25OYW1lLCBj b25zdCBBdG9taWNTdHJpbmcmIGV2ZW50UGFyYW1ldGVyTmFtZSwgY29uc3QgU3RyaW5nJiBjb2Rl LCBjb25zdCBTdHJpbmcgc291cmNlVVJMLCBjb25zdCBUZXh0UG9zaXRpb24mLCBQYXNzUmVmUHRy PE5vZGU+LCBjb25zdCBXb3JsZENvbnRleHRIYW5kbGUmKTsKKyAgICAgICAgVjhMYXp5RXZlbnRM aXN0ZW5lcihjb25zdCBBdG9taWNTdHJpbmcmIGZ1bmN0aW9uTmFtZSwgY29uc3QgQXRvbWljU3Ry aW5nJiBldmVudFBhcmFtZXRlck5hbWUsIGNvbnN0IFN0cmluZyYgY29kZSwgY29uc3QgU3RyaW5n IHNvdXJjZVVSTCwgY29uc3QgVGV4dFBvc2l0aW9uJiwgTm9kZSosIGNvbnN0IFdvcmxkQ29udGV4 dEhhbmRsZSYpOwogCiAgICAgICAgIHZpcnR1YWwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gY2FsbExp c3RlbmVyRnVuY3Rpb24oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIHY4OjpIYW5kbGU8djg6OlZh bHVlPiBqc0V2ZW50LCBFdmVudCopOwogCkBAIC03Myw4ICs3Myw3IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICAgICAgQXRvbWljU3RyaW5nIG1fZXZlbnRQYXJhbWV0ZXJOYW1lOwogICAgICAg ICBTdHJpbmcgbV9jb2RlOwogICAgICAgICBTdHJpbmcgbV9zb3VyY2VVUkw7Ci0gICAgICAgIFJl ZlB0cjxOb2RlPiBtX25vZGU7Ci0gICAgICAgIFJlZlB0cjxIVE1MRm9ybUVsZW1lbnQ+IG1fZm9y bUVsZW1lbnQ7CisgICAgICAgIE5vZGUqIG1fbm9kZTsKICAgICAgICAgVGV4dFBvc2l0aW9uIG1f cG9zaXRpb247CiAgICAgfTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDlmMzA4YzIzNDk4NjJjNWM2NWMwNWFlMTcxMDVl ZmQzZWIwZGYwMGQuLjBhNGNlZjg4OTcwZThiMzIwN2VhYmM3NDZmNDFjNWJmMzFhM2JkMWMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNC0wMyAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFt2OF0gRml4IG1lbW9yeSBsZWFrIGluIFY4TGF6eUV2ZW50 TGlzdGVuZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTgzMDU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBmYXN0L2RvbS9pbmxpbmUtZXZlbnQtYXR0cmlidXRlcy1tb3ZlZC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZG9tL2lubGluZS1ldmVudC1hdHRyaWJ1dGVzLW1vdmVkLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL2lubGluZS1ldmVudC1hdHRyaWJ1dGVzLXJl bGVhc2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9pbmxpbmUtZXZl bnQtYXR0cmlidXRlcy1yZWxlYXNlLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA0LTAyICBTdGVwaGVu IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgPGltZyBzdHlsZT0n d2lkdGg6IDEwMCUnIHNyYz0nZm9vLnN2Zyc+IGdldHMgcGl4ZWxsYXRlZCB3aGVuIHN0cmV0Y2hl ZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vaW5saW5lLWV2ZW50LWF0dHJpYnV0 ZXMtbW92ZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vaW5saW5lLWV2ZW50 LWF0dHJpYnV0ZXMtbW92ZWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmUxOGVmOTk0MDIzMWUy ZTYxNDI1ZDk3ZmJjYTJhODJiZWU5NzM4NTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9pbmxpbmUtZXZlbnQtYXR0cmlidXRlcy1tb3ZlZC1leHBlY3RlZC50eHQKQEAg LTAsMCArMSwxMCBAQAorVGVzdHMgdGhhdCB3ZSBoYXZlIHRoZSBleHBlY3RlZCBmb3JtIGluIHNj b3BlCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGV4cGVjdGVkIGlzICJ1 bmRlZmluZWQiCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExF VEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vaW5saW5lLWV2ZW50LWF0dHJp YnV0ZXMtbW92ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2lubGluZS1ldmVudC1hdHRy aWJ1dGVzLW1vdmVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYmJmY2RlZmQ4NzJlNmNmYWY0OGE4OWRiMjgw MTA3MDljMjBmZjllNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2lu bGluZS1ldmVudC1hdHRyaWJ1dGVzLW1vdmVkLmh0bWwKQEAgLTAsMCArMSwyNSBAQAorPCFET0NU WVBFIGh0bWw+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCdUZXN0cyB0aGF0IHdlIGhhdmUgdGhl IGV4cGVjdGVkIGZvcm0gaW4gc2NvcGUnKTsKKworZnVuY3Rpb24gZGlzcGF0Y2hDbGljayhlbGVt ZW50KQoreworICAgIHZhciBjbGlja0V2ZW50ID0gZG9jdW1lbnQuY3JlYXRlRXZlbnQoJ01vdXNl RXZlbnQnKTsKKyAgICBjbGlja0V2ZW50LmluaXRNb3VzZUV2ZW50KCdjbGljaycsIHRydWUsIGZh bHNlLCB3aW5kb3csIDAsIDAsIDAsIDAsIDAsIGZhbHNlLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCAw LCBudWxsKTsKKyAgICBlbGVtZW50LmRpc3BhdGNoRXZlbnQoY2xpY2tFdmVudCk7Cit9CisKK3Zh ciBleHBlY3RlZDsKK3ZhciBmID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZm9ybScpOwordmFy IGkgPSBmLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lucHV0JykpOworaS5z ZXRBdHRyaWJ1dGUoJ29uY2xpY2snLCAnZXhwZWN0ZWQgPSB0eXBlb2YgYWN0aW9uJyk7CitmLnJl bW92ZUNoaWxkKGkpOworZiA9IG51bGw7CitnYygpOworZGlzcGF0Y2hDbGljayhpKTsKK3Nob3Vs ZEJlRXF1YWxUb1N0cmluZygnZXhwZWN0ZWQnLCAndW5kZWZpbmVkJyk7CisKKzwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgpc IE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL2lubGluZS1ldmVudC1hdHRyaWJ1dGVzLXJlbGVhc2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZmFzdC9kb20vaW5saW5lLWV2ZW50LWF0dHJpYnV0ZXMtcmVsZWFzZS1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uODY2ZjhjY2VmYTk1ZjBkZjgzY2U4NTkwZmZlZGRmMjFhNjVjMGU4YQot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2lubGluZS1ldmVudC1hdHRy aWJ1dGVzLXJlbGVhc2UtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK1Rlc3RzIHRoYXQg d2UgZG8gbm90IGhvbGQgb24gdG8gYW55IG5vZGVzCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNl ZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRF Ii4KKworCitQQVNTIGFmdGVyQ291bnQgLSBiZWZvcmVDb3VudCBpcyAwCitQQVNTIHN1Y2Nlc3Nm dWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9kb20vaW5saW5lLWV2ZW50LWF0dHJpYnV0ZXMtcmVsZWFzZS5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vaW5saW5lLWV2ZW50LWF0dHJpYnV0ZXMtcmVsZWFzZS5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmJmMTE4YmJlNWQ0MjQ3NzVjY2RiZDRkNzZlYmM3MzllZGUwYTY4YmMKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9pbmxpbmUtZXZlbnQtYXR0cmlidXRl cy1yZWxlYXNlLmh0bWwKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8c2NyaXB0 IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+ CisKK2Rlc2NyaXB0aW9uKCdUZXN0cyB0aGF0IHdlIGRvIG5vdCBob2xkIG9uIHRvIGFueSBub2Rl cycpOworCitnYygpOworCitmdW5jdGlvbiBudW1iZXJPZkxpdmVOb2RlcygpIHsKKyAgICByZXR1 cm4gd2luZG93LmludGVybmFscyAmJiB3aW5kb3cuaW50ZXJuYWxzLm51bWJlck9mTGl2ZU5vZGVz ICYmIHdpbmRvdy5pbnRlcm5hbHMubnVtYmVyT2ZMaXZlTm9kZXMoKTsKK30KKwordmFyIGJlZm9y ZUNvdW50ID0gbnVtYmVyT2ZMaXZlTm9kZXMoKTsKKwordmFyIGYgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCdmb3JtJyk7Cit2YXIgaSA9IGYuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgnaW5wdXQnKSk7CitpLnNldEF0dHJpYnV0ZSgnb25jbGljaycsICcnKTsKK2YucmVtb3Zl Q2hpbGQoaSk7CitmID0gbnVsbDsKK2kgPSBudWxsOworZ2MoKTsKKwordmFyIGFmdGVyQ291bnQg PSBudW1iZXJPZkxpdmVOb2RlcygpOworCitzaG91bGRCZSgnYWZ0ZXJDb3VudCAtIGJlZm9yZUNv dW50JywgJzAnKTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=