83049 2012-04-03 11:18:18 -0700 [Qt][WK2] Assertion failure on loading new page after panning/zooming in touchwebview 2012-04-10 08:36:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dinu.jacob webkit-unassigned menard webkit.review.bot zoltan oldest_to_newest 594663 0 dinu.jacob 2012-04-03 11:18:18 -0700 On loading a new page after panning/zooming (which results in a change in position), the following ASSERT observed: ASSERTION FAILED: !m_suspendCount Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp(420) : void WebKit::QtViewportInteractionEngine::reset() 1 0xb73545fb WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit27QtViewportInteractionEngine5resetEv+0x4b) [0xb73545fb] 2 0xb7354677 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit27QtViewportInteractionEngine16applyConstraintsERKNS0_11ConstraintsE+0x1f) [0xb7354677] 3 0xb725747a WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN29QQuickWebViewFlickablePrivate27didChangeViewportPropertiesERKN7WebCore17ViewportArgumentsE+0x5e) [0xb725747a] 4 0xb734a2f7 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN12QtPageClient27didChangeViewportPropertiesERKN7WebCore17ViewportArgumentsE+0x33) [0xb734a2f7] 5 0xb72f554b WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit12WebPageProxy27didChangeViewportPropertiesERKN7WebCore17ViewportArgumentsE+0x25) [0xb72f554b] 6 0xb7487a30 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN7CoreIPC18callMemberFunctionIN6WebKit12WebPageProxyEMS2_FvRKN7WebCore17ViewportArgumentsEES4_EEvRKNS_10Arguments1IT1_EEPT_T0_+0x3a) [0xb7487a30] 7 0xb7482e05 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN7CoreIPC13handleMessageIN8Messages12WebPageProxy27DidChangeViewportPropertiesEN6WebKit12WebPageProxyEMS5_FvRKN7WebCore17ViewportArgumentsEEEEvPNS_15ArgumentDecoderEPT0_T1_+0x55) [0xb7482e05] 8 0xb74808ea WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit12WebPageProxy29didReceiveWebPageProxyMessageEPN7CoreIPC10ConnectionENS1_9MessageIDEPNS1_15ArgumentDecoderE+0x17c) [0xb74808ea] 9 0xb72f06b2 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit12WebPageProxy17didReceiveMessageEPN7CoreIPC10ConnectionENS1_9MessageIDEPNS1_15ArgumentDecoderE+0xfa) [0xb72f06b2] 10 0xb7329726 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit15WebProcessProxy17didReceiveMessageEPN7CoreIPC10ConnectionENS1_9MessageIDEPNS1_15ArgumentDecoderE+0x1a2) [0xb7329726] 11 0xb72a9f32 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit25WebConnectionToWebProcess17didReceiveMessageEPN7CoreIPC10ConnectionENS1_9MessageIDEPNS1_15ArgumentDecoderE+0x10c) [0xb72a9f32] 12 0xb71c8fd0 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN7CoreIPC10Connection15dispatchMessageERNS0_7MessageINS_15ArgumentDecoderEEE+0x14e) [0xb71c8fd0] 13 0xb71c9180 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN7CoreIPC10Connection16dispatchMessagesEv+0xa2) [0xb71c9180] 594671 1 dinu.jacob 2012-04-03 11:23:18 -0700 ensureContentWithinViewportBoundary is called with 'immediate' flag set to false. This results in an animation as there is a change in the visible content rectangle. While the animation is in progress, ChangeViewportProperties message is received. This results in a call to QtViewportInteractionEngine::applyConstraints and the ASSERT in reset fails as we are in the middle of animation for the visible content rect change. 594709 2 dinu.jacob 2012-04-03 12:00:54 -0700 When handling contents size change, should set the new visible content rect immediately, instead of animating to it. 594720 3 135386 dinu.jacob 2012-04-03 12:07:20 -0700 Created attachment 135386 Patch 599236 4 135386 kenneth 2012-04-10 06:59:55 -0700 Comment on attachment 135386 Patch This is fine, but there really shouldnt be many cases where it would be outside of the view (unless the content shrinks for some reason). If that happens in other cases, those should really be examined. 599303 5 135386 webkit.review.bot 2012-04-10 08:36:30 -0700 Comment on attachment 135386 Patch Clearing flags on attachment: 135386 Committed r113720: <http://trac.webkit.org/changeset/113720> 599304 6 webkit.review.bot 2012-04-10 08:36:35 -0700 All reviewed patches have been landed. Closing bug. 135386 2012-04-03 12:07:20 -0700 2012-04-10 08:36:30 -0700 Patch 83049.patch text/plain 1428 dinu.jacob ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwNTRkNjM2Li4yODJhMWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDQtMDMgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAg ICAgICBbUXRdW1dLMl0gQXNzZXJ0aW9uIGZhaWx1cmUgb24gbG9hZGluZyBuZXcgcGFnZSBhZnRl ciBwYW5uaW5nL3pvb21pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgzMDQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBoYW5kbGluZyBjb250ZW50cyBzaXplIGNoYW5nZSwgc2V0IHRoZSB2aXNp YmxlIGNvbnRlbnQgcmVjdGFuZ2xlIGltbWVkaWF0ZWx5LAorICAgICAgICBpbnN0ZWFkIG9mIGFu aW1hdGluZyB0byBpdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJh Y3Rpb25FbmdpbmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25F bmdpbmU6Oml0ZW1TaXplQ2hhbmdlZCk6CisKIDIwMTItMDQtMDMgIEJhbGF6cyBLZWxlbWVuICA8 a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bV0syXSBBU1NFUlQoIShvdXRwdXRC eXRlcy5zaXplKCkgJSBzaXplb2YoVUNoYXIpKSkgaW4gUGx1Z2luUHJvY2Vzc1Byb3h5UXQuY3Bw CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVy YWN0aW9uRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmUuY3BwCmluZGV4IGU0MWZlMjAuLjM0ODA2NmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rp b25FbmdpbmUuY3BwCkBAIC01OTMsNyArNTkzLDcgQEAgdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rp b25FbmdpbmU6Oml0ZW1TaXplQ2hhbmdlZCgpCiAgICAgICAgIHJldHVybjsKIAogICAgIFZpZXdw b3J0VXBkYXRlRGVmZXJyZXIgZ3VhcmQodGhpcyk7Ci0gICAgZW5zdXJlQ29udGVudFdpdGhpblZp ZXdwb3J0Qm91bmRhcnkoKTsKKyAgICBlbnN1cmVDb250ZW50V2l0aGluVmlld3BvcnRCb3VuZGFy eSh0cnVlKTsKIH0KIAogdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OnNjYWxlQ29u dGVudChjb25zdCBRUG9pbnRGJiBjZW50ZXJJbkNTU0Nvb3JkaW5hdGVzLCBxcmVhbCBjc3NTY2Fs ZSkK