83034 2012-04-03 08:17:47 -0700 [Qt][WK2] ASSERT(!(outputBytes.size() % sizeof(UChar))) in PluginProcessProxyQt.cpp 2012-04-03 08:45:18 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kbalazs kbalazs oldest_to_newest 594493 0 kbalazs 2012-04-03 08:17:47 -0700 The problem is that if the plugin speak into stdout than it confusing our stdout based ipc. 594501 1 135332 kbalazs 2012-04-03 08:23:16 -0700 Created attachment 135332 Patch 594518 2 135332 zherczeg 2012-04-03 08:42:07 -0700 Comment on attachment 135332 Patch r=me 594519 3 135332 kbalazs 2012-04-03 08:45:12 -0700 Comment on attachment 135332 Patch Clearing flags on attachment: 135332 Committed r113041: <http://trac.webkit.org/changeset/113041> 594521 4 kbalazs 2012-04-03 08:45:18 -0700 All reviewed patches have been landed. Closing bug. 135332 2012-04-03 08:23:16 -0700 2012-04-03 08:45:11 -0700 Patch bug-83034-20120403172314.patch text/plain 3734 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjg3ZjQ0ZWQ4NjI1NTBj Y2RhMWIyNjJlNTI2NmMwY2UxMTcxODNkYi4uYjc5OTE5MDc0ZTY3MDdhNDM2NzViZmNmZDNkMDMz N2UzYjI0NDdiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTAzICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dLMl0gQVNT RVJUKCEob3V0cHV0Qnl0ZXMuc2l6ZSgpICUgc2l6ZW9mKFVDaGFyKSkpIGluIFBsdWdpblByb2Nl c3NQcm94eVF0LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODMwMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEb24ndCBhbGxvdyB0aGUgcGx1Z2luIHRvIHBvbGx1dGUgdGhlIHN0YW5kYXJkIG91dHB1 dC4KKyAgICAgICAgUmVpbnZlbnQgU3RkT3V0RGV2TnVsbFJlZGlyZWN0b3Igd2hpY2ggd2FzIHJl bW92ZWQgaW4KKyAgICAgICAgcjExMjg4OSBmb3IgdGhpcyBwdXJwb3NlLgorCisgICAgICAgICog U2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcDoK KyAgICAgICAgKFN0ZG91dERldk51bGxSZWRpcmVjdG9yKToKKyAgICAgICAgKFdlYktpdCk6Cisg ICAgICAgIChXZWJLaXQ6OlN0ZG91dERldk51bGxSZWRpcmVjdG9yOjpTdGRvdXREZXZOdWxsUmVk aXJlY3Rvcik6CisgICAgICAgIChXZWJLaXQ6OlN0ZG91dERldk51bGxSZWRpcmVjdG9yOjp+U3Rk b3V0RGV2TnVsbFJlZGlyZWN0b3IpOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbk1v ZHVsZTo6c2NhblBsdWdpbik6CisKIDIwMTItMDQtMDMgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAg PGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBUYXAgaGlnaGxpZ2h0IGF0 dGVtcHRlZCBoaWRkZW4gc2V2ZXJhbCB0aW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv U2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdp bk1vZHVsZVgxMS5jcHAKaW5kZXggZDJlM2VjOTRhZDFhNmY3NjA1YjAzOWI2NzMyNWY4YTE5Nzkw Y2Y3Ni4uZWE1OWUzZDVjNTQ5NGY1YTNiYzVhNmQ2OWVhODBmMmRmNTg2ODY3NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1 Z2luTW9kdWxlWDExLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OZXRz Y2FwZS94MTEvTmV0c2NhcGVQbHVnaW5Nb2R1bGVYMTEuY3BwCkBAIC00MSw2ICs0MSwzMiBAQCB1 c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2NsYXNzIFN0 ZG91dERldk51bGxSZWRpcmVjdG9yIHsKK3B1YmxpYzoKKyAgICBTdGRvdXREZXZOdWxsUmVkaXJl Y3RvcigpOworICAgIH5TdGRvdXREZXZOdWxsUmVkaXJlY3RvcigpOworCitwcml2YXRlOgorICAg IGludCBtX3NhdmVkU3Rkb3V0OworfTsKKworU3Rkb3V0RGV2TnVsbFJlZGlyZWN0b3I6OlN0ZG91 dERldk51bGxSZWRpcmVjdG9yKCkKKyAgICA6IG1fc2F2ZWRTdGRvdXQoLTEpCit7CisgICAgaW50 IG5ld1N0ZG91dCA9IG9wZW4oIi9kZXYvbnVsbCIsIE9fV1JPTkxZKTsKKyAgICBpZiAobmV3U3Rk b3V0ID09IC0xKQorICAgICAgICByZXR1cm47CisgICAgbV9zYXZlZFN0ZG91dCA9IGR1cChTVERP VVRfRklMRU5PKTsKKyAgICBkdXAyKG5ld1N0ZG91dCwgU1RET1VUX0ZJTEVOTyk7Cit9CisKK1N0 ZG91dERldk51bGxSZWRpcmVjdG9yOjp+U3Rkb3V0RGV2TnVsbFJlZGlyZWN0b3IoKQoreworICAg IGlmIChtX3NhdmVkU3Rkb3V0ICE9IC0xKQorICAgICAgICBkdXAyKG1fc2F2ZWRTdGRvdXQsIFNU RE9VVF9GSUxFTk8pOworfQorCisKIHN0YXRpYyB2b2lkIHBhcnNlTUlNRURlc2NyaXB0aW9uKGNv bnN0IFN0cmluZyYgbWltZURlc2NyaXB0aW9uLCBWZWN0b3I8TWltZUNsYXNzSW5mbz4mIHJlc3Vs dCkKIHsKICAgICBBU1NFUlRfQVJHKHJlc3VsdCwgcmVzdWx0LmlzRW1wdHkoKSk7CkBAIC0xNTQs MTkgKzE4MCwyNSBAQCBzdGF0aWMgU3RyaW5nIHRydW5jYXRlVG9TaW5nbGVMaW5lKGNvbnN0IFN0 cmluZyYgc3RyaW5nKQogCiBib29sIE5ldHNjYXBlUGx1Z2luTW9kdWxlOjpzY2FuUGx1Z2luKGNv bnN0IFN0cmluZyYgcGx1Z2luUGF0aCkKIHsKLSAgICAvLyBXZSBhcmUgbG9hZGluZyB0aGUgcGx1 Z2luIGhlcmUgc2luY2UgaXQgZG9lcyBub3Qgc2VlbSB0byBiZSBhIHN0YW5kYXJkaXplZCB3YXkg dG8KLSAgICAvLyBnZXQgdGhlIG5lZWRlZCBpbmZvcm1hdGlvbnMgZnJvbSBhIFVOSVggcGx1Z2lu IHdpdGhvdXQgbG9hZGluZyBpdC4KLSAgICBSZWZQdHI8TmV0c2NhcGVQbHVnaW5Nb2R1bGU+IHBs dWdpbk1vZHVsZSA9IE5ldHNjYXBlUGx1Z2luTW9kdWxlOjpnZXRPckNyZWF0ZShwbHVnaW5QYXRo KTsKLSAgICBpZiAoIXBsdWdpbk1vZHVsZSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAg cGx1Z2luTW9kdWxlLT5pbmNyZW1lbnRMb2FkQ291bnQoKTsKICAgICBSYXdQbHVnaW5NZXRhRGF0 YSBtZXRhRGF0YTsKLSAgICBib29sIHN1Y2Nlc3MgPSBwbHVnaW5Nb2R1bGUtPmdldFBsdWdpbklu Zm9Gb3JMb2FkZWRQbHVnaW4obWV0YURhdGEpOwotICAgIHBsdWdpbk1vZHVsZS0+ZGVjcmVtZW50 TG9hZENvdW50KCk7CiAKLSAgICBpZiAoIXN1Y2Nlc3MpCi0gICAgICAgIHJldHVybiBmYWxzZTsK KyAgICB7CisgICAgICAgIC8vIERvbid0IGFsbG93IHRoZSBwbHVnaW4gdG8gcG9sbHV0ZSB0aGUg c3RhbmRhcmQgb3V0cHV0LgorICAgICAgICBTdGRvdXREZXZOdWxsUmVkaXJlY3RvciBzdGRPdXRS ZWRpcmVjdG9yOworCisgICAgICAgIC8vIFdlIGFyZSBsb2FkaW5nIHRoZSBwbHVnaW4gaGVyZSBz aW5jZSBpdCBkb2VzIG5vdCBzZWVtIHRvIGJlIGEgc3RhbmRhcmRpemVkIHdheSB0bworICAgICAg ICAvLyBnZXQgdGhlIG5lZWRlZCBpbmZvcm1hdGlvbnMgZnJvbSBhIFVOSVggcGx1Z2luIHdpdGhv dXQgbG9hZGluZyBpdC4KKyAgICAgICAgUmVmUHRyPE5ldHNjYXBlUGx1Z2luTW9kdWxlPiBwbHVn aW5Nb2R1bGUgPSBOZXRzY2FwZVBsdWdpbk1vZHVsZTo6Z2V0T3JDcmVhdGUocGx1Z2luUGF0aCk7 CisgICAgICAgIGlmICghcGx1Z2luTW9kdWxlKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwor CisgICAgICAgIHBsdWdpbk1vZHVsZS0+aW5jcmVtZW50TG9hZENvdW50KCk7CisgICAgICAgIGJv b2wgc3VjY2VzcyA9IHBsdWdpbk1vZHVsZS0+Z2V0UGx1Z2luSW5mb0ZvckxvYWRlZFBsdWdpbiht ZXRhRGF0YSk7CisgICAgICAgIHBsdWdpbk1vZHVsZS0+ZGVjcmVtZW50TG9hZENvdW50KCk7CisK KyAgICAgICAgaWYgKCFzdWNjZXNzKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0K IAogICAgIC8vIFdyaXRlIGRhdGEgdG8gc3RhbmRhcmQgb3V0cHV0IGZvciB0aGUgVUkgcHJvY2Vz cy4KICAgICBTdHJpbmcgb3V0cHV0WzNdID0gewo=