83023 2012-04-03 06:09:30 -0700 Call incrementStatsCounter directly 2012-04-03 19:55:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82948 1 pilgrim pilgrim abarth fishd haraken japhet webkit.review.bot oldest_to_newest 594422 0 pilgrim 2012-04-03 06:09:30 -0700 Call incrementStatsCounter directly 594423 1 135319 pilgrim 2012-04-03 06:10:12 -0700 Created attachment 135319 Patch 594426 2 135319 haraken 2012-04-03 06:14:47 -0700 Comment on attachment 135319 Patch OK! 594483 3 135319 webkit.review.bot 2012-04-03 08:03:44 -0700 Comment on attachment 135319 Patch Clearing flags on attachment: 135319 Committed r113034: <http://trac.webkit.org/changeset/113034> 594484 4 webkit.review.bot 2012-04-03 08:03:49 -0700 All reviewed patches have been landed. Closing bug. 594522 5 135319 abarth 2012-04-03 08:45:25 -0700 Comment on attachment 135319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135319&action=review > Source/WebCore/bindings/v8/V8Proxy.h:49 > -#define INC_STATS(name) PlatformSupport::incrementStatsCounter(name) > +#define INC_STATS(name) webkitPlatformSupport()->incrementStatsCounter(name) Does this compile with ENABLE_DOM_STATS_COUNTERS enabled? webkitPlatformSupport shouldn't be visible outside the WebKit layer, but this macro is used in WebCore. 594528 6 135319 haraken 2012-04-03 08:50:26 -0700 Comment on attachment 135319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135319&action=review >> Source/WebCore/bindings/v8/V8Proxy.h:49 >> +#define INC_STATS(name) webkitPlatformSupport()->incrementStatsCounter(name) > > Does this compile with ENABLE_DOM_STATS_COUNTERS enabled? webkitPlatformSupport shouldn't be visible outside the WebKit layer, but this macro is used in WebCore. Ah, good point, the indirection call is necessary. May I roll the patch out? 594582 7 abarth 2012-04-03 10:02:30 -0700 > Ah, good point, the indirection call is necessary. May I roll the patch out? I don't think anyone commonly builds this configuration, so we might want to wait for Mark to fix it. 595167 8 pilgrim 2012-04-03 19:55:40 -0700 (In reply to comment #7) > > Ah, good point, the indirection call is necessary. May I roll the patch out? > > I don't think anyone commonly builds this configuration, so we might want to wait for Mark to fix it. Fix is bug 83109. 135319 2012-04-03 06:10:12 -0700 2012-04-03 08:50:26 -0700 Patch bug-83023-20120403091003.patch text/plain 3858 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzAyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTAzICBNYXJrIFBp bGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBDYWxsIGluY3JlbWVudFN0 YXRzQ291bnRlciBkaXJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODMwMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaDoKKyAgICAgICAgKFBsYXRmb3JtU3VwcG9ydCk6CisK IDIwMTItMDQtMDMgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNjaGVzQGxpbnV4 LmludGVsLmNvbT4KIAogICAgICAgICBTb3VwIEhUVFAgYmFja2VuZCBkb2VzIG5vdCBzZW5kIENv bnRlbnQtTGVuZ3RoIGluIGNlcnRhaW4gY2FzZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4UHJveHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOFByb3h5LmgJKHJldmlzaW9uIDExMzAxNykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4UHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBAQAogI2luY2x1ZGUg PHd0Zi90ZXh0L1RleHRQb3NpdGlvbi5oPgogCiAjaWYgZGVmaW5lZChFTkFCTEVfRE9NX1NUQVRT X0NPVU5URVJTKSAmJiBQTEFURk9STShDSFJPTUlVTSkKLSNkZWZpbmUgSU5DX1NUQVRTKG5hbWUp IFBsYXRmb3JtU3VwcG9ydDo6aW5jcmVtZW50U3RhdHNDb3VudGVyKG5hbWUpCisjZGVmaW5lIElO Q19TVEFUUyhuYW1lKSB3ZWJraXRQbGF0Zm9ybVN1cHBvcnQoKS0+aW5jcmVtZW50U3RhdHNDb3Vu dGVyKG5hbWUpCiAjZWxzZQogI2RlZmluZSBJTkNfU1RBVFMobmFtZSkKICNlbmRpZgpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1TdXBwb3J0LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1TdXBwb3J0 LmgJKHJldmlzaW9uIDExMzAxNykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1BsYXRmb3JtU3VwcG9ydC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNjAsNyArMjYwLDYgQEAgcHVi bGljOgogICAgIHN0YXRpYyB2b2lkIHN0b3BTaGFyZWRUaW1lcigpOwogCiAgICAgLy8gU3RhdHND b3VudGVycyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KLSAgICBzdGF0aWMgdm9pZCBpbmNyZW1lbnRTdGF0c0NvdW50ZXIoY29uc3QgY2hhciog bmFtZSk7CiAgICAgc3RhdGljIHZvaWQgaGlzdG9ncmFtQ3VzdG9tQ291bnRzKGNvbnN0IGNoYXIq IG5hbWUsIGludCBzYW1wbGUsIGludCBtaW4sIGludCBtYXgsIGludCBidWNrZXRDb3VudCk7CiAg ICAgc3RhdGljIHZvaWQgaGlzdG9ncmFtRW51bWVyYXRpb24oY29uc3QgY2hhciogbmFtZSwgaW50 IHNhbXBsZSwgaW50IGJvdW5kYXJ5VmFsdWUpOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwkocmV2aXNpb24gMTEzMDIwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNC0wMyAgTWFyayBQaWxn cmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2FsbCBpbmNyZW1lbnRTdGF0 c0NvdW50ZXIgZGlyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgzMDIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBzcmMvUGxhdGZvcm1TdXBwb3J0LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgor ICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFt ZUltcGw6OldlYkZyYW1lSW1wbCk6CisKIDIwMTItMDQtMDMgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYlZpZXdJbXBsIGRvZXNuJ3Qgbm90aWZ5IHRoZSBw YWdlIHRoYXQgdGhlIHVzZXIgaGFzIGNhbmNlbGVkIGZ1bGxzY3JlZW4uCkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1BsYXRmb3JtU3VwcG9ydC5jcHAJKHJldmlzaW9uIDEx MzAxNykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1BsYXRmb3JtU3VwcG9ydC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTcxMywxMSArNzEzLDYgQEAgdm9pZCBQbGF0Zm9ybVN1cHBvcnQ6 OnN0b3BTaGFyZWRUaW1lcigpCiAKIC8vIFN0YXRzQ291bnRlcnMgLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotdm9pZCBQbGF0 Zm9ybVN1cHBvcnQ6OmluY3JlbWVudFN0YXRzQ291bnRlcihjb25zdCBjaGFyKiBuYW1lKQotewot ICAgIHdlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5pbmNyZW1lbnRTdGF0c0NvdW50ZXIobmFtZSk7 Ci19Ci0KIHZvaWQgUGxhdGZvcm1TdXBwb3J0OjpoaXN0b2dyYW1DdXN0b21Db3VudHMoY29uc3Qg Y2hhciogbmFtZSwgaW50IHNhbXBsZSwgaW50IG1pbiwgaW50IG1heCwgaW50IGJ1Y2tldENvdW50 KQogewogICAgIHdlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5oaXN0b2dyYW1DdXN0b21Db3VudHMo bmFtZSwgc2FtcGxlLCBtaW4sIG1heCwgYnVja2V0Q291bnQpOwpJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCShyZXZpc2lvbiAxMTMwMTcpCisrKyBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xOTc2LDcgKzE5NzYsNyBAQCBXZWJGcmFtZUltcGw6OldlYkZyYW1lSW1wbChXZWJGcmFt ZUNsaWVuCiAgICAgLCBtX2lkZW50aWZpZXIoZ2VuZXJhdGVGcmFtZUlkZW50aWZpZXIoKSkKICAg ICAsIG1faW5TYW1lRG9jdW1lbnRIaXN0b3J5TG9hZChmYWxzZSkKIHsKLSAgICBQbGF0Zm9ybVN1 cHBvcnQ6OmluY3JlbWVudFN0YXRzQ291bnRlcih3ZWJGcmFtZUFjdGl2ZUNvdW50KTsKKyAgICBX ZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmluY3JlbWVudFN0YXRzQ291bnRlcih3ZWJGcmFt ZUFjdGl2ZUNvdW50KTsKICAgICBmcmFtZUNvdW50Kys7CiB9CiAK