83022 2012-04-03 06:04:23 -0700 Web Inspector: [chromium] add provisional save method into the frontend client. 2012-04-03 07:29:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman abarth dglazkov fishd jamesr tkent webkit.review.bot yurys oldest_to_newest 594416 0 pfeldman 2012-04-03 06:04:23 -0700 Patch to follow. 594418 1 135318 pfeldman 2012-04-03 06:05:36 -0700 Created attachment 135318 Patch 594421 2 webkit.review.bot 2012-04-03 06:07:40 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 594447 3 135318 yurys 2012-04-03 06:54:11 -0700 Comment on attachment 135318 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135318&action=review > Source/WebKit/chromium/public/WebDevToolsFrontendClient.h:54 > + virtual void save(const WebString& url, const WebString& content, bool saveAs) { } I think we should pass defaultFileName as well. 594465 4 pfeldman 2012-04-03 07:29:48 -0700 Committed r113032: <http://trac.webkit.org/changeset/113032> 135318 2012-04-03 06:05:36 -0700 2012-04-03 06:54:11 -0700 Patch bug-83022-20120403170534.patch text/plain 1494 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZkNzllYjA0YTFhZWRjNDNkOGVjNTE5N2I1ZGUxZmNhMTFmOGMwOWQuLmUxZTM4MWViZjU0MzA3 YmU4NDRiMDM5MzYxNjI3NzE5ZTQwNWRjMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDQtMDMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW2Nocm9taXVtXSBhZGQgcHJvdmlz aW9uYWwgc2F2ZSBtZXRob2QgaW50byB0aGUgZnJvbnRlbmQgY2xpZW50LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMwMjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJEZXZUb29sc0Zy b250ZW5kQ2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkRldlRvb2xzRnJvbnRlbmRDbGll bnQ6OnNhdmUpOgorCiAyMDEyLTA0LTAyICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2VkLCBDQ0xheWVyVHJlZUhv c3QgcnVuTXVsdGlUaHJlYWQgaXMgZmxha3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0Zyb250ZW5kQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0Zyb250ZW5kQ2xpZW50LmgKaW5kZXggYzA5ZjUx NGMxMTBkOGU4MTEyZDYyOTY1YjljYjBjZGM1ZjJhYTY4MS4uYzI0NjYyMzVhMTg4ZDgwMjgyMmYx Y2U1MjkzMzdlY2E4NDdhMTI2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViRGV2VG9vbHNGcm9udGVuZENsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRDbGllbnQuaApAQCAtNTEsNiArNTEsNyBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIG1vdmVXaW5kb3dCeShjb25zdCBXZWJGbG9hdFBv aW50JikgeyB9CiAgICAgdmlydHVhbCB2b2lkIG9wZW5Jbk5ld1RhYihjb25zdCBXZWJTdHJpbmcm IHNpZGUpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBzYXZlQXMoY29uc3QgV2ViU3RyaW5nJiBmaWxl TmFtZSwgY29uc3QgV2ViU3RyaW5nJiBjb250ZW50KSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgc2F2 ZShjb25zdCBXZWJTdHJpbmcmIHVybCwgY29uc3QgV2ViU3RyaW5nJiBjb250ZW50LCBib29sIHNh dmVBcykgeyB9CiAKIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5XZWJEZXZUb29sc0Zyb250ZW5k Q2xpZW50KCkge30K