83013 2012-04-03 03:32:17 -0700 [chromium] Canvas2DLayerChromium::updateCompositorResources should flush after copying 2012-04-03 07:50:24 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.kevs3d.co.uk/dev/asteroidsbench/ P2 Normal --- 1 skyostil skyostil cc-bugs jamesr senorblanco webkit.review.bot oldest_to_newest 594346 0 skyostil 2012-04-03 03:32:17 -0700 Canvas2DLayerChromium::updateCompositorResources should issue a glFlush after copying the canvas back buffer texture to the front buffer. Otherwise the canvas may start rendering new context before the copy is performed, causing the copy to source from partially rendered data. The flush was there previously but got mistakenly removed when the new TextureCopier utility was added. 594399 1 135313 skyostil 2012-04-03 05:13:26 -0700 Created attachment 135313 Patch 594479 2 135313 webkit.review.bot 2012-04-03 07:50:19 -0700 Comment on attachment 135313 Patch Clearing flags on attachment: 135313 Committed r113033: <http://trac.webkit.org/changeset/113033> 594480 3 webkit.review.bot 2012-04-03 07:50:24 -0700 All reviewed patches have been landed. Closing bug. 135313 2012-04-03 05:13:26 -0700 2012-04-03 07:50:19 -0700 Patch bug-83013-20120403131325.patch text/plain 5380 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyODM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NiNzNjZmNiM2FmMWRh OWZmNWI1OTM2YTljYTQwOTJlMzU1NmU1ZC4uOWQ3YTNkZmE4N2IwNjBmMjIzZDdkZTBhYTU2NDA5 ZWRhZTRmZmRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTAzICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Q2FudmFzMkRMYXllckNocm9taXVtOjp1cGRhdGVDb21wb3NpdG9yUmVzb3VyY2VzIHNob3VsZCBm bHVzaCBhZnRlciBjb3B5aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MzAxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlIG5lZWQgdG8gZmx1c2ggdGhlIEdQVSBjb21tYW5kIHF1ZXVlIGFmdGVyIGNv cHlpbmcgdGhlIGNhbnZhcyBiYWNrCisgICAgICAgIGJ1ZmZlciBpbnRvIHRoZSBmcm9udCBidWZm ZXIuIE90aGVyd2lzZSB0aGUgY29weSBtaWdodCBiZSBkZWxheWVkIHRvIGEKKyAgICAgICAgcG9p bnQgd2hlcmUgbmV3IGNvbnRlbnRzIGhhdmUgYWxyZWFkeSBiZWVuIGRyYXduIGludG8gdGhlIGJh Y2sgYnVmZmVyLAorICAgICAgICBsZWFkaW5nIHRvIGZsaWNrZXJpbmcuCisKKyAgICAgICAgQWRk ZWQgdGVzdCB0byBDYW52YXMyRExheWVyQ2hyb21pdW1UZXN0LgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vQ2FudmFzMkRMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNhbnZhczJETGF5ZXJDaHJvbWl1bTo6dXBkYXRlQ29tcG9zaXRvclJlc291cmNl cyk6CisKIDIwMTItMDQtMDIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIEFkZCBhIGNhbGVuZGFyIHBpY2tlciBpbmRpY2F0b3IgdG8gZGF0ZS10eXBlIGlucHV0 IGZpZWxkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCAzMTM4NTBiOWZlYjY5Njg2ZDcy YmVlZWI0ZTA2Y2UwMDRmOTRmMzIxLi5jOTk4YjMwYmQ4YWExNGY0YWIzYTA5NmEwMTgwMDIxMTM0 MjdlMDBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEy LTA0LTAzICBTYW1pIEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFtjaHJvbWl1bV0gQ2FudmFzMkRMYXllckNocm9taXVtOjp1cGRhdGVDb21wb3NpdG9yUmVzb3Vy Y2VzIHNob3VsZCBmbHVzaCBhZnRlciBjb3B5aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzAxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvQ2FudmFzMkRMYXllckNocm9taXVtVGVzdC5j cHA6IE1ha2Ugc3VyZSBjb250ZXh0IGlzIGZsdXNoZWQgYWZ0ZXIgY29weWluZy4KKwogMjAxMi0w NC0wMiAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIGEg Y2FsZW5kYXIgcGlja2VyIGluZGljYXRvciB0byBkYXRlLXR5cGUgaW5wdXQgZmllbGRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9DYW52YXMy RExheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vQ2FudmFzMkRMYXllckNocm9taXVtLmNwcAppbmRleCBmY2JmNTRhNzdlMWQ4N2JhOGZh ZDlkMmUyMjc0NTdjZGFkNWFhYjgzLi4wMjhmNTEzYTQxN2IxZmUwMjFmOTM1YTM2MzYxYzcxY2M2 ZmIzMTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9DYW52YXMyRExheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0NhbnZhczJETGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTEzNiw2 ICsxMzYsNyBAQCB2b2lkIENhbnZhczJETGF5ZXJDaHJvbWl1bTo6dXBkYXRlQ29tcG9zaXRvclJl c291cmNlcyhHcmFwaGljc0NvbnRleHQzRCogY29udGV4dAogCiAgICAgbV9mcm9udFRleHR1cmUt PmFsbG9jYXRlKHVwZGF0ZXIuYWxsb2NhdG9yKCkpOwogICAgIHVwZGF0ZXIuY29waWVyKCktPmNv cHlUZXh0dXJlKGNvbnRleHQsIG1fYmFja1RleHR1cmVJZCwgbV9mcm9udFRleHR1cmUtPnRleHR1 cmVJZCgpLCBtX3NpemUpOworICAgIEdMQyhjb250ZXh0LCBjb250ZXh0LT5mbHVzaCgpKTsKIH0K IAogdm9pZCBDYW52YXMyRExheWVyQ2hyb21pdW06OnB1c2hQcm9wZXJ0aWVzVG8oQ0NMYXllcklt cGwqIGxheWVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DYW52 YXMyRExheWVyQ2hyb21pdW1UZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv Q2FudmFzMkRMYXllckNocm9taXVtVGVzdC5jcHAKaW5kZXggZWEzZDQwZmZlMDgxMDhiZmQxOWFk NzI2NTg1ZWM1NDhiOTM0MjNjOS4uMjY0NzVjZTM2OWU1ZTIzMzcyMDIxMjFjODY3YjAyYzQyZDFi NjM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DYW52YXMyRExh eWVyQ2hyb21pdW1UZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0Nh bnZhczJETGF5ZXJDaHJvbWl1bVRlc3QuY3BwCkBAIC03NCwxNyArNzQsNyBAQCBwcml2YXRlOgog CiBjbGFzcyBNb2NrQ2FudmFzQ29udGV4dCA6IHB1YmxpYyBGYWtlV2ViR3JhcGhpY3NDb250ZXh0 M0QgewogcHVibGljOgotICAgIE1PQ0tfTUVUSE9EMChjcmVhdGVGcmFtZWJ1ZmZlciwgV2ViR0xJ ZCgpKTsKLSAgICBNT0NLX01FVEhPRDAoY3JlYXRlVGV4dHVyZSwgV2ViR0xJZCgpKTsKLQotICAg IE1PQ0tfTUVUSE9EMihiaW5kRnJhbWVidWZmZXIsIHZvaWQoV0dDM0RlbnVtLCBXZWJHTElkKSk7 Ci0gICAgTU9DS19NRVRIT0Q1KGZyYW1lYnVmZmVyVGV4dHVyZTJELCB2b2lkKFdHQzNEZW51bSwg V0dDM0RlbnVtLCBXR0MzRGVudW0sIFdlYkdMSWQsIFdHQzNEaW50KSk7Ci0KLSAgICBNT0NLX01F VEhPRDIoYmluZFRleHR1cmUsIHZvaWQoV0dDM0RlbnVtLCBXZWJHTElkKSk7Ci0gICAgTU9DS19N RVRIT0Q4KGNvcHlUZXhTdWJJbWFnZTJELCB2b2lkKFdHQzNEZW51bSwgV0dDM0RpbnQsIFdHQzNE aW50LCBXR0MzRGludCwgV0dDM0RpbnQsIFdHQzNEaW50LCBXR0MzRHNpemVpLCBXR0MzRHNpemVp KSk7Ci0KLSAgICBNT0NLX01FVEhPRDEoZGVsZXRlRnJhbWVidWZmZXIsIHZvaWQoV2ViR0xJZCkp OwotICAgIE1PQ0tfTUVUSE9EMShkZWxldGVUZXh0dXJlLCB2b2lkKFdlYkdMSWQpKTsKKyAgICBN T0NLX01FVEhPRDAoZmx1c2gsIHZvaWQodm9pZCkpOwogfTsKIAogY2xhc3MgTW9ja1RleHR1cmVB bGxvY2F0b3IgOiBwdWJsaWMgVGV4dHVyZUFsbG9jYXRvciB7CkBAIC0xMDcsNiArOTcsOSBAQCBw cm90ZWN0ZWQ6CiAgICAgICAgIFJlZlB0cjxHcmFwaGljc0NvbnRleHQzRD4gbWFpbkNvbnRleHQg PSBHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6OmNyZWF0ZUdyYXBoaWNzQ29udGV4dEZyb21XZWJD b250ZXh0KGFkb3B0UHRyKG5ldyBNb2NrQ2FudmFzQ29udGV4dCgpKSwgR3JhcGhpY3NDb250ZXh0 M0Q6OlJlbmRlckRpcmVjdGx5VG9Ib3N0V2luZG93KTsKICAgICAgICAgUmVmUHRyPEdyYXBoaWNz Q29udGV4dDNEPiBpbXBsQ29udGV4dCA9IEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6Y3JlYXRl R3JhcGhpY3NDb250ZXh0RnJvbVdlYkNvbnRleHQoYWRvcHRQdHIobmV3IE1vY2tDYW52YXNDb250 ZXh0KCkpLCBHcmFwaGljc0NvbnRleHQzRDo6UmVuZGVyRGlyZWN0bHlUb0hvc3RXaW5kb3cpOwog CisgICAgICAgIE1vY2tDYW52YXNDb250ZXh0JiBpbXBsTW9jayA9ICpzdGF0aWNfY2FzdDxNb2Nr Q2FudmFzQ29udGV4dCo+KEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6ZXh0cmFjdFdlYkdyYXBo aWNzQ29udGV4dDNEKGltcGxDb250ZXh0LmdldCgpKSk7CisgICAgICAgIE1vY2tDYW52YXNDb250 ZXh0JiBtYWluTW9jayA9ICpzdGF0aWNfY2FzdDxNb2NrQ2FudmFzQ29udGV4dCo+KEdyYXBoaWNz Q29udGV4dDNEUHJpdmF0ZTo6ZXh0cmFjdFdlYkdyYXBoaWNzQ29udGV4dDNEKG1haW5Db250ZXh0 LmdldCgpKSk7CisKICAgICAgICAgTW9ja1RleHR1cmVBbGxvY2F0b3IgYWxsb2NhdG9yTW9jazsK ICAgICAgICAgTW9ja1RleHR1cmVDb3BpZXIgY29waWVyTW9jazsKICAgICAgICAgQ0NUZXh0dXJl VXBkYXRlciB1cGRhdGVyKCZhbGxvY2F0b3JNb2NrLCAmY29waWVyTW9jayk7CkBAIC0xMjcsNiAr MTIwLDkgQEAgcHJvdGVjdGVkOgogICAgICAgICB7CiAgICAgICAgICAgICBJblNlcXVlbmNlIHNl cXVlbmNlOwogCisgICAgICAgICAgICAvLyBQYWludCBjYW52YXMgY29udGVudHMgb24gdGhlIG1h aW4gdGhyZWFkLgorICAgICAgICAgICAgRVhQRUNUX0NBTEwobWFpbk1vY2ssIGZsdXNoKCkpOwor CiAgICAgICAgICAgICAvLyBOb3RlIHRoYXQgdGhlIGNhbnZhcyBiYWNraW5nIHRleHR1cmUgaXMg ZG91YmxlYnVmZmVyZWQgb25seSB3aGVuIHVzaW5nIHRoZSB0aHJlYWRlZAogICAgICAgICAgICAg Ly8gY29tcG9zaXRvci4KICAgICAgICAgICAgIGlmICh0aHJlYWRlZCkgewpAQCAtMTM0LDYgKzEz MCw3IEBAIHByb3RlY3RlZDoKICAgICAgICAgICAgICAgICBFWFBFQ1RfQ0FMTChhbGxvY2F0b3JN b2NrLCBjcmVhdGVUZXh0dXJlKHNpemUsIEdyYXBoaWNzQ29udGV4dDNEOjpSR0JBKSkKICAgICAg ICAgICAgICAgICAgICAgLldpbGxPbmNlKFJldHVybihmcm9udFRleHR1cmVJZCkpOwogICAgICAg ICAgICAgICAgIEVYUEVDVF9DQUxMKGNvcGllck1vY2ssIGNvcHlUZXh0dXJlKGltcGxDb250ZXh0 LmdldCgpLCBiYWNrVGV4dHVyZUlkLCBmcm9udFRleHR1cmVJZCwgc2l6ZSkpOworICAgICAgICAg ICAgICAgIEVYUEVDVF9DQUxMKGltcGxNb2NrLCBmbHVzaCgpKTsKIAogICAgICAgICAgICAgICAg IC8vIFRlYXJkb3duIFRleHR1cmVNYW5hZ2VyLgogICAgICAgICAgICAgICAgIEVYUEVDVF9DQUxM KGFsbG9jYXRvck1vY2ssIGRlbGV0ZVRleHR1cmUoZnJvbnRUZXh0dXJlSWQsIHNpemUsIEdyYXBo aWNzQ29udGV4dDNEOjpSR0JBKSk7Cg==