83004 2012-04-02 23:44:45 -0700 [Plugins] delete ws_info regardless of window mode 2012-04-17 00:47:52 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 justine.bang webkit-unassigned hausmann jmalonzo vestbo oldest_to_newest 594234 0 justine.bang 2012-04-02 23:44:45 -0700 In UNIX port(Gtk/QT/Brackberry), m_npWindow.ws_info = new NPSetWindowCallbackStruct; is called in PluginView::platformStart(). each platform does not delete this object(m_npWindow.ws_info), and it is done in PluginView:stop(). However, If m_isWindowed is false (it means windowless mode), it's not deleted. m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak. Every plugin works well after this patch without any crash. 594237 1 135281 justine.bang 2012-04-02 23:48:19 -0700 Created attachment 135281 [UNIX Plugins] delete ws_info, remove memory leak patch. it's simple. i just removed a condition in the IF statement. 602861 2 137267 justine.bang 2012-04-15 20:03:36 -0700 Created attachment 137267 [UNIX Plugins] delete ws_info, remove memory leak rebase and change casting code to C++ style. 602953 3 135281 hausmann 2012-04-16 01:04:53 -0700 Comment on attachment 135281 [UNIX Plugins] delete ws_info, remove memory leak Mark this as obsolete because there's a second patch for review. 602956 4 137267 hausmann 2012-04-16 01:07:38 -0700 Comment on attachment 137267 [UNIX Plugins] delete ws_info, remove memory leak View in context: https://bugs.webkit.org/attachment.cgi?id=137267&action=review Looks good in general, but I think you can remove the if() altogether and there are a few language nitpicks :) > Source/WebCore/ChangeLog:3 > + [Plugins] delete ws_info regardless window mode. "regardless window mode" -> "regardless of the window mode" > Source/WebCore/ChangeLog:10 > + Additionally, change casting synta to C++ style. synta -> syntax > Source/WebCore/plugins/PluginView.cpp:370 > + if (m_npWindow.ws_info) > + delete static_cast<NPSetWindowCallbackStruct *>(m_npWindow.ws_info); I don't think the if() is needed at all. delete 0 is perfectly valid C++. 602966 5 137298 justine.bang 2012-04-16 01:30:08 -0700 Created attachment 137298 [UNIX Plugins] delete ws_info, remove memory leak change the title. revise wrong word. remove unneeded if(). 602970 6 137298 justine.bang 2012-04-16 01:33:59 -0700 Comment on attachment 137298 [UNIX Plugins] delete ws_info, remove memory leak mark this as obsolete 602977 7 137298 justine.bang 2012-04-16 01:38:57 -0700 Comment on attachment 137298 [UNIX Plugins] delete ws_info, remove memory leak sorry for my mistake 602991 8 137267 justine.bang 2012-04-16 02:01:08 -0700 Comment on attachment 137267 [UNIX Plugins] delete ws_info, remove memory leak >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 1863a58..2b59ef9 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,17 @@ >+2012-04-15 Bang Kwang min <justine.bang@samsung.com> >+ >+ [Plugins] delete ws_info regardless of window mode. >+ https://bugs.webkit.org/show_bug.cgi?id=83004 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak. >+ Every plugin works well after this patch without any crash. >+ Additionally, change casting syntax to C++ style. >+ >+ * plugins/PluginView.cpp: >+ (WebCore::PluginView::stop): >+ > 2012-04-15 James Robinson <jamesr@chromium.org> > > [chromium] LayerRendererChromium shouldn't know anything about CCLayerImpl >diff --git a/Source/WebCore/plugins/PluginView.cpp b/Source/WebCore/plugins/PluginView.cpp >index 749f609..389a8fe 100644 >--- a/Source/WebCore/plugins/PluginView.cpp >+++ b/Source/WebCore/plugins/PluginView.cpp >@@ -366,8 +366,8 @@ void PluginView::stop() > } > > #ifdef XP_UNIX >- if (m_isWindowed && m_npWindow.ws_info) >- delete (NPSetWindowCallbackStruct *)m_npWindow.ws_info; >+ if (m_npWindow.ws_info) >+ delete static_cast<NPSetWindowCallbackStruct *>(m_npWindow.ws_info); > m_npWindow.ws_info = 0; > #endif > 602992 9 137298 justine.bang 2012-04-16 02:02:14 -0700 Comment on attachment 137298 [UNIX Plugins] delete ws_info, remove memory leak as i think, delete 0 is the problem so, please review previous patch. i modified the title and comment. 603001 10 137307 justine.bang 2012-04-16 02:12:41 -0700 Created attachment 137307 [UNIX Plugins] delete ws_info, remove memory leak rebase. I'm sorry i'm not accustomed to manage the attachment. - if remove if(), it does not pass qt port test. 603003 11 hausmann 2012-04-16 02:30:05 -0700 (In reply to comment #10) > Created an attachment (id=137307) [details] > [UNIX Plugins] delete ws_info, remove memory leak > > rebase. > > I'm sorry i'm not accustomed to manage the attachment. No worries, it seems you got the hang of it :) > - > if remove if(), it does not pass qt port test. Can you elaborate a bit on that? 603022 12 hausmann 2012-04-16 03:48:10 -0700 (In reply to comment #9) > (From update of attachment 137298 [details]) > as i think, delete 0 is the problem See also http://www.parashift.com/c++-faq-lite/freestore-mgmt.html#faq-16.8 603053 13 justine.bang 2012-04-16 04:52:24 -0700 (In reply to comment #12) > (In reply to comment #9) > > (From update of attachment 137298 [details] [details]) > > as i think, delete 0 is the problem > > See also http://www.parashift.com/c++-faq-lite/freestore-mgmt.html#faq-16.8 I agree with you, and i has uploaded the patch, but it failed to pass test. please see attachment id 137298. you can see qt, qt-wk2 and efl are pink color. To know why it failed, i'm trying to build QT. 603583 14 137433 justine.bang 2012-04-16 17:04:14 -0700 Created attachment 137433 delete without null checking. delete without null checking. you can say that. 603585 15 justine.bang 2012-04-16 17:06:16 -0700 *** Bug 84021 has been marked as a duplicate of this bug. *** 603849 16 137433 hausmann 2012-04-17 00:46:06 -0700 Comment on attachment 137433 delete without null checking. View in context: https://bugs.webkit.org/attachment.cgi?id=137433&action=review > Source/WebCore/plugins/PluginView.cpp:369 > + delete static_cast<NPSetWindowCallbackStruct *>(m_npWindow.ws_info); Small coding style glitch, space after *. I'll fix it when landing. 603850 17 hausmann 2012-04-17 00:47:52 -0700 Committed r114358: <http://trac.webkit.org/changeset/114358> 135281 2012-04-02 23:48:19 -0700 2012-04-16 01:04:53 -0700 [UNIX Plugins] delete ws_info, remove memory leak patch-[20120403]-[justine.bang@samsung.com]-[delete-ws_info].patch text/plain 1198 justine.bang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMmIxNWVmLi4zYzc1NmZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDQtMDIgIEJhbmcgS3dhbmcgbWluICA8anVzdGluZS5iYW5nQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtQbHVnaW5zXSBkZWxldGUgd3NfaW5mbyByZWdhcmRsZXNzIHdpbmRvdyBt b2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMw MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtX25w V2luZG93LndzX2luZm8gc2hvdWxkIGJlIGRlbGV0ZWQgZXZlbiBpZiBwbHVnaW4gcnVuIGFzIHdp bmRvd2xlc3MgbW9kZSB0byByZW1vdmUgbWVtb3J5IGxlYWsuCisgICAgICAgIEV2ZXJ5IHBsdWdp biB3b3JrcyB3ZWxsIGFmdGVyIHRoaXMgcGF0Y2ggd2l0aG91dCBhbnkgY3Jhc2guCisKKyAgICAg ICAgKiBwbHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmll dzo6c3RvcCk6CisKIDIwMTItMDQtMDIgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVt Lm9yZz4KIAogICAgICAgICA8c2VsZWN0PiBzaG91bGRuJ3QgaW50cnVkZSBhcyBhIHJ1bi1pbi4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4IDc0OWY2MDkuLjQzNzE4ZDAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcApAQCAtMzY2LDcgKzM2Niw3IEBA IHZvaWQgUGx1Z2luVmlldzo6c3RvcCgpCiAgICAgfQogCiAjaWZkZWYgWFBfVU5JWAotICAgIGlm IChtX2lzV2luZG93ZWQgJiYgbV9ucFdpbmRvdy53c19pbmZvKQorICAgIGlmIChtX25wV2luZG93 LndzX2luZm8pCiAgICAgICAgICAgIGRlbGV0ZSAoTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCAq KW1fbnBXaW5kb3cud3NfaW5mbzsKICAgICBtX25wV2luZG93LndzX2luZm8gPSAwOwogI2VuZGlm Cg== 137267 2012-04-15 20:03:36 -0700 2012-04-16 02:12:41 -0700 [UNIX Plugins] delete ws_info, remove memory leak patch-[20120403]-[justine.bang@samsung.com]-[delete-ws_info].patch text/plain 1374 justine.bang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxODYzYTU4Li4yYjU5ZWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDQtMTUgIEJhbmcgS3dhbmcgbWluICA8anVzdGluZS5iYW5nQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtQbHVnaW5zXSBkZWxldGUgd3NfaW5mbyByZWdhcmRsZXNzIHdpbmRvdyBt b2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODMw MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtX25w V2luZG93LndzX2luZm8gc2hvdWxkIGJlIGRlbGV0ZWQgZXZlbiBpZiBwbHVnaW4gcnVuIGFzIHdp bmRvd2xlc3MgbW9kZSB0byByZW1vdmUgbWVtb3J5IGxlYWsuCisgICAgICAgIEV2ZXJ5IHBsdWdp biB3b3JrcyB3ZWxsIGFmdGVyIHRoaXMgcGF0Y2ggd2l0aG91dCBhbnkgY3Jhc2guCisgICAgICAg IEFkZGl0aW9uYWxseSwgY2hhbmdlIGNhc3Rpbmcgc3ludGEgdG8gQysrIHN0eWxlLgorCisgICAg ICAgICogcGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZp ZXc6OnN0b3ApOgorCiAyMDEyLTA0LTE1ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBMYXllclJlbmRlcmVyQ2hyb21pdW0gc2hvdWxk bid0IGtub3cgYW55dGhpbmcgYWJvdXQgQ0NMYXllckltcGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1Bs dWdpblZpZXcuY3BwCmluZGV4IDc0OWY2MDkuLjM4OWE4ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5WaWV3LmNwcApAQCAtMzY2LDggKzM2Niw4IEBAIHZvaWQgUGx1Z2luVmlldzo6c3Rv cCgpCiAgICAgfQogCiAjaWZkZWYgWFBfVU5JWAotICAgIGlmIChtX2lzV2luZG93ZWQgJiYgbV9u cFdpbmRvdy53c19pbmZvKQotICAgICAgICAgICBkZWxldGUgKE5QU2V0V2luZG93Q2FsbGJhY2tT dHJ1Y3QgKiltX25wV2luZG93LndzX2luZm87CisgICAgaWYgKG1fbnBXaW5kb3cud3NfaW5mbykK KyAgICAgICAgICAgZGVsZXRlIHN0YXRpY19jYXN0PE5QU2V0V2luZG93Q2FsbGJhY2tTdHJ1Y3Qg Kj4obV9ucFdpbmRvdy53c19pbmZvKTsKICAgICBtX25wV2luZG93LndzX2luZm8gPSAwOwogI2Vu ZGlmCiAK 137298 2012-04-16 01:30:08 -0700 2012-04-16 02:02:14 -0700 [UNIX Plugins] delete ws_info, remove memory leak patch-[20120403]-[justine.bang@samsung.com]-[delete-ws_info].patch text/plain 1346 justine.bang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxODYzYTU4Li43NjJiMzgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDQtMTUgIEJhbmcgS3dhbmcgbWluICA8anVzdGluZS5iYW5nQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtQbHVnaW5zXSBkZWxldGUgd3NfaW5mbyByZWdhcmRsZXNzIG9mIHRoZSB3 aW5kb3cgbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgzMDA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgbV9ucFdpbmRvdy53c19pbmZvIHNob3VsZCBiZSBkZWxldGVkIGV2ZW4gaWYgcGx1Z2luIHJ1 biBhcyB3aW5kb3dsZXNzIG1vZGUgdG8gcmVtb3ZlIG1lbW9yeSBsZWFrLgorICAgICAgICBFdmVy eSBwbHVnaW4gd29ya3Mgd2VsbCBhZnRlciB0aGlzIHBhdGNoIHdpdGhvdXQgYW55IGNyYXNoLgor ICAgICAgICBBZGRpdGlvbmFsbHksIGNoYW5nZSBjYXN0aW5nIHN5bnRheCB0byBDKysgc3R5bGUu CisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UGx1Z2luVmlldzo6c3RvcCk6CisKIDIwMTItMDQtMTUgIEphbWVzIFJvYmluc29uICA8amFtZXNy QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIExheWVyUmVuZGVyZXJDaHJvbWl1 bSBzaG91bGRuJ3Qga25vdyBhbnl0aGluZyBhYm91dCBDQ0xheWVySW1wbApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs dWdpbnMvUGx1Z2luVmlldy5jcHAKaW5kZXggNzQ5ZjYwOS4uMmM3NWM1YiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCkBAIC0zNjYsOCArMzY2LDcgQEAgdm9pZCBQbHVnaW5W aWV3OjpzdG9wKCkKICAgICB9CiAKICNpZmRlZiBYUF9VTklYCi0gICAgaWYgKG1faXNXaW5kb3dl ZCAmJiBtX25wV2luZG93LndzX2luZm8pCi0gICAgICAgICAgIGRlbGV0ZSAoTlBTZXRXaW5kb3dD YWxsYmFja1N0cnVjdCAqKW1fbnBXaW5kb3cud3NfaW5mbzsKKyAgICBkZWxldGUgc3RhdGljX2Nh c3Q8TlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCAqPihtX25wV2luZG93LndzX2luZm8pOwogICAg IG1fbnBXaW5kb3cud3NfaW5mbyA9IDA7CiAjZW5kaWYKIAo= 137307 2012-04-16 02:12:41 -0700 2012-04-16 17:04:14 -0700 [UNIX Plugins] delete ws_info, remove memory leak patch-[20120403]-[justine.bang@samsung.com]-[delete-ws_info].patch text/plain 1304 justine.bang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMDJiY2NlLi4wZjNmYzc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDQtMTYgIEJhbmcgS3dhbmcgbWluICA8anVzdGluZS5iYW5nQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtQbHVnaW5zXSBkZWxldGUgd3NfaW5mbyByZWdhcmRsZXNzIG9mIHdpbmRv dyBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODMwMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBt X25wV2luZG93LndzX2luZm8gc2hvdWxkIGJlIGRlbGV0ZWQgZXZlbiBpZiBwbHVnaW4gcnVuIGFz IHdpbmRvd2xlc3MgbW9kZSB0byByZW1vdmUgbWVtb3J5IGxlYWsuCisgICAgICAgIEV2ZXJ5IHBs dWdpbiB3b3JrcyB3ZWxsIGFmdGVyIHRoaXMgcGF0Y2ggd2l0aG91dCBhbnkgY3Jhc2guCisgICAg ICAgIEFkZGl0aW9uYWxseSwgY2hhbmdlIGNhc3Rpbmcgc3ludGF4IHRvIEMrKyBzdHlsZS4KKwor ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVn aW5WaWV3OjpzdG9wKToKKwogMjAxMi0wNC0xNiAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+ CiAKICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5WaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAK aW5kZXggNzQ5ZjYwOS4uMzg5YThmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5WaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcu Y3BwCkBAIC0zNjYsOCArMzY2LDggQEAgdm9pZCBQbHVnaW5WaWV3OjpzdG9wKCkKICAgICB9CiAK ICNpZmRlZiBYUF9VTklYCi0gICAgaWYgKG1faXNXaW5kb3dlZCAmJiBtX25wV2luZG93LndzX2lu Zm8pCi0gICAgICAgICAgIGRlbGV0ZSAoTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCAqKW1fbnBX aW5kb3cud3NfaW5mbzsKKyAgICBpZiAobV9ucFdpbmRvdy53c19pbmZvKQorICAgICAgICAgICBk ZWxldGUgc3RhdGljX2Nhc3Q8TlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCAqPihtX25wV2luZG93 LndzX2luZm8pOwogICAgIG1fbnBXaW5kb3cud3NfaW5mbyA9IDA7CiAjZW5kaWYKIAo= 137433 2012-04-16 17:04:14 -0700 2012-04-17 00:46:06 -0700 delete without null checking. patch-[20120403]-[justine.bang@samsung.com]-[delete-ws_info].patch text/plain 1268 justine.bang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMDJiY2NlLi4wZjNmYzc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDQtMTYgIEJhbmcgS3dhbmcgbWluICA8anVzdGluZS5iYW5nQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtQbHVnaW5zXSBkZWxldGUgd3NfaW5mbyByZWdhcmRsZXNzIG9mIHdpbmRv dyBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODMwMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBt X25wV2luZG93LndzX2luZm8gc2hvdWxkIGJlIGRlbGV0ZWQgZXZlbiBpZiBwbHVnaW4gcnVuIGFz IHdpbmRvd2xlc3MgbW9kZSB0byByZW1vdmUgbWVtb3J5IGxlYWsuCisgICAgICAgIEV2ZXJ5IHBs dWdpbiB3b3JrcyB3ZWxsIGFmdGVyIHRoaXMgcGF0Y2ggd2l0aG91dCBhbnkgY3Jhc2guCisgICAg ICAgIEFkZGl0aW9uYWxseSwgY2hhbmdlIGNhc3Rpbmcgc3ludGF4IHRvIEMrKyBzdHlsZS4KKwor ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVn aW5WaWV3OjpzdG9wKToKKwogMjAxMi0wNC0xNiAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+ CiAKICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5WaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAK aW5kZXggNzQ5ZjYwOS4uMzg5YThmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5WaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcu Y3BwCkBAIC0zNjYsOCArMzY2LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpzdG9wKCkKICAgICB9CiAK ICNpZmRlZiBYUF9VTklYCi0gICAgaWYgKG1faXNXaW5kb3dlZCAmJiBtX25wV2luZG93LndzX2lu Zm8pCi0gICAgICAgICAgIGRlbGV0ZSAoTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCAqKW1fbnBX aW5kb3cud3NfaW5mbzsKKyAgICBkZWxldGUgc3RhdGljX2Nhc3Q8TlBTZXRXaW5kb3dDYWxsYmFj a1N0cnVjdCAqPihtX25wV2luZG93LndzX2luZm8pOwogICAgIG1fbnBXaW5kb3cud3NfaW5mbyA9 IDA7CiAjZW5kaWYKIAo=