83000 2012-04-02 23:11:55 -0700 REGRESSION(r80439): Crash in StylePropertySet::borderSpacingValue 2012-04-03 09:52:52 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 rniwa rniwa bdakin darin dbates hyatt kling macpherson menard mikelawther sam simon.fraser webkit.review.bot oldest_to_newest 594218 0 rniwa 2012-04-02 23:11:55 -0700 Reduction: <!DOCTYPE html> <body> <script type="text/javascript"> a = document.createElement("a"); a.setAttribute("style", "-webkit-border-horizontal-spacing:1px;"); a.style.getPropertyValue('border-spacing'); </script> http://crbug.com/121121 594219 1 rniwa 2012-04-02 23:18:51 -0700 Should specifying -webkit-border-horizontal-spacing also set -webkit-border-vertical-spacing to be consistent with the standard border-spacing property? (border-spacing doesn't allow only vertical spacing to be specified). 594239 2 rniwa 2012-04-02 23:48:39 -0700 I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal). 594240 3 135282 rniwa 2012-04-02 23:52:07 -0700 Created attachment 135282 Patch 594368 4 135282 kling 2012-04-03 04:35:17 -0700 Comment on attachment 135282 Patch Good find. 594369 5 kling 2012-04-03 04:36:16 -0700 (In reply to comment #2) > I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal). r=me as is to fix the crash. This question still needs an answer though. 594552 6 rniwa 2012-04-03 09:26:27 -0700 I'm going to land this patch as is since we can always revert it if we want the other behavior instead. (In reply to comment #5) > (In reply to comment #2) > > I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal). > > r=me as is to fix the crash. This question still needs an answer though. Yes, please someone answer my question... 594576 7 135282 webkit.review.bot 2012-04-03 09:52:47 -0700 Comment on attachment 135282 Patch Clearing flags on attachment: 135282 Committed r113049: <http://trac.webkit.org/changeset/113049> 594577 8 webkit.review.bot 2012-04-03 09:52:52 -0700 All reviewed patches have been landed. Closing bug. 135282 2012-04-02 23:52:07 -0700 2012-04-03 09:52:47 -0700 Patch bug-83000-20120402235206.patch text/plain 4297 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjk4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTAyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjgwNDM5KTog Q3Jhc2ggaW4gU3R5bGVQcm9wZXJ0eVNldDo6Ym9yZGVyU3BhY2luZ1ZhbHVlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzAwMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHRoZSBjcmFzaCBieSBl eGl0aW5nIGVhcmx5IGluIFN0eWxlUHJvcGVydHlTZXQ6OmJvcmRlclNwYWNpbmdWYWx1ZSB3aGVu CisgICAgICAgIHRoZSB2ZXJ0aWNhbCB2YWx1ZSBpcyBzZXQuCisKKyAgICAgICAgVGVzdDogZmFz dC9jc3MvYm9yZGVyLXNwYWNpbmctd2l0aG91dC12ZXJ0aWNhbC12YWx1ZS5odG1sCisKKyAgICAg ICAgKiBjc3MvU3R5bGVQcm9wZXJ0eVNldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVBy b3BlcnR5U2V0Ojpib3JkZXJTcGFjaW5nVmFsdWUpOgorCiAyMDEyLTA0LTAyICBEYW5hIEphbnNl bnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIFNr Q2FudmFzOjpMYXllckl0ZXIgdXNlIGZyb20gT3BhcXVlUmVnaW9uU2tpYQpJbmRleDogU291cmNl L1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0LmNwcAkocmV2aXNpb24gMTEyOTUyKQorKysgU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x ODEsOSArMTgxLDExIEBAIFN0cmluZyBTdHlsZVByb3BlcnR5U2V0Ojpib3JkZXJTcGFjaW5nVmEK ICAgICBSZWZQdHI8Q1NTVmFsdWU+IGhvcml6b250YWxWYWx1ZSA9IGdldFByb3BlcnR5Q1NTVmFs dWUoc2hvcnRoYW5kLnByb3BlcnRpZXMoKVswXSk7CiAgICAgUmVmUHRyPENTU1ZhbHVlPiB2ZXJ0 aWNhbFZhbHVlID0gZ2V0UHJvcGVydHlDU1NWYWx1ZShzaG9ydGhhbmQucHJvcGVydGllcygpWzFd KTsKIAotICAgIGlmICghaG9yaXpvbnRhbFZhbHVlKQorICAgIC8vIFdoaWxlIHN0YW5kYXJkIGJv cmRlci1zcGFjaW5nIHByb3BlcnR5IGRvZXMgbm90IGFsbG93IHNwZWNpZnlpbmcgYm9yZGVyLXNw YWNpbmctdmVydGljYWwgd2l0aG91dAorICAgIC8vIHNwZWNpZnlpbmcgYm9yZGVyLXNwYWNpbmct aG9yaXpvbnRhbCA8aHR0cDovL3d3dy53My5vcmcvVFIvQ1NTMjEvdGFibGVzLmh0bWwjc2VwYXJh dGVkLWJvcmRlcnM+LAorICAgIC8vIC13ZWJraXQtYm9yZGVyLXNwYWNpbmctdmVydGljYWwgY2Fu IGJlIHNldCB3aXRob3V0IC13ZWJraXQtYm9yZGVyLXNwYWNpbmctaG9yaXpvbnRhbC4KKyAgICBp ZiAoIWhvcml6b250YWxWYWx1ZSB8fCAhdmVydGljYWxWYWx1ZSkKICAgICAgICAgcmV0dXJuIFN0 cmluZygpOwotICAgIEFTU0VSVCh2ZXJ0aWNhbFZhbHVlKTsgLy8gQnkgPGh0dHA6Ly93d3cudzMu b3JnL1RSL0NTUzIxL3RhYmxlcy5odG1sI3NlcGFyYXRlZC1ib3JkZXJzPi4KIAogICAgIFN0cmlu ZyBob3Jpem9udGFsVmFsdWVDU1NUZXh0ID0gaG9yaXpvbnRhbFZhbHVlLT5jc3NUZXh0KCk7CiAg ICAgU3RyaW5nIHZlcnRpY2FsVmFsdWVDU1NUZXh0ID0gdmVydGljYWxWYWx1ZS0+Y3NzVGV4dCgp OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gMTEyOTg2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDQtMDIgIFJ5b3N1a2UgTml3YSAg PHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyODA0MzkpOiBDcmFzaCBp biBTdHlsZVByb3BlcnR5U2V0Ojpib3JkZXJTcGFjaW5nVmFsdWUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMDAwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgcmVncmVzc2lvbiBmb3Igb2J0YWlu aW5nIHRoZSB2YWx1ZSBvZiBib3JkZXItc3BhY2luZyB3aXRob3V0IHNwZWNpZnlpbmcKKyAgICAg ICAgLXdlYmtpdC1ob3Jpem9udGFsLXZlcnRpY2FsLgorCisgICAgICAgICogZmFzdC9jc3MvYm9y ZGVyLXNwYWNpbmctd2l0aG91dC12ZXJ0aWNhbC12YWx1ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvY3NzL2JvcmRlci1zcGFjaW5nLXdpdGhvdXQtdmVydGljYWwtdmFsdWUu aHRtbDogQWRkZWQuCisKIDIwMTItMDQtMDIgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwu cG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xs ZXIgZGlzYWJsZUltYWdlTG9hZGluZyBpbXBsZW1lbnRhdGlvbi4KSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvY3NzL2JvcmRlci1zcGFjaW5nLXdpdGhvdXQtdmVydGljYWwtdmFsdWUtZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL2JvcmRlci1zcGFjaW5nLXdp dGhvdXQtdmVydGljYWwtdmFsdWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9jc3MvYm9yZGVyLXNwYWNpbmctd2l0aG91dC12ZXJ0aWNhbC12YWx1ZS1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0ZXN0cyBvYnRhaW5p bmcgdGhlIHZhbHVlIG9mICJib3JkZXItc3BhY2luZyIgcHJvcGVydHkgd2l0aG91dCBzZXR0aW5n IC13ZWJraXQtYm9yZGVyLXZlcnRpY2FsLXNwYWNpbmcuIFdlYktpdCBzaG91bGQgbm90IGNyYXNo IGFuZCB3ZSBzaG91bGQgZ2V0IG51bGwuCisKK1BBU1MuIFdlYktpdCBkaWRuJ3QgY3Jhc2guCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9ib3JkZXItc3BhY2luZy13aXRob3V0LXZlcnRpY2Fs LXZhbHVlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvYm9yZGVyLXNw YWNpbmctd2l0aG91dC12ZXJ0aWNhbC12YWx1ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9jc3MvYm9yZGVyLXNwYWNpbmctd2l0aG91dC12ZXJ0aWNhbC12YWx1ZS5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxib2R5Pgor PHA+VGhpcyB0ZXN0cyBvYnRhaW5pbmcgdGhlIHZhbHVlIG9mICJib3JkZXItc3BhY2luZyIgcHJv cGVydHkgd2l0aG91dCBzZXR0aW5nIC13ZWJraXQtYm9yZGVyLXZlcnRpY2FsLXNwYWNpbmcuCitX ZWJLaXQgc2hvdWxkIG5vdCBjcmFzaCBhbmQgd2Ugc2hvdWxkIGdldCBudWxsLjwvcD4KKzxzY3Jp cHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKK3ZhciBhID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOworYS5zZXRBdHRyaWJ1dGUoInN0eWxlIiwgIi13 ZWJraXQtYm9yZGVyLWhvcml6b250YWwtc3BhY2luZzogMXB4OyIpOworCit2YXIgYm9yZGVyU3Bh Y2luZyA9IGEuc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnYm9yZGVyLXNwYWNpbmcnKTsKK2lmIChi b3JkZXJTcGFjaW5nICE9PSBudWxsKQorICAgIGRvY3VtZW50LndyaXRlKCdGQUlMLiBXZWJLaXQg ZGlkblwndCBjcmFzaCBidXQgZ290ICInICsgYm9yZGVyU3BhY2luZyArICciIGJ1dCBleHBlY3Rl ZCAiIi4nKTsKK2Vsc2UKKyAgICBkb2N1bWVudC53cml0ZSgiUEFTUy4gV2ViS2l0IGRpZG4ndCBj cmFzaC4iKTsKKworPC9zY3JpcHQ+Cg==