82993 2012-04-02 18:39:02 -0700 chromium: fast/dom/error-to-string-stack-overflow.html is failing after v8 roll to 3.10.0.2 2012-04-04 01:02:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke webkit-unassigned abarth apavlov danno haraken ulan webkit.review.bot oldest_to_newest 594119 0 dpranke 2012-04-02 18:39:02 -0700 See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fdom%2Ferror-to-string-stack-overflow.html%2Csvg%2Fcustom%2Ftext-ctm.svg&builder=Webkit%20Win It looks like the v8 roll in http://codereview.chromium.org/9950056 caused this, so I'm going to roll it out. I apologize for the lack of notification; it looks like this has been failing all day but we didn't have a webkit gardener so no one noticed. -- Dirk 594318 1 ulan 2012-04-03 02:30:52 -0700 The difference between the expected(-) and the actual(+) in Linux 64-bit: -CONSOLE MESSAGE: Uncaught RangeError: Maximum call stack size exceeded +CONSOLE MESSAGE: line 14: Uncaught RangeError: Maximum call stack size exceeded Regression test for We started reporting the line number with V8 3.10.0.2. Should we adjust the test expectations for Linux 64-bit (platform/chromium-linux/)? Note that the test expectations for Linux 32-bit already have the correct line number: CONSOLE MESSAGE: line 14: Uncaught RangeError: Maximum call stack size exceeded 594329 2 135295 ulan 2012-04-03 03:00:52 -0700 Created attachment 135295 Adjust test expectation to include the line number of the exception. This can be landed after V8 3.10.0.3 roll. 594344 3 135300 ulan 2012-04-03 03:31:17 -0700 Created attachment 135300 Update LayoutTests/platform/chromium/test_expectations.txt to ignore the test Looks like the correct sequence is to land this patch with updated LayoutTests/platform/chromium/test_expectations.txt and then roll V8. Could someone please review and land this patch for me? 594362 4 135300 haraken 2012-04-03 04:10:47 -0700 Comment on attachment 135300 Update LayoutTests/platform/chromium/test_expectations.txt to ignore the test Looks good! 594403 5 135300 webkit.review.bot 2012-04-03 05:52:50 -0700 Comment on attachment 135300 Update LayoutTests/platform/chromium/test_expectations.txt to ignore the test Rejecting attachment 135300 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: queue/Source/WebKit/chromium/third_party/sfntly/cpp/src --revision 128 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 42>At revision 128. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12321126 594405 6 haraken 2012-04-03 05:54:38 -0700 Would you please rebase your patch with the latest WebKit trunk and then re-upload it, just in case? 594415 7 135317 ulan 2012-04-03 06:02:54 -0700 Created attachment 135317 Rebased Rebased to avoid merge conflict. 594437 8 135317 webkit.review.bot 2012-04-03 06:40:16 -0700 Comment on attachment 135317 Rebased Clearing flags on attachment: 135317 Committed r113029: <http://trac.webkit.org/changeset/113029> 594438 9 webkit.review.bot 2012-04-03 06:40:22 -0700 All reviewed patches have been landed. Closing bug. 594699 10 dpranke 2012-04-03 11:53:53 -0700 Oh, I'm sorry I rolled this out just for a rebaseline :(. If I had been sharper last night I would've noticed. Glad it's fixed now, and sorry for the inconvenience! 595297 11 ulan 2012-04-04 01:02:03 -0700 (In reply to comment #10) > Oh, I'm sorry I rolled this out just for a rebaseline :(. If I had been sharper last night I would've noticed. Glad it's fixed now, and sorry for the inconvenience! No problem, we should have updated the expectations before rolling in. 135295 2012-04-03 03:00:52 -0700 2012-04-03 03:31:17 -0700 Adjust test expectation to include the line number of the exception. 82993 text/plain 1478 ulan SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExMzAwMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTAzICBVbGFuIERlZ2VuYmFldiAg PHVsYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGNocm9taXVtOiBmYXN0L2RvbS9lcnJvci10 by1zdHJpbmctc3RhY2stb3ZlcmZsb3cuaHRtbCBpcyBmYWlsaW5nIGFmdGVyIHY4IHJvbGwgdG8g My4xMC4wLjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTgyOTkzCisKKyAgICAgICAgQWRqdXN0IHRlc3QgZXhwZWN0YXRpb24gdG8gaW5jbHVkZSB0aGUg bGluZSBudW1iZXIgb2YgdGhlIGV4Y2VwdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLWxpbnV4L2Zhc3QvZG9t L2Vycm9yLXRvLXN0cmluZy1zdGFjay1vdmVyZmxvdy1leHBlY3RlZC50eHQ6CisKIDIwMTItMDQt MDMgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAg RW5hYmxlIGFuaW1WYWwgc3VwcG9ydCBmb3IgU1ZHQW5pbWF0ZWRFbnVtZXJhdGlvbgpJbmRleDog TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgvZmFzdC9kb20vZXJyb3ItdG8tc3Ry aW5nLXN0YWNrLW92ZXJmbG93LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9mYXN0L2RvbS9lcnJvci10by1zdHJpbmctc3RhY2st b3ZlcmZsb3ctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxMTMwMDIpCisrKyBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS1saW51eC9mYXN0L2RvbS9lcnJvci10by1zdHJpbmctc3RhY2stb3Zl cmZsb3ctZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotQ09OU09M RSBNRVNTQUdFOiBVbmNhdWdodCBSYW5nZUVycm9yOiBNYXhpbXVtIGNhbGwgc3RhY2sgc2l6ZSBl eGNlZWRlZAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDE0OiBVbmNhdWdodCBSYW5nZUVycm9yOiBN YXhpbXVtIGNhbGwgc3RhY2sgc2l6ZSBleGNlZWRlZAogUmVncmVzc2lvbiB0ZXN0IGZvciBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3NzQuIFRoaXMgdGVzdCBwYXNz ZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KIAogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2Vy aWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgo= 135300 2012-04-03 03:31:17 -0700 2012-04-03 06:02:54 -0700 Update LayoutTests/platform/chromium/test_expectations.txt to ignore the test 82993_1 text/plain 2090 ulan SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExMzAwNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTAzICBVbGFuIERlZ2VuYmFldiAg PHVsYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGNocm9taXVtOiBmYXN0L2RvbS9lcnJvci10 by1zdHJpbmctc3RhY2stb3ZlcmZsb3cuaHRtbCBpcyBmYWlsaW5nIGFmdGVyIHY4IHJvbGwgdG8g My4xMC4wLjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTgyOTkzCisKKyAgICAgICAgQWRqdXN0IHRlc3QgZXhwZWN0YXRpb24gdG8gaW5jbHVkZSB0aGUg bGluZSBudW1iZXIgb2YgdGhlIGV4Y2VwdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLWxpbnV4L2Zhc3QvZG9t L2Vycm9yLXRvLXN0cmluZy1zdGFjay1vdmVyZmxvdy1leHBlY3RlZC50eHQ6CisgICAgICAgICog cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDEyLTA0LTAzICBQ aGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBt ZWRpYS92aWRlby12b2x1bWUuaHRtbCBmYWlscyBvbiAzMi1iaXRzIGRlYnVnCkluZGV4OiBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9mYXN0L2RvbS9lcnJvci10by1zdHJpbmct c3RhY2stb3ZlcmZsb3ctZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtLWxpbnV4L2Zhc3QvZG9tL2Vycm9yLXRvLXN0cmluZy1zdGFjay1vdmVy Zmxvdy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDExMzAwNCkKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtLWxpbnV4L2Zhc3QvZG9tL2Vycm9yLXRvLXN0cmluZy1zdGFjay1vdmVyZmxv dy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi1DT05TT0xFIE1F U1NBR0U6IFVuY2F1Z2h0IFJhbmdlRXJyb3I6IE1heGltdW0gY2FsbCBzdGFjayBzaXplIGV4Y2Vl ZGVkCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTQ6IFVuY2F1Z2h0IFJhbmdlRXJyb3I6IE1heGlt dW0gY2FsbCBzdGFjayBzaXplIGV4Y2VlZGVkCiBSZWdyZXNzaW9uIHRlc3QgZm9yIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDc3NC4gVGhpcyB0ZXN0IHBhc3NlcyBp ZiBpdCBkb2Vzbid0IGNyYXNoLgogCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMu dHh0CShyZXZpc2lvbiAxMTMwMDQpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTQwMTksMyArNDAxOSw1IEBA IEJVR1dLIFdJTiBSRUxFQVNFIDogaHR0cC90ZXN0cy94bWxodHRwcmUKIEJVR0NSMTIxNDQyIExJ TlVYIERFQlVHIDogcGx1Z2lucy9pZnJhbWUtc2hpbXMuaHRtbCA9IENSQVNIIFRFWFQgUEFTUwog CiBCVUdXSzgyOTk0IDogY29tcG9zaXRpbmcvcmVmbGVjdGlvbnMvYmFja2ZhY2UtaGlkZGVuLXJl ZmxlY3Rpb24uaHRtbCA9IFBBU1MgQ1JBU0gKKworQlVHV0s4Mjk5MyA6IGZhc3QvZG9tL2Vycm9y LXRvLXN0cmluZy1zdGFjay1vdmVyZmxvdy5odG1sID0gVEVYVAo= 135317 2012-04-03 06:02:54 -0700 2012-04-03 06:40:16 -0700 Rebased 82993_2 text/plain 2140 ulan SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExMzAxOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTAzICBVbGFuIERlZ2VuYmFldiAg PHVsYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGNocm9taXVtOiBmYXN0L2RvbS9lcnJvci10 by1zdHJpbmctc3RhY2stb3ZlcmZsb3cuaHRtbCBpcyBmYWlsaW5nIGFmdGVyIHY4IHJvbGwgdG8g My4xMC4wLjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTgyOTkzCisKKyAgICAgICAgQWRqdXN0IHRlc3QgZXhwZWN0YXRpb24gdG8gaW5jbHVkZSB0aGUg bGluZSBudW1iZXIgb2YgdGhlIGV4Y2VwdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLWxpbnV4L2Zhc3QvZG9t L2Vycm9yLXRvLXN0cmluZy1zdGFjay1vdmVyZmxvdy1leHBlY3RlZC50eHQ6CisgICAgICAgICog cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDEyLTA0LTAzICBD aHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAg W0VGTF0gTGF5b3V0VGVzdENvbnRyb2xsZXIgbmVlZHMgaW1wbGVtZW50YXRpb24gb2Ygc2V0RGVm ZXJzTG9hZGluZwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgvZmFz dC9kb20vZXJyb3ItdG8tc3RyaW5nLXN0YWNrLW92ZXJmbG93LWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9mYXN0L2RvbS9lcnJv ci10by1zdHJpbmctc3RhY2stb3ZlcmZsb3ctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxMTMwMDQp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9mYXN0L2RvbS9lcnJvci10 by1zdHJpbmctc3RhY2stb3ZlcmZsb3ctZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0x LDQgKzEsNCBAQAotQ09OU09MRSBNRVNTQUdFOiBVbmNhdWdodCBSYW5nZUVycm9yOiBNYXhpbXVt IGNhbGwgc3RhY2sgc2l6ZSBleGNlZWRlZAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDE0OiBVbmNh dWdodCBSYW5nZUVycm9yOiBNYXhpbXVtIGNhbGwgc3RhY2sgc2l6ZSBleGNlZWRlZAogUmVncmVz c2lvbiB0ZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA3 NzQuIFRoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KIAogT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkocmV2aXNpb24gMTEzMDE4KQorKysgTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkp CkBAIC0zOTkwLDYgKzM5OTAsNyBAQCBCVUdfT0pBTiBTS0lQIDogZmFzdC9qcy9mdW5jdGlvbi1u YW1lcy5oCiAvLyBpbXBvcnRhbnQuCiBCVUdfT0pBTiBTS0lQIDogZmFzdC9qcy9nbG9iYWwtY29u c3RydWN0b3JzLmh0bWwgPSBGQUlMCiAKK0JVR1dLODI5OTMgTElOVVggOiBmYXN0L2RvbS9lcnJv ci10by1zdHJpbmctc3RhY2stb3ZlcmZsb3cuaHRtbCA9IFRFWFQKIAogLy8gVGhpcyBzaG91bGQg b25seSBiZSBhIGxheWVyIGNoYW5nZS4KIEJVR1dLODIxMjkgOiBmYXN0L2JveC1zaGFkb3cvc2hh ZG93LWJ1ZmZlci1wYXJ0aWFsLmh0bWwgPSBURVhUCg==