8295 2006-04-10 08:33:49 -0700 Dictionary pop-up panel targets the wrong word in a scrolled IFRAME 2012-03-07 09:01:21 -0800 1 1 1 Unclassified WebKit Accessibility 420+ Mac OS X 10.4 VERIFIED FIXED Regression P2 Normal --- 1 mitz webkit-unassigned ap oldest_to_newest 38867 0 mitz 2006-04-10 08:33:49 -0700 Summary: When invoking the Dictionary pop-up panel on a word inside an IFRAME that is scrolled, the pop-up panel is invoked instead on a different word in the frame (the point targeted is offset from the mouse pointer by the scroll offset of the frame). Steps to reproduce: 1) Open the attached test case 2) Click the inner frame's down scroll arrow once 3) Move the mouse pointer over "laoreet" inside the inner frame 4) Press Command-Control-D Expected result: The Dictionary pop-up panel should appear over "laoreet". Actual result: The pop-up panel appears over "vehicula". 38868 1 7618 mitz 2006-04-10 08:35:28 -0700 Created attachment 7618 Test case I am going to attach a patch 38869 2 ap 2006-04-10 08:50:22 -0700 As many editing/accessibility bugs, this has now become a native text field regression, marking as such. 38871 3 7619 mitz 2006-04-10 09:06:03 -0700 Created attachment 7619 Patch, including manual test 38872 4 mitz 2006-04-10 09:14:05 -0700 I think there is a similar problem in -[WebCoreFrameBridge _visiblePositionForPoint] (the final coordinates passed to positionForCoordinates() are wrong). I will try to come up with a test case for that. 38873 5 7619 eric 2006-04-10 09:31:23 -0700 Comment on attachment 7619 Patch, including manual test Looks great. r=me. 7618 2006-04-10 08:35:28 -0700 2006-04-10 08:35:28 -0700 Test case dictionary pop-up.html text/html 1046 mitz PGJvZHkgc3R5bGU9ImhlaWdodDogMjAwMHB4OyI+CjxwPkNsaWNrIHRoZSBmcmFtZSZyc3F1bztz IGRvd24gc2Nyb2xsIGFycm93IG9uY2UsIG1vdmUgdGhlIG1vdXNlIHBvaW50ZXIKb3ZlciAmbGRx dW87PHNwYW4gc3R5bGU9ImNvbG9yOiBncmVlbiI+bGFvcmVldDwvc3Bhbj4mcmRxdW87LCBhbmQg cHJlc3MKQ29tbWFuZC1Db250cm9sLUQgdG8gaW52b2tlIHRoZSBkaWN0aW9uYXJ5IHBvcC11cC48 L3A+CjxpZnJhbWUgc3R5bGU9ImJhY2tncm91bmQ6ICNmZmQ7IiBzcmM9ImRhdGE6dGV4dC9odG1s LEN1cmFiaXR1ciBwcmV0aXVtLCBxdWFtIHF1aXMgc2VtcGVyIG1hbGVzdWFkYSwgZXN0IGxpYmVy byBmZXVnaWF0IGxpYmVybywgdmVsIGZyaW5naWxsYSBvcmNpIG5pYmggc2VkIG5lcXVlLiBRdWlz cXVlIGV1IG51bGxhIG5vbiBuaXNpIG1vbGVzdGllIGFjY3Vtc2FuLiBFdGlhbSB0ZWxsdXMgdXJu YSwgPHNwYW4gc3R5bGU9JTIyY29sb3I6IGdyZWVuOyUyMj5sYW9yZWV0PC9zcGFuPiBhYywgbGFv cmVldCBub24sIHN1c2NpcGl0IHNlZCwgc2FwaWVuLiBQaGFzZWxsdXMgdmVoaWN1bGEsIHNlbSBh dCBwb3N1ZXJlIHZlaGljdWxhLCBhdWd1ZSBuaWJoIG1vbGVzdGllIG5pc2wsIG5lYyB1bGxhbWNv cnBlciBsYWN1cyBhbnRlIHZ1bHB1dGF0ZSBwZWRlLiBDdW0gc29jaWlzIG5hdG9xdWUgcGVuYXRp YnVzIGV0IG1hZ25pcyBkaXMgcGFydHVyaWVudCBtb250ZXMsIG5hc2NldHVyIHJpZGljdWx1cyBt dXMuIE1hdXJpcyB2aXZlcnJhIGF1Z3VlIHZpdGFlIHB1cnVzLiBNb3JiaSBzZWQgc2VtLiBEb25l YyBkdWkgbmlzaSwgdWx0cmljZXMgbm9uLCBwcmV0aXVtIHF1aXMsIGhlbmRyZXJpdCBub24sIGVz dC4gRG9uZWMgdGVsbHVzLiBEb25lYyBlZ2V0IGR1aSBpZCBlcm9zIHBoYXJldHJhIHJ1dHJ1bS4g U3VzcGVuZGlzc2Ugc29kYWxlcyBsZWN0dXMgc2l0IGFtZXQgbnVsbGEuIE1vcmJpIHRvcnRvciBh cmN1LCBjb252YWxsaXMgYmxhbmRpdCwgZWxlbWVudHVtIGV1LCBhbGlxdWV0IGEsIHRlbGx1cy4K Ij48L2lmcmFtZT4KPC9ib2R5Pgo= 7619 2006-04-10 09:06:03 -0700 2012-03-07 09:01:21 -0800 Patch, including manual test 8295_r1.patch text/plain 4043 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMzc1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDYtMDQtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD04Mjk1CisgICAgICAgICAgRGljdGlvbmFyeSBwb3AtdXAgcGFuZWwgdGFyZ2V0cyB0aGUg d3Jvbmcgd29yZCBpbiBhIHNjcm9sbGVkIElGUkFNRQorCisgICAgICAgICoga3dxL1dlYkNvcmVB WE9iamVjdC5tbToKKyAgICAgICAgKC1bV2ViQ29yZUFYT2JqZWN0IGRvQVhUZXh0TWFya2VyRm9y UG9zaXRpb246XSk6IFJlbW92ZWQgdGhlIGFkZGl0aW9uIG9mIHNjcm9sbAorICAgICAgICBvZmZz ZXRzLCB3aGljaCBpcyByZWR1bmRhbnQgZm9yIHNjcm9sbGVkIHZpZXdzLCB0aGVuIGNoYW5nZWQg dGhlIGZpcnN0IHZpZXcKKyAgICAgICAgdG8gYmUgdGhlIGRvY3VtZW50J3Mgc2Nyb2xsZWQgdmll dyBpbnN0ZWFkIG9mIGl0cyBzY3JvbGwgdmlldyAoYWxsIHN1YnNlcXVlbnQgdmlld3Mgd2VyZQor ICAgICAgICBhbHJlYWR5IHNjcm9sbGVkIHZpZXdzKS4KKyAgICAgICAgKiBtYW51YWwtdGVzdHMv ZGljdGlvbmFyeS1zY3JvbGxlZC1pZnJhbWUuaHRtbDogQWRkZWQuCisKIDIwMDYtMDQtMDkgIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEBueXBvcC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4uCkluZGV4OiBXZWJDb3JlL2t3cS9XZWJDb3JlQVhPYmplY3QubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9rd3EvV2ViQ29yZUFYT2JqZWN0Lm1tCShyZXZpc2lvbiAxMzc0MykKKysrIFdl YkNvcmUva3dxL1dlYkNvcmVBWE9iamVjdC5tbQkod29ya2luZyBjb3B5KQpAQCAtMTA0Nyw3ICsx MDQ3LDcgQEAgc3RhdGljIEludFJlY3QgYm91bmRpbmdCb3hSZWN0KFJlbmRlck9iagogewogICAg IC8vIGNvbnZlcnQgYWJzb2x1dGUgcG9pbnQgdG8gdmlldyBjb29yZGluYXRlcwogICAgIEZyYW1l VmlldyAqZG9jVmlldyA9IFtzZWxmIHRvcFZpZXddOwotICAgIE5TVmlldyAqdmlldyA9IGRvY1Zp ZXctPmdldFZpZXcoKTsKKyAgICBOU1ZpZXcgKnZpZXcgPSBkb2NWaWV3LT5nZXREb2N1bWVudFZp ZXcoKTsKICAgICBSZW5kZXJPYmplY3QgKnJlbmRlcmVyID0gW3NlbGYgdG9wUmVuZGVyZXJdOwog ICAgIE5vZGUgKmlubmVyTm9kZSA9IE5VTEw7CiAgICAgTlNQb2ludCBvdXJwb2ludDsKQEAgLTEw NTcsOCArMTA1Nyw2IEBAIHN0YXRpYyBJbnRSZWN0IGJvdW5kaW5nQm94UmVjdChSZW5kZXJPYmoK ICAgICAgICAgLy8gYXNrIHRoZSBkb2N1bWVudCBsYXllciB0byBoaXRUZXN0CiAgICAgICAgIE5T UG9pbnQgd2luZG93Q29vcmQgPSBbW3ZpZXcgd2luZG93XSBjb252ZXJ0U2NyZWVuVG9CYXNlOiBw b2ludF07CiAgICAgICAgIG91cnBvaW50ID0gW3ZpZXcgY29udmVydFBvaW50OndpbmRvd0Nvb3Jk IGZyb21WaWV3Om5pbF07Ci0gICAgICAgIG91cnBvaW50LnggKz0gZG9jVmlldy0+Y29udGVudHNY KCk7Ci0gICAgICAgIG91cnBvaW50LnkgKz0gZG9jVmlldy0+Y29udGVudHNZKCk7CiAgICAgICAg IAogICAgICAgICBSZW5kZXJPYmplY3Q6Ok5vZGVJbmZvIG5vZGVJbmZvKHRydWUsIHRydWUpOwog ICAgICAgICByZW5kZXJlci0+bGF5ZXIoKS0+aGl0VGVzdChub2RlSW5mbywgSW50UG9pbnQob3Vy cG9pbnQpKTsKSW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL2RpY3Rpb25hcnktc2Nyb2xsZWQt aWZyYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9tYW51YWwtdGVzdHMvZGljdGlvbmFy eS1zY3JvbGxlZC1pZnJhbWUuaHRtbAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvbWFudWFsLXRl c3RzL2RpY3Rpb25hcnktc2Nyb2xsZWQtaWZyYW1lLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMjggQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0LjAxLy9F TiIKKyAgICAgICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L3N0cmljdC5kdGQiPgorPGh0 bWwgbGFuZz0iZW4iPgorPGhlYWQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPjxiPkJVRyBJRDo8L2I+ IDxhIGhyZWY9Imh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODI5NSI+QnVnemlsbGEgYnVnIDgyOTU8L2E+IERpY3Rpb25hcnkgcG9wLXVwIHBhbmVsIHRhcmdl dHMgdGhlIHdyb25nIHdvcmQgaW4gYSBzY3JvbGxlZCBJRlJBTUU8L3A+CisKKzxwIGlkPSJ0ZXN0 IiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjpza3libHVlOyBwYWRkaW5nOjNweDsiPjxiPlNURVBT IFRPIFRFU1Q6PC9iPjxicj4KKzEuIENsaWNrIHRoZSBpbm5lciBmcmFtZSZyc3F1bztzIGRvd24g c2Nyb2xsIGFycm93IG9uY2UuPGJyPgorMi4gTW92ZSB0aGUgbW91c2UgcG9pbnRlcgorb3ZlciAm bGRxdW87dGFyZ2V0JnJkcXVvOy48YnI+CiszLiBQcmVzcyBDb21tYW5kLUNvbnRyb2wtRCB0byBp bnZva2UgdGhlIERpY3Rpb25hcnkgcG9wLXVwIHBhbmVsLgorPC9wPgorCis8cCBpZD0ic3VjY2Vz cyIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6cGFsZWdyZWVuOyBwYWRkaW5nOjNweDsiPjxiPlRF U1QgUEFTUzo8L2I+IAorVGhlIERpY3Rpb25hcnkgcG9wLXVwIHBhbmVsIHdpbGwgYXBwZWFyIG92 ZXIgJmxkcXVvO3RhcmdldCZyZHF1bzssIGdpdmluZyBpdHMgZGVmaW5pdGlvbi4KKzwvcD4KKwor PHAgaWQ9ImZhaWx1cmUiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiNGRjMzMDA7IHBhZGRpbmc6 M3B4OyI+PGI+VEVTVCBGQUlMOjwvYj4gIAorVGhlIERpY3Rpb25hcnkgcG9wLXVwIHBhbmVsIHdp bGwgYXBwZWFyIG92ZXIgJmxkcXVvO2ZhaWx1cmUmcmRxdW87LCB3aXRoIHRoZSBkZWZpbml0aW9u IG9mIGZhaWx1cmUuCis8L3A+CisKKzxpZnJhbWUgc3R5bGU9ImJhY2tncm91bmQ6ICNmZmQ7IiBz cmM9ImRhdGE6dGV4dC9odG1sLEN1cmFiaXR1ciBwcmV0aXVtLCBxdWFtIHF1aXMgc2VtcGVyIG1h bGVzdWFkYSwgZXN0IGxpYmVybyBmZXVnaWF0IGxpYmVybywgdmVsIGZyaW5naWxsYSBvcmNpIG5p Ymggc2VkIG5lcXVlLiBRdWlzcXVlIGV1IG51bGxhIG5vbiBuaXNpIG1vbGVzdGllIGFjY3Vtc2Fu LiBFdGlhbSB0ZWxsdXMgdXJuYSwgPHNwYW4gc3R5bGU9JTIyY29sb3I6IGdyZWVuOyUyMj50YXJn ZXQ8L3NwYW4+IGFjLCBsYW9yZWV0IG5vbiwgc3VzY2lwaXQgc2VkLCBzYXBpZW4uIFBoYXNlbGx1 cyB2ZWhpY3VsYSwgc2VtIGF0IHBvc3VlcmUgdGVsIGZhaWx1cmUsIGF1Z3VlIG5pYmggbW9sZXN0 aWUgbmlzbCwgbmVjIHVsbGFtY29ycGVyIGxhY3VzIGFudGUgdnVscHV0YXRlIHBlZGUuIEN1bSBz b2NpaXMgbmF0b3F1ZSBwZW5hdGlidXMgZXQgbWFnbmlzIGRpcyBwYXJ0dXJpZW50IG1vbnRlcywg bmFzY2V0dXIgcmlkaWN1bHVzIG11cy4gTWF1cmlzIHZpdmVycmEgYXVndWUgdml0YWUgcHVydXMu IE1vcmJpIHNlZCBzZW0uIERvbmVjIGR1aSBuaXNpLCB1bHRyaWNlcyBub24sIHByZXRpdW0gcXVp cywgaGVuZHJlcml0IG5vbiwgZXN0LiBEb25lYyB0ZWxsdXMuIERvbmVjIGVnZXQgZHVpIGlkIGVy b3MgcGhhcmV0cmEgcnV0cnVtLiBTdXNwZW5kaXNzZSBzb2RhbGVzIGxlY3R1cyBzaXQgYW1ldCBu dWxsYS4gTW9yYmkgdG9ydG9yIGFyY3UsIGNvbnZhbGxpcyBibGFuZGl0LCBlbGVtZW50dW0gZXUs IGFsaXF1ZXQgYSwgdGVsbHVzLgorIj48L2lmcmFtZT4KKworPC9ib2R5PgorPC9odG1sPgo=