82944 2012-04-02 14:12:22 -0700 [mac] LayoutTestHelper crashes if there is no main display 2012-04-02 14:24:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton webkit-unassigned jberlin simon.fraser oldest_to_newest 593827 0 thorton 2012-04-02 14:12:22 -0700 It looks like LayoutTestHelper is crashing on some of the bots because ColorSyncDeviceCopyDeviceInfo returns null. It looks like this is probably due to them not having a display. We should check for this case and not do anything to the main display color profile, since I don't see how we can! I'm not sure what will happen to the colorspace of pixel results in that situation, but fixing this can't make it *worse*. 593828 1 thorton 2012-04-02 14:12:42 -0700 <rdar://problem/11162954> 593830 2 135183 thorton 2012-04-02 14:14:57 -0700 Created attachment 135183 patch 593841 3 thorton 2012-04-02 14:24:25 -0700 Landed in http://trac.webkit.org/changeset/112943 135183 2012-04-02 14:14:57 -0700 2012-04-02 14:16:01 -0700 patch tools.diff text/plain 2170 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3YWE0 YTY5Li4xMjkwNGQ5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDQtMDIgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY10gTGF5b3V0VGVzdEhlbHBlciBjcmFz aGVzIGlmIHRoZXJlIGlzIG5vIG1haW4gZGlzcGxheQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI5NDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEx MTYyOTU0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHRoZXJlJ3Mgbm8gbWFpbiBkaXNwbGF5IGF0dGFjaGVkLCBDb2xvclN5bmNEZXZpY2VDb3B5 RGV2aWNlSW5mbyByZXR1cm5zCisgICAgICAgIGEgbnVsbCBkaWN0aW9uYXJ5LCBzbyB3ZSBzaG91 bGRuJ3QgZ28gYWhlYWQgYW5kIHRyeSB0byByZWFkIGZyb20gaXQuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdEhlbHBlci5tOgorICAgICAgICAoaW5zdGFsbExheW91 dFRlc3RDb2xvclByb2ZpbGUpOgorCiAyMDEyLTA0LTAyICBCYWxhenMgS2VsZW1lbiAgPGtiYWxh enNAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdW1dLMl0gU2V0IHVwIHBsdWdpbiBwcm9jZXNz IG9uIFVuaXgKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9MYXlvdXRUZXN0 SGVscGVyLm0gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdEhlbHBlci5tCmlu ZGV4IGEyNzdhNjMuLjk2MWZmMzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21h Yy9MYXlvdXRUZXN0SGVscGVyLm0KKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0xheW91 dFRlc3RIZWxwZXIubQpAQCAtNTQsNiArNTQsMTIgQEAgc3RhdGljIHZvaWQgaW5zdGFsbExheW91 dFRlc3RDb2xvclByb2ZpbGUoKQogICAgIAogICAgIGlmICghc1VzZXJDb2xvclByb2ZpbGVVUkwp IHsKICAgICAgICAgQ0ZEaWN0aW9uYXJ5UmVmIGRldmljZUluZm8gPSBDb2xvclN5bmNEZXZpY2VD b3B5RGV2aWNlSW5mbyhrQ29sb3JTeW5jRGlzcGxheURldmljZUNsYXNzLCBtYWluRGlzcGxheUlE KTsKKworICAgICAgICBpZiAoIWRldmljZUluZm8pIHsKKyAgICAgICAgICAgIE5TTG9nKEAiTm8g ZGlzcGxheSBhdHRhY2hlZCB0byBzeXN0ZW07IG5vdCBzZXR0aW5nIG1haW4gZGlzcGxheSdzIGNv bG9yIHByb2ZpbGUuIik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKwogICAgICAg ICBDRkRpY3Rpb25hcnlSZWYgcHJvZmlsZUluZm8gPSAoQ0ZEaWN0aW9uYXJ5UmVmKUNGRGljdGlv bmFyeUdldFZhbHVlKGRldmljZUluZm8sIGtDb2xvclN5bmNDdXN0b21Qcm9maWxlcyk7CiAgICAg ICAgIGlmIChwcm9maWxlSW5mbykgewogICAgICAgICAgICAgc1VzZXJDb2xvclByb2ZpbGVVUkwg PSAoQ0ZVUkxSZWYpQ0ZEaWN0aW9uYXJ5R2V0VmFsdWUocHJvZmlsZUluZm8sIENGU1RSKCIxIikp OwpAQCAtODMsNyArODksNyBAQCBzdGF0aWMgdm9pZCBpbnN0YWxsTGF5b3V0VGVzdENvbG9yUHJv ZmlsZSgpCiAgICAgQ0ZEaWN0aW9uYXJ5U2V0VmFsdWUocHJvZmlsZUluZm8sIGtDb2xvclN5bmNE ZXZpY2VEZWZhdWx0UHJvZmlsZUlELCBwcm9maWxlVVJMKTsKICAgICAKICAgICBpZiAoIUNvbG9y U3luY0RldmljZVNldEN1c3RvbVByb2ZpbGVzKGtDb2xvclN5bmNEaXNwbGF5RGV2aWNlQ2xhc3Ms IG1haW5EaXNwbGF5SUQsIHByb2ZpbGVJbmZvKSkgewotICAgICAgICBmcHJpbnRmKHN0ZGVyciwg IkZhaWxlZCB0byBzZXQgY29sb3IgcHJvZmlsZSBmb3IgbWFpbiBkaXNwbGF5ISBNYW55IHBpeGVs IHRlc3RzIG1heSBmYWlsIGFzIGEgcmVzdWx0LlxuIik7CisgICAgICAgIE5TTG9nKEAiRmFpbGVk IHRvIHNldCBjb2xvciBwcm9maWxlIGZvciBtYWluIGRpc3BsYXkhIE1hbnkgcGl4ZWwgdGVzdHMg bWF5IGZhaWwgYXMgYSByZXN1bHQuIik7CiAgICAgICAgIAogICAgICAgICBpZiAoc1VzZXJDb2xv clByb2ZpbGVVUkwpIHsKICAgICAgICAgICAgIENGUmVsZWFzZShzVXNlckNvbG9yUHJvZmlsZVVS TCk7Cg==