82940 2012-04-02 13:36:49 -0700 Simplify CSSStyleSelector constructor through the use of a helper function 2012-04-03 05:11:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric aa abarth gustavo macpherson menard webkit.review.bot xan.lopez oldest_to_newest 593776 0 eric 2012-04-02 13:36:49 -0700 Simplify CSSStyleSelector constructor through the use of a helper function 593778 1 135171 eric 2012-04-02 13:37:34 -0700 Created attachment 135171 Patch 593801 2 135171 menard 2012-04-02 13:55:18 -0700 Comment on attachment 135171 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135171&action=review > Source/WebCore/css/CSSStyleSelector.cpp:410 > +void CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets(const Vector<RefPtr<CSSStyleSheet> >* userSheets, RuleSet& userStyle) While I see the benefit of the patch to avoid code duplication, I'm not sure whether it's part of the usage to pass a object by reference to modify it. 593806 3 eric 2012-04-02 13:57:35 -0700 See http://www.webkit.org/coding/coding-style.html "Pointers and References" for minimal guidance on the subject. In short: yes, we do pass by reference at times. 593808 4 eric 2012-04-02 13:58:09 -0700 "An out argument of a function should be passed by reference except rare cases where it is optional in which case it should be passed by pointer." seems to suggest that we prefer references to pointers. :) 593887 5 135171 gustavo 2012-04-02 14:56:51 -0700 Comment on attachment 135171 Patch Attachment 135171 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12310679 593903 6 135171 eric 2012-04-02 15:10:11 -0700 Comment on attachment 135171 Patch gtk lies! 594393 7 135171 webkit.review.bot 2012-04-03 05:11:28 -0700 Comment on attachment 135171 Patch Clearing flags on attachment: 135171 Committed r113016: <http://trac.webkit.org/changeset/113016> 594395 8 webkit.review.bot 2012-04-03 05:11:34 -0700 All reviewed patches have been landed. Closing bug. 135171 2012-04-02 13:37:34 -0700 2012-04-03 05:11:28 -0700 Patch bug-82940-20120402133732.patch text/plain 4278 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyODIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU0NzJiZmJmZDI5ZGZh OGU4NWY1MWQ0Y2VkM2FhOGI5MDZkYTE1Yi4uN2ZjYzdjYzVkZDUxN2NkNDU5MjgyYWEyYzE3YTU4 ODA2YTE2YjAzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTAyICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBTaW1wbGlmeSBDU1NTdHlsZVNl bGVjdG9yIGNvbnN0cnVjdG9yIHRocm91Z2ggdGhlIHVzZSBvZiBhIGhlbHBlciBmdW5jdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI5NDAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlv ciBjaGFuZ2UsIHRodXMgbm8gdGVzdHMuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rv ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpDU1NTdHlsZVNlbGVj dG9yKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxl Y3Rvcjo6YWRkQXV0aG9yUnVsZXNBbmRDb2xsZWN0VXNlclJ1bGVzRnJvbVNoZWV0cyk6CisgICAg ICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuaDoKKyAgICAgICAgKENTU1N0eWxlU2VsZWN0b3Ip OgorCiAyMDEyLTA0LTAxICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTEyNzYwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0 eWxlU2VsZWN0b3IuY3BwCmluZGV4IGVlODJjY2E5MmZiMWY1N2QzZTJjMTk5MjkxNDY1OTY3NjI4 NzRhYzQuLmJhOTYxOTNjYzcwZDEwYWM2YjMzYzY2YmE1NTg1NjNkNzZiZjQ1M2YgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKQEAgLTM5MCwyNSArMzkwLDggQEAgQ1NT U3R5bGVTZWxlY3Rvcjo6Q1NTU3R5bGVTZWxlY3RvcihEb2N1bWVudCogZG9jdW1lbnQsIGJvb2wg bWF0Y2hBdXRob3JBbmRVc2VyU3QKICAgICBPd25QdHI8UnVsZVNldD4gdGVtcFVzZXJTdHlsZSA9 IGFkb3B0UHRyKG5ldyBSdWxlU2V0KTsKICAgICBpZiAoQ1NTU3R5bGVTaGVldCogcGFnZVVzZXJT aGVldCA9IGRvY3VtZW50LT5wYWdlVXNlclNoZWV0KCkpCiAgICAgICAgIHRlbXBVc2VyU3R5bGUt PmFkZFJ1bGVzRnJvbVNoZWV0KHBhZ2VVc2VyU2hlZXQsICptX21lZGl1bSwgdGhpcyk7Ci0gICAg aWYgKGNvbnN0IFZlY3RvcjxSZWZQdHI8Q1NTU3R5bGVTaGVldD4gPiogcGFnZUdyb3VwVXNlclNo ZWV0cyA9IGRvY3VtZW50LT5wYWdlR3JvdXBVc2VyU2hlZXRzKCkpIHsKLSAgICAgICAgdW5zaWdu ZWQgbGVuZ3RoID0gcGFnZUdyb3VwVXNlclNoZWV0cy0+c2l6ZSgpOwotICAgICAgICBmb3IgKHVu c2lnbmVkIGkgPSAwOyBpIDwgbGVuZ3RoOyBpKyspIHsKLSAgICAgICAgICAgIGlmIChwYWdlR3Jv dXBVc2VyU2hlZXRzLT5hdChpKS0+aXNVc2VyU3R5bGVTaGVldCgpKQotICAgICAgICAgICAgICAg IHRlbXBVc2VyU3R5bGUtPmFkZFJ1bGVzRnJvbVNoZWV0KHBhZ2VHcm91cFVzZXJTaGVldHMtPmF0 KGkpLmdldCgpLCAqbV9tZWRpdW0sIHRoaXMpOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAg ICAgICAgIG1fYXV0aG9yU3R5bGUtPmFkZFJ1bGVzRnJvbVNoZWV0KHBhZ2VHcm91cFVzZXJTaGVl dHMtPmF0KGkpLmdldCgpLCAqbV9tZWRpdW0sIHRoaXMpOwotICAgICAgICB9Ci0gICAgfQotICAg IGlmIChjb25zdCBWZWN0b3I8UmVmUHRyPENTU1N0eWxlU2hlZXQ+ID4qIGRvY3VtZW50VXNlclNo ZWV0cyA9IGRvY3VtZW50LT5kb2N1bWVudFVzZXJTaGVldHMoKSkgewotICAgICAgICB1bnNpZ25l ZCBsZW5ndGggPSBkb2N1bWVudFVzZXJTaGVldHMtPnNpemUoKTsKLSAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7Ci0gICAgICAgICAgICBpZiAoZG9jdW1lbnRV c2VyU2hlZXRzLT5hdChpKS0+aXNVc2VyU3R5bGVTaGVldCgpKQotICAgICAgICAgICAgICAgIHRl bXBVc2VyU3R5bGUtPmFkZFJ1bGVzRnJvbVNoZWV0KGRvY3VtZW50VXNlclNoZWV0cy0+YXQoaSku Z2V0KCksICptX21lZGl1bSwgdGhpcyk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAg ICAgbV9hdXRob3JTdHlsZS0+YWRkUnVsZXNGcm9tU2hlZXQoZG9jdW1lbnRVc2VyU2hlZXRzLT5h dChpKS5nZXQoKSwgKm1fbWVkaXVtLCB0aGlzKTsKLSAgICAgICAgfQotICAgIH0KLQorICAgIGFk ZEF1dGhvclJ1bGVzQW5kQ29sbGVjdFVzZXJSdWxlc0Zyb21TaGVldHMoZG9jdW1lbnQtPnBhZ2VH cm91cFVzZXJTaGVldHMoKSwgKnRlbXBVc2VyU3R5bGUpOworICAgIGFkZEF1dGhvclJ1bGVzQW5k Q29sbGVjdFVzZXJSdWxlc0Zyb21TaGVldHMoZG9jdW1lbnQtPmRvY3VtZW50VXNlclNoZWV0cygp LCAqdGVtcFVzZXJTdHlsZSk7CiAgICAgaWYgKHRlbXBVc2VyU3R5bGUtPm1fcnVsZUNvdW50ID4g MCB8fCB0ZW1wVXNlclN0eWxlLT5tX3BhZ2VSdWxlcy5zaXplKCkgPiAwKQogICAgICAgICBtX3Vz ZXJTdHlsZSA9IHRlbXBVc2VyU3R5bGUucmVsZWFzZSgpOwogCkBAIC00MjMsNyArNDA2LDIyIEBA IENTU1N0eWxlU2VsZWN0b3I6OkNTU1N0eWxlU2VsZWN0b3IoRG9jdW1lbnQqIGRvY3VtZW50LCBi b29sIG1hdGNoQXV0aG9yQW5kVXNlclN0CiAKICAgICBhcHBlbmRBdXRob3JTdHlsZXNoZWV0cygw LCBkb2N1bWVudC0+c3R5bGVTaGVldHMoKS0+dmVjdG9yKCkpOwogfQotICAgIAorCit2b2lkIENT U1N0eWxlU2VsZWN0b3I6OmFkZEF1dGhvclJ1bGVzQW5kQ29sbGVjdFVzZXJSdWxlc0Zyb21TaGVl dHMoY29uc3QgVmVjdG9yPFJlZlB0cjxDU1NTdHlsZVNoZWV0PiA+KiB1c2VyU2hlZXRzLCBSdWxl U2V0JiB1c2VyU3R5bGUpCit7CisgICAgaWYgKCF1c2VyU2hlZXRzKQorICAgICAgICByZXR1cm47 CisKKyAgICB1bnNpZ25lZCBsZW5ndGggPSB1c2VyU2hlZXRzLT5zaXplKCk7CisgICAgZm9yICh1 bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7CisgICAgICAgIGNvbnN0IFJlZlB0cjxD U1NTdHlsZVNoZWV0PiYgc2hlZXQgPSB1c2VyU2hlZXRzLT5hdChpKTsKKyAgICAgICAgaWYgKHNo ZWV0LT5pc1VzZXJTdHlsZVNoZWV0KCkpCisgICAgICAgICAgICB1c2VyU3R5bGUuYWRkUnVsZXNG cm9tU2hlZXQoc2hlZXQuZ2V0KCksICptX21lZGl1bSwgdGhpcyk7CisgICAgICAgIGVsc2UKKyAg ICAgICAgICAgIG1fYXV0aG9yU3R5bGUtPmFkZFJ1bGVzRnJvbVNoZWV0KHNoZWV0LmdldCgpLCAq bV9tZWRpdW0sIHRoaXMpOworICAgIH0KK30KKwogc3RhdGljIFBhc3NPd25QdHI8UnVsZVNldD4g bWFrZVJ1bGVTZXQoY29uc3QgVmVjdG9yPENTU1N0eWxlU2VsZWN0b3I6OlJ1bGVGZWF0dXJlPiYg cnVsZXMpCiB7CiAgICAgc2l6ZV90IHNpemUgPSBydWxlcy5zaXplKCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1N0eWxlU2VsZWN0b3IuaAppbmRleCA1ODE4MzY3NGE5MjJiMmY2MWMzMzc5YTc3ZmNkMmMw ZDFiMDAwNDg0Li42NWNkNDAwOWUzNTRkZjYzNzQyZGFjMTI3NmZjNjU4ZmY3YmI0NWZmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmgKQEAgLTM5Myw2ICszOTMsOCBAQCBwdWJs aWM6CiBwcml2YXRlOgogICAgIHN0YXRpYyBSZW5kZXJTdHlsZSogc19zdHlsZU5vdFlldEF2YWls YWJsZTsKIAorICAgIHZvaWQgYWRkQXV0aG9yUnVsZXNBbmRDb2xsZWN0VXNlclJ1bGVzRnJvbVNo ZWV0cyhjb25zdCBWZWN0b3I8UmVmUHRyPENTU1N0eWxlU2hlZXQ+ID4qLCBSdWxlU2V0JiB1c2Vy U3R5bGUpOworCiAgICAgdm9pZCBjYWNoZUJvcmRlckFuZEJhY2tncm91bmQoKTsKIAogICAgIHZv aWQgbWFwRmlsbEF0dGFjaG1lbnQoQ1NTUHJvcGVydHlJRCwgRmlsbExheWVyKiwgQ1NTVmFsdWUq KTsK