82917 2012-04-02 11:24:29 -0700 [Qt][WK2] ResourceError::isCancellation() is always returning false 2012-04-02 12:47:02 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 jesus jesus kenneth menard webkit.review.bot zoltan oldest_to_newest 593626 0 jesus 2012-04-02 11:24:29 -0700 We are missing the encoding of a boolean in ArgumentCoder<ResourceError> and, therefore, we always get the default value (false) for ResourceError::isCancellation() with errors being sent through the IPC. This is impacting directly the implementation of QtWebPageLoadClient::dispatchLoadFailed, line 95. 593639 1 135142 jesus 2012-04-02 11:45:38 -0700 Created attachment 135142 Patch 593705 2 135142 jesus 2012-04-02 12:46:55 -0700 Comment on attachment 135142 Patch Clearing flags on attachment: 135142 Committed r112921: <http://trac.webkit.org/changeset/112921> 593707 3 jesus 2012-04-02 12:47:02 -0700 All reviewed patches have been landed. Closing bug. 135142 2012-04-02 11:45:38 -0700 2012-04-02 12:46:54 -0700 Patch bug-82917-20120402154502.patch text/plain 2306 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWNjNDg1ZWZjYTRlMTA3 MWU1YWU5MWM5NjE4ZGIyNjJjZmU5Y2YzMi4uMGQ4NTMzZjZiZDJjY2M2YTgwZDhiN2M4ZTg0NDY0 MGMyYjZmMTUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTAyICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbUXRdW1dLMl0gUmVzb3VyY2VFcnJvcjo6aXNDYW5jZWxsYXRpb24oKSBpcyBhbHdheXMg cmV0dXJuaW5nIGZhbHNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MjkxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIHdlcmUgbWlzc2luZyB0aGUgZW5jb2Rpbmcgb2YgYSBib29sZWFuIGluIEFyZ3Vt ZW50Q29kZXI8UmVzb3VyY2VFcnJvcj4KKyAgICAgICAgYW5kLCB0aGVyZWZvcmUsIHdlIHdlcmUg Z2V0dGluZyBhbHdheXMgImZhbHNlIiBmb3IgUmVzb3VyY2VFcnJvcjo6aXNDYW5jZWxsYXRpb24o KQorICAgICAgICBmb3IgZXJyb3JzIGJlaW5nIHNlbnQgdGhyb3VnaCB0aGUgSVBDLgorCisgICAg ICAgICogU2hhcmVkL3F0L1dlYkNvcmVBcmd1bWVudENvZGVyc1F0LmNwcDoKKyAgICAgICAgKENv cmVJUEM6Ojo6ZW5jb2RlKToKKyAgICAgICAgKENvcmVJUEM6Ojo6ZGVjb2RlKToKKwogMjAxMi0w My0zMCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgU3Rv cCBjcmVhdGluZyB0aGUgV2ViIEluc3BlY3RvcidzIE5TV2luZG93IHdoZW4gZGV0YWNoaW5nIG9u IGNsb3NlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L1dlYkNvcmVBcmd1 bWVudENvZGVyc1F0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9XZWJDb3JlQXJndW1l bnRDb2RlcnNRdC5jcHAKaW5kZXggOTUwZDM3MmQyZGRjN2U0NmY4MDc3ODM5NTBlMGMyODc2ZTM3 ZGI0YS4uN2E3N2VmMzBmN2IxOTQ2M2M5OTM1ZjY2NGIyZjU2ZDkxZDlmZWFmYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L1dlYkNvcmVBcmd1bWVudENvZGVyc1F0LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzUXQuY3Bw CkBAIC0xMDIsOCArMTAyLDkgQEAgdm9pZCBBcmd1bWVudENvZGVyPFJlc291cmNlRXJyb3I+Ojpl bmNvZGUoQXJndW1lbnRFbmNvZGVyKiBlbmNvZGVyLCBjb25zdCBSZXNvdXIKIHsKICAgICBlbmNv ZGVyLT5lbmNvZGUocmVzb3VyY2VFcnJvci5kb21haW4oKSk7CiAgICAgZW5jb2Rlci0+ZW5jb2Rl KHJlc291cmNlRXJyb3IuZXJyb3JDb2RlKCkpOwotICAgIGVuY29kZXItPmVuY29kZShyZXNvdXJj ZUVycm9yLmZhaWxpbmdVUkwoKSk7IAorICAgIGVuY29kZXItPmVuY29kZShyZXNvdXJjZUVycm9y LmZhaWxpbmdVUkwoKSk7CiAgICAgZW5jb2Rlci0+ZW5jb2RlKHJlc291cmNlRXJyb3IubG9jYWxp emVkRGVzY3JpcHRpb24oKSk7CisgICAgZW5jb2Rlci0+ZW5jb2RlKHJlc291cmNlRXJyb3IuaXND YW5jZWxsYXRpb24oKSk7CiB9CiAKIGJvb2wgQXJndW1lbnRDb2RlcjxSZXNvdXJjZUVycm9yPjo6 ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciogZGVjb2RlciwgUmVzb3VyY2VFcnJvciYgcmVzb3VyY2VF cnJvcikKQEAgLTEyMyw4ICsxMjQsMTMgQEAgYm9vbCBBcmd1bWVudENvZGVyPFJlc291cmNlRXJy b3I+OjpkZWNvZGUoQXJndW1lbnREZWNvZGVyKiBkZWNvZGVyLCBSZXNvdXJjZUVycm8KICAgICBT dHJpbmcgbG9jYWxpemVkRGVzY3JpcHRpb247CiAgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUobG9j YWxpemVkRGVzY3JpcHRpb24pKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgCisKKyAgICBi b29sIGlzQ2FuY2VsbGF0aW9uOworICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlKGlzQ2FuY2VsbGF0 aW9uKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgcmVzb3VyY2VFcnJvciA9IFJlc291 cmNlRXJyb3IoZG9tYWluLCBlcnJvckNvZGUsIGZhaWxpbmdVUkwsIGxvY2FsaXplZERlc2NyaXB0 aW9uKTsKKyAgICByZXNvdXJjZUVycm9yLnNldElzQ2FuY2VsbGF0aW9uKGlzQ2FuY2VsbGF0aW9u KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo=