82879 2012-04-02 03:42:27 -0700 Remove TreeScope::isShadowRoot() 2012-04-02 20:01:10 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shinyak shinyak dglazkov dominicc hayato morrita shinyak webkit.review.bot oldest_to_newest 593313 0 shinyak 2012-04-02 03:42:27 -0700 It seems weird that TreeScope has isShadowRoot(). We should do treeScope->rootNode()->isShadowRoot. Since rootNode() is inlined, the overall performance won't change. 593325 1 shinyak 2012-04-02 04:00:45 -0700 Because of this existence, some code requires to include non-necessary ShadowRoot.h... 593402 2 135080 shinyak 2012-04-02 05:52:29 -0700 Created attachment 135080 Patch 594154 3 135080 webkit.review.bot 2012-04-02 20:01:06 -0700 Comment on attachment 135080 Patch Clearing flags on attachment: 135080 Committed r112978: <http://trac.webkit.org/changeset/112978> 594155 4 webkit.review.bot 2012-04-02 20:01:10 -0700 All reviewed patches have been landed. Closing bug. 135080 2012-04-02 05:52:29 -0700 2012-04-02 20:01:06 -0700 Patch bug-82879-20120402215228.patch text/plain 5181 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDdhYWI3YWYxY2E0OTBj MTRmNDRjYTQ2MjUwMGI3YTJhM2M1NDExYS4uZTk5ZWQyZjk4NzE2ZTg1MTNkOTBmMWU1MmQ5MDBm N2JmOGY4NzA3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA0LTAyICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgVHJl ZVNjb3BlOjppc1NoYWRvd1Jvb3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04Mjg3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyBUcmVlU2NvcGU6OmlzU2hhZG93Um9vdCgp LiBUbyBtYWtlIGNvZGUgZmFzdCwgVHJlZVNjb3BlOjppc1NoYWRvd1Jvb3QKKyAgICAgICAgaXMg aW1wbGVtZW50ZWQgaW4gU2hhZG93Um9vdC5oLiBTbyB3aGVuIHVzaW5nIFRyZWVTY29wZTo6aXNT aGFkb3dSb290KCksIFNoYWRvd1Jvb3QuaCBpcworICAgICAgICBhbHdheXMgcmVxdWlyZWQuIElu IHNvbWUgY2FzZSwgIHRoaXMgbWlnaHQgYnJpbmcgdW5uZWNlc3NhcnkgZGVwZW5kZW5jeS4KKwor ICAgICAgICBTaW5jZSBUcmVlU2NvcGU6OnJvb3ROb2RlKCkgaXMgaW5saW5lZCwgdGhlIG92ZXJh bGwgcGVyZm9ybWFuY2Ugd29uJ3QgY2hhbmdlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgc2lt cGxlIHJlZmFjdG9yaW5nLgorCisgICAgICAgICogZG9tL1NoYWRvd1Jvb3QuaDoKKyAgICAgICAg KiBkb20vVHJlZVNjb3BlLmg6CisgICAgICAgICogaHRtbC9zaGFkb3cvSFRNTFNoYWRvd0VsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFNoYWRvd0VsZW1lbnQ6OmRvZXNTZWxlY3RG cm9tSG9zdENoaWxkcmVuKToKKyAgICAgICAgKiBodG1sL3NoYWRvdy9JbnNlcnRpb25Qb2ludC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNlcnRpb25Qb2ludDo6YXR0YWNoKToKKyAgICAgICAg KFdlYkNvcmU6Okluc2VydGlvblBvaW50Ojphc3NpZ25lZEZyb20pOgorICAgICAgICAoV2ViQ29y ZTo6SW5zZXJ0aW9uUG9pbnQ6OmlzU2hhZG93Qm91bmRhcnkpOgorCiAyMDEyLTA0LTAxICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgbm90aWZpY2F0aW9uIHBy b3BlcnRpZXMgYW5kIGZ1bmN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1No YWRvd1Jvb3QuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmgKaW5kZXggNThiNDhj NjRiNWI4OTUzYTlhMmEyOWFkOGZiYjRlZTNjNDEwNGMyYi4uNmMzZTdjYzkyNDgyZWQ0ZWZkYmFj MjBkM2UyMmQ2Y2EzZGUwMTNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRv d1Jvb3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5oCkBAIC0xMzksMTgg KzEzOSw2IEBAIGlubGluZSBTaGFkb3dSb290KiB0b1NoYWRvd1Jvb3QoTm9kZSogbm9kZSkKICAg ICByZXR1cm4gY29uc3RfY2FzdDxTaGFkb3dSb290Kj4odG9TaGFkb3dSb290KHN0YXRpY19jYXN0 PGNvbnN0IE5vZGUqPihub2RlKSkpOwogfQogCi1pbmxpbmUgU2hhZG93Um9vdCogdG9TaGFkb3dS b290KFRyZWVTY29wZSogc2NvcGUpCi17Ci0gICAgQVNTRVJUKCFzY29wZSB8fCBzY29wZS0+aXNT aGFkb3dSb290KCkpOwotICAgIHJldHVybiBzdGF0aWNfY2FzdDxTaGFkb3dSb290Kj4oc2NvcGUp OwotfQotCi0vLyBQdXQgdGhpcyBUcmVlU2NvcGUgbWV0aG9kIGhlcmUgdG8gaW5saW5lIGl0Lgot aW5saW5lIGJvb2wgVHJlZVNjb3BlOjppc1NoYWRvd1Jvb3QoKSBjb25zdAotewotICAgIHJldHVy biBtX3Jvb3ROb2RlLT5pc1NoYWRvd1Jvb3QoKTsKLX0KLQogfSAvLyBuYW1lc3BhY2UKIAogI2Vu ZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vVHJlZVNjb3BlLmggYi9Tb3VyY2Uv V2ViQ29yZS9kb20vVHJlZVNjb3BlLmgKaW5kZXggNTcxOWY5NWQwZWVhMmI4NmUzMzFlYjgwNmU0 MTJhYjJiZWM2YzRmNS4uMTZjZjY2NDRlNTY1NzgyNmQzYWMxODQ0MzA5ZTNjNGRlNjViZjBhYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1RyZWVTY29wZS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9UcmVlU2NvcGUuaApAQCAtNjEsNyArNjEsNiBAQCBwdWJsaWM6CiAgICAgdm9p ZCBhZGROb2RlTGlzdENhY2hlKCkgeyArK21fbnVtTm9kZUxpc3RDYWNoZXM7IH0KICAgICB2b2lk IHJlbW92ZU5vZGVMaXN0Q2FjaGUoKSB7IEFTU0VSVChtX251bU5vZGVMaXN0Q2FjaGVzID4gMCk7 IC0tbV9udW1Ob2RlTGlzdENhY2hlczsgfQogICAgIGJvb2wgaGFzTm9kZUxpc3RDYWNoZXMoKSBj b25zdCB7IHJldHVybiBtX251bU5vZGVMaXN0Q2FjaGVzOyB9Ci0gICAgYm9vbCBpc1NoYWRvd1Jv b3QoKSBjb25zdDsKIAogICAgIC8vIEZpbmQgZmlyc3QgYW5jaG9yIHdpdGggdGhlIGdpdmVuIG5h bWUuCiAgICAgLy8gRmlyc3Qgc2VhcmNoZXMgZm9yIGFuIGVsZW1lbnQgd2l0aCB0aGUgZ2l2ZW4g SUQsIGJ1dCBpZiB0aGF0IGZhaWxzLCB0aGVuIGxvb2tzCkBAIC0xMDcsNCArMTA2LDMgQEAgaW5s aW5lIGJvb2wgVHJlZVNjb3BlOjpjb250YWluc011bHRpcGxlRWxlbWVudHNXaXRoSWQoY29uc3Qg QXRvbWljU3RyaW5nJiBpZCkgY28KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8v IFRyZWVTY29wZV9oCi0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0hU TUxTaGFkb3dFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0hUTUxTaGFk b3dFbGVtZW50LmNwcAppbmRleCA2OWM5MzYyOWY3NWRkNzM1MDhhMTg3NDVkODY3MWY3NDI0YzZm MTQwLi45Mzg0Mzk2MTJjYTIxZDI2OWU1Nzc4YTk2YjE1OTgwZWY3NTQyYjlhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9IVE1MU2hhZG93RWxlbWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvSFRNTFNoYWRvd0VsZW1lbnQuY3BwCkBAIC02Myw4 ICs2Myw4IEBAIGJvb2wgSFRNTFNoYWRvd0VsZW1lbnQ6OmRvZXNTZWxlY3RGcm9tSG9zdENoaWxk cmVuKCkgY29uc3QKIHsKICAgICBUcmVlU2NvcGUqIHNjb3BlID0gdHJlZVNjb3BlKCk7CiAKLSAg ICBpZiAoc2NvcGUtPmlzU2hhZG93Um9vdCgpKQotICAgICAgICByZXR1cm4gdG9TaGFkb3dSb290 KHNjb3BlKS0+aXNPbGRlc3QoKTsKKyAgICBpZiAoc2NvcGUtPnJvb3ROb2RlKCktPmlzU2hhZG93 Um9vdCgpKQorICAgICAgICByZXR1cm4gdG9TaGFkb3dSb290KHNjb3BlLT5yb290Tm9kZSgpKS0+ aXNPbGRlc3QoKTsKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvc2hhZG93L0luc2VydGlvblBvaW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvc2hhZG93L0luc2VydGlvblBvaW50LmNwcAppbmRleCA2NDljZjUwYzExZTE1OTkyNDZmMDk0 OGQxMzI5NjcyMzBmZmM4YWFkLi4zMmYyNGY0NzQzZWVlMDYwZjlkYWQ1MWI2YTc4NmMyODNmZWUy ODk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9JbnNlcnRpb25Qb2lu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvSW5zZXJ0aW9uUG9pbnQuY3Bw CkBAIC00OSw4ICs0OSw4IEBAIEluc2VydGlvblBvaW50Ojp+SW5zZXJ0aW9uUG9pbnQoKQogdm9p ZCBJbnNlcnRpb25Qb2ludDo6YXR0YWNoKCkKIHsKICAgICBUcmVlU2NvcGUqIHNjb3BlID0gdHJl ZVNjb3BlKCk7Ci0gICAgaWYgKHNjb3BlLT5pc1NoYWRvd1Jvb3QoKSkgewotICAgICAgICBTaGFk b3dSb290KiByb290ID0gdG9TaGFkb3dSb290KHNjb3BlKTsKKyAgICBpZiAoc2NvcGUtPnJvb3RO b2RlKCktPmlzU2hhZG93Um9vdCgpKSB7CisgICAgICAgIFNoYWRvd1Jvb3QqIHJvb3QgPSB0b1No YWRvd1Jvb3Qoc2NvcGUtPnJvb3ROb2RlKCkpOwogICAgICAgICBpZiAoZG9lc1NlbGVjdEZyb21I b3N0Q2hpbGRyZW4oKSkgewogICAgICAgICAgICAgZGlzdHJpYnV0ZUhvc3RDaGlsZHJlbihyb290 LT50cmVlKCkpOwogICAgICAgICAgICAgYXR0YWNoRGlzdHJpYnV0ZWROb2RlKCk7CkBAIC04NSwx MSArODUsMTEgQEAgdm9pZCBJbnNlcnRpb25Qb2ludDo6ZGV0YWNoKCkKIAogU2hhZG93Um9vdCog SW5zZXJ0aW9uUG9pbnQ6OmFzc2lnbmVkRnJvbSgpIGNvbnN0CiB7Ci0gICAgVHJlZVNjb3BlKiBz Y29wZSA9IHRyZWVTY29wZSgpOwotICAgIGlmICghc2NvcGUtPmlzU2hhZG93Um9vdCgpKQorICAg IE5vZGUqIHRyZWVTY29wZVJvb3QgPSB0cmVlU2NvcGUoKS0+cm9vdE5vZGUoKTsKKyAgICBpZiAo IXRyZWVTY29wZVJvb3QtPmlzU2hhZG93Um9vdCgpKQogICAgICAgICByZXR1cm4gMDsKIAotICAg IFNoYWRvd1Jvb3QqIG9sZGVyU2hhZG93Um9vdCA9IHRvU2hhZG93Um9vdChzY29wZSktPm9sZGVy U2hhZG93Um9vdCgpOworICAgIFNoYWRvd1Jvb3QqIG9sZGVyU2hhZG93Um9vdCA9IHRvU2hhZG93 Um9vdCh0cmVlU2NvcGVSb290KS0+b2xkZXJTaGFkb3dSb290KCk7CiAgICAgaWYgKG9sZGVyU2hh ZG93Um9vdCAmJiBvbGRlclNoYWRvd1Jvb3QtPmFzc2lnbmVkVG8oKSA9PSB0aGlzKQogICAgICAg ICByZXR1cm4gb2xkZXJTaGFkb3dSb290OwogICAgIHJldHVybiAwOwpAQCAtOTcsOSArOTcsNyBA QCBTaGFkb3dSb290KiBJbnNlcnRpb25Qb2ludDo6YXNzaWduZWRGcm9tKCkgY29uc3QKIAogYm9v bCBJbnNlcnRpb25Qb2ludDo6aXNTaGFkb3dCb3VuZGFyeSgpIGNvbnN0CiB7Ci0gICAgaWYgKFRy ZWVTY29wZSogc2NvcGUgPSB0cmVlU2NvcGUoKSkKLSAgICAgICAgcmV0dXJuIHNjb3BlLT5pc1No YWRvd1Jvb3QoKTsKLSAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIHRyZWVTY29wZSgpLT5y b290Tm9kZSgpLT5pc1NoYWRvd1Jvb3QoKTsKIH0KIAogYm9vbCBJbnNlcnRpb25Qb2ludDo6cmVu ZGVyZXJJc05lZWRlZChjb25zdCBOb2RlUmVuZGVyaW5nQ29udGV4dCYgY29udGV4dCkK