82877 2012-04-02 03:36:01 -0700 [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests 2012-04-10 08:34:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned pnormand oldest_to_newest 593310 0 cgarcia 2012-04-02 03:36:01 -0700 The method lstrip is incorrectly used to get the name of failed tests from the full path. 593312 1 135058 cgarcia 2012-04-02 03:39:50 -0700 Created attachment 135058 Patch 593315 2 135058 pnormand 2012-04-02 03:45:05 -0700 Comment on attachment 135058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135058&action=review > Tools/Scripts/run-gtk-tests:268 > + names = [test.replace(self._programs_path, '', 1) for test in failed_tests] What about os.path.basename(test) ? 593316 3 cgarcia 2012-04-02 03:47:46 -0700 (In reply to comment #2) > (From update of attachment 135058 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135058&action=review > > > Tools/Scripts/run-gtk-tests:268 > > + names = [test.replace(self._programs_path, '', 1) for test in failed_tests] > > What about os.path.basename(test) ? that would give you the name, but we also want the directory unittests/WebKit2APITests 593321 4 pnormand 2012-04-02 03:52:35 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 135058 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=135058&action=review > > > > > Tools/Scripts/run-gtk-tests:268 > > > + names = [test.replace(self._programs_path, '', 1) for test in failed_tests] > > > > What about os.path.basename(test) ? > > that would give you the name, but we also want the directory unittests/WebKit2APITests Is it really useful? The test naming conventions differ between WK1 and WK2 593323 5 cgarcia 2012-04-02 03:54:52 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 135058 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=135058&action=review > > > > > > > Tools/Scripts/run-gtk-tests:268 > > > > + names = [test.replace(self._programs_path, '', 1) for test in failed_tests] > > > > > > What about os.path.basename(test) ? > > > > that would give you the name, but we also want the directory unittests/WebKit2APITests > > Is it really useful? > The test naming conventions differ between WK1 and WK2 That's how we refer to tests, see SkippedTest class 593333 6 cgarcia 2012-04-02 04:07:19 -0700 Committed r112853: <http://trac.webkit.org/changeset/112853> 135058 2012-04-02 03:39:50 -0700 2012-04-10 08:34:09 -0700 Patch run-gtk-tests-failed-tests.diff text/plain 1209 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxOGYw M2JmLi5mMDQzODZjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDQtMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBuYW1lcyBvZiBmYWls ZWQgdW5pdCB0ZXN0cyBpbiBUb29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyODc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1ndGstdGVz dHM6CisgICAgICAgIChUZXN0UnVubmVyLnJ1bl90ZXN0cyk6IFVzZSByZXBsYWNlIGluc3RlYWQg b2YgbHN0cmlwIHRvIHJlbW92ZQorICAgICAgICB0aGUgcHJvZ3JhbXNfcGF0aCBmcm9tIHRoZSBm dWxsIHBhdGggb2YgdW5pdCB0ZXN0cy4KKwogMjAxMi0wMy0yOSAgRGFuIEJlcm5zdGVpbiAgPG1p dHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZWQg4oCcSW50ZWzigJ0gZnJvbSB0aGUgTGlv biBidWlsZGVyc+KAmSBuYW1lcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10 ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwppbmRleCAxYzIwOWFlLi42ZGU1ZDhi IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMvU2Ny aXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC0yNjUsNyArMjY1LDcgQEAgY2xhc3MgVGVzdFJ1bm5lcjoK ICAgICAgICAgICAgIHNlbGYuX3RlYXJfZG93bl90ZXN0aW5nX2Vudmlyb25tZW50KCkKIAogICAg ICAgICBpZiBmYWlsZWRfdGVzdHM6Ci0gICAgICAgICAgICBuYW1lcyA9IFt0ZXN0LmxzdHJpcChz ZWxmLl9wcm9ncmFtc19wYXRoKSBmb3IgdGVzdCBpbiBmYWlsZWRfdGVzdHNdCisgICAgICAgICAg ICBuYW1lcyA9IFt0ZXN0LnJlcGxhY2Uoc2VsZi5fcHJvZ3JhbXNfcGF0aCwgJycsIDEpIGZvciB0 ZXN0IGluIGZhaWxlZF90ZXN0c10KICAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoIlRlc3Rz IGZhaWxlZDogJXNcbiIgJSAiLCAiLmpvaW4obmFtZXMpKQogICAgICAgICAgICAgc3lzLnN0ZG91 dC5mbHVzaCgpCiAK