82866 2012-04-02 02:14:40 -0700 [GTK] Test /webkit2/WebKitWebView/mouse-target is flaky in GTK Linux 32-bit Release bot 2013-03-06 13:11:41 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson pnormand webkit.review.bot oldest_to_newest 593270 0 cgarcia 2012-04-02 02:14:40 -0700 TEST: ./WebKitBuild/Release/Programs/WebKit2APITests/TestWebKitWebView... (pid=17523) /webkit2/WebKitWebView/default-context: OK /webkit2/WebKitWebView/custom-charset: OK /webkit2/WebKitWebView/settings: OK /webkit2/WebKitWebView/replace-content: OK /webkit2/WebKitWebView/create-ready-close: OK /webkit2/WebKitWebView/javascript-dialogs: OK /webkit2/WebKitWebView/window-properties: OK /webkit2/WebKitWebView/mouse-target: ** ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:439:void testWebViewMouseTarget(UIClientTest*, gconstpointer): assertion failed: (webkit_hit_test_result_context_is_media(hitTestResult)) FAIL 848697 1 191710 rego 2013-03-06 04:07:13 -0800 Created attachment 191710 Patch I don't have 32-bits so I cannot test it. Anyway the patch fix the problem in 64-bits as the test was not passing in 64-bits either. 848698 2 webkit.review.bot 2013-03-06 04:08:50 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 849227 3 191710 webkit.review.bot 2013-03-06 13:11:38 -0800 Comment on attachment 191710 Patch Clearing flags on attachment: 191710 Committed r144969: <http://trac.webkit.org/changeset/144969> 849228 4 webkit.review.bot 2013-03-06 13:11:41 -0800 All reviewed patches have been landed. Closing bug. 191710 2013-03-06 04:07:13 -0800 2013-03-06 13:11:38 -0800 Patch bug-82866-20130306130318.patch text/plain 6092 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjViYzgxNjI5MjA3NmIx MmY3MDlmOTVmYWI4NzhjNjcwMWYwYjkzMy4uZTFhYTI4OTg0ZDUyNGMzNjNhOWZhODA3ODQzNDM3 MjhlNGQ2MjdhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA2ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdW0dU S10gRml4IHVuaXQgdGVzdCBXZWJLaXQyQVBJVGVzdHMvV2ViS2l0V2ViVmlldy9tb3VzZS10YXJn ZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyODY2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCB3 YXMgZmFpbGluZyBiZWNhdXNlIG9mIG5ldyBtZWRpYSBjb250cm9scyBuZWVkcyBtb3JlIHNwYWNl IHRvIGJlCisgICAgICAgIHBhaW50ZWQgdGhhbiBqdXN0IDEweDEwIHBpeGVscy4gVGhpcyBpcyBz aW1pbGFyIHRvIHIxNDQwNzAuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9U ZXN0V2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAgICh0ZXN0V2ViVmlld01vdXNlVGFyZ2V0KTog TW9kaWZpZWQgSFRNTCBpbiBvcmRlciB0byBnaXZlIG1vcmUgc3BhY2UgdG8gdGhlIG1lZGlhIGNv bnRyb2xzLgorCiAyMDEzLTAzLTA0ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRu eWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAgIFtXSzJdW0VGTF0gQWRkIGNhbGxiYWNrcyB0byB0 aGUgV0tWaWV3Q2xpZW50IHRvIGhhbmRsZSBXZWIgUHJvY2VzcyBjcmFzaCBhbmQgcmVsYXVuY2gK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RX ZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3Rz L1Rlc3RXZWJLaXRXZWJWaWV3LmNwcAppbmRleCA2ZWQ0YTM4ZTMwMTE1YWJkMTA2YjViY2ViZGY1 ODNhY2EyOTQ4YmZkLi45Y2YxZGRjY2Y3OTRhM2MwOTVmNjMxOGI2Y2MwOTIzNjRkYmFmNWMxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2Vi S2l0V2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVz dHMvVGVzdFdlYktpdFdlYlZpZXcuY3BwCkBAIC00NzksOSArNDc5LDkgQEAgc3RhdGljIHZvaWQg dGVzdFdlYlZpZXdNb3VzZVRhcmdldChVSUNsaWVudFRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIp CiAgICAgICAgICIgPGEgc3R5bGU9J3Bvc2l0aW9uOmFic29sdXRlOyBsZWZ0OjE7IHRvcDoxJyBo cmVmPSdodHRwOi8vd3d3LndlYmtpdGd0ay5vcmcnIHRpdGxlPSdXZWJLaXRHVEsrIFRpdGxlJz5X ZWJLaXRHVEsrIFdlYnNpdGU8L2E+IgogICAgICAgICAiIDxpbWcgc3R5bGU9J3Bvc2l0aW9uOmFi c29sdXRlOyBsZWZ0OjE7IHRvcDoxMCcgc3JjPScweGRlYWRiZWVmJyB3aWR0aD01IGhlaWdodD01 PjwvaW1nPiIKICAgICAgICAgIiA8YSBzdHlsZT0ncG9zaXRpb246YWJzb2x1dGU7IGxlZnQ6MTsg dG9wOjIwJyBocmVmPSdodHRwOi8vd3d3LndlYmtpdGd0ay5vcmcvbG9nbycgdGl0bGU9J1dlYktp dEdUSysgTG9nbyc+PGltZyBzcmM9JzB4ZGVhZGJlZWYnIHdpZHRoPTUgaGVpZ2h0PTU+PC9pbWc+ PC9hPiIKLSAgICAgICAgIiA8dmlkZW8gc3R5bGU9J3Bvc2l0aW9uOmFic29sdXRlOyBsZWZ0OjE7 IHRvcDozMCcgd2lkdGg9MTAgaGVpZ2h0PTEwIGNvbnRyb2xzPSdjb250cm9scyc+PHNvdXJjZSBz cmM9J21vdmllLm9nZycgdHlwZT0ndmlkZW8vb2dnJyAvPjwvdmlkZW8+IgotICAgICAgICAiIDxp bnB1dCBzdHlsZT0ncG9zaXRpb246YWJzb2x1dGU7IGxlZnQ6MTsgdG9wOjUwJyBzaXplPScxMCc+ PC9pbnB1dD4iCi0gICAgICAgICIgPGRpdiBzdHlsZT0ncG9zaXRpb246YWJzb2x1dGU7IGxlZnQ6 MTsgdG9wOjcwOyB3aWR0aDozMDsgaGVpZ2h0OjMwOyBvdmVyZmxvdzpzY3JvbGwnPiZuYnNwOzwv ZGl2PiIKKyAgICAgICAgIiA8aW5wdXQgc3R5bGU9J3Bvc2l0aW9uOmFic29sdXRlOyBsZWZ0OjE7 IHRvcDozMCcgc2l6ZT0nMTAnPjwvaW5wdXQ+IgorICAgICAgICAiIDxkaXYgc3R5bGU9J3Bvc2l0 aW9uOmFic29sdXRlOyBsZWZ0OjE7IHRvcDo1MDsgd2lkdGg6MzA7IGhlaWdodDozMDsgb3ZlcmZs b3c6c2Nyb2xsJz4mbmJzcDs8L2Rpdj4iCisgICAgICAgICIgPHZpZGVvIHN0eWxlPSdwb3NpdGlv bjphYnNvbHV0ZTsgbGVmdDoxOyB0b3A6MTAwJyB3aWR0aD0nMzAwJyBoZWlnaHQ9JzMwMCcgY29u dHJvbHM9J2NvbnRyb2xzJz48c291cmNlIHNyYz0nbW92aWUub2dnJyB0eXBlPSd2aWRlby9vZ2cn IC8+PC92aWRlbz4iCiAgICAgICAgICI8L2JvZHk+PC9odG1sPiI7CiAKICAgICB0ZXN0LT5sb2Fk SHRtbChsaW5rc0hvdmVyZWRIVE1MLCAiZmlsZTovLy8iKTsKQEAgLTUzMCw3ICs1MzAsNyBAQCBz dGF0aWMgdm9pZCB0ZXN0V2ViVmlld01vdXNlVGFyZ2V0KFVJQ2xpZW50VGVzdCogdGVzdCwgZ2Nv bnN0cG9pbnRlcikKICAgICBnX2Fzc2VydCghdGVzdC0+bV9tb3VzZVRhcmdldE1vZGlmaWVycyk7 CiAKICAgICAvLyBNb3ZlIG92ZXIgbWVkaWEuCi0gICAgaGl0VGVzdFJlc3VsdCA9IHRlc3QtPm1v dmVNb3VzZUFuZFdhaXRVbnRpbE1vdXNlVGFyZ2V0Q2hhbmdlZCgxLCAzMCk7CisgICAgaGl0VGVz dFJlc3VsdCA9IHRlc3QtPm1vdmVNb3VzZUFuZFdhaXRVbnRpbE1vdXNlVGFyZ2V0Q2hhbmdlZCgx LCAxMDApOwogICAgIGdfYXNzZXJ0KCF3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRfaXNf bGluayhoaXRUZXN0UmVzdWx0KSk7CiAgICAgZ19hc3NlcnQoIXdlYmtpdF9oaXRfdGVzdF9yZXN1 bHRfY29udGV4dF9pc19pbWFnZShoaXRUZXN0UmVzdWx0KSk7CiAgICAgZ19hc3NlcnQod2Via2l0 X2hpdF90ZXN0X3Jlc3VsdF9jb250ZXh0X2lzX21lZGlhKGhpdFRlc3RSZXN1bHQpKTsKQEAgLTU0 MCw3ICs1NDAsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViVmlld01vdXNlVGFyZ2V0KFVJQ2xpZW50 VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICBnX2Fzc2VydCghdGVzdC0+bV9tb3VzZVRh cmdldE1vZGlmaWVycyk7CiAKICAgICAvLyBNb3ZlciBvdmVyIGlucHV0LgotICAgIGhpdFRlc3RS ZXN1bHQgPSB0ZXN0LT5tb3ZlTW91c2VBbmRXYWl0VW50aWxNb3VzZVRhcmdldENoYW5nZWQoNSwg NTUpOworICAgIGhpdFRlc3RSZXN1bHQgPSB0ZXN0LT5tb3ZlTW91c2VBbmRXYWl0VW50aWxNb3Vz ZVRhcmdldENoYW5nZWQoNSwgMzUpOwogICAgIGdfYXNzZXJ0KCF3ZWJraXRfaGl0X3Rlc3RfcmVz dWx0X2NvbnRleHRfaXNfbGluayhoaXRUZXN0UmVzdWx0KSk7CiAgICAgZ19hc3NlcnQoIXdlYmtp dF9oaXRfdGVzdF9yZXN1bHRfY29udGV4dF9pc19pbWFnZShoaXRUZXN0UmVzdWx0KSk7CiAgICAg Z19hc3NlcnQoIXdlYmtpdF9oaXRfdGVzdF9yZXN1bHRfY29udGV4dF9pc19tZWRpYShoaXRUZXN0 UmVzdWx0KSk7CkBAIC01NDksNyArNTQ5LDcgQEAgc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdNb3Vz ZVRhcmdldChVSUNsaWVudFRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAgZ19hc3NlcnQo IXRlc3QtPm1fbW91c2VUYXJnZXRNb2RpZmllcnMpOwogCiAgICAgLy8gTW92ZSBvdmVyIHNjcm9s bGJhci4KLSAgICBoaXRUZXN0UmVzdWx0ID0gdGVzdC0+bW92ZU1vdXNlQW5kV2FpdFVudGlsTW91 c2VUYXJnZXRDaGFuZ2VkKDUsIDk1KTsKKyAgICBoaXRUZXN0UmVzdWx0ID0gdGVzdC0+bW92ZU1v dXNlQW5kV2FpdFVudGlsTW91c2VUYXJnZXRDaGFuZ2VkKDUsIDc1KTsKICAgICBnX2Fzc2VydCgh d2Via2l0X2hpdF90ZXN0X3Jlc3VsdF9jb250ZXh0X2lzX2xpbmsoaGl0VGVzdFJlc3VsdCkpOwog ICAgIGdfYXNzZXJ0KCF3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRfaXNfaW1hZ2UoaGl0 VGVzdFJlc3VsdCkpOwogICAgIGdfYXNzZXJ0KCF3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRl eHRfaXNfbWVkaWEoaGl0VGVzdFJlc3VsdCkpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9n IGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDA0ZGIzNGZhY2FkNTA3NWQ0NDMxYWQ4N2ZiZDU5YzRi NTA0OTFkNDkuLjU1Y2M4Yzg2OGM4YjNhYzhhN2FlYWYxNDJjZjhjNzk0ZmU5MzFiZjAgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAxMy0wMy0wNiAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNv bT4KKworICAgICAgICBbV0syXVtHVEtdIEZpeCB1bml0IHRlc3QgV2ViS2l0MkFQSVRlc3RzL1dl YktpdFdlYlZpZXcvbW91c2UtdGFyZ2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04Mjg2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3RzOgorICAgICAgICAoVGVzdFJ1 bm5lcik6IFVuZmxhZyBXZWJLaXQyQVBJVGVzdHMvV2ViS2l0V2ViVmlldy9tb3VzZS10YXJnZXQg dGVzdCBhcworICAgICAgICBpdCBpcyBwYXNzaW5nIG5vdy4KKwogMjAxMy0wMy0wNCAgTWlraGFp bCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KIAogICAgICAgICBb V0syXVtFRkxdIEFkZCBjYWxsYmFja3MgdG8gdGhlIFdLVmlld0NsaWVudCB0byBoYW5kbGUgV2Vi IFByb2Nlc3MgY3Jhc2ggYW5kIHJlbGF1bmNoCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1 bi1ndGstdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKaW5kZXggMzYzNGU1YjFj YmNmZGM3ZGU5MjJkYjMxNDg1N2NkOTgxNWFiNTAwYi4uMzVlNzBlZDI2ODViMzRjY2M1MGIwYzJl YWMxNDBlY2VkZGVjYzM5MCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3Rz CisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwpAQCAtNzIsNyArNzIsNiBAQCBjbGFz cyBUZXN0UnVubmVyOgogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0MkFQSVRlc3RzL1Rlc3RX ZWJLaXRBY2Nlc3NpYmlsaXR5IiwgIi93ZWJraXQyL1dlYktpdEFjY2Vzc2liaWxpdHkvYXRzcGkt YmFzaWMtaGllcmFyY2h5IiwgIlRlc3QgZmFpbHMiLCAxMDA0MDgpLAogICAgICAgICBTa2lwcGVk VGVzdCgiV2ViS2l0MkFQSVRlc3RzL1Rlc3RXZWJLaXRGaW5kQ29udHJvbGxlciIsICIvd2Via2l0 Mi9XZWJLaXRGaW5kQ29udHJvbGxlci9oaWRlIiwgIlRlc3QgYWx3YXlzIGZhaWxzIGluIFh2ZmIi LCA4OTgxMCksCiAgICAgICAgIFNraXBwZWRUZXN0KCJXZWJLaXQyQVBJVGVzdHMvVGVzdFdlYktp dFdlYkNvbnRleHQiLCAiL3dlYmtpdDIvV2ViS2l0V2ViQ29udGV4dC91cmktc2NoZW1lIiwgIlRl c3QgZmFpbHMiLCAxMDQ3NzkpLAotICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0MkFQSVRlc3Rz L1Rlc3RXZWJLaXRXZWJWaWV3IiwgIi93ZWJraXQyL1dlYktpdFdlYlZpZXcvbW91c2UtdGFyZ2V0 IiwgIlRlc3QgaXMgZmxha3kgaW4gR1RLIExpbnV4IDMyLWJpdCBSZWxlYXNlIGJvdCIsIDgyODY2 KSwKICAgICAgICAgU2tpcHBlZFRlc3QoIlRlc3RXZWJLaXRBUEkvVGVzdFdlYktpdDIiLCAiV2Vi S2l0Mi5DYW5IYW5kbGVSZXF1ZXN0IiwgIlRlc3QgZmFpbHMiLCA4ODQ1MyksCiAgICAgICAgIFNr aXBwZWRUZXN0KCJUZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXQyIiwgIldlYktpdDIuTW91c2VNb3Zl QWZ0ZXJDcmFzaCIsICJUZXN0IGlzIGZsYWt5IiwgODUwNjYpLAogICAgICAgICBTa2lwcGVkVGVz dCgiVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0MiIsICJXZWJLaXQyLk5ld0ZpcnN0VmlzdWFsbHlO b25FbXB0eUxheW91dEZvckltYWdlcyIsICJUZXN0IGlzIGZsYWt5IiwgODUwNjYpLAo=