82863 2012-04-02 00:37:07 -0700 [chromium] Disable ENABLE_INPUT_TYPE_COLOR for aura and android 2012-04-02 03:20:47 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi peter tkent webkit.review.bot oldest_to_newest 593231 0 keishi 2012-04-02 00:37:07 -0700 Disable ENABLE_INPUT_TYPE_COLOR for aura and android. I turned them on by mistake but the UIs aren't ready. 593234 1 135037 keishi 2012-04-02 00:46:13 -0700 Created attachment 135037 Patch 593236 2 135037 peter 2012-04-02 00:54:08 -0700 Comment on attachment 135037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review Have you tested this? This will define ENABLE_INPUT_TYPE_COLOR multiple times, which will cause compiler warnings. Output for an Android build: <command-line>: warning: "ENABLE_INPUT_TYPE_COLOR" redefined <command-line>: warning: this is the location of the previous definition Disabling this feature for Android LGTM, at least until the Chromium-side implementation is complete. > Source/WebKit/chromium/features.gypi:141 > + 'feature_defines': [ nit: indenting. 593238 3 135037 peter 2012-04-02 00:57:16 -0700 Comment on attachment 135037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review > Source/WebKit/chromium/features.gypi:140 > + ['OS=="android" or use_aura==1',{ one more nit: space after the comma. 593243 4 135039 keishi 2012-04-02 01:18:36 -0700 Created attachment 135039 Patch 593244 5 keishi 2012-04-02 01:20:10 -0700 (In reply to comment #2) > (From update of attachment 135037 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review > > Have you tested this? This will define ENABLE_INPUT_TYPE_COLOR multiple times, which will cause compiler warnings. Output for an Android build: Sorry. I didn't have an android or aura build environment. 593256 6 135039 peter 2012-04-02 01:47:56 -0700 Comment on attachment 135039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135039&action=review Thank you! There's one more thing you'll want to adjust, namely that Mac is being excluded now instead of Android. Deferring to tkent/a reviewer now :-). > Source/WebKit/chromium/features.gypi:139 > + ['OS=="mac" or use_aura==1', { s/mac/android/ 593260 7 135045 keishi 2012-04-02 02:01:25 -0700 Created attachment 135045 Patch 593261 8 135046 keishi 2012-04-02 02:04:43 -0700 Created attachment 135046 Patch 593272 9 135046 tkent 2012-04-02 02:16:03 -0700 Comment on attachment 135046 Patch ok 593306 10 135046 webkit.review.bot 2012-04-02 03:20:43 -0700 Comment on attachment 135046 Patch Clearing flags on attachment: 135046 Committed r112849: <http://trac.webkit.org/changeset/112849> 593307 11 webkit.review.bot 2012-04-02 03:20:47 -0700 All reviewed patches have been landed. Closing bug. 135037 2012-04-02 00:46:13 -0700 2012-04-02 01:18:30 -0700 Patch bug-82863-20120402164612.patch text/plain 1251 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyODMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBiYTdmYWQzMzIyODA0MDJjN2YyMjdhMGJiZjg5NjhhMWQxM2U5NzYuLmFiYmFlODkyZDBmMTE3 NWFhMDYxYzZjZDI3ODYyOWEyMDQ4YjNhOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDQtMDIgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEaXNhYmxlIEVOQUJMRV9JTlBVVF9UWVBFX0NP TE9SIGZvciBhdXJhIGFuZCBhbmRyb2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04Mjg2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToKKwogMjAxMi0wNC0wMSAgSm9uIExlZSAg PGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIG5vdGlmaWNhdGlvbiBwcm9wZXJ0 aWVzIGFuZCBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVh dHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCA0 MWY2MjkzMjA5ZTU1YWNjMTg2MGJjMTIwMmIyZjg3YmMwZWE0MTkzLi4zNDM5MTk5NTM5YjJhNWM5 MGI4OWUyOGRlNmExNmRkNTg3OTZlYjVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5n eXBpCkBAIC0xMzcsNiArMTM3LDExIEBACiAgICAgICAgICAgJ0VOQUJMRV9XRUJfQVVESU89MScs CiAgICAgICAgIF0sCiAgICAgICB9XSwKKyAgICAgIFsnT1M9PSJhbmRyb2lkIiBvciB1c2VfYXVy YT09MScseworICAgICAgICAgICdmZWF0dXJlX2RlZmluZXMnOiBbCisgICAgICAgICAgJ0VOQUJM RV9JTlBVVF9UWVBFX0NPTE9SPTAnLAorICAgICAgICBdLAorICAgICAgfV0sCiAgICAgICBbJ3Vz ZV9hY2NlbGVyYXRlZF9jb21wb3NpdGluZz09MScsIHsKICAgICAgICAgJ2ZlYXR1cmVfZGVmaW5l cyc6IFsKICAgICAgICAgICAnV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORz0xJywK 135039 2012-04-02 01:18:36 -0700 2012-04-02 02:01:20 -0700 Patch bug-82863-20120402171834.patch text/plain 1612 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyODMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBiYTdmYWQzMzIyODA0MDJjN2YyMjdhMGJiZjg5NjhhMWQxM2U5NzYuLmFiYmFlODkyZDBmMTE3 NWFhMDYxYzZjZDI3ODYyOWEyMDQ4YjNhOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDQtMDIgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEaXNhYmxlIEVOQUJMRV9JTlBVVF9UWVBFX0NP TE9SIGZvciBhdXJhIGFuZCBhbmRyb2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04Mjg2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToKKwogMjAxMi0wNC0wMSAgSm9uIExlZSAg PGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIG5vdGlmaWNhdGlvbiBwcm9wZXJ0 aWVzIGFuZCBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVh dHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCA0 MWY2MjkzMjA5ZTU1YWNjMTg2MGJjMTIwMmIyZjg3YmMwZWE0MTkzLi4wYWM5M2EzM2YyNDk2Yjhk NjFhMjkwNWQyZWFhYTNmMTM1ODhkYmEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5n eXBpCkBAIC01Myw3ICs1Myw2IEBACiAgICAgICAnRU5BQkxFX0lDT05EQVRBQkFTRT0wJywKICAg ICAgICdFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRT0xJywKICAgICAgICdFTkFCTEVfSU5QVVRfU1BF RUNIPTEnLAotICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0NPTE9SPTEnLAogICAgICAgJ0VOQUJM RV9JTlBVVF9UWVBFX0RBVEU9MCcsCiAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUU9 MCcsCiAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUVMT0NBTD0wJywKQEAgLTEzNyw2 ICsxMzYsMTUgQEAKICAgICAgICAgICAnRU5BQkxFX1dFQl9BVURJTz0xJywKICAgICAgICAgXSwK ICAgICAgIH1dLAorICAgICAgWydPUz09Im1hYyIgb3IgdXNlX2F1cmE9PTEnLCB7CisgICAgICAg ICdmZWF0dXJlX2RlZmluZXMnOiBbCisgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0NPTE9S PTAnLAorICAgICAgICBdLAorICAgICAgfSwgeworICAgICAgICAnZmVhdHVyZV9kZWZpbmVzJzog WworICAgICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9DT0xPUj0xJywKKyAgICAgICAgXSwKKyAg ICAgIH1dLAogICAgICAgWyd1c2VfYWNjZWxlcmF0ZWRfY29tcG9zaXRpbmc9PTEnLCB7CiAgICAg ICAgICdmZWF0dXJlX2RlZmluZXMnOiBbCiAgICAgICAgICAgJ1dURl9VU0VfQUNDRUxFUkFURURf Q09NUE9TSVRJTkc9MScsCg== 135045 2012-04-02 02:01:25 -0700 2012-04-02 02:04:36 -0700 Patch bug-82863-20120402180124.patch text/plain 1616 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyODMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBiYTdmYWQzMzIyODA0MDJjN2YyMjdhMGJiZjg5NjhhMWQxM2U5NzYuLmFiYmFlODkyZDBmMTE3 NWFhMDYxYzZjZDI3ODYyOWEyMDQ4YjNhOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDQtMDIgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEaXNhYmxlIEVOQUJMRV9JTlBVVF9UWVBFX0NP TE9SIGZvciBhdXJhIGFuZCBhbmRyb2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04Mjg2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToKKwogMjAxMi0wNC0wMSAgSm9uIExlZSAg PGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIG5vdGlmaWNhdGlvbiBwcm9wZXJ0 aWVzIGFuZCBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVh dHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCA0 MWY2MjkzMjA5ZTU1YWNjMTg2MGJjMTIwMmIyZjg3YmMwZWE0MTkzLi5lYTViMjNmMmI0NWE4Mzc1 OWZjMjJkNzIxZjA2NGZkMWFjNTU0MTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5n eXBpCkBAIC01Myw3ICs1Myw2IEBACiAgICAgICAnRU5BQkxFX0lDT05EQVRBQkFTRT0wJywKICAg ICAgICdFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRT0xJywKICAgICAgICdFTkFCTEVfSU5QVVRfU1BF RUNIPTEnLAotICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0NPTE9SPTEnLAogICAgICAgJ0VOQUJM RV9JTlBVVF9UWVBFX0RBVEU9MCcsCiAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUU9 MCcsCiAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUVMT0NBTD0wJywKQEAgLTEzNyw2 ICsxMzYsMTUgQEAKICAgICAgICAgICAnRU5BQkxFX1dFQl9BVURJTz0xJywKICAgICAgICAgXSwK ICAgICAgIH1dLAorICAgICAgWydPUz09ImFuZG9yaWQiIG9yIHVzZV9hdXJhPT0xJywgeworICAg ICAgICAnZmVhdHVyZV9kZWZpbmVzJzogWworICAgICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9D T0xPUj0wJywKKyAgICAgICAgXSwKKyAgICAgIH0sIHsKKyAgICAgICAgJ2ZlYXR1cmVfZGVmaW5l cyc6IFsKKyAgICAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfQ09MT1I9MScsCisgICAgICAgIF0s CisgICAgICB9XSwKICAgICAgIFsndXNlX2FjY2VsZXJhdGVkX2NvbXBvc2l0aW5nPT0xJywgewog ICAgICAgICAnZmVhdHVyZV9kZWZpbmVzJzogWwogICAgICAgICAgICdXVEZfVVNFX0FDQ0VMRVJB VEVEX0NPTVBPU0lUSU5HPTEnLAo= 135046 2012-04-02 02:04:43 -0700 2012-04-02 03:20:42 -0700 Patch bug-82863-20120402180442.patch text/plain 1616 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyODMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBiYTdmYWQzMzIyODA0MDJjN2YyMjdhMGJiZjg5NjhhMWQxM2U5NzYuLmFiYmFlODkyZDBmMTE3 NWFhMDYxYzZjZDI3ODYyOWEyMDQ4YjNhOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDQtMDIgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEaXNhYmxlIEVOQUJMRV9JTlBVVF9UWVBFX0NP TE9SIGZvciBhdXJhIGFuZCBhbmRyb2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04Mjg2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToKKwogMjAxMi0wNC0wMSAgSm9uIExlZSAg PGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIG5vdGlmaWNhdGlvbiBwcm9wZXJ0 aWVzIGFuZCBmdW5jdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVh dHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCA0 MWY2MjkzMjA5ZTU1YWNjMTg2MGJjMTIwMmIyZjg3YmMwZWE0MTkzLi5iMDBkMDdhMzQ5ZDk5NTk1 MWVlMTkwZGJmNTFlOTZiNzI4NDdiMmI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5n eXBpCkBAIC01Myw3ICs1Myw2IEBACiAgICAgICAnRU5BQkxFX0lDT05EQVRBQkFTRT0wJywKICAg ICAgICdFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRT0xJywKICAgICAgICdFTkFCTEVfSU5QVVRfU1BF RUNIPTEnLAotICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0NPTE9SPTEnLAogICAgICAgJ0VOQUJM RV9JTlBVVF9UWVBFX0RBVEU9MCcsCiAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUU9 MCcsCiAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfREFURVRJTUVMT0NBTD0wJywKQEAgLTEzNyw2 ICsxMzYsMTUgQEAKICAgICAgICAgICAnRU5BQkxFX1dFQl9BVURJTz0xJywKICAgICAgICAgXSwK ICAgICAgIH1dLAorICAgICAgWydPUz09ImFuZHJvaWQiIG9yIHVzZV9hdXJhPT0xJywgeworICAg ICAgICAnZmVhdHVyZV9kZWZpbmVzJzogWworICAgICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9D T0xPUj0wJywKKyAgICAgICAgXSwKKyAgICAgIH0sIHsKKyAgICAgICAgJ2ZlYXR1cmVfZGVmaW5l cyc6IFsKKyAgICAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfQ09MT1I9MScsCisgICAgICAgIF0s CisgICAgICB9XSwKICAgICAgIFsndXNlX2FjY2VsZXJhdGVkX2NvbXBvc2l0aW5nPT0xJywgewog ICAgICAgICAnZmVhdHVyZV9kZWZpbmVzJzogWwogICAgICAgICAgICdXVEZfVVNFX0FDQ0VMRVJB VEVEX0NPTVBPU0lUSU5HPTEnLAo=