82859 2012-04-02 00:03:28 -0700 Missing NULL check for vendor string from glGetString() 2012-04-02 10:32:37 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 srikumar.b webkit-unassigned haraken srikumar.b webkit.review.bot oldest_to_newest 593208 0 srikumar.b 2012-04-02 00:03:28 -0700 glGetString(GL_VENDOR) is possible to return NULL value but in Webkit we are not validating the return value before we call strstr() to compare the vendor list. Hence webkit crashes when it does not get vendor string response from openGL call glGetString(GL_VENDOR). Refer to http://www.opengl.org/sdk/docs/man/xhtml/glGetString.xml for glGetString() description. 593220 1 srikumar.b 2012-04-02 00:27:24 -0700 Please assign it to me. I will be uploading the patch with the changes. 593510 2 135112 srikumar.b 2012-04-02 09:02:07 -0700 Created attachment 135112 proposed patch Proposed patch. Changes to add additional check for vendor string. 593538 3 135112 haraken 2012-04-02 09:42:58 -0700 Comment on attachment 135112 proposed patch Looks OK. 593578 4 135112 webkit.review.bot 2012-04-02 10:32:33 -0700 Comment on attachment 135112 proposed patch Clearing flags on attachment: 135112 Committed r112901: <http://trac.webkit.org/changeset/112901> 593579 5 webkit.review.bot 2012-04-02 10:32:37 -0700 All reviewed patches have been landed. Closing bug. 135112 2012-04-02 09:02:07 -0700 2012-04-02 10:32:33 -0700 proposed patch 82859.patch text/plain 2088 srikumar.b SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjg5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTAyICBTcmlrdW1h ciBCb25kYSAgPHNyaWt1bWFyLmJAZ21haWwuY29tPgorCisgICAgICAgIE1pc3NpbmcgTlVMTCBj aGVjayBmb3IgdmVuZG9yIHN0cmluZyBmcm9tIGdsR2V0U3RyaW5nKCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyODU5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ2xHZXRTdHJpbmcoKSBwb3NzaWJsZSB0 byByZXR1cm4gTlVMTCB2YWx1ZS4KKyAgICAgICAgUmVmZXIgdG8gaHR0cDovL3d3dy5vcGVuZ2wu b3JnL3Nkay9kb2NzL21hbi94aHRtbC9nbEdldFN0cmluZy54bWwKKyAgICAgICAgZm9yIG1vcmUg aW5mb3JtYXRpb24uIFRoZSBtaXNzaW5nIG51bGwgY2hlY2sgY3Jhc2hlcyB3ZWJraXQgd2hlbgor ICAgICAgICB2ZW5kb3IgbmFtZSBpcyBub3Qgc2V0IChudWxsKSBieSBnbEdldFN0cmluZygpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoaXMgaXMgbWlzc2luZyBOVUxMIGNoZWNr IGZvcgorICAgICAgICBmb3Igb3BlbkdMIEFQSSByZXNwb25zZS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6dmFsaWRhdGVBdHRyaWJ1dGVzKToK KwogMjAxMi0wNC0wMiAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEltcGxlbWVudCBmcm9udGVuZCBmb3IgZGV2aWNlIG1l dHJpY3MgZW11bGF0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9v cGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9w ZW5HTENvbW1vbi5jcHAJKHJldmlzaW9uIDExMjgzMykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTk0LDcgKzk0LDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6dmFs aWRhdGVBdHRyaWJ1dAogICAgICAgICAvLyBDdXJyZW50bHkgaW4gTWFjIHdlIG9ubHkgdHVybiBv biBhbnRpYWxpYXMgaWYgdmVuZG9yIGlzIE5WSURJQSwKICAgICAgICAgLy8gb3IgaWYgQVRJIGFu ZCBvbiAxMC43LjIgYW5kIGFib3ZlLgogICAgICAgICBjb25zdCBjaGFyKiB2ZW5kb3IgPSByZWlu dGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPig6OmdsR2V0U3RyaW5nKEdMX1ZFTkRPUikpOwotICAg ICAgICBpZiAoIXN0ZDo6c3Ryc3RyKHZlbmRvciwgIk5WSURJQSIpICYmICEoc3RkOjpzdHJzdHIo dmVuZG9yLCAiQVRJIikgJiYgc3lzdGVtQWxsb3dzTXVsdGlzYW1wbGluZ09uQVRJQ2FyZHMoKSkp CisgICAgICAgIGlmICghdmVuZG9yIHx8ICghc3RkOjpzdHJzdHIodmVuZG9yLCAiTlZJRElBIikg JiYgIShzdGQ6OnN0cnN0cih2ZW5kb3IsICJBVEkiKSAmJiBzeXN0ZW1BbGxvd3NNdWx0aXNhbXBs aW5nT25BVElDYXJkcygpKSkpCiAgICAgICAgICAgICBpc1ZhbGlkVmVuZG9yID0gZmFsc2U7CiAg ICAgICAgIGlmICghaXNWYWxpZFZlbmRvciB8fCAhZXh0ZW5zaW9ucy0+c3VwcG9ydHMoIkdMX0FO R0xFX2ZyYW1lYnVmZmVyX211bHRpc2FtcGxlIikgfHwgaXNHTEVTMkNvbXBsaWFudCgpKQogICAg ICAgICAgICAgbV9hdHRycy5hbnRpYWxpYXMgPSBmYWxzZTsK